[pgadmin-hackers] pgAdmin 4 commit: Allow users to choose SELECT permissions for tables i
Allow users to choose SELECT permissions for tables in the Grant Wizard. Fixes #1835 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9320811d7c77aff2b594840ab9a2fb248cb1e3d Modified Files -- .../tools/grant_wizard/templates/grant_wizard/pg/9.1_plus/acl.json | 2 +- .../tools/grant_wizard/templates/grant_wizard/ppas/9.1_plus/acl.json| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Allow users to choose SELECT permissions for sequence
Allow users to choose SELECT permissions for sequences in the Grant Wizard. Fixes #1835 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0aaa80029ca98cfe6bf15f8ead6ba5e18b69554 Modified Files -- .../tools/grant_wizard/templates/grant_wizard/pg/9.1_plus/acl.json | 2 +- .../tools/grant_wizard/templates/grant_wizard/ppas/9.1_plus/acl.json| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)
Hi Dave, PFA updated patch with suggestion given. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 5, 2016 at 7:29 PM, Dave Page wrote: > OK, that's much better. I think I've figured out what's causing the > remaining execution error as well - we're not disabling the buttons > until we get a response from the server, so if you click too quickly, > you make multiple requests at once. I tested this by adding a "SELECT > pg_sleep(2);" to a loop in a function. > > If you can fix that as well, then I think we can call this issue fixed. > > Thanks! > > On Wed, Oct 5, 2016 at 1:09 PM, Murtuza Zabuawala > wrote: > > Hi Dave, > > > > PFA updated patch for the same. > > RM#1227 > > > > Please review. > > > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Mon, Oct 3, 2016 at 6:05 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala > >> wrote: > >> > Hi Dave, > >> > > >> > PFA updated patch to fix mentioned issue as well as incremental msgs > >> > updates > >> > in Messages Tab. > >> > >> This doesn't seem to work well. In pgAdmin 4 I get the following: > >> > >> > >> SELECT 1 > >> INFO: EMPNO ENAME > >> > >> > >> INFO: - --- > >> > >> > >> SELECT 1 > >> SELECT 1 > >> SELECT 1 > >> INFO: 7369 SMITH > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7499 ALLEN > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7521 WARD > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7566 JONES > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7654 MARTIN > >> > >> > >> SELECT 1 > >> INFO: 7698 BLAKE > >> > >> > >> SELECT 1 > >> SELECT 1 > >> SELECT 1 > >> INFO: 7782 CLARK > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7788 SCOTT > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7839 KING > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7844 TURNER > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7876 ADAMS > >> > >> > >> SELECT 1 > >> INFO: 7900 JAMES > >> > >> > >> SELECT 1 > >> SELECT 1 > >> INFO: 7902 FORD > >> > >> > >> SELECT 1 > >> SELECT 1 > >> SELECT 1 > >> INFO: 7934 MILLER > >> > >> > >> SELECT 1 > >> SELECT 1 > >> SELECT 1 > >> SELECT 1 > >> > >> > >> Whilst in pgAdmin III I get: > >> > >> > >> INFO: EMPNOENAME > >> INFO: ---- > >> INFO: 7369 SMITH > >> INFO: 7499 ALLEN > >> INFO: 7521 WARD > >> INFO: 7566 JONES > >> INFO: 7654 MARTIN > >> INFO: 7698 BLAKE > >> INFO: 7782 CLARK > >> INFO: 7788 SCOTT > >> INFO: 7839 KING > >> INFO: 7844 TURNER > >> INFO: 7876 ADAMS > >> INFO: 7900 JAMES > >> INFO: 7902 FORD > >> INFO: 7934 MILLER > >> SELECT 1 > >> > >> > >> Sidenote: pgAdmin III uses a fixed-width font for this output which > >> works far better than pgAdmin 4's variable width font. > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > RM_1227_v4.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)
Hi Dave, The issue you mentioned is different issue and not related to synonyms node. I will create separate ticket & work on it mean while you can commit changes for RM#1611 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 5, 2016 at 6:53 PM, Dave Page wrote: > Hi > > I created a synonym from within the "dave" schema, but selected > "public" (which wasn't expanded), and it placed the synonym as a > direct child of "public". See the attached screenshot. > > On Wed, Oct 5, 2016 at 1:28 PM, Murtuza Zabuawala > wrote: > > Hi Dave, > > > > PFA updated patch, Added schema filter in sql. > > Please review. > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Wed, Oct 5, 2016 at 5:38 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala > >> wrote: > >> > Hi, > >> > > >> > PFA patch to fix the issue in synonym node, where it was not horning > >> > parent > >> > node while creating in different node, issue was that we were not > >> > sending > >> > node properly. > >> > RM#1611 > >> > >> That doesn't seem like a reliable way to get the correct parent ID - > >> what if there are multiple synonyms in different schemas but with the > >> same name? > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
[pgadmin-hackers] Running pgadmin4 as desktop application
Hi, Can you please clarify how to start pgadmin4 in desktop application mode? I read https://www.pgadmin.org/docs4/dev/desktop_deployment.html but when I run /usr/pgadmin4-1.0/runtime/pgAdmin4 (installed via community RPMs), I get: " An error occurred initialising the application server: Failed to locate pgAdmin4.py, terminating server thread." (as reported 2 days ago on the list), followed by a segfault. There is an ini file at the same directory, with contents like this: $ cat /usr/pgadmin4-1.0/runtime/pgAdmin4.ini [General] ApplicationPath=/usr/lib/python3.5/site-packages/pgadmin4-web PythonPath= Can you please give me a clue so that I can fix the packaging? Regards, -- Devrim GÜNDÜZ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR signature.asc Description: This is a digitally signed message part
Re: [pgadmin-hackers] Running pgadmin4 as desktop application
Hi On Thu, Oct 6, 2016 at 11:25 AM, Devrim Gündüz wrote: > > Hi, > > Can you please clarify how to start pgadmin4 in desktop application mode? I > read > > https://www.pgadmin.org/docs4/dev/desktop_deployment.html > > but when I run > > /usr/pgadmin4-1.0/runtime/pgAdmin4 (installed via community RPMs), I get: > > " > An error occurred initialising the application server: > Failed to locate pgAdmin4.py, terminating server thread." > > (as reported 2 days ago on the list), followed by a segfault. There is an ini > file at the same directory, with contents like this: > > $ cat /usr/pgadmin4-1.0/runtime/pgAdmin4.ini > > [General] > ApplicationPath=/usr/lib/python3.5/site-packages/pgadmin4-web > PythonPath= > > > Can you please give me a clue so that I can fix the packaging? The global config file that Qt will read by default seems to be "/etc/pgAdmin Development Team/pgAdmin 4.conf". I may change that for 1.1 to use a less obnoxious path. The contents of it seem to need to be: [General] ApplicationPath=../../../../usr/lib/python2.7/site-packages/pgadmin4-web/ PythonPath="/usr/lib64/python2.7/site-packages/;/usr/lib/python2.7/site-packages/" The ApplicationPath is the directory containing pgAdmin4.py. Due to a bugette in the way the runtime works, it needs to be relative to the location of the runtime, hence all the back-tracking. The PythonPath needs to include both the 32 and 64 bit directories, as it seems that some of the Python modules end up in each. That was enough to get it to start for me. Then, we run into the tricky issues, where you may have to deal with conflicts between web and desktop mode. In our other installers, we ship a blank config_local.py file, with a simple comment at the top telling the user they can customise any settings in that file. For web users, we don't want that, as it's used as a security mechanism (startup will fail if it's not present, and tell the user they must set some security-critical options). Those options don't matter in desktop mode, hence why we pre-write the file. Perhaps the way around that is to have the shortcut on the menu call a script that can create config_local.py if needed? Though, I see you already have config_distro.py forcing the user into desktop mode, which is a potential conflict. The other issue I see is with the docs: 1) The path in config_distro.py is /usr/share/doc/pgadmin4-docs/en_US/html/. That directory doesn't exist - if the docs are compiled in-situ, they'll end up in /usr/share/doc/pgadmin4-docs/en_US/html/_build/html 2) The docs aren't built, so there is no _build/html directory. 3) The docs are integrated into the application so really should be a dependency of the pgadmin4 RPM. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager]
Hi, *Issue:* When clicked on upload icon while saving a file prompt user to leave page. It is because the icon is a button and its type is set to submit which makes it to prompt, instead it should be 'button' Storage Manager's menu items depends on capabilities list set by the module using it. If capabilities doesn't have 'upload' in it, It won't work. Upload button is bound to click event only when it is in capabilities. *Solution:* As upload button is being added only when it is in capabilities, so upload button html is removed from html file. It will not shown on UI untill it is in capabilities list. Please find attached patch and review. Thanks, Surinder Kumar RM1739.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
