[pgadmin-hackers] pgAdmin 4 commit: Fix regression test import issue.

2016-10-13 Thread Dave Page
Fix regression test import issue.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36c185e9dcb183ff93c75c06f7fbdcb9cd011ee1
Author: Navnath Gadakh 

Modified Files
--
web/pgadmin/utils/route.py | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Add regression tests for FTS nodes.

2016-10-13 Thread Dave Page
Add regression tests for FTS nodes.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b91babdc217fc685b9096c5ae9f3290f8b1b5f1
Author: Priyanka Shendge 

Modified Files
--
.../schemas/fts_configurations/tests/__init__.py   | 16 
.../tests/test_fts_configuration_add.py| 89 
.../tests/test_fts_configuration_delete.py | 84 +++
.../tests/test_fts_configuration_get.py| 77 +
.../tests/test_fts_configuration_put.py| 92 +
.../schemas/fts_configurations/tests/utils.py  | 80 ++
.../schemas/fts_dictionaries/tests/__init__.py | 16 
.../tests/test_fts_dictionaries_add.py | 82 ++
.../tests/test_fts_dictionaries_delete.py  | 87 
.../tests/test_fts_dictionaries_get.py | 77 +
.../tests/test_fts_dictionaries_put.py | 95 +
.../schemas/fts_dictionaries/tests/utils.py| 80 ++
.../databases/schemas/fts_parser/tests/__init__.py | 16 
.../fts_parser/tests/test_fts_parser_add.py| 78 ++
.../fts_parser/tests/test_fts_parser_delete.py | 87 
.../fts_parser/tests/test_fts_parser_get.py| 76 +
.../fts_parser/tests/test_fts_parser_put.py| 96 ++
.../databases/schemas/fts_parser/tests/utils.py| 81 ++
.../schemas/fts_templates/tests/__init__.py| 16 
.../fts_templates/tests/test_fts_templates_add.py  | 77 +
.../tests/test_fts_templates_delete.py | 84 +++
.../fts_templates/tests/test_fts_templates_get.py  | 76 +
.../fts_templates/tests/test_fts_templates_put.py  | 93 +
.../databases/schemas/fts_templates/tests/utils.py | 77 +
24 files changed, 1732 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Add regression tests for Foreignb Tables.

2016-10-13 Thread Dave Page
Add regression tests for Foreignb Tables.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=540c389d92d4d9b4910fab68f6b44a8b9e8f2786
Author: Priyanka Shendge 

Modified Files
--
.../schemas/foreign_tables/tests/__init__.py   |  16 
.../foreign_tables/tests/test_foreign_table_add.py | 100 +
.../tests/test_foreign_table_delete.py |  90 +++
.../foreign_tables/tests/test_foreign_table_get.py |  84 +
.../foreign_tables/tests/test_foreign_table_put.py |  98 
.../schemas/foreign_tables/tests/utils.py  |  81 +
6 files changed, 469 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Foreign Table Patch

2016-10-13 Thread Dave Page
Thanks, applied.

On Wednesday, October 12, 2016, Priyanka Shendge <
priyanka.shen...@enterprisedb.com> wrote:

> Please ignore previous patch, it was failing for  EPAS servers. PFA
> revised patch.
>
> *Run the test suite by following command:*
>   python runtests.py
>
> Thank you.
>
>
> On 12 October 2016 at 07:39, Priyanka Shendge  enterprisedb.com
> >
> wrote:
>
>> Hi Dave,
>>
>> PFA patch for Foreign Table node.
>>
>> *Run the test suite by following command:*
>>   python runtests.py
>>
>> Thank you.
>>
>> --
>> Best,
>> Priyanka
>>
>> EnterpriseDB Corporation
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Best,
> Priyanka
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


Re: [pgadmin-hackers] FTS nodes (Configuration, Dictionaries, Parser, Templates) patch

2016-10-13 Thread Dave Page
Thanks, applied.

On Wednesday, October 12, 2016, Priyanka Shendge <
priyanka.shen...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA patch for FTS nodes.
>
> *Run test suite by following command:*
>   python runtests.py
>
> --
> Best,
> Priyanka
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


[pgadmin-hackers] pgAdmin 4 commit: Ignore patches and autosave files from QT Creator

2016-10-13 Thread Dave Page
Ignore patches and autosave files from QT Creator

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f089744d6d8971417f4a398f2e1210a0fd6bcc68

Modified Files
--
.gitignore | 3 +++
1 file changed, 3 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-13 Thread Ashesh Vashi
Hi Dave,

On Tue, Oct 11, 2016 at 9:10 PM, Dave Page  wrote:

> Hi Ashesh,
>
> Can you please review the attached patch, and apply if you're happy with
> it?
>
Overall the patch looked good to me.
But - I encounter an issue in 'web' mode, which wont happen with 'runtime'.

Steps for reproduction on existing pgAdmin 4 environment with 'web' mode.
- Apply the patch
- Start the pgAdmin4 application (stand alone application).
- Open pgAdmin home page.
- Log out (if already login).

And, you will see an exception.

I have figure out the issue with the patch.
We were setting the SECURITY_PASSWORD_SALT, after initializing the Security
object.
Hence - it could not set the SECURITY_KEY, and SECURITY_PASSWORD_SALT
properly.

I had moved the Security object initialization after fetching these
configurations from the database.
I have attached a addon patch for the same.

Now - I run into another issue.
Because - the existing password was hashed using the old
SECURITY_PASSWORD_SALT, I am no more able to login to pgAdmin 4.

I think - we need to think about different strategy for upgrading the
configuration file in the 'web' mode.
I was thinking - we can store the existing security configurations in the
database during upgrade process in 'web' mode.

I was not able to spend much time on it due to some other priorities.

--
Thanks & Regards,
Ashesh Vashi


> The purpose is to auto-generate the various security keys that are
> currently in the configuration file, and store them in the SQLite database.
> This allows us to remove the checks for config_local.py and the hard-coded
> default keys which are causing some problems with packaging:
>
> - Hard coded defaults are fine for Desktop mode, and packages generally
> aim to make that work primarily.
> - Hard coded defaults are a security risk for Server mode, hence we
> currently require the user to manually setup keys, which is currently being
> overridden by packagers for Desktop mode.
>
> This change ensures that we have unique security keys for every
> installation, whether running in desktop or server mode (generated from
> os.urandom).
>
> Thanks!
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


add_auto_generate_security_keys.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers