Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]
Hi,
Pls updated patch for RM1911.
1. This includes fix for issue index out of range when user enters path of
folder without trailing slash (showed by Dave).
2. To make this functionality compatible with save last used directory
feature.
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jan 9, 2017 at 12:40 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi Dave,
>
>
> Please find attached rebased patch.
>
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Sun, Jan 8, 2017 at 4:07 PM, Dave Page wrote:
>
>> Hi
>>
>> Can you rebase this please? It no longer applies :-(
>>
>>
>> On Wednesday, December 28, 2016, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>> Here is updated (V4) patch.
>>>
>>> Changes: 1] Now can enter both type of slashes ( / and \ ) and all will
>>> get replaced with the platform standard.
>>> 2] Added unicode support.
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Mon, Dec 19, 2016 at 5:16 PM, Dave Page wrote:
>>>
Hi
On Fri, Dec 16, 2016 at 6:46 PM, Harshal Dhumal
wrote:
> Hi Dave,
>
> Please find updated patch below for direct file navigation.
> I have covered all of above mentioned case.
Still not there I'm afraid:
- On Mac, if I type \Users\dpage, it changes it to /\Users\dpage and
then tells me it doesn't exist. Per the RM, either forward or back
slashes should be acceptable ("The path should accept either / or \ as
separators. Upon successful navigation to the path (after pressing
Return), the slashes should be replaced with the platform standard if
needed.")
- Unicode handling seems to be completely broken - see the attached
screenshot.
I haven't tested on Windows yet, and only in Desktop mode on Mac.
Please test on Windows and Mac or Linux with both Python 2 and 3, in
both Server and Desktop modes to ensure that the behaviour meets the
requirements of the ticket with Unicode and non-Unicode paths and
files before resubmitting.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
>
RM1911_V6_14_Jan.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] .gitignore Improvement Suggestion
Good day pga-hackers, while playing around with the source and Git I found out that building an executable on my Raspberry Pi creates a file called "pgAdmin4" in the runtime folder. The .gitignore file in the same folder only mentions a "pgadmin4" file without a capital "a" in its name. As I'm new to this project it could well be that this was changed in one of the last commits of which I have no knowledge. Because it's just a small change to fix this potentially new and probably unwanted error I attached the fix to this mail. I also put all lines in the .gitignores in alphabetical order to make them easier to read and to prevent duplicate lines. No matter if only the real fix is going to get accepted or the reordering too: did I submit the .diff (patch) correctly? I'm new to Git via the command line as you already know. Please tell me, if I made any mistakes. Greetings from Germany, Jonas Thelemann diff --git a/.gitignore b/.gitignore index e1fdf53..0ae8098 100644 --- a/.gitignore +++ b/.gitignore @@ -1,35 +1,35 @@ +*.autosave *.db -*.pyc -*.pyo -*.o -*.psp *.diff +*.o *.patch -*.autosave -_build -build-* +*.psp +*.pyc +*.pyo +*.swo +*.swp .DS_Store .idea +/dist +/mac-build +/pip-build +/src-build +/win-build +_build +build-* +pgadmin4.log +pkg/win32/installer.iss runtime/.qmake.cache +runtime/.qmake.stash runtime/Makefile +runtime/Makefile.Debug +runtime/Makefile.Release runtime/moc_BrowserWindow.cpp runtime/moc_Server.cpp runtime/pgAdmin4.app/ runtime/pgAdmin4.pro.user* +runtime/pgAdmin4_resource.rc +runtime/release/ runtime/ui_BrowserWindow.h -runtime/.qmake.stash web/config_local.py web/regression/test_config.json -pgadmin4.log -*.swp -*.swo -/mac-build -/src-build -/pip-build -/win-build -/dist -pkg/win32/installer.iss -runtime/Makefile.Debug -runtime/Makefile.Release -runtime/release/ -runtime/pgAdmin4_resource.rc diff --git a/pkg/mac/.gitignore b/pkg/mac/.gitignore index 5656003..a9aa86f 100644 --- a/pkg/mac/.gitignore +++ b/pkg/mac/.gitignore @@ -1,4 +1,4 @@ # Global excludes across all subdirectories +codesign.conf debug.pgadmin.Info.plist pgadmin.Info.plist -codesign.conf diff --git a/runtime/.gitignore b/runtime/.gitignore index a130a9a..8075ebd 100644 --- a/runtime/.gitignore +++ b/runtime/.gitignore @@ -1,13 +1,14 @@ .qmake.cache +.qmake.stash Makefile moc_BrowserWindow.cpp +moc_ConfigWindow.cpp moc_Server.cpp +moc_TabWindow.cpp +moc_WebViewWindow.cpp +pgAdmin4 pgAdmin4.app/ pgAdmin4.pro.user* +qrc_pgAdmin4.cpp ui_BrowserWindow.h -.qmake.stash -moc_ConfigWindow.cpp -moc_TabWindow.cpp -moc_WebViewWindow.cpp -qrc_pgadmin4.cpp ui_ConfigWindow.h diff --git a/web/regression/.gitignore b/web/regression/.gitignore index 570f022..0581810 100644 --- a/web/regression/.gitignore +++ b/web/regression/.gitignore @@ -1,4 +1,4 @@ parent_id.pkl regression.log -test_config.json test_advanced_config.json +test_config.json -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] .gitignore Improvement Suggestion
Well, 10 minutes later I notice that I made a mistake describing the fix. The attached file is correct though. Fix A (not the reordering) consists of 2 fixes. One is adding the "pgAdmin4" executable file to the ignore list in the runtime folder. The other is to rename the line/file "qrc_pgadmin4.cpp" to "qrc_pgAdmin4.cpp" in the .gitignore of the runtime folder. That's what I meant with 'lower case "a" to capital "A"'. Sorry for my faux pas there, it's 5 am and I seriously should go to bed now. Good night, Jonas Thelemann Am 15.01.2017 um 05:00 schrieb Jonas Thelemann: Good day pga-hackers, while playing around with the source and Git I found out that building an executable on my Raspberry Pi creates a file called "pgAdmin4" in the runtime folder. The .gitignore file in the same folder only mentions a "pgadmin4" file without a capital "a" in its name. As I'm new to this project it could well be that this was changed in one of the last commits of which I have no knowledge. Because it's just a small change to fix this potentially new and probably unwanted error I attached the fix to this mail. I also put all lines in the .gitignores in alphabetical order to make them easier to read and to prevent duplicate lines. No matter if only the real fix is going to get accepted or the reordering too: did I submit the .diff (patch) correctly? I'm new to Git via the command line as you already know. Please tell me, if I made any mistakes. Greetings from Germany, Jonas Thelemann -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
