Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties
On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix the RM 2069 - Wrong tablespace > displayed in table properties. > > When the table is created without a tablespace, the "pg_default" tablespace > gets selected rather than the default tablespace (the current database > tablespace). > So, this issue has been fixed. Unfortunately more work is required. I started hacking on it (see attached), but there is more effort needed and I'm out of time. Specifically: - We need to remove 'pg_default' as the default tablespace when creating objects. Let's have no default, and let PG automatically pick the right tablespace, unless the user specifically overrides it. My updated patch removes that default, and fixes some of the SQL to handle it. - Matviews don't list the correct tablespace in their properties list. - Unique constraints ignore the tablespace option if the user selects pg_default, even if the database's default is something different. So I think to complete this we need to review all objects that use tablespaces (databases, tables, matviews, indexes, index-backed constraints) and ensure: - No default tablespace is selected when creating an object. - If the user selects a tablespace, the CREATE SQL must handle it properly. Similarly, if they leave it to the default. - The Properties views must display the actual tablespace in use, whether it is specific to the object, or the database default. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_2069-Dave.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin
Hi Fahar,
Could you please test this updated patch?
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas
wrote:
> Thanks Dave.
>
> On Tue, Jan 17, 2017 at 3:07 PM, Dave Page wrote:
>
>> Not surprising. Don't bother testing that any more for now thanks. I
>> suspect it's a simple bug that Ashesh can fix pronto.
>>
>> On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <
>> fahar.ab...@enterprisedb.com> wrote:
>>
>>> Issue is also reproducible with PG-9.6 server.
>>>
>>> Regards,
>>>
>>>
>>> On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <
>>> fahar.ab...@enterprisedb.com> wrote:
>>>
Please attached the log files output from the terminal and pgAdmin4.log.
Kind Regards,
On Tue, Jan 17, 2017 at 2:46 PM, Dave Page wrote:
> Thanks. What log output do you get?
>
> On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <
> fahar.ab...@enterprisedb.com> wrote:
>
>> Hi Dave.
>>
>> After applying this patch on Windows 2012 server 64 with Python
>> 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.
>>
>> Please find attached the snapshot.
>>
>> Kind Regards,
>>
>> On Wed, Jan 11, 2017 at 6:19 PM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
Hi Dave,
On Wed, Jan 11, 2017 at 12:03 PM, Dave Page
wrote:
>
> KeyError: u'end_time'
>
> The status file contains:
>
> {"start_time": "2017-01-11 06:27:20.939703 +", "pid": 49363,
> "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +"}
>
Thanks for reviewing the patch.
Please find the updated patch.
Changes:
- Using now ValueError instead of json.JSONDecodeError, which is
subclass of ValueError, to allow to it to work with 2.6+ python.
- Checking the existence of value in dict before accessing it.
>>> That seems to work for me in a brief test on my Mac. :-)
>>>
>>> Fahar; are you able to apply and test this patch on Windows and
>>> Linux, in server and desktop modes? Basically all the external processes
>>> should be tested - backup, restore & maintenance (vacuum) etc). I don't
>>> have any VMs available at the moment due to travel.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Syed Fahar Abbas
>> Quality Management Group
>>
>> EnterpriseDB Corporation
>> Phone Office: +92-51-835-8874
>> Phone Direct: +92-51-8466803 <+92%2051%208466803>
>> Mobile: +92-333-5409707 <+92%20333%205409707>
>> Skype ID: syed.fahar.abbas
>> Website: www.enterprisedb.com
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Syed Fahar Abbas
Quality Management Group
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803 <(051)%208466803>
Mobile: +92-333-5409707 <0333%205409707>
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com
>>>
>>>
>>>
>>> --
>>> Syed Fahar Abbas
>>> Quality Management Group
>>>
>>> EnterpriseDB Corporation
>>> Phone Office: +92-51-835-8874
>>> Phone Direct: +92-51-8466803 <+92%2051%208466803>
>>> Mobile: +92-333-5409707 <+92%20333%205409707>
>>> Skype ID: syed.fahar.abbas
>>> Website: www.enterprisedb.com
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Syed Fahar Abbas
> Quality Management Group
>
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803
> Mobile: +92-333-5409707
> Skype ID: syed.fahar.abbas
> Website: www.enterprisedb.com
>
RM1679_v8.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin
Sure Will test this on Monday will be leaving in few minutes.
Kind Regards,
On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Fahar,
>
> Could you please test this updated patch?
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas > wrote:
>
>> Thanks Dave.
>>
>> On Tue, Jan 17, 2017 at 3:07 PM, Dave Page wrote:
>>
>>> Not surprising. Don't bother testing that any more for now thanks. I
>>> suspect it's a simple bug that Ashesh can fix pronto.
>>>
>>> On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <
>>> fahar.ab...@enterprisedb.com> wrote:
>>>
Issue is also reproducible with PG-9.6 server.
Regards,
On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <
fahar.ab...@enterprisedb.com> wrote:
> Please attached the log files output from the terminal and
> pgAdmin4.log.
>
> Kind Regards,
>
>
> On Tue, Jan 17, 2017 at 2:46 PM, Dave Page wrote:
>
>> Thanks. What log output do you get?
>>
>> On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <
>> fahar.ab...@enterprisedb.com> wrote:
>>
>>> Hi Dave.
>>>
>>> After applying this patch on Windows 2012 server 64 with Python
>>> 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.
>>>
>>> Please find attached the snapshot.
>>>
>>> Kind Regards,
>>>
>>> On Wed, Jan 11, 2017 at 6:19 PM, Dave Page
>>> wrote:
>>>
Hi
On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Wed, Jan 11, 2017 at 12:03 PM, Dave Page
> wrote:
>
>>
>> KeyError: u'end_time'
>>
>> The status file contains:
>>
>> {"start_time": "2017-01-11 06:27:20.939703 +", "pid": 49363,
>> "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +"}
>>
>
> Thanks for reviewing the patch.
> Please find the updated patch.
>
> Changes:
> - Using now ValueError instead of json.JSONDecodeError, which is
> subclass of ValueError, to allow to it to work with 2.6+ python.
> - Checking the existence of value in dict before accessing it.
>
>
>
That seems to work for me in a brief test on my Mac. :-)
Fahar; are you able to apply and test this patch on Windows and
Linux, in server and desktop modes? Basically all the external
processes
should be tested - backup, restore & maintenance (vacuum) etc). I don't
have any VMs available at the moment due to travel.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>> --
>>> Syed Fahar Abbas
>>> Quality Management Group
>>>
>>> EnterpriseDB Corporation
>>> Phone Office: +92-51-835-8874
>>> Phone Direct: +92-51-8466803 <+92%2051%208466803>
>>> Mobile: +92-333-5409707 <+92%20333%205409707>
>>> Skype ID: syed.fahar.abbas
>>> Website: www.enterprisedb.com
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Syed Fahar Abbas
> Quality Management Group
>
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803 <(051)%208466803>
> Mobile: +92-333-5409707 <0333%205409707>
> Skype ID: syed.fahar.abbas
> Website: www.enterprisedb.com
>
--
Syed Fahar Abbas
Quality Management Group
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803 <+92%2051%208466803>
Mobile: +92-333-5409707 <+92%20333%205409707>
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Syed Fahar Abbas
>> Quality Management Group
>>
>> EnterpriseDB Corporation
>> Phone Office: +92-51-835-8874
>> Phone Direct: +92-51-8466803 <(051)%208466803>
>> Mobile: +92-333-5409707 <0333%205409707>
>> Skype ID: syed.fahar.abbas
>> Website: www.enterprisedb.com
>>
>
>
--
Syed Fahar Abbas
Quality Management Group
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.e
[pgadmin-hackers] pgAdmin 4 commit: Properly remove any event listeners added by subnode
Properly remove any event listeners added by subnode control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=415119d5814054cdce6f16a9545ccd35c91270a7 Author: Harshal Dhumal Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Minor patch for subnode control clean up code [pgAdmin4]
Thanks, applied. On Thu, Jan 19, 2017 at 6:41 AM, Harshal Dhumal wrote: > Hi, > > This patch includes following change: > Properly remove any event listeners added by subnode control. > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Revert "Handle comments on databases with datallowcon
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024" This reverts commit e431eb9d8ecc28572b39d26c9effcf66f70f6ae1. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac4178233b8772f964825f8c8e0c95e23feddcc1 Modified Files -- .../server_groups/servers/databases/__init__.py| 140 +++-- 1 file changed, 75 insertions(+), 65 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)
FYI, I've reverted this patch for now, as I found it was causing other problems. On Fri, Jan 20, 2017 at 5:40 AM, Murtuza Zabuawala wrote: > Let me check > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Jan 20, 2017 at 2:16 AM, George Gelashvili > wrote: >> >> Hi Dave and Murtuza, >> >> FYI - on our machines, running the DatabasesUpdateTestCase fails with an >> error after e431eb9d8ecc28572b39d26c9effcf66f70f6ae1: >> >> Traceback (most recent call last): >> File >> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_put.py", >> line 58, in runTest >> self.db_id) >> File >> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", >> line 149, in disconnect_database >> assert db_con.status_code == 200 >> AssertionError >> >> - Tira & George >> >> >> On Mon, Jan 16, 2017 at 10:43 AM, Dave Page wrote: >>> >>> Hi >>> >>> On Fri, Jan 13, 2017 at 10:00 AM, Murtuza Zabuawala >>> wrote: >>> > Hi Dave, >>> > >>> > I am not able to re-produce it, I reviewed reconnect to database logic >>> > and >>> > it is not affected by this patch, Would you please provide me exact >>> > steps? >>> >>> Weird, neither can I now. I guess something was messed up in my >>> environment then. >>> >>> Patch applied - sorry for the noise! >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin
That's strange.
I tested in Chrome, Need check in IE.
Meanwhile can try with Chrome/Firefox?
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas
wrote:
> Hi Murtaza,
>
> I just applied this patch and issue is still not resolved.
>
> In case of Maintenance DB and Backup database message, *Maintenance job
> created* and *Backup job created* displayed but no other dialogue box
> displayed either process is completed or not.
>
> Screen-shot and pgadmin.log file is attached.
>
> Kind Regards,
>
>
> On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala enterprisedb.com> wrote:
>
>> Hi Fahar,
>>
>> Could you please test this updated patch?
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <
>> fahar.ab...@enterprisedb.com> wrote:
>>
>>> Thanks Dave.
>>>
>>> On Tue, Jan 17, 2017 at 3:07 PM, Dave Page wrote:
>>>
Not surprising. Don't bother testing that any more for now thanks. I
suspect it's a simple bug that Ashesh can fix pronto.
On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <
fahar.ab...@enterprisedb.com> wrote:
> Issue is also reproducible with PG-9.6 server.
>
> Regards,
>
>
> On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <
> fahar.ab...@enterprisedb.com> wrote:
>
>> Please attached the log files output from the terminal and
>> pgAdmin4.log.
>>
>> Kind Regards,
>>
>>
>> On Tue, Jan 17, 2017 at 2:46 PM, Dave Page wrote:
>>
>>> Thanks. What log output do you get?
>>>
>>> On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <
>>> fahar.ab...@enterprisedb.com> wrote:
>>>
Hi Dave.
After applying this patch on Windows 2012 server 64 with Python
2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.
Please find attached the snapshot.
Kind Regards,
On Wed, Jan 11, 2017 at 6:19 PM, Dave Page
wrote:
> Hi
>
> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Wed, Jan 11, 2017 at 12:03 PM, Dave Page
>> wrote:
>>
>>>
>>> KeyError: u'end_time'
>>>
>>> The status file contains:
>>>
>>> {"start_time": "2017-01-11 06:27:20.939703 +", "pid": 49363,
>>> "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +"}
>>>
>>
>> Thanks for reviewing the patch.
>> Please find the updated patch.
>>
>> Changes:
>> - Using now ValueError instead of json.JSONDecodeError, which is
>> subclass of ValueError, to allow to it to work with 2.6+ python.
>> - Checking the existence of value in dict before accessing it.
>>
>>
>>
> That seems to work for me in a brief test on my Mac. :-)
>
> Fahar; are you able to apply and test this patch on Windows and
> Linux, in server and desktop modes? Basically all the external
> processes
> should be tested - backup, restore & maintenance (vacuum) etc). I
> don't
> have any VMs available at the moment due to travel.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Syed Fahar Abbas
Quality Management Group
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803 <+92%2051%208466803>
Mobile: +92-333-5409707 <+92%20333%205409707>
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Syed Fahar Abbas
>> Quality Management Group
>>
>> EnterpriseDB Corporation
>> Phone Office: +92-51-835-8874
>> Phone Direct: +92-51-8466803 <(051)%208466803>
>> Mobile: +92-333-5409707 <0333%205409707>
>> Skype ID: syed.fahar.abbas
>> Website: www.enterprisedb.com
>>
>
>
>
> --
> Syed Fahar Abbas
> Quality Management Group
>
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803 <+92%2051%208466803>
> Mobile: +92-333-5409707 <+92%20333%205409707>
> Skype ID: syed.fahar.abbas
> Websit
[pgadmin-hackers] pgAdmin 4 commit: Python 3 fix for the regression tests
Python 3 fix for the regression tests Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d4cffc608c44a5574fbe433ab9fa1f9fbd58ed Author: George Gelashvili Modified Files -- web/regression/test_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers][Patch] Python 3 compatibility
Thanks, patch applied.
On Thu, Jan 19, 2017 at 10:12 PM, George Gelashvili
wrote:
> Hello
>
> We stumbled on the following error when running tests off of master:
>
> Traceback (most recent call last):
> File "web/regression/runtests.py", line 254, in
> servers_info = test_utils.get_config_data()
> File "/Users/pivotal/workspace/pgadmin4/web/regression/test_utils.py",
> line 72, in get_config_data
> if (not srv.has_key('enabled')) or srv['enabled'] == True:
> AttributeError: 'dict' object has no attribute 'has_key'
>
> Please find attached a fix for this.
>
> - George & Tira
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)
Hi
On Thu, Jan 19, 2017 at 11:15 PM, George Gelashvili
wrote:
> Here's an updated patch which polls to wait for the app to start instead of
> sleeping for 10 seconds.
I see the browser opening now, and it immediately loads pgAdmin. Then,
it prompts me for a reload whenever the test is run, which fails no
matter how quickly I hit the prompt from what I can see:
==
ERROR: runTest
(pgadmin.acceptance.tests.test_connects_to_database.ConnectsToDatabase)
--
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/pgadmin/acceptance/tests/test_connects_to_database.py",
line 41, in setUp
self._wait_for_app()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/acceptance/tests/test_connects_to_database.py",
line 109, in _wait_for_app
self.__wait_for("app to start", page_shows_app)
File
"/Users/dpage/git/pgadmin4/web/pgadmin/acceptance/tests/test_connects_to_database.py",
line 117, in __wait_for
result = condition_met_function()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/acceptance/tests/test_connects_to_database.py",
line 107, in page_shows_app
return self.driver.title == config.APP_NAME
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 257, in title
resp = self.execute(Command.GET_TITLE)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 236, in execute
self.error_handler.check_response(response)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 192, in check_response
raise exception_class(message, screen, stacktrace)
UnexpectedAlertPresentException: Alert Text: None
Message: unexpected alert open: {Alert text : Are you sure you wish to
close the pgAdmin 4 browser?}
(Session info: chrome=55.0.2883.95)
(Driver info: chromedriver=2.27.440174
(e97a722caafc2d3a8b807ee115bfb307f7d2cfd9),platform=Mac OS X 10.12.1
x86_64)
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)
On Thu, Jan 19, 2017 at 10:07 PM, George Gelashvili
wrote:
>
> Here is an updated patch which starts the server up when the test starts and
> uses the values from config.py for server name etc. It still requires
> installing chromedriver before running. Should we add something to the
> readme about that?
Yes, we definitely should (including download site URL)
> On Tue, Jan 17, 2017 at 11:09 AM, Atira Odhner wrote:
>>
>> Thanks for your feedback, Dave!
>>
>> We can put the tests under the regression directory. I think that makes
>> sense.
>> I'm not picturing these tests being module specific, but we may want to
>> enable running it as a separate suite of tests.
>>
>> Thanks for the callout about the port and title. We'll make sure those are
>> pulled from config or that the pgAdmin server is spun up by the test with
>> specific values.
>>
>> I have a couple ideas about why the test might not have been running for
>> you. I think the patch we attached didn't spin up its own pgAdmin yet and it
>> definitely doesn't fill in username/password if your app is running that
>> way. That's part of the WIP-ness :-P
>>
>> -Tira
>>
>> Hi
>>
>> On Thu, Jan 12, 2017 at 10:41 PM, George Gelashvili
>> wrote:
>> > here's the patch we forgot to attach. Also, you can see work on our
>> > branch
>> > at:
>> >
>> > https://github.com/pivotalsoftware/pgadmin4/tree/pivotal/acceptance-tests
>> >
>> > On Thu, Jan 12, 2017 at 5:26 PM, George Gelashvili
>> >
>> > wrote:
>> >>
>> >> Hi there,
>> >>
>> >> We are working on browser-automation-based acceptance tests that
>> >> exercise
>> >> pgAdmin4 the way a user might.
>>
>> Nice!
>>
>> >> The first "connect to database" test works, but at the moment depends
>> >> on
>> >> Chrome and chromedriver. We would appreciate feedback on any possible
>> >> license or code style issues at this point, as well as any thoughts on
>> >> adding this sort of test to the codebase.
>>
>> A few thoughts:
>>
>> - If these tests are to run as part of the regression suite, the
>> framework for them should live under that directory.
>>
>> - Are any of the tests likely to be module-specific? If so, they
>> should really be part of the relevant module as the regression tests
>> are. If they're more general/less tightly coupled, then I don't see a
>> problem with them residing where they are.
>>
>> - Please take care not to include changes to .gitgnore files that
>> aren't relevant to the rest of us.
>>
>> - The port number is hard-coded in the test.
>>
>> - You've hard-coded the string "pgAdmin 4". We've tried to keep that
>> title as a config option in config.py, so you should pull the string
>> from there rather than hard-coding it.
>>
>> - The connect test fails for me (Mac, Python 2.7). I have a suspicion
>> that this may be because when the test starts chromedriver, OS X
>> prompts the user about whether a listening port should be opened, but
>> the tests don't wait (though, I tested with 3 servers configured and
>> it failed with the same error on the second and third as well, long
>> after I clicked OK on the prompt):
>>
>> Traceback (most recent call last):
>> File
>> "/Users/dpage/git/pgadmin4/web/acceptance/test_connects_to_database.py",
>> line 32, in runTest
>> self.assertEqual("pgAdmin 4", self.driver.title)
>> AssertionError: 'pgAdmin 4' != u'localhost'
>>
>> - Please keep tests in the pgadmin. namespace (pgadmin.acceptance.??).
>>
>> - It looks like running a single test won't work yet (because of
>> TestsGeneratorRegistry.load_generators('pgadmin.%s.tests' %
>> arguments['pkg']))
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)
Thanks for bringing that to our attention! Here's the latest patch
On Fri, Jan 20, 2017 at 10:38 AM, Dave Page wrote:
> On Thu, Jan 19, 2017 at 10:07 PM, George Gelashvili
> wrote:
> >
> > Here is an updated patch which starts the server up when the test starts
> and
> > uses the values from config.py for server name etc. It still requires
> > installing chromedriver before running. Should we add something to the
> > readme about that?
>
> Yes, we definitely should (including download site URL)
>
> > On Tue, Jan 17, 2017 at 11:09 AM, Atira Odhner
> wrote:
> >>
> >> Thanks for your feedback, Dave!
> >>
> >> We can put the tests under the regression directory. I think that makes
> >> sense.
> >> I'm not picturing these tests being module specific, but we may want to
> >> enable running it as a separate suite of tests.
> >>
> >> Thanks for the callout about the port and title. We'll make sure those
> are
> >> pulled from config or that the pgAdmin server is spun up by the test
> with
> >> specific values.
> >>
> >> I have a couple ideas about why the test might not have been running for
> >> you. I think the patch we attached didn't spin up its own pgAdmin yet
> and it
> >> definitely doesn't fill in username/password if your app is running that
> >> way. That's part of the WIP-ness :-P
> >>
> >> -Tira
> >>
> >> Hi
> >>
> >> On Thu, Jan 12, 2017 at 10:41 PM, George Gelashvili
> >> wrote:
> >> > here's the patch we forgot to attach. Also, you can see work on our
> >> > branch
> >> > at:
> >> >
> >> > https://github.com/pivotalsoftware/pgadmin4/tree/
> pivotal/acceptance-tests
> >> >
> >> > On Thu, Jan 12, 2017 at 5:26 PM, George Gelashvili
> >> >
> >> > wrote:
> >> >>
> >> >> Hi there,
> >> >>
> >> >> We are working on browser-automation-based acceptance tests that
> >> >> exercise
> >> >> pgAdmin4 the way a user might.
> >>
> >> Nice!
> >>
> >> >> The first "connect to database" test works, but at the moment depends
> >> >> on
> >> >> Chrome and chromedriver. We would appreciate feedback on any possible
> >> >> license or code style issues at this point, as well as any thoughts
> on
> >> >> adding this sort of test to the codebase.
> >>
> >> A few thoughts:
> >>
> >> - If these tests are to run as part of the regression suite, the
> >> framework for them should live under that directory.
> >>
> >> - Are any of the tests likely to be module-specific? If so, they
> >> should really be part of the relevant module as the regression tests
> >> are. If they're more general/less tightly coupled, then I don't see a
> >> problem with them residing where they are.
> >>
> >> - Please take care not to include changes to .gitgnore files that
> >> aren't relevant to the rest of us.
> >>
> >> - The port number is hard-coded in the test.
> >>
> >> - You've hard-coded the string "pgAdmin 4". We've tried to keep that
> >> title as a config option in config.py, so you should pull the string
> >> from there rather than hard-coding it.
> >>
> >> - The connect test fails for me (Mac, Python 2.7). I have a suspicion
> >> that this may be because when the test starts chromedriver, OS X
> >> prompts the user about whether a listening port should be opened, but
> >> the tests don't wait (though, I tested with 3 servers configured and
> >> it failed with the same error on the second and third as well, long
> >> after I clicked OK on the prompt):
> >>
> >> Traceback (most recent call last):
> >> File
> >> "/Users/dpage/git/pgadmin4/web/acceptance/test_connects_
> to_database.py",
> >> line 32, in runTest
> >> self.assertEqual("pgAdmin 4", self.driver.title)
> >> AssertionError: 'pgAdmin 4' != u'localhost'
> >>
> >> - Please keep tests in the pgadmin. namespace (pgadmin.acceptance.??).
> >>
> >> - It looks like running a single test won't work yet (because of
> >> TestsGeneratorRegistry.load_generators('pgadmin.%s.tests' %
> >> arguments['pkg']))
> >>
> >> Thanks!
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >>
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/requirements_py2.txt b/requirements_py2.txt
index 51170a45..de167121 100644
--- a/requirements_py2.txt
+++ b/requirements_py2.txt
@@ -36,6 +36,7 @@ testscenarios==0.5.0
testtools==2.0.0
traceback2==1.4.0
unittest2==1.1.0
+selenium==3.0.2
Werkzeug==0.9.6
WTForms==2.0.2
sqlparse==0.1.19
diff --git a/requirements_py3.txt b/requirements_py3.txt
index f68db7a8..9565a6e4 100644
--- a/requirements_py3.txt
+++ b/requirements_py3.txt
@@ -35,6 +35,7 @@ testscenarios==0.5.0
testtools==2.0.0
traceback2==1.4.0
u
Re: [pgadmin-hackers] Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin
I tested in Google chrome Windows 2012 R2 64 with Python 2.7.11. It might
be possible that you tested on Python 3+.
Please confirm?
On Fri, Jan 20, 2017 at 6:49 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> That's strange.
>
> I tested in Chrome, Need check in IE.
>
> Meanwhile can try with Chrome/Firefox?
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas > wrote:
>
>> Hi Murtaza,
>>
>> I just applied this patch and issue is still not resolved.
>>
>> In case of Maintenance DB and Backup database message, *Maintenance job
>> created* and *Backup job created* displayed but no other dialogue box
>> displayed either process is completed or not.
>>
>> Screen-shot and pgadmin.log file is attached.
>>
>> Kind Regards,
>>
>>
>> On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Fahar,
>>>
>>> Could you please test this updated patch?
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <
>>> fahar.ab...@enterprisedb.com> wrote:
>>>
Thanks Dave.
On Tue, Jan 17, 2017 at 3:07 PM, Dave Page wrote:
> Not surprising. Don't bother testing that any more for now thanks. I
> suspect it's a simple bug that Ashesh can fix pronto.
>
> On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <
> fahar.ab...@enterprisedb.com> wrote:
>
>> Issue is also reproducible with PG-9.6 server.
>>
>> Regards,
>>
>>
>> On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <
>> fahar.ab...@enterprisedb.com> wrote:
>>
>>> Please attached the log files output from the terminal and
>>> pgAdmin4.log.
>>>
>>> Kind Regards,
>>>
>>>
>>> On Tue, Jan 17, 2017 at 2:46 PM, Dave Page
>>> wrote:
>>>
Thanks. What log output do you get?
On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <
fahar.ab...@enterprisedb.com> wrote:
> Hi Dave.
>
> After applying this patch on Windows 2012 server 64 with Python
> 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.
>
> Please find attached the snapshot.
>
> Kind Regards,
>
> On Wed, Jan 11, 2017 at 6:19 PM, Dave Page
> wrote:
>
>> Hi
>>
>> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Wed, Jan 11, 2017 at 12:03 PM, Dave Page
>>> wrote:
>>>
KeyError: u'end_time'
The status file contains:
{"start_time": "2017-01-11 06:27:20.939703 +", "pid":
49363, "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456
+"}
>>>
>>> Thanks for reviewing the patch.
>>> Please find the updated patch.
>>>
>>> Changes:
>>> - Using now ValueError instead of json.JSONDecodeError, which is
>>> subclass of ValueError, to allow to it to work with 2.6+ python.
>>> - Checking the existence of value in dict before accessing it.
>>>
>>>
>>>
>> That seems to work for me in a brief test on my Mac. :-)
>>
>> Fahar; are you able to apply and test this patch on Windows and
>> Linux, in server and desktop modes? Basically all the external
>> processes
>> should be tested - backup, restore & maintenance (vacuum) etc). I
>> don't
>> have any VMs available at the moment due to travel.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Syed Fahar Abbas
> Quality Management Group
>
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803 <+92%2051%208466803>
> Mobile: +92-333-5409707 <+92%20333%205409707>
> Skype ID: syed.fahar.abbas
> Website: www.enterprisedb.com
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>> --
>>> Syed Fahar Abbas
>>> Quality Management Group
>>>
>>> EnterpriseDB Corporation
>>> Phone Office: +92-51-835-8874
>>> Phone Direct: +92-51-84668
