Re: [pgadmin-hackers] First DataTable submission to CVS!!
>concerns will be (in the future, when your looking to integrate the code), >object/variable naming, consistant indenting (2 char), and licence the >comments. > Yes, thats fine. >1) Check the spelling of dtbFieldConstraint's values before you write too >much code around them. Thanks! >2) I don't like the italic/underline. I think plain for regular fields, and >bold + a colour for fkey/pkeys etc. Tell you what, what about making this a stylistic issue a property setting of some kind. We can then build in (in future if not at start) an option in the setting of options to diagram-pane ocx the way to represent these settings and make it a pgAdmin View Designer feature user-setable option. >3) Use of only 3 datatypes is not good. It should support any (including >custom) types, as does the rest of pgSchema/pgAdmin. Of course, this will >make the box bigger, but I think it's a must. Sorry, should have pointed out the fact that as this is early code to show you where I am heading I have not tried to flesh out all the Enum settings, and so I fully agree other data types are needed!!! >Looks pretty good though. You might want to drop email to Mark >([EMAIL PROTECTED]) he's the 3rd core developer but is usually >very quiet. He's been working on a similar sort of control on and off for >some time to represent a node on a network in a network mapping extension to >some other software we write. It strikes me that there will be many >similarities between the code in his and your controls, especially when it >comes to drawing & tracking many of them and drawing links between them. Thanks Dave, I will Tim. ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
[pgadmin-hackers] DataTable new upload
Dave, Jean-Michel, Mark, I have submitted a new set of files to the CVS in dev/datatable see the readme.txt in /dev/datatable for details - note I have NOT yet had time to implement all the suggestions Dav gave last time I uploaded a version. when commiting files to the cvs it asks for the log entry. I write one but it appears when you watch the command line window at the base it truncates what I write to about 50 charatcers followed by Does this mean I should only write this many charatcers in the log as the rest will be cut off? Thanks Tim. ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/users-lounge/docs/faq.html
[pgadmin-hackers] Help Documentation, coding Standards, typo
In coding standards help page, Dave, you have g down as your notation for Double but the example has dTotal as the example. I guess you mean 'd', so the is a typo. Coding Standards does not say what label controls should start with. Tim. ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [pgadmin-hackers] Latest DataTable Code
At 08:45 03/04/2002 +0100, Dave Page wrote: >Hi Tim, > >Apologies for not getting to this sooner... > >I just took a *quick* look at the latest DataTable code. Looks good, just 2 >things spring to mind: > >1) Resize doesn't appear to work either in design mode, or runtime. Next job on the to do list. The last thing I got working was the scroll bar in readiness for the resize work. >2) Consider using a true collection for m_dtbFields. That way, you can index >them by name & numeric index, have an unlimited amount (someone will go over >127, I'm sure!), and expose the collection to the client application >(similar to how the listview exposes the listitems collection. OK. >Regards, Dave. ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [pgadmin-hackers] RFD: PostgreSQL Schema Support
At 13:40 05/04/2002 +0100, Dave Page wrote: >I'm currently starting to implement support for some of the more desirable >features of PostgreSQL 7.3 which is now well in development. One of these I wish the desirable features for 7.3 included all of alter table implemented. Do you know if it is BTW? A bit out of touch with the 'to do' and 'Now done' lists. >There are a number of ways we could implement this, and I'd like to get some >feedback on what people think is right. Tricky. My gut feeling is get the classes / object model as close as possible to what PostgreSQL exposes. As stated for 7.2 and before this is one thing, for 7.3 onwards its another. Perhaps you can freeze pgAdminII code base at some soon point, make it known this is where support for 7.2 and earlier ends, and move the version number up a notch and follow through with the 7.3 only route from here on in? Perhaps for a season offer bug fixe releases only to the frozen 7.2 version, with a cut off date, roughly in keeping with the expected adoption rate of 7.3. For us mere NT/2000 folk, perhaps also wait until 7.3 is out on Cygwin, too before freezing all support for 7.2. Ahhh, the wonderful world of open source Its like looking at the best countryside in full clarity. but whilst sitting on a train, the view always keeps shifting.. Tim Finch, FosterFinch Ltd http://www.fosterfinch.co.uk ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
