pgsql: Add missing pg_basebackup TAP test for meson.

2023-06-15 Thread Masahiko Sawada
Add missing pg_basebackup TAP test for meson.

011_in_place_tablespace was missing from the list of pg_basebackup
tests to run under meson, so add it.

Oversight in 363e8f9115.

Discussion: 
https://postgr.es/m/CAD21AoDTh1A8bvNBF3LQNQg=27xtpsgvpt+4_yyej6p4zv8...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/0225eec80bddbf69d0509851b2df2bafd62fcc30

Modified Files
--
src/bin/pg_basebackup/meson.build | 1 +
1 file changed, 1 insertion(+)



pgsql: Fix typo in comment.

2023-06-15 Thread Amit Langote
Fix typo in comment.

Back-patch down to 11.

Author: Sho Kato ()
Discussion: 
https://postgr.es/m/TYCPR01MB68499042A33BC32241193AAF9F5BA%40TYCPR01MB6849.jpnprd01.prod.outlook.com

Branch
--
REL_11_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b103d616caeb6a06e9391be1cb1e7483b328e641

Modified Files
--
src/backend/rewrite/rewriteHandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix typo in comment.

2023-06-15 Thread Amit Langote
Fix typo in comment.

Back-patch down to 11.

Author: Sho Kato ()
Discussion: 
https://postgr.es/m/TYCPR01MB68499042A33BC32241193AAF9F5BA%40TYCPR01MB6849.jpnprd01.prod.outlook.com

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2f6e826f65798ccdb3860f346e9bef58c1c962c3

Modified Files
--
src/backend/rewrite/rewriteHandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix typo in comment.

2023-06-15 Thread Amit Langote
Fix typo in comment.

Back-patch down to 11.

Author: Sho Kato ()
Discussion: 
https://postgr.es/m/TYCPR01MB68499042A33BC32241193AAF9F5BA%40TYCPR01MB6849.jpnprd01.prod.outlook.com

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d5300bc79dff0ada2132d82d59dfe1703a6e9ed1

Modified Files
--
src/backend/rewrite/rewriteHandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix typo in comment.

2023-06-15 Thread Amit Langote
Fix typo in comment.

Back-patch down to 11.

Author: Sho Kato ()
Discussion: 
https://postgr.es/m/TYCPR01MB68499042A33BC32241193AAF9F5BA%40TYCPR01MB6849.jpnprd01.prod.outlook.com

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/3f157d085bd72a69fabd6e2621800204c19cc76f

Modified Files
--
src/backend/rewrite/rewriteHandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix typo in comment.

2023-06-15 Thread Amit Langote
Fix typo in comment.

Back-patch down to 11.

Author: Sho Kato ()
Discussion: 
https://postgr.es/m/TYCPR01MB68499042A33BC32241193AAF9F5BA%40TYCPR01MB6849.jpnprd01.prod.outlook.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/160c23b5fa0243d2f743cc70c96dac44d9932645

Modified Files
--
src/backend/rewrite/rewriteHandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix typo in comment.

2023-06-15 Thread Amit Langote
Fix typo in comment.

Back-patch down to 11.

Author: Sho Kato ()
Discussion: 
https://postgr.es/m/TYCPR01MB68499042A33BC32241193AAF9F5BA%40TYCPR01MB6849.jpnprd01.prod.outlook.com

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/35470357ee4c6f05b78926d3e07a45d8712f3130

Modified Files
--
src/backend/rewrite/rewriteHandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: When removing a left join, clean out references in EquivalenceCl

2023-06-15 Thread Tom Lane
When removing a left join, clean out references in EquivalenceClasses.

Since commit b448f1c8d, we've been able to remove left joins
(that are otherwise removable) even when they are underneath
other left joins, a case that was previously prevented by a
delay_upper_joins check.  This is a clear improvement, but
it has a surprising side-effect: it's now possible that there
are EquivalenceClasses whose relid sets mention the removed
baserel and/or outer join.  If we fail to clean those up,
we may drop essential join quals due to not having any join
level that appears to satisfy their relid sets.

(It's not quite 100% clear that this was impossible before.
But the lack of complaints since we added join removal a dozen
years ago strongly suggests that it was impossible.)

Richard Guo and Tom Lane, per bug #17976 from Zuming Jiang

Discussion: https://postgr.es/m/17976-4b638b525e9a9...@postgresql.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f4c00d138f6dea4c9d8af8ec280b7edc9b0a29e1

Modified Files
--
src/backend/optimizer/plan/analyzejoins.c | 68 +++
src/test/regress/expected/join.out| 31 ++
src/test/regress/sql/join.sql | 23 +++
3 files changed, 122 insertions(+)



pgsql: Remove outdated reference to a removed file

2023-06-15 Thread Amit Langote
Remove outdated reference to a removed file

parse_jsontable.c was removed as part of 2f2b18bd3f55, though its
mention in src/backend/parser/README was not.  Fix that.

Discussion: 
https://postgr.es/m/CA%2BHiwqHDzw8AP8p_dEkFr0xg458ZTf58zbivAHhK4UeNrx9Tdg%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/5c8c8079b0f93bb714b14e4ce9b463411cad7db4

Modified Files
--
src/backend/parser/README | 1 -
1 file changed, 1 deletion(-)



pgsql: libpq: Fix up some error message coding

2023-06-15 Thread Peter Eisentraut
libpq: Fix up some error message coding

This applies the new error message API from commit 0873b2d354 to the
changes introduced by bbf9c282ce.  The latter was committed shortly
after the former, so it probably didn't get the news in time.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/d6326ba8fe69ced797412ea9bb97b2f35588f791

Modified Files
--
src/interfaces/libpq/fe-protocol3.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)



pgsql: Add missing subscription TAP test for meson

2023-06-15 Thread Michael Paquier
Add missing subscription TAP test for meson

033_run_as_table_owner was missing from the list of subscription tests
to run under meson, so add it.

Oversight in 4826759.

Author: Hayato Kuroda
Discussion: 
https://postgr.es/m/tyapr01mb58668f4d85a9a122a158f442f5...@tyapr01mb5866.jpnprd01.prod.outlook.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ac68323a8788a881aa37671126346c08b1b08091

Modified Files
--
src/test/subscription/meson.build | 1 +
1 file changed, 1 insertion(+)



pgsql: Replace GUC_UNIT_MEMORY|GUC_UNIT_TIME with GUC_UNIT.

2023-06-15 Thread Masahiko Sawada
Replace GUC_UNIT_MEMORY|GUC_UNIT_TIME with GUC_UNIT.

We used (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT some
places but we already define it in guc.h. This commit replaces them
with GUC_UNIT for better consistency with their surrounding code.

Author: Japin Li
Reviewed-by: Richard Guo, Michael Paquier, Masahiko Sawada
Discussion: 
https://postgr.es/m/meyp282mb1669ec0fed922f7a151673acb6...@meyp282mb1669.ausp282.prod.outlook.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a54fc892ad0a5673d75b199128b1f5fcf5e1a41d

Modified Files
--
src/backend/utils/misc/guc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)