pgsql: doc PG 17 relnotes: wording adjustments

2024-05-15 Thread Bruce Momjian
doc PG 17 relnotes:  wording adjustments

Reported-by: jian he

Discussion: 
https://postgr.es/m/cacjufxhtjbqdmbc4ipgte_xd4amgonrm680ji5m5gca8+ye...@mail.gmail.com

Co-authored-by: jian he

Backpatch-through: master

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f6ebb418317a1e84be46e7e7b02a26d8c44984de

Modified Files
--
doc/src/sgml/release-17.sgml | 8 
1 file changed, 4 insertions(+), 4 deletions(-)



pgsql: doc PG 17 relnotes: add item about vacuum storage/limits/WAL

2024-05-15 Thread Bruce Momjian
doc PG 17 relnotes:  add item about vacuum storage/limits/WAL

Reported-by: Alvaro Herrera

Discussion: https://postgr.es/m/202405150838.sg5ddcexyyf4@alvherre.pgsql

Backpatch-through: master

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a8010d03e1f30c657b6c868fa857c7b8b53c3fbc

Modified Files
--
doc/src/sgml/release-17.sgml | 19 +++
1 file changed, 19 insertions(+)



pgsql: jit: Remove {llvm-config,clang}-N configure probes.

2024-05-15 Thread Thomas Munro
jit: Remove {llvm-config,clang}-N configure probes.

Previously we searched for llvm-config-N and clang-N as well as the
unversioned names, and maintained a list of expected values of N.  There
doesn't seem to be any reason to think that the default llvm-config and
clang won't be good enough, and if they aren't, they can be overridden
with LLVM_CONFIG and CLANG, so let's stop maintaining that list.

The list had not been updated since LLVM 7 with no complaints, so commit
820b5af73dc probably should have just removed it when dropping support
for 7, instead of trying to be helpful by bringing it up to date with
recent version numbers.

The Meson build system didn't have that, so no change there.

Suggested-by: Peter Eisentraut 
Discussion: 
https://postgr.es/m/CA%2BhUKG%2BSOP-aR%3DYF_n0dtXGWeCy6x%2BCn-RMWURU5ySQdmeKW1Q%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/4dd29b683334739168f60df520dcc9218b6fead7

Modified Files
--
config/llvm.m4 | 4 ++--
configure  | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)



pgsql: Fix some inconsistencies in EXPLAIN output

2024-05-15 Thread David Rowley
Fix some inconsistencies in EXPLAIN output

06286709e added a SERIALIZE option to EXPLAIN which included showing the
amount of kilobytes serialized.  The calculation to convert bytes into
kilobytes wasn't consistent with how that's done in the rest of EXPLAIN.
Traditionally we round up to the nearest kB, but the new code rounded to
the nearest kB.

To fix this, invent a macro that does the conversion and use that macro
everywhere that requires this conversion.

Additionally, 5de890e36 added EXPLAIN (MEMORY) but included the memory
sizes in bytes.  Convert these values to kilobytes to align with the
other memory related outputs.

In passing, swap out a "long" type in show_hash_info() and use a uint64
instead.  We do support platforms where sizeof(Size) == 8 and
sizeof(long) == 4, so using a long there is questionable.

Reported-by: jian he
Reviewed-by: jian he
Discussion: 
https://www.postgresql.org/message-id/cacjufxe4sp7xvgowhqtfx5hs85axmkobpwdo-xzhzvtpk3e...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/0de37b51065bc5b5848d65a9bb6f932ef392374f

Modified Files
--
src/backend/commands/explain.c| 48 ---
src/test/regress/expected/explain.out |  6 ++---
2 files changed, 30 insertions(+), 24 deletions(-)



pgsql: doc: Mention more variant --name=value of -c name=value for post

2024-05-15 Thread Michael Paquier
doc: Mention more variant --name=value of -c name=value for postgres

postgres --name=value and -c name=value are equivalents.  This commit
expands the documentation of libpq's "option" connection parameter and
the server startup sequence for shell interactions to mention both
rather than only -c.

Extracted from a larger patch by the same authors.

Reported-by: Alexey Palazhchenko
Author: David Johnston, Aleksander Alekseev
Reviewed-by: Nathan Bossart, Peter Eisentraut, Álvaro Herrera
Discussion: 
https://postgr.es/m/CAJ7c6TMkuLiLfrA+EFCPYfhXoMKRxxssB5c86+ibxfaz6+=s...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f01e3ba56fd125ccba65b23a1829fc25b6f3fc65

Modified Files
--
doc/src/sgml/config.sgml | 11 ++-
doc/src/sgml/libpq.sgml  |  7 ---
2 files changed, 10 insertions(+), 8 deletions(-)



pgsql: Doc: update src/tools/pgindent/README for current practice.

2024-05-15 Thread Tom Lane
Doc: update src/tools/pgindent/README for current practice.

This README explains how to run pgindent, but it was written
for our former practice of running pgindent only infrequently.
Nowadays the plan is to keep the tree indent-clean all the time,
so the typical thing is to do an incremental pgindent run with
each commit.  Revise to explain that as the normal case, and
the infrequent full-on process as a separate thing.

For now, pgperltidy is still a run-it-infrequently item.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/3c03ee1a39c0f808cb261a207b6d465c606598bf

Modified Files
--
src/tools/pgindent/README | 79 +++
1 file changed, 45 insertions(+), 34 deletions(-)



pgsql: Fix query result leak during binary upgrade

2024-05-15 Thread Daniel Gustafsson
Fix query result leak during binary upgrade

9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional.  353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.

Reviewed-by: Tom Lane 
Discussion: https://postgr.es/m/374550c1-f4ed-4d9d-9498-0fd029ccf...@yesql.se
Backpatch-through: v15

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/e6fc3b70df906868df36517c2c7c5a38725e1451

Modified Files
--
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



pgsql: Fix query result leak during binary upgrade

2024-05-15 Thread Daniel Gustafsson
Fix query result leak during binary upgrade

9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional.  353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.

Reviewed-by: Tom Lane 
Discussion: https://postgr.es/m/374550c1-f4ed-4d9d-9498-0fd029ccf...@yesql.se
Backpatch-through: v15

Branch
--
REL_16_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/0ae05c18e0bf740e6457e710f9323e75f6619c35

Modified Files
--
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



pgsql: Fix query result leak during binary upgrade

2024-05-15 Thread Daniel Gustafsson
Fix query result leak during binary upgrade

9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional.  353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.

Reviewed-by: Tom Lane 
Discussion: https://postgr.es/m/374550c1-f4ed-4d9d-9498-0fd029ccf...@yesql.se
Backpatch-through: v15

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a8f87d5d21c2f3ddd644c9cb313ecd43290a446e

Modified Files
--
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



pgsql: Re-forbid underscore in positional parameters

2024-05-15 Thread Peter Eisentraut
Re-forbid underscore in positional parameters

Underscores were added to numeric literals in faff8f8e47.  This change
also affected the positional parameters (e.g., $1) rule, which uses
the same production for its digits.  But this did not actually work,
because the digits for parameters are processed using atol(), which
does not handle underscores and ignores whatever it cannot parse.

The underscores notation is probably not useful for positional
parameters, so for simplicity revert that rule to its old form that
only accepts digits 0-9.

Author: Erik Wienhold 
Reviewed-by: Michael Paquier 
Discussion: 
https://www.postgresql.org/message-id/flat/5d216d1c-91f6-4cbe-95e2-b4cbd930520c%40ewie.name

Branch
--
REL_16_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/315661ecafbcbb23116cceea2ea80657d7763af0

Modified Files
--
src/backend/parser/scan.l| 5 +++--
src/fe_utils/psqlscan.l  | 5 +++--
src/interfaces/ecpg/preproc/pgc.l| 5 +++--
src/test/regress/expected/numerology.out | 4 
src/test/regress/sql/numerology.sql  | 1 +
5 files changed, 14 insertions(+), 6 deletions(-)



pgsql: Re-forbid underscore in positional parameters

2024-05-15 Thread Peter Eisentraut
Re-forbid underscore in positional parameters

Underscores were added to numeric literals in faff8f8e47.  This change
also affected the positional parameters (e.g., $1) rule, which uses
the same production for its digits.  But this did not actually work,
because the digits for parameters are processed using atol(), which
does not handle underscores and ignores whatever it cannot parse.

The underscores notation is probably not useful for positional
parameters, so for simplicity revert that rule to its old form that
only accepts digits 0-9.

Author: Erik Wienhold 
Reviewed-by: Michael Paquier 
Discussion: 
https://www.postgresql.org/message-id/flat/5d216d1c-91f6-4cbe-95e2-b4cbd930520c%40ewie.name

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/98b4f53d156efe09294d6e1d62a5b52f544eee29

Modified Files
--
src/backend/parser/scan.l| 5 +++--
src/fe_utils/psqlscan.l  | 5 +++--
src/interfaces/ecpg/preproc/pgc.l| 5 +++--
src/test/regress/expected/numerology.out | 4 
src/test/regress/sql/numerology.sql  | 1 +
5 files changed, 14 insertions(+), 6 deletions(-)



pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables

Erroneously introduced by 571df93cff8.

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/a826021e562450abb3b9682087111029f2319330

Modified Files
--
doc/src/sgml/ref/initdb.sgml | 6 --
doc/src/sgml/ref/pg_ctl-ref.sgml | 7 ---
2 files changed, 13 deletions(-)



pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables

Erroneously introduced by 571df93cff8.

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b284513752529652344ce496df3b844b797dd6b4

Modified Files
--
doc/src/sgml/ref/initdb.sgml | 6 --
doc/src/sgml/ref/pg_ctl-ref.sgml | 7 ---
2 files changed, 13 deletions(-)



pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables

Erroneously introduced by 571df93cff8.

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/3566fc0150acd569079a90a65c4d2a2b501e067f

Modified Files
--
doc/src/sgml/ref/initdb.sgml | 6 --
doc/src/sgml/ref/pg_ctl-ref.sgml | 7 ---
2 files changed, 13 deletions(-)



pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables

Erroneously introduced by 571df93cff8.

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
REL_16_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/987ab19ec9260618b36c186e0777f0bd43b8ded1

Modified Files
--
doc/src/sgml/ref/initdb.sgml | 6 --
doc/src/sgml/ref/pg_ctl-ref.sgml | 7 ---
2 files changed, 13 deletions(-)



pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables

Erroneously introduced by 571df93cff8.

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/4f8ff6af1fdca2b33434dd61d4ace7cb480afa21

Modified Files
--
doc/src/sgml/ref/initdb.sgml | 6 --
doc/src/sgml/ref/pg_ctl-ref.sgml | 7 ---
2 files changed, 13 deletions(-)



pgsql: doc: Add standard Environment section to pg_amcheck ref page

2024-05-15 Thread Peter Eisentraut
doc: Add standard Environment section to pg_amcheck ref page

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/cff942453f21ad13db28d820711a45ec94e856a2

Modified Files
--
doc/src/sgml/ref/pg_amcheck.sgml | 18 ++
1 file changed, 18 insertions(+)



pgsql: doc: Add standard Environment section to pg_upgrade ref page

2024-05-15 Thread Peter Eisentraut
doc: Add standard Environment section to pg_upgrade ref page

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/96bc29edfde9b8ad0de573702a6b1c55f73ce912

Modified Files
--
doc/src/sgml/ref/pgupgrade.sgml | 98 +
1 file changed, 98 insertions(+)



pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables

Erroneously introduced by 571df93cff8.

Reviewed-by: Daniel Gustafsson 
Discussion: 
https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2e2b2d076ab62c7850aaca65d1b575f602a9ce6d

Modified Files
--
doc/src/sgml/ref/initdb.sgml | 6 --
doc/src/sgml/ref/pg_ctl-ref.sgml | 7 ---
2 files changed, 13 deletions(-)



pgsql: Remove stray blank line among gram.y keywords

2024-05-15 Thread Peter Eisentraut
Remove stray blank line among gram.y keywords

introduced by de3600452b

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/54cf0c51184fde6e4c01059be0080b5a60ce6802

Modified Files
--
src/backend/parser/gram.y | 1 -
1 file changed, 1 deletion(-)



pgsql: Make all Perl warnings fatal, catch-up

2024-05-15 Thread Peter Eisentraut
Make all Perl warnings fatal, catch-up

Apply c5385929593 to new Perl files that had missed the note.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/cc70e170c0213977c106a61c8cedeaac83136c3d

Modified Files
--
src/bin/pg_walsummary/t/001_basic.pl| 2 +-
src/bin/pg_walsummary/t/002_blocks.pl   | 2 +-
src/common/unicode/generate-unicode_case_table.pl   | 2 +-
src/test/modules/test_json_parser/t/001_test_json_parser_incremental.pl | 2 +-
src/test/modules/test_json_parser/t/002_inline.pl   | 2 +-
src/test/modules/test_json_parser/t/003_test_semantic.pl| 2 +-
src/test/modules/test_json_parser/t/004_test_parser_perf.pl | 2 +-
src/test/modules/test_misc/t/005_timeouts.pl| 2 +-
src/test/recovery/t/040_standby_failover_slots_sync.pl  | 2 +-
src/test/recovery/t/041_checkpoint_at_promote.pl| 2 +-
src/test/recovery/t/042_low_level_backup.pl | 2 +-
11 files changed, 11 insertions(+), 11 deletions(-)