pgsql: Revert "Remove reset of testtablespace from pg_regress on Window
Revert "Remove reset of testtablespace from pg_regress on Windows" This reverts commit 2b2a070, that moved the reset of path "testtablespace" used by the regression tests as a path for tablespaces (via --outputdir) from pg_regress to the MSVC script vcregress.pl, as this broke the behavior added by ce5d342 to be able to safely run the regression test suite with an administrative Windows account using a restricted token. Note that before 2b2a070, the code doing the reset in pg_regress.c included a comment telling that we had better move that out to a different place, leading to the mistake done in 2b2a070. Fix this comment, and document instead that we had better never remove this code, for the sake of not breaking again the behavior we expect on Windows. Thanks to Thomas Munro and Andrew Dunstan for the discussion. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/ca+hukgliieezfrdwxwfe+_wnxho_f5smx972x1weubhs7v1...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/61be85afabba0cd85bb1bcaacbea8efa8641f564 Modified Files -- src/test/regress/pg_regress.c | 19 +++ src/tools/msvc/vcregress.pl | 17 ++--- 2 files changed, 21 insertions(+), 15 deletions(-)
Re: pgsql: Remove reset of testtablespace from pg_regress on Windows
On Thu, Jul 09, 2020 at 10:21:57PM -0400, Andrew Dunstan wrote: > I certainly agree we should document more clearly why it's there, to > help forestall anyone else who comes along and thinks it would just be > neater to remove it. so +1. Okay. Done, then. -- Michael signature.asc Description: PGP signature
pgsql: Add missing tags in application doc
Add missing tags in application doc s Most of them already have this, but some were missing. Author: Author: Dagfinn Ilmari Mannsåker Discussion: https://www.postgresql.org/message-id/flat/87o8pco34z.fsf%40wibble.ilmari.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/72a16cb3ee3017ccd8e4d58ea3c0c7bceec8b702 Modified Files -- doc/src/sgml/ref/initdb.sgml | 2 +- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- doc/src/sgml/ref/pg_config-ref.sgml | 2 +- doc/src/sgml/ref/pg_dump.sgml | 2 +- doc/src/sgml/ref/pg_receivewal.sgml | 2 +- doc/src/sgml/ref/pg_restore.sgml | 2 +- doc/src/sgml/ref/pg_verifybackup.sgml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)
pgsql: Doc: update or remove dead external links.
Doc: update or remove dead external links. Re-point comp.ai.genetic FAQ link to a more stable address. Remove stale links to AIX documentation; we don't really need to tell AIX users how to use their systems. Remove stale links to HP documentation about SSL. We've had to update those twice before, making it increasingly obvious that HP does not intend them to be stable landing points. They're not particularly authoritative, either. (This change effectively reverts bbd3bdba3.) Daniel Gustafsson and Álvaro Herrera, per a gripe from Kyotaro Horiguchi. Back-patch, since these links are just as dead in the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/da76f05e276caea502b04365b136d719237667e8 Modified Files -- doc/src/sgml/geqo.sgml | 2 +- doc/src/sgml/installation.sgml | 56 -- doc/src/sgml/libpq.sgml| 3 --- doc/src/sgml/runtime.sgml | 3 --- 4 files changed, 1 insertion(+), 63 deletions(-)
pgsql: Doc: update or remove dead external links.
Doc: update or remove dead external links. Re-point comp.ai.genetic FAQ link to a more stable address. Remove stale links to AIX documentation; we don't really need to tell AIX users how to use their systems. Remove stale links to HP documentation about SSL. We've had to update those twice before, making it increasingly obvious that HP does not intend them to be stable landing points. They're not particularly authoritative, either. (This change effectively reverts bbd3bdba3.) Daniel Gustafsson and Álvaro Herrera, per a gripe from Kyotaro Horiguchi. Back-patch, since these links are just as dead in the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e91cd951b1114a009a0256f211a41d0ec873b2fc Modified Files -- doc/src/sgml/geqo.sgml | 2 +- doc/src/sgml/installation.sgml | 56 -- doc/src/sgml/libpq.sgml| 3 --- doc/src/sgml/runtime.sgml | 3 --- 4 files changed, 1 insertion(+), 63 deletions(-)
pgsql: Doc: update or remove dead external links.
Doc: update or remove dead external links. Re-point comp.ai.genetic FAQ link to a more stable address. Remove stale links to AIX documentation; we don't really need to tell AIX users how to use their systems. Remove stale links to HP documentation about SSL. We've had to update those twice before, making it increasingly obvious that HP does not intend them to be stable landing points. They're not particularly authoritative, either. (This change effectively reverts bbd3bdba3.) Daniel Gustafsson and Álvaro Herrera, per a gripe from Kyotaro Horiguchi. Back-patch, since these links are just as dead in the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/df1265087900c068489c47b4934f96f8f0f3ec59 Modified Files -- doc/src/sgml/geqo.sgml | 2 +- doc/src/sgml/installation.sgml | 56 -- doc/src/sgml/libpq.sgml| 3 --- doc/src/sgml/runtime.sgml | 3 --- 4 files changed, 1 insertion(+), 63 deletions(-)
pgsql: Doc: update or remove dead external links.
Doc: update or remove dead external links. Re-point comp.ai.genetic FAQ link to a more stable address. Remove stale links to AIX documentation; we don't really need to tell AIX users how to use their systems. Remove stale links to HP documentation about SSL. We've had to update those twice before, making it increasingly obvious that HP does not intend them to be stable landing points. They're not particularly authoritative, either. (This change effectively reverts bbd3bdba3.) Daniel Gustafsson and Álvaro Herrera, per a gripe from Kyotaro Horiguchi. Back-patch, since these links are just as dead in the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a20535da7273186361a2a82a558658135cb9ab07 Modified Files -- doc/src/sgml/geqo.sgml | 2 +- doc/src/sgml/installation.sgml | 56 -- doc/src/sgml/libpq.sgml| 3 --- doc/src/sgml/runtime.sgml | 3 --- 4 files changed, 1 insertion(+), 63 deletions(-)
pgsql: Doc: update or remove dead external links.
Doc: update or remove dead external links. Re-point comp.ai.genetic FAQ link to a more stable address. Remove stale links to AIX documentation; we don't really need to tell AIX users how to use their systems. Remove stale links to HP documentation about SSL. We've had to update those twice before, making it increasingly obvious that HP does not intend them to be stable landing points. They're not particularly authoritative, either. (This change effectively reverts bbd3bdba3.) Daniel Gustafsson and Álvaro Herrera, per a gripe from Kyotaro Horiguchi. Back-patch, since these links are just as dead in the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a5f18e8c2180ccfff07380efe52f93e9491dd9b5 Modified Files -- doc/src/sgml/geqo.sgml | 2 +- doc/src/sgml/installation.sgml | 56 -- doc/src/sgml/libpq.sgml| 3 --- doc/src/sgml/runtime.sgml | 3 --- 4 files changed, 1 insertion(+), 63 deletions(-)
pgsql: Doc: update or remove dead external links.
Doc: update or remove dead external links. Re-point comp.ai.genetic FAQ link to a more stable address. Remove stale links to AIX documentation; we don't really need to tell AIX users how to use their systems. Remove stale links to HP documentation about SSL. We've had to update those twice before, making it increasingly obvious that HP does not intend them to be stable landing points. They're not particularly authoritative, either. (This change effectively reverts bbd3bdba3.) Daniel Gustafsson and Álvaro Herrera, per a gripe from Kyotaro Horiguchi. Back-patch, since these links are just as dead in the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/763a0b63a25c13ac940ce2c64b37b8446ccbf895 Modified Files -- doc/src/sgml/geqo.sgml | 2 +- doc/src/sgml/installation.sgml | 56 -- doc/src/sgml/libpq.sgml| 3 --- doc/src/sgml/runtime.sgml | 3 --- 4 files changed, 1 insertion(+), 63 deletions(-)
pgsql: Doc: update or remove dead external links.
Doc: update or remove dead external links. Re-point comp.ai.genetic FAQ link to a more stable address. Remove stale links to AIX documentation; we don't really need to tell AIX users how to use their systems. Remove stale links to HP documentation about SSL. We've had to update those twice before, making it increasingly obvious that HP does not intend them to be stable landing points. They're not particularly authoritative, either. (This change effectively reverts bbd3bdba3.) Daniel Gustafsson and Álvaro Herrera, per a gripe from Kyotaro Horiguchi. Back-patch, since these links are just as dead in the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0ecd36ee0e49250048f038c81fbc12b4102caa7e Modified Files -- doc/src/sgml/geqo.sgml | 2 +- doc/src/sgml/installation.sgml | 56 -- doc/src/sgml/libpq.sgml| 3 --- doc/src/sgml/runtime.sgml | 3 --- 4 files changed, 1 insertion(+), 63 deletions(-)
pgsql: Forbid numeric NaN in jsonpath
Forbid numeric NaN in jsonpath SQL standard doesn't define numeric Inf or NaN values. It appears even more ridiculous to support then in jsonpath assuming JSON doesn't support these values as well. This commit forbids returning NaN from .double(), which was previously allowed. NaN can't be result of inner-jsonpath computation over non-NaNs. So, we can not expect NaN in the jsonpath output. Reported-by: Tom Lane Discussion: https://postgr.es/m/203949.1591879542%40sss.pgh.pa.us Author: Alexander Korotkov Reviewed-by: Tom Lane Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/df646509f371069c65f84309eb5749642e8650b3 Modified Files -- src/backend/utils/adt/jsonb_util.c | 8 src/backend/utils/adt/jsonpath_exec.c| 15 --- src/test/regress/expected/jsonb_jsonpath.out | 12 ++-- 3 files changed, 10 insertions(+), 25 deletions(-)
pgsql: Forbid numeric NaN in jsonpath
Forbid numeric NaN in jsonpath SQL standard doesn't define numeric Inf or NaN values. It appears even more ridiculous to support then in jsonpath assuming JSON doesn't support these values as well. This commit forbids returning NaN from .double(), which was previously allowed. NaN can't be result of inner-jsonpath computation over non-NaNs. So, we can not expect NaN in the jsonpath output. Reported-by: Tom Lane Discussion: https://postgr.es/m/203949.1591879542%40sss.pgh.pa.us Author: Alexander Korotkov Reviewed-by: Tom Lane Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f4ae676e3178124c2bc2b3a3530efe8f3cdbc442 Modified Files -- src/backend/utils/adt/jsonb_util.c | 8 src/backend/utils/adt/jsonpath_exec.c| 15 --- src/test/regress/expected/jsonb_jsonpath.out | 12 ++-- 3 files changed, 10 insertions(+), 25 deletions(-)
pgsql: Forbid numeric NaN in jsonpath
Forbid numeric NaN in jsonpath SQL standard doesn't define numeric Inf or NaN values. It appears even more ridiculous to support then in jsonpath assuming JSON doesn't support these values as well. This commit forbids returning NaN from .double(), which was previously allowed. NaN can't be result of inner-jsonpath computation over non-NaNs. So, we can not expect NaN in the jsonpath output. Reported-by: Tom Lane Discussion: https://postgr.es/m/203949.1591879542%40sss.pgh.pa.us Author: Alexander Korotkov Reviewed-by: Tom Lane Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/89a0b1a7ca0af36818ed7076c12ac00bcf4f007d Modified Files -- src/backend/utils/adt/jsonb_util.c | 8 src/backend/utils/adt/jsonpath_exec.c| 15 --- src/test/regress/expected/jsonb_jsonpath.out | 12 ++-- 3 files changed, 10 insertions(+), 25 deletions(-)
pgsql: Improve error reporting for jsonpath .double() method
Improve error reporting for jsonpath .double() method When jsonpath .double() method detects that numeric or string can't be converted to double precision, it throws an error. This commit makes these errors explicitly express the reason of failure. Discussion: https://postgr.es/m/CAPpHfdtqJtiSXkP7tOXez18NxhLUH_-75bL8%3DOce4Ki%2Bbv7V6Q%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Tom Lane Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b9a04a9bc6653183ed23532145325694fbc46002 Modified Files -- src/backend/utils/adt/jsonpath_exec.c| 4 ++-- src/test/regress/expected/jsonb_jsonpath.out | 8 +--- src/test/regress/sql/jsonb_jsonpath.sql | 1 + 3 files changed, 8 insertions(+), 5 deletions(-)
pgsql: Improve error reporting for jsonpath .double() method
Improve error reporting for jsonpath .double() method When jsonpath .double() method detects that numeric or string can't be converted to double precision, it throws an error. This commit makes these errors explicitly express the reason of failure. Discussion: https://postgr.es/m/CAPpHfdtqJtiSXkP7tOXez18NxhLUH_-75bL8%3DOce4Ki%2Bbv7V6Q%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Tom Lane Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3ec5f6b53dfb6acfe66a952edef1b6887da91777 Modified Files -- src/backend/utils/adt/jsonpath_exec.c| 4 ++-- src/test/regress/expected/jsonb_jsonpath.out | 8 +--- src/test/regress/sql/jsonb_jsonpath.sql | 1 + 3 files changed, 8 insertions(+), 5 deletions(-)
pgsql: Improve error reporting for jsonpath .double() method
Improve error reporting for jsonpath .double() method When jsonpath .double() method detects that numeric or string can't be converted to double precision, it throws an error. This commit makes these errors explicitly express the reason of failure. Discussion: https://postgr.es/m/CAPpHfdtqJtiSXkP7tOXez18NxhLUH_-75bL8%3DOce4Ki%2Bbv7V6Q%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Tom Lane Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0657181167467ec5cfb5a28aacf47ca02f5f4588 Modified Files -- src/backend/utils/adt/jsonpath_exec.c| 4 ++-- src/test/regress/expected/jsonb_jsonpath.out | 8 +--- src/test/regress/sql/jsonb_jsonpath.sql | 1 + 3 files changed, 8 insertions(+), 5 deletions(-)
pgsql: Rename field "relkind" to "objtype" for CTAS and ALTER TABLE nod
Rename field "relkind" to "objtype" for CTAS and ALTER TABLE nodes "relkind" normally refers to the char field from pg_class. However, in the parse nodes AlterTableStmt and CreateTableAsStmt, "relkind" was used for a field of type enum ObjectType, that could refer to other object types than those possible for a relkind. Such fields being usually named "objtype", switch the name in both structures to make things more consistent. Note that this led to some confusion in functions that also operate on a RangeTableEntry object, which also has a field named "relkind". This naming goes back to commit 09d4e96, where only OBJECT_TABLE and OBJECT_INDEX were used. This got extended later to use as well OBJECT_TYPE with e440e12, not really a relation kind. Author: Mark Dilger Reviewed-by: Daniel Gustafsson, Álvaro Herrera, Michael Paquier Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cc35d8933a211d9965eb1c1d2749a903d5735db2 Modified Files -- src/backend/commands/tablecmds.c | 4 ++-- src/backend/nodes/copyfuncs.c | 4 ++-- src/backend/nodes/equalfuncs.c | 4 ++-- src/backend/parser/analyze.c | 4 ++-- src/backend/parser/gram.y | 44 +++--- src/backend/parser/parse_utilcmd.c | 6 +++--- src/backend/tcop/utility.c | 4 ++-- src/include/nodes/parsenodes.h | 4 ++-- 8 files changed, 37 insertions(+), 37 deletions(-)
