pgsql: doc: Improve description of min_dynamic_shared_memory
doc: Improve description of min_dynamic_shared_memory While on it, fix one oversight in 90fbf7c, that introduced a reference to an incorrect value for the compression level of pg_dump. Author: Justin Pryzby Reviewed-by: Thomas Munro, Michael Paquier Discussion: https://postgr.es/m/ca+hukgjrtlwwpcqfjm_xaok98m8arok903x92o0x-4vljpw...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1b3433e25f81d6fc4f231887ab965e1ea1bcb47e Modified Files -- doc/src/sgml/config.sgml | 4 ++-- src/bin/pg_dump/pg_backup_archiver.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)
pgsql: doc: Improve some grammar and sentences
doc: Improve some grammar and sentences 90fbf7c has taken care of that for HEAD. This includes the portion of the fixes that applies to the documentation, where needed depending on the branch. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b25c106df71fc317e65814e4f301afa05b7b2304 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: doc: Improve some grammar and sentences
doc: Improve some grammar and sentences 90fbf7c has taken care of that for HEAD. This includes the portion of the fixes that applies to the documentation, where needed depending on the branch. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9ad2689889ad47274550afadef430bc4929a9cd7 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- doc/src/sgml/sources.sgml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: Improve some grammar and sentences
doc: Improve some grammar and sentences 90fbf7c has taken care of that for HEAD. This includes the portion of the fixes that applies to the documentation, where needed depending on the branch. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a8c68e7796d4c1d420639b4563a70aee8c7e6f85 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: doc: Improve some grammar and sentences
doc: Improve some grammar and sentences 90fbf7c has taken care of that for HEAD. This includes the portion of the fixes that applies to the documentation, where needed depending on the branch. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e06713ab6eaca9e74f405de1195a9c020f886dd9 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: doc: Improve some grammar and sentences
doc: Improve some grammar and sentences 90fbf7c has taken care of that for HEAD. This includes the portion of the fixes that applies to the documentation, where needed depending on the branch. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d46eb10c06f411fc370e8255c03ec01c8e49c5f2 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: doc: Improve some grammar and sentences
doc: Improve some grammar and sentences 90fbf7c has taken care of that for HEAD. This includes the portion of the fixes that applies to the documentation, where needed depending on the branch. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5253906fac5a2f3669f7867bcb5507f6f0ea891c Modified Files -- doc/src/sgml/catalogs.sgml| 2 +- doc/src/sgml/pgstatstatements.sgml| 2 +- doc/src/sgml/ref/explain.sgml | 6 +++--- doc/src/sgml/ref/pg_dump.sgml | 2 +- doc/src/sgml/ref/pg_verifybackup.sgml | 2 +- doc/src/sgml/sources.sgml | 2 +- doc/src/sgml/wal.sgml | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-)
pgsql: Implement operators for checking if the range contains a multira
Implement operators for checking if the range contains a multirange We have operators for checking if the multirange contains a range but don't have the opposite. This commit improves completeness of the operator set by adding two new operators: @> (anyrange,anymultirange) and <@(anymultirange,anyrange). Catversion is bumped. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4d7684cc754f312aee468abb83ca4f7da94b30a3 Modified Files -- doc/src/sgml/func.sgml | 14 ++ src/backend/utils/adt/multirangetypes.c | 60 ++ src/backend/utils/adt/multirangetypes_selfuncs.c | 6 +- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_operator.dat | 12 ++ src/include/catalog/pg_proc.dat | 6 + src/include/utils/multirangetypes.h | 4 +- src/test/regress/expected/multirangetypes.out| 240 +++ src/test/regress/sql/multirangetypes.sql | 40 9 files changed, 381 insertions(+), 3 deletions(-)
pgsql: Add support of multirange matching to the existing range GiST in
Add support of multirange matching to the existing range GiST indexes 6df7a9698b has introduced a set of operators between ranges and multiranges. Existing GiST indexes for ranges could easily support majority of them. This commit adds support for new operators to the existing range GiST indexes. New operators resides the same strategy numbers as existing ones. Appropriate check function is determined using the subtype. Catversion is bumped. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/db6335b5b1d6654b0e3104f36817800d127c1c91 Modified Files -- doc/src/sgml/gist.sgml| 35 ++- doc/src/sgml/rangetypes.sgml | 21 +- src/backend/utils/adt/multirangetypes.c | 21 ++ src/backend/utils/adt/rangetypes_gist.c | 393 +- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_amop.dat | 80 ++ src/include/catalog/pg_amproc.dat | 18 ++ src/include/catalog/pg_opclass.dat| 2 + src/include/catalog/pg_opfamily.dat | 2 + src/include/catalog/pg_proc.dat | 8 + src/include/utils/multirangetypes.h | 2 + src/test/regress/expected/multirangetypes.out | 257 + src/test/regress/expected/rangetypes.out | 162 +++ src/test/regress/sql/multirangetypes.sql | 63 + src/test/regress/sql/rangetypes.sql | 27 ++ 15 files changed, 1024 insertions(+), 69 deletions(-)
pgsql: Fix bugs in comparison functions for multirange_bsearch_match()
Fix bugs in comparison functions for multirange_bsearch_match() Two functions multirange_range_overlaps_bsearch_comparison() and multirange_range_contains_bsearch_comparison() contain bugs of returning -1 instead of 1. This commit fixes these bugs and adds corresponding regression tests. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a5b81b6f0006ea0b502780ce7f73d295a225842c Modified Files -- src/backend/utils/adt/multirangetypes.c | 4 ++-- src/test/regress/expected/multirangetypes.out | 12 src/test/regress/sql/multirangetypes.sql | 2 ++ 3 files changed, 16 insertions(+), 2 deletions(-)
pgsql: Improve the signature of internal multirange functions
Improve the signature of internal multirange functions There is a set of *_internal() functions exposed in include/utils/multirangetypes.h. This commit improves the signatures of these functions in two ways. * Add const qualifies where applicable. * Replace multirange typecache argument with range typecache argument. Multirange typecache was used solely to find the range typecache. At the same time, range typecache is easier for the caller to find. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d1d61a8b23b604faf797695eeacaa5da4fe64762 Modified Files -- src/backend/utils/adt/multirangetypes.c | 206 +--- src/include/utils/multirangetypes.h | 69 ++- 2 files changed, 153 insertions(+), 122 deletions(-)
Re: pgsql: Add support of multirange matching to the existing range GiST in
On Tue, Dec 29, 2020 at 11:45 PM Alexander Korotkov wrote: > Add support of multirange matching to the existing range GiST indexes I accidentally squash here a commit which implements GiST multirange indexes. That commit was intended to go separately with its own commit message below. Sorry for that. > Add GiST indexes for multiranges > > This commits adds a pretty trivial way for multirange indexing: approximate > multirange as union range with no gaps. New multiranges opclass shares the > majority of functions with ranges opclass. > > This is not an ideal way to index multirages, but something we can easily > have. -- Regards, Alexander Korotkov
pgsql: Suppress log spam from multiple reports of SIGQUIT shutdown.
Suppress log spam from multiple reports of SIGQUIT shutdown. When the postmaster sends SIGQUIT to its children, there's no real need for all the children to log that fact; the postmaster already made a log entry about it, so adding perhaps dozens or hundreds of child-process log entries adds nothing of value. So, let's introduce a new ereport level to specify "WARNING, but never send to log" and use that for these messages. Such a change wouldn't have been desirable before commit 7e784d1dc, because if someone manually SIGQUIT's a backend, we *do* want to log that. But now we can tell the difference between a signal that was issued by the postmaster and one that was not with reasonable certainty. While we're here, also clear error_context_stack before ereport'ing, to prevent error callbacks from being invoked in the signal-handler context. This should reduce the odds of getting hung up while trying to notify the client. Per a suggestion from Andres Freund. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1f9158ba48122fa232db955a2ee324eec1848ba9 Modified Files -- src/backend/tcop/postgres.c| 16 ++-- src/backend/utils/error/elog.c | 10 +- src/include/utils/elog.h | 12 ++-- 3 files changed, 29 insertions(+), 9 deletions(-)
Re: pgsql: Multirange datatypes
Alexander Korotkov writes:
> Multirange datatypes
Multiple buildfarm members are issuing similar warnings about
multirangetypes.c:
calliphoridae | 2020-12-29 23:10:11 |
/home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/multirangetypes.c:218:37:
warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
calliphoridae | 2020-12-29 23:10:11 |
/home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/multirangetypes.c:236:37:
warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
These are evidently unhappy with code like
if ...
...
}
else
/* include it in range_str */ ;
So apparently preferred style is more like
else
{
/* include it in range_str */
}
I don't particularly care for the wording of this comment, either:
it looks like it's describing an action that's about to be taken,
only there's no action there. Could it say something more like
"we already included it in range_str", or "we'll include it in
range_str below the switch", or whatever's appropriate?
regards, tom lane
pgsql: Doc: fix up PDF build warnings from over-width table columns.
Doc: fix up PDF build warnings from over-width table columns. Addition of multirange info to tables 8.27 and 65.1 made them start throwing "exceed the available area" warnings in PDF docs builds. For 8.27, twiddling the existing column width hints was enough to fix this. For 65.1, I twiddled the widths a little, but to really fix it I had to insert a space after each comma in the table, to allow a line break to occur there. (This seemed easier to read and maintain than the alternative of inserting &zwsp; entities.) Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f20dc2c8dd50a5c738d535205d5d44bff82d3f75 Modified Files -- doc/src/sgml/datatype.sgml | 4 +- doc/src/sgml/gist.sgml | 211 +++-- 2 files changed, 109 insertions(+), 106 deletions(-)
pgsql: Remove references to libpq_srcdir in adminpack and old_snapshot
Remove references to libpq_srcdir in adminpack and old_snapshot Those two modules included references to libpq's source path, without using anything from libpq. Some copy-pastos done when each module was created are likely at the origin of those useless references (aecf5ee for old_snapshot, fe59e56 for adminpack). Reviewed-by: Tom Lane, David Rowley Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/107a2d4204ff4bf4ce05e3525f0d94fc0bd497ff Modified Files -- contrib/adminpack/Makefile| 1 - contrib/old_snapshot/Makefile | 1 - 2 files changed, 2 deletions(-)
Re: pgsql: Add support of multirange matching to the existing range GiST in
On Tue, Dec 29, 2020 at 11:53:14PM +0300, Alexander Korotkov wrote: > On Tue, Dec 29, 2020 at 11:45 PM Alexander Korotkov > wrote: >> Add support of multirange matching to the existing range GiST indexes > > I accidentally squash here a commit which implements GiST multirange > indexes. That commit was intended to go separately with its own > commit message below. Sorry for that. The buildfarm got a bit angry after this commit: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=clam&dt=2020-12-30%2003%3A00%3A11 Here is a diff from member clam, that uses ppc64: select count(*) from test_multirange_gist where mr <@ int4range(10,50); - count - 500 -(1 row) - +ERROR: unknown multirange operator 4540 This points out to OID_RANGE_MULTIRANGE_CONTAINED_OP. Please note that you should add a "Discussion:" in those commits to be able to track down where this stuff has been discussed. -- Michael signature.asc Description: PGP signature
