pgsql: Remove mention of the version number from pg_trgm docs

2021-05-04 Thread Alexander Korotkov
Remove mention of the version number from pg_trgm docs

We don't usually mention the version number in similar situations.  So, neither
mention it here.

Reported-by: Bruce Momjian
Discussion: https://postgr.es/m/20210503234914.GO6180%40momjian.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ae9492a61bbf575e2862cf9323c7f02806382093

Modified Files
--
doc/src/sgml/pgtrgm.sgml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)



pgsql: Fix ALTER TABLE / INHERIT with generated columns

2021-05-04 Thread Peter Eisentraut
Fix ALTER TABLE / INHERIT with generated columns

When running ALTER TABLE t2 INHERIT t1, we must check that columns in
t2 that correspond to a generated column in t1 are also generated and
have the same generation expression.  Otherwise, this would allow
creating setups that a normal CREATE TABLE sequence would not allow.

Discussion: 
https://www.postgresql.org/message-id/22de27f6-7096-8d96-4619-7b882932c...@2ndquadrant.com

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/13ff139a238480cd3221c51c269d5ccdd429594f

Modified Files
--
src/backend/commands/tablecmds.c| 60 +
src/test/regress/expected/generated.out | 21 
src/test/regress/sql/generated.sql  | 14 
3 files changed, 95 insertions(+)



pgsql: Fix ALTER TABLE / INHERIT with generated columns

2021-05-04 Thread Peter Eisentraut
Fix ALTER TABLE / INHERIT with generated columns

When running ALTER TABLE t2 INHERIT t1, we must check that columns in
t2 that correspond to a generated column in t1 are also generated and
have the same generation expression.  Otherwise, this would allow
creating setups that a normal CREATE TABLE sequence would not allow.

Discussion: 
https://www.postgresql.org/message-id/22de27f6-7096-8d96-4619-7b882932c...@2ndquadrant.com

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/64190d65f2995203df401738b77adc5ebd4d2fce

Modified Files
--
src/backend/commands/tablecmds.c| 60 +
src/test/regress/expected/generated.out | 21 
src/test/regress/sql/generated.sql  | 14 
3 files changed, 95 insertions(+)



pgsql: Fix ALTER TABLE / INHERIT with generated columns

2021-05-04 Thread Peter Eisentraut
Fix ALTER TABLE / INHERIT with generated columns

When running ALTER TABLE t2 INHERIT t1, we must check that columns in
t2 that correspond to a generated column in t1 are also generated and
have the same generation expression.  Otherwise, this would allow
creating setups that a normal CREATE TABLE sequence would not allow.

Discussion: 
https://www.postgresql.org/message-id/22de27f6-7096-8d96-4619-7b882932c...@2ndquadrant.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a970edbed306354b0079bdcdc2fc74312122ad89

Modified Files
--
src/backend/commands/tablecmds.c| 60 +
src/test/regress/expected/generated.out | 21 
src/test/regress/sql/generated.sql  | 14 
3 files changed, 95 insertions(+)



pgsql: pg_dump: Fix dump of generated columns in partitions

2021-05-04 Thread Peter Eisentraut
pg_dump: Fix dump of generated columns in partitions

The previous fix for dumping of inherited generated columns
(0bf83648a52df96f7c8677edbbdf141bfa0cf32b) must not be applied to
partitions, since, unlike normal inherited tables, they are always
dumped separately and reattached.

Reported-by: Santosh Udupi 
Discussion: 
https://www.postgresql.org/message-id/flat/CACLRvHZ4a-%2BSM_159%2BtcrHdEqxFrG%3DW4gwTRnwf7Oj0UNj5R2A%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/feb270d1005f3d7b3705dec9e04c9a205750ea97

Modified Files
--
src/bin/pg_dump/common.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)



pgsql: pg_dump: Fix dump of generated columns in partitions

2021-05-04 Thread Peter Eisentraut
pg_dump: Fix dump of generated columns in partitions

The previous fix for dumping of inherited generated columns
(0bf83648a52df96f7c8677edbbdf141bfa0cf32b) must not be applied to
partitions, since, unlike normal inherited tables, they are always
dumped separately and reattached.

Reported-by: Santosh Udupi 
Discussion: 
https://www.postgresql.org/message-id/flat/CACLRvHZ4a-%2BSM_159%2BtcrHdEqxFrG%3DW4gwTRnwf7Oj0UNj5R2A%40mail.gmail.com

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bdaa0d2d726911e31b19ed3a02ecb33dfc6d3673

Modified Files
--
src/bin/pg_dump/common.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)



pgsql: pg_dump: Fix dump of generated columns in partitions

2021-05-04 Thread Peter Eisentraut
pg_dump: Fix dump of generated columns in partitions

The previous fix for dumping of inherited generated columns
(0bf83648a52df96f7c8677edbbdf141bfa0cf32b) must not be applied to
partitions, since, unlike normal inherited tables, they are always
dumped separately and reattached.

Reported-by: Santosh Udupi 
Discussion: 
https://www.postgresql.org/message-id/flat/CACLRvHZ4a-%2BSM_159%2BtcrHdEqxFrG%3DW4gwTRnwf7Oj0UNj5R2A%40mail.gmail.com

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/a6a3a274abd1368a0104fe2cfc7227c9a7e95970

Modified Files
--
src/bin/pg_dump/common.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)



pgsql: doc: Fix typos

2021-05-04 Thread Peter Eisentraut
doc: Fix typos

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/c98a6d7887ea6588b4e9797903182312a2b46f67

Modified Files
--
doc/src/sgml/ecpg.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



pgsql: Fix OID passed to object-alter hook during ALTER CONSTRAINT

2021-05-04 Thread Alvaro Herrera
Fix OID passed to object-alter hook during ALTER CONSTRAINT

The OID of the constraint is used instead of the OID of the trigger --
an easy mistake to make.  Apparently the object-alter hooks are not very
well tested :-(

Backpatch to 12, where this typo was introduced by 578b229718e8

Discussion: https://postgr.es/m/20210503231633.GA6994@alvherre.pgsql

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e798d095da3a4a4bb5c50bb3dff886f07ef52f55

Modified Files
--
src/backend/commands/tablecmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix OID passed to object-alter hook during ALTER CONSTRAINT

2021-05-04 Thread Alvaro Herrera
Fix OID passed to object-alter hook during ALTER CONSTRAINT

The OID of the constraint is used instead of the OID of the trigger --
an easy mistake to make.  Apparently the object-alter hooks are not very
well tested :-(

Backpatch to 12, where this typo was introduced by 578b229718e8

Discussion: https://postgr.es/m/20210503231633.GA6994@alvherre.pgsql

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/91a6b3862fef95c3075d9bea945b6d974433389f

Modified Files
--
src/backend/commands/tablecmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix OID passed to object-alter hook during ALTER CONSTRAINT

2021-05-04 Thread Alvaro Herrera
Fix OID passed to object-alter hook during ALTER CONSTRAINT

The OID of the constraint is used instead of the OID of the trigger --
an easy mistake to make.  Apparently the object-alter hooks are not very
well tested :-(

Backpatch to 12, where this typo was introduced by 578b229718e8

Discussion: https://postgr.es/m/20210503231633.GA6994@alvherre.pgsql

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/72fabd4bfb5a8189591933cf244eabcaf83d4b8b

Modified Files
--
src/backend/commands/tablecmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Disable cache clobber to avoid breaking postgres_fdw termination

2021-05-04 Thread Tom Lane
Disable cache clobber to avoid breaking postgres_fdw termination test.

Commit 93f414614 improved a pre-existing test case so that it would
show whether or not termination of the "remote" worker process happened.
This soon exposed that, when debug_invalidate_system_caches_always
(nee CLOBBER_CACHE_ALWAYS) is enabled, no such termination occurs.
That's because cache invalidation forces postgres_fdw connections
to be dropped at end of transaction, so that there's no worker to
terminate.  There's a race condition as to whether the worker will
manage to get out of the BackendStatusArray before we look, but at
least on buildfarm member hyrax, it's failed twice in two attempts.

Rather than re-lobotomizing the test, let's fix this by transiently
disabling debug_invalidate_system_caches_always.  (Hooray for that
being just a GUC nowadays, rather than a compile-time option.)
If this proves not to be enough to make the test stable, we can
do the other thing instead.

Discussion: https://postgr.es/m/3854538.1620081...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/1273a15bf91fa322915e32d3b6dc6ec916397268

Modified Files
--
contrib/postgres_fdw/expected/postgres_fdw.out | 13 ++---
contrib/postgres_fdw/sql/postgres_fdw.sql  | 16 +---
2 files changed, 23 insertions(+), 6 deletions(-)



pgsql: GUC description improvements for clarity

2021-05-04 Thread Peter Eisentraut
GUC description improvements for clarity

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/38f36aad8c55c8f91e3fb8720fae1847c8fa0552

Modified Files
--
src/backend/utils/misc/guc.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)