pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL_11_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bd110e250e9d9291d7fc1ea12ddd5d177a2460bd

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f3653d7992358708baf401fcabb239b46d27942f

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ef4edf88df6592b6a29649f3ae69d44cef478291

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/dc43fc9b3aa3e0fa9c84faddad6d301813580f88

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/68cc72d4d55cd1d45c24f0f3fccc1f445b6ad0da

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/0cbc50737864177a29430be41e5b134a29e77554

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/927e235aa0f6ce598eee9f251e09653a015974d8

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f90b9998b1e302ddf219ad92d86bb0c21fdf4753

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f70550327ba53c052f4c8171044c7d23edacc79c

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ad96696ead364347d4b492bf9a2d5b82bbe5a2d3

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: 
https://postgr.es/m/ca+hukgltszqwes8vnpmwo9ao0wselt36ocpdaztcct1h7q7...@mail.gmail.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d9a81e8671897340dcfec2d2365def9972d917d0

Modified Files
--
src/backend/optimizer/geqo/geqo_main.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)



pgsql: Clean up recent Coverity complaints.

2022-01-23 Thread Tom Lane
Clean up recent Coverity complaints.

Commit 5c649fe15 introduced a memory leak into pg_basebackup's
parse_compress_options.  (I simplified nearby code while at it.)

Commit 9a974cbcb introduced a memory leak into pg_dump's
binary_upgrade_set_pg_class_oids.

Coverity also complained about a call of SnapBuildProcessChange that
ignored the result, unlike every other call of that function.  This
is evidently intentional, so add a (void) cast to indicate that.
(It's also old, dating to b89e15105; I suppose the reason it showed
up now is 7a5f6b474's recent rearrangement of nearby code.)

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/353708e1fb2d8b1a34f6da2c25d4bb6633cf4493

Modified Files
--
src/backend/replication/logical/decode.c | 2 +-
src/bin/pg_basebackup/pg_basebackup.c| 9 +++--
src/bin/pg_dump/pg_dump.c| 3 ++-
3 files changed, 10 insertions(+), 4 deletions(-)



pgsql: pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_

2022-01-23 Thread Tom Lane
pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid

Commit 6df7a9698 wrote appendPQExpBuffer where it should have
written printfPQExpBuffer.  This resulted in re-issuing the
previous query along with the desired one, which very accidentally
had no negative consequences except for some wasted cycles.

Back-patch to v14 where that came in.

Discussion: https://postgr.es/m/[email protected]

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ac7df108cf32e11e4bd120898ed09bd58fa5b62c

Modified Files
--
src/bin/pg_dump/pg_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_

2022-01-23 Thread Tom Lane
pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid

Commit 6df7a9698 wrote appendPQExpBuffer where it should have
written printfPQExpBuffer.  This resulted in re-issuing the
previous query along with the desired one, which very accidentally
had no negative consequences except for some wasted cycles.

Back-patch to v14 where that came in.

Discussion: https://postgr.es/m/[email protected]

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1042de69dbb6f3c0aa92a741a68aeca23f4ed45e

Modified Files
--
src/bin/pg_dump/pg_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: pg_basebackup: Skip a few more fsyncs if --no-sync is specified.

2022-01-23 Thread Andres Freund
pg_basebackup: Skip a few more fsyncs if --no-sync is specified.

This is mostly interesting for running the regression tests on machines with
slow / overloaded IO.

Discussion: 
https://postgr.es/m/[email protected]

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9c86d9337eb0b9fdf7a8ce19d6044cc7ca0086fb

Modified Files
--
src/bin/pg_basebackup/pg_basebackup.c | 18 +++---
src/bin/pg_basebackup/walmethods.c| 12 +++-
2 files changed, 26 insertions(+), 4 deletions(-)



pgsql: Temporarily add some information about python include paths to c

2022-01-23 Thread Andres Freund
Temporarily add some information about python include paths to configure.

We're still (see e0e567a1067, e0e567a1067) working on replacing use of the
deprecated distutils. This commit just makes configure print out the results
of different ways of determining the include path. Hopefully this will help us
to find a way to transition away from distutils without turning the buildfarm
red for prolonged amounts of time.

Discussion: 
https://postgr.es/m/[email protected]

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f032f63e727c1ab07603b3d1cd88d50f850d5738

Modified Files
--
config/python.m4 | 21 +
configure| 23 +++
2 files changed, 44 insertions(+)