pgsql: pg_waldump: Improve option parsing error messages
pg_waldump: Improve option parsing error messages I rephrased the error messages to be more in the style of option_parse_int(), and also made use of the new "detail" message facility. I didn't actually use option_parse_int() (which could be used for -n) because libpgfeutils wasn't used here yet and I wanted to keep this just to string changes. But it could be done in the future. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/25f915b31e41e5c86e1905d199c7d41cc66161ed Modified Files -- src/bin/pg_waldump/pg_waldump.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-)
pgsql: doc: Explain 'invalid' index state for CREATE INDEX CONCURRENTLY
doc: Explain 'invalid' index state for CREATE INDEX CONCURRENTLY It wasn't previously mentioned that the index is created as invalid, which is confusing to new users. Backpatch to 14 (only because of a conflict in 13). Author: Laurenz Albe Reported-by: Lauren Fliksteen Reviewed-by: Rajakavitha Kodhandapani Discussion: https://postgr.es/m/[email protected] Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa783575294f6e3579b9c78a75d54a693f010213 Modified Files -- doc/src/sgml/ref/create_index.sgml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
pgsql: doc: Explain 'invalid' index state for CREATE INDEX CONCURRENTLY
doc: Explain 'invalid' index state for CREATE INDEX CONCURRENTLY It wasn't previously mentioned that the index is created as invalid, which is confusing to new users. Backpatch to 14 (only because of a conflict in 13). Author: Laurenz Albe Reported-by: Lauren Fliksteen Reviewed-by: Rajakavitha Kodhandapani Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a5084a10fe60412036899a79b3aee76ba31a3579 Modified Files -- doc/src/sgml/ref/create_index.sgml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
pgsql: Add pg_version() to PostgreSQL::Test::Cluster
Add pg_version() to PostgreSQL::Test::Cluster _pg_version (version number based on PostgreSQL::Version) is a field private to Cluster.pm but there was no helper routine to retrieve it from a Cluster's node. The same is done for install_path, for example, and the version object becomes handy when writing tests that need version-specific handling. Reviewed-by: Andrew Dunstan, Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b39838889e76274b107935fa8e8951baf0e8b31b Modified Files -- src/test/perl/PostgreSQL/Test/Cluster.pm | 14 ++ 1 file changed, 14 insertions(+)
pgsql: Backpatch regression tests added by 2d689babe3cb
Backpatch regression tests added by 2d689babe3cb A new plpgsql test function was added in 14 and up to cover for a bugfix that was not backpatchable. We can add it to older versions as a way to cover other bits of DDL event triggers, with an exception clause to avoid the problematic corner case. Originally authored by Michaël Paquier. Backpatch: 10 through 13. Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/99867e7277229bb234f369a14f100148171d2276 Modified Files -- src/test/regress/expected/event_trigger.out | 59 +++-- src/test/regress/sql/event_trigger.sql | 28 +- 2 files changed, 82 insertions(+), 5 deletions(-)
pgsql: Backpatch regression tests added by 2d689babe3cb
Backpatch regression tests added by 2d689babe3cb A new plpgsql test function was added in 14 and up to cover for a bugfix that was not backpatchable. We can add it to older versions as a way to cover other bits of DDL event triggers, with an exception clause to avoid the problematic corner case. Originally authored by Michaël Paquier. Backpatch: 10 through 13. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/daf015fd0c1dc9ca421dbe8567f50b26740e6a81 Modified Files -- src/test/regress/expected/event_trigger.out | 59 +++-- src/test/regress/sql/event_trigger.sql | 28 +- 2 files changed, 82 insertions(+), 5 deletions(-)
pgsql: Backpatch regression tests added by 2d689babe3cb
Backpatch regression tests added by 2d689babe3cb A new plpgsql test function was added in 14 and up to cover for a bugfix that was not backpatchable. We can add it to older versions as a way to cover other bits of DDL event triggers, with an exception clause to avoid the problematic corner case. Originally authored by Michaël Paquier. Backpatch: 10 through 13. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fa51cc86c684e95070228e6829e2753900c6bc79 Modified Files -- src/test/regress/expected/event_trigger.out | 58 +++-- src/test/regress/sql/event_trigger.sql | 28 +- 2 files changed, 81 insertions(+), 5 deletions(-)
pgsql: Backpatch regression tests added by 2d689babe3cb
Backpatch regression tests added by 2d689babe3cb A new plpgsql test function was added in 14 and up to cover for a bugfix that was not backpatchable. We can add it to older versions as a way to cover other bits of DDL event triggers, with an exception clause to avoid the problematic corner case. Originally authored by Michaël Paquier. Backpatch: 10 through 13. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ac78cec9811b88e63854406a938f1de6673f3047 Modified Files -- src/test/regress/expected/event_trigger.out | 59 +++-- src/test/regress/sql/event_trigger.sql | 28 +- 2 files changed, 82 insertions(+), 5 deletions(-)
pgsql: Fix DDL deparse of CREATE OPERATOR CLASS
Fix DDL deparse of CREATE OPERATOR CLASS When an implicit operator family is created, it wasn't getting reported. Make it do so. This has always been missing. Backpatch to 10. Author: Masahiko Sawada Reported-by: Leslie LEMAIRE Reviewed-by: Amit Kapila Reviewed-by: Michael Paquiër Discussion: https://postgr.es/m/[email protected] Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/58b088a9b3c2ec19998a3822190afdd6af847efe Modified Files -- src/backend/commands/opclasscmds.c| 19 ++- src/backend/tcop/utility.c| 6 ++ .../modules/test_ddl_deparse/expected/opfamily.out| 1 + src/test/regress/expected/event_trigger.out | 5 + src/test/regress/sql/event_trigger.sql| 4 5 files changed, 30 insertions(+), 5 deletions(-)
pgsql: Fix DDL deparse of CREATE OPERATOR CLASS
Fix DDL deparse of CREATE OPERATOR CLASS When an implicit operator family is created, it wasn't getting reported. Make it do so. This has always been missing. Backpatch to 10. Author: Masahiko Sawada Reported-by: Leslie LEMAIRE Reviewed-by: Amit Kapila Reviewed-by: Michael Paquiër Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3753a169e110bfedd1c7eef5159d3a5c05cd881e Modified Files -- src/backend/commands/opclasscmds.c| 19 ++- src/backend/tcop/utility.c| 6 ++ .../modules/test_ddl_deparse/expected/opfamily.out| 1 + src/test/regress/expected/event_trigger.out | 5 + src/test/regress/sql/event_trigger.sql| 4 5 files changed, 30 insertions(+), 5 deletions(-)
pgsql: Fix DDL deparse of CREATE OPERATOR CLASS
Fix DDL deparse of CREATE OPERATOR CLASS When an implicit operator family is created, it wasn't getting reported. Make it do so. This has always been missing. Backpatch to 10. Author: Masahiko Sawada Reported-by: Leslie LEMAIRE Reviewed-by: Amit Kapila Reviewed-by: Michael Paquiër Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6c6ea6ea81eb4385b109a59b93cdea0d91223aea Modified Files -- src/backend/commands/opclasscmds.c| 19 ++- src/backend/tcop/utility.c| 6 ++ .../modules/test_ddl_deparse/expected/opfamily.out| 1 + src/test/regress/expected/event_trigger.out | 5 + src/test/regress/sql/event_trigger.sql| 4 5 files changed, 30 insertions(+), 5 deletions(-)
pgsql: Fix DDL deparse of CREATE OPERATOR CLASS
Fix DDL deparse of CREATE OPERATOR CLASS When an implicit operator family is created, it wasn't getting reported. Make it do so. This has always been missing. Backpatch to 10. Author: Masahiko Sawada Reported-by: Leslie LEMAIRE Reviewed-by: Amit Kapila Reviewed-by: Michael Paquiër Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4492e73a66bf88dc7d556a29fde476ba1deb69cb Modified Files -- src/backend/commands/opclasscmds.c| 19 ++- src/backend/tcop/utility.c| 6 ++ .../modules/test_ddl_deparse/expected/opfamily.out| 1 + src/test/regress/expected/event_trigger.out | 5 + src/test/regress/sql/event_trigger.sql| 4 5 files changed, 30 insertions(+), 5 deletions(-)
pgsql: Fix DDL deparse of CREATE OPERATOR CLASS
Fix DDL deparse of CREATE OPERATOR CLASS When an implicit operator family is created, it wasn't getting reported. Make it do so. This has always been missing. Backpatch to 10. Author: Masahiko Sawada Reported-by: Leslie LEMAIRE Reviewed-by: Amit Kapila Reviewed-by: Michael Paquiër Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6029861916e8e2c0155c332c10f182a22619c663 Modified Files -- src/backend/commands/opclasscmds.c| 19 ++- src/backend/tcop/utility.c| 6 ++ .../modules/test_ddl_deparse/expected/opfamily.out| 1 + src/test/regress/expected/event_trigger.out | 5 + src/test/regress/sql/event_trigger.sql| 4 5 files changed, 30 insertions(+), 5 deletions(-)
pgsql: Fix DDL deparse of CREATE OPERATOR CLASS
Fix DDL deparse of CREATE OPERATOR CLASS When an implicit operator family is created, it wasn't getting reported. Make it do so. This has always been missing. Backpatch to 10. Author: Masahiko Sawada Reported-by: Leslie LEMAIRE Reviewed-by: Amit Kapila Reviewed-by: Michael Paquiër Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/70f70d7d3f584dbc964348f82a3737ee66f4de01 Modified Files -- src/backend/commands/opclasscmds.c| 19 ++- src/backend/tcop/utility.c| 6 ++ .../modules/test_ddl_deparse/expected/opfamily.out| 1 + src/test/regress/expected/event_trigger.out | 3 +++ src/test/regress/sql/event_trigger.sql| 4 5 files changed, 28 insertions(+), 5 deletions(-)
pgsql: Fix mis-merge of result file
Fix mis-merge of result file Failed to "git add" this file in this branch. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8c47622bb36972a95cf3789217bf33b2d18a00ce Modified Files -- src/test/regress/expected/event_trigger.out | 2 ++ 1 file changed, 2 insertions(+)
pgsql: Remove portability hazard in unsafe_tests/sql/guc_privs.sql.
Remove portability hazard in unsafe_tests/sql/guc_privs.sql. This new-in-v15 test case assumed it could set max_stack_depth as high as 2MB. You might think that'd be true on any modern platform but you'd be wrong, as I found out while experimenting with NetBSD/hppa. This test is about privileges not platform capabilities, so there seems no need to use any value greater than the 100kB setting already used in a couple of places in the core regression tests. There's certainly no call to expect people to raise their platform's default ulimit just to run this test. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5e5fa323350060360799004f96840bbf3cb51e49 Modified Files -- src/test/modules/unsafe_tests/expected/guc_privs.out | 4 ++-- src/test/modules/unsafe_tests/sql/guc_privs.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
pgsql: Improve and fix some issues in the TAP tests of pg_upgrade
Improve and fix some issues in the TAP tests of pg_upgrade This is based on a set of suggestions from Noah, with the following changes made: - The set of databases created in the tests are now prefixed with "regression" to not trigger any warnings with name restrictions when compiling the code with -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS, and now only the first name checks after the Windows case of double quotes mixed with backslashes. - Fix an issue with EXTRA_REGRESS_OPTS, which were not processed in a way consistent with 027_stream_regress.pl (missing space between the option string and pg_regress). This got introduced in 7dd3ee5. - Add a check on the exit code of the pg_regress command, to catch failures after running the regression tests. Reviewed-by: Noah Misch Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eaa5ebe046c4f247d843bdfd36da4c28be9dbfab Modified Files -- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-)
