Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.
On 13.07.22 20:24, Tom Lane wrote: Peter Eisentraut writes: What platforms did this fail on? How can one observe the failure locally? wrasse at least: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17 I think possibly you could duplicate the problem with gcc by using -fkeep-inline-functions, but I've not tried. Confirmed, -fkeep-inline-functions will catch it. Good to know.
pgsql: Create a distinct wait event for POSIX DSM allocation.
Create a distinct wait event for POSIX DSM allocation. Previously we displayed "DSMFillZeroWrite" while in posix_fallocate(), because we shared the same wait event for "mmap" and "posix" DSM types. Let's introduce a new wait event "DSMAllocate", to be more accurate. Reported-by: Andres Freund Discussion: https://postgr.es/m/20220711174518.yldckniicknsxgzl%40awork3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7bae3bbf62d63cdd49ae4ca4a851cef0cdbe6ab5 Modified Files -- doc/src/sgml/monitoring.sgml| 5 + src/backend/storage/ipc/dsm_impl.c | 2 +- src/backend/utils/activity/wait_event.c | 3 +++ src/include/utils/wait_event.h | 1 + 4 files changed, 10 insertions(+), 1 deletion(-)
pgsql: Remove redundant ftruncate() for POSIX DSM memory.
Remove redundant ftruncate() for POSIX DSM memory. In early releases of the DSM infrastructure, it was possible to resize segments. That was removed in release 12 by commit 3c60d0fa. Now the ftruncate() + posix_fallocate() sequence during DSM segment creation has a redundant step: we're always extending from zero to the desired size, so we might as well just call posix_fallocate(). Let's also include the remaining ftruncate() call (non-Linux POSIX systems) in the wait event reporting, for good measure. Discussion: https://postgr.es/m/CA%2BhUKGJSm-nq8s%2B_59zb7NbFQF-OS%3DxTnTAiGLrQpuSmU2y_1A%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/712704d3539e5ed6807e0b46fddaaf8ed47c2403 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 54 ++ 1 file changed, 25 insertions(+), 29 deletions(-)
pgsql: Block signals while allocating DSM memory.
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd coding where the CHECK_FOR_INTERRUPTS() call was somewhat removed from the loop (see commit 422952ee). On further reflection, that was not a great choice for at least two reasons: 1. If interrupts were held, the CHECK_FOR_INTERRUPTS() would do nothing and the EINTR error would be surfaced to the user. 2. If EINTR was reported but neither QueryCancelPending nor ProcDiePending was set, then we'd dutifully retry, but with a bit more understanding of how posix_fallocate() works, it's now clear that you can get into a loop that never terminates. posix_fallocate() is not a function that can do some of the job and tell you about progress if it's interrupted, it has to undo what it's done so far and report EINTR, and if signals keep arriving faster than it can complete (cf recovery conflict signals), you're stuck. Therefore, for now, we'll simply block most signals to guarantee progress. SIGQUIT is not blocked (see InitPostmasterChild()), because its expected handler doesn't return, and unblockable signals like SIGCONT are not expected to arrive at a high rate. For good measure, we'll include the ftruncate() call in the blocked region, and add a retry loop. Back-patch to all supported releases. Reported-by: Alvaro Herrera Reported-by: Nicola Contu Reviewed-by: Alvaro Herrera Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20220701154105.jjfutmngoedgiad3%40alvherre.pgsql Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4518c798b2b9a84958eca4cde6e7e450b6150da6 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-)
pgsql: Block signals while allocating DSM memory.
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd coding where the CHECK_FOR_INTERRUPTS() call was somewhat removed from the loop (see commit 422952ee). On further reflection, that was not a great choice for at least two reasons: 1. If interrupts were held, the CHECK_FOR_INTERRUPTS() would do nothing and the EINTR error would be surfaced to the user. 2. If EINTR was reported but neither QueryCancelPending nor ProcDiePending was set, then we'd dutifully retry, but with a bit more understanding of how posix_fallocate() works, it's now clear that you can get into a loop that never terminates. posix_fallocate() is not a function that can do some of the job and tell you about progress if it's interrupted, it has to undo what it's done so far and report EINTR, and if signals keep arriving faster than it can complete (cf recovery conflict signals), you're stuck. Therefore, for now, we'll simply block most signals to guarantee progress. SIGQUIT is not blocked (see InitPostmasterChild()), because its expected handler doesn't return, and unblockable signals like SIGCONT are not expected to arrive at a high rate. For good measure, we'll include the ftruncate() call in the blocked region, and add a retry loop. Back-patch to all supported releases. Reported-by: Alvaro Herrera Reported-by: Nicola Contu Reviewed-by: Alvaro Herrera Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20220701154105.jjfutmngoedgiad3%40alvherre.pgsql Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c4a617ea117e9ca1e79c20d4d8430e0784cc9139 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-)
pgsql: Block signals while allocating DSM memory.
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd coding where the CHECK_FOR_INTERRUPTS() call was somewhat removed from the loop (see commit 422952ee). On further reflection, that was not a great choice for at least two reasons: 1. If interrupts were held, the CHECK_FOR_INTERRUPTS() would do nothing and the EINTR error would be surfaced to the user. 2. If EINTR was reported but neither QueryCancelPending nor ProcDiePending was set, then we'd dutifully retry, but with a bit more understanding of how posix_fallocate() works, it's now clear that you can get into a loop that never terminates. posix_fallocate() is not a function that can do some of the job and tell you about progress if it's interrupted, it has to undo what it's done so far and report EINTR, and if signals keep arriving faster than it can complete (cf recovery conflict signals), you're stuck. Therefore, for now, we'll simply block most signals to guarantee progress. SIGQUIT is not blocked (see InitPostmasterChild()), because its expected handler doesn't return, and unblockable signals like SIGCONT are not expected to arrive at a high rate. For good measure, we'll include the ftruncate() call in the blocked region, and add a retry loop. Back-patch to all supported releases. Reported-by: Alvaro Herrera Reported-by: Nicola Contu Reviewed-by: Alvaro Herrera Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20220701154105.jjfutmngoedgiad3%40alvherre.pgsql Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2019e6ecfa26b11e2191a7a1ab41cea4f3ef1544 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-)
pgsql: Block signals while allocating DSM memory.
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd coding where the CHECK_FOR_INTERRUPTS() call was somewhat removed from the loop (see commit 422952ee). On further reflection, that was not a great choice for at least two reasons: 1. If interrupts were held, the CHECK_FOR_INTERRUPTS() would do nothing and the EINTR error would be surfaced to the user. 2. If EINTR was reported but neither QueryCancelPending nor ProcDiePending was set, then we'd dutifully retry, but with a bit more understanding of how posix_fallocate() works, it's now clear that you can get into a loop that never terminates. posix_fallocate() is not a function that can do some of the job and tell you about progress if it's interrupted, it has to undo what it's done so far and report EINTR, and if signals keep arriving faster than it can complete (cf recovery conflict signals), you're stuck. Therefore, for now, we'll simply block most signals to guarantee progress. SIGQUIT is not blocked (see InitPostmasterChild()), because its expected handler doesn't return, and unblockable signals like SIGCONT are not expected to arrive at a high rate. For good measure, we'll include the ftruncate() call in the blocked region, and add a retry loop. Back-patch to all supported releases. Reported-by: Alvaro Herrera Reported-by: Nicola Contu Reviewed-by: Alvaro Herrera Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20220701154105.jjfutmngoedgiad3%40alvherre.pgsql Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e73fe6e828d141b0ee0be8d7f58d73b3f0fad872 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-)
pgsql: Block signals while allocating DSM memory.
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd coding where the CHECK_FOR_INTERRUPTS() call was somewhat removed from the loop (see commit 422952ee). On further reflection, that was not a great choice for at least two reasons: 1. If interrupts were held, the CHECK_FOR_INTERRUPTS() would do nothing and the EINTR error would be surfaced to the user. 2. If EINTR was reported but neither QueryCancelPending nor ProcDiePending was set, then we'd dutifully retry, but with a bit more understanding of how posix_fallocate() works, it's now clear that you can get into a loop that never terminates. posix_fallocate() is not a function that can do some of the job and tell you about progress if it's interrupted, it has to undo what it's done so far and report EINTR, and if signals keep arriving faster than it can complete (cf recovery conflict signals), you're stuck. Therefore, for now, we'll simply block most signals to guarantee progress. SIGQUIT is not blocked (see InitPostmasterChild()), because its expected handler doesn't return, and unblockable signals like SIGCONT are not expected to arrive at a high rate. For good measure, we'll include the ftruncate() call in the blocked region, and add a retry loop. Back-patch to all supported releases. Reported-by: Alvaro Herrera Reported-by: Nicola Contu Reviewed-by: Alvaro Herrera Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20220701154105.jjfutmngoedgiad3%40alvherre.pgsql Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ff78bf796d8069002eb75edd0d5fc7fc6bf0a63b Modified Files -- src/backend/storage/ipc/dsm_impl.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-)
pgsql: Block signals while allocating DSM memory.
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd coding where the CHECK_FOR_INTERRUPTS() call was somewhat removed from the loop (see commit 422952ee). On further reflection, that was not a great choice for at least two reasons: 1. If interrupts were held, the CHECK_FOR_INTERRUPTS() would do nothing and the EINTR error would be surfaced to the user. 2. If EINTR was reported but neither QueryCancelPending nor ProcDiePending was set, then we'd dutifully retry, but with a bit more understanding of how posix_fallocate() works, it's now clear that you can get into a loop that never terminates. posix_fallocate() is not a function that can do some of the job and tell you about progress if it's interrupted, it has to undo what it's done so far and report EINTR, and if signals keep arriving faster than it can complete (cf recovery conflict signals), you're stuck. Therefore, for now, we'll simply block most signals to guarantee progress. SIGQUIT is not blocked (see InitPostmasterChild()), because its expected handler doesn't return, and unblockable signals like SIGCONT are not expected to arrive at a high rate. For good measure, we'll include the ftruncate() call in the blocked region, and add a retry loop. Back-patch to all supported releases. Reported-by: Alvaro Herrera Reported-by: Nicola Contu Reviewed-by: Alvaro Herrera Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20220701154105.jjfutmngoedgiad3%40alvherre.pgsql Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/39683c69a03e525e3611c47ffaccc16be18c0a8f Modified Files -- src/backend/storage/ipc/dsm_impl.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-)
pgsql: Block signals while allocating DSM memory.
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd coding where the CHECK_FOR_INTERRUPTS() call was somewhat removed from the loop (see commit 422952ee). On further reflection, that was not a great choice for at least two reasons: 1. If interrupts were held, the CHECK_FOR_INTERRUPTS() would do nothing and the EINTR error would be surfaced to the user. 2. If EINTR was reported but neither QueryCancelPending nor ProcDiePending was set, then we'd dutifully retry, but with a bit more understanding of how posix_fallocate() works, it's now clear that you can get into a loop that never terminates. posix_fallocate() is not a function that can do some of the job and tell you about progress if it's interrupted, it has to undo what it's done so far and report EINTR, and if signals keep arriving faster than it can complete (cf recovery conflict signals), you're stuck. Therefore, for now, we'll simply block most signals to guarantee progress. SIGQUIT is not blocked (see InitPostmasterChild()), because its expected handler doesn't return, and unblockable signals like SIGCONT are not expected to arrive at a high rate. For good measure, we'll include the ftruncate() call in the blocked region, and add a retry loop. Back-patch to all supported releases. Reported-by: Alvaro Herrera Reported-by: Nicola Contu Reviewed-by: Alvaro Herrera Reviewed-by: Andres Freund Discussion: https://postgr.es/m/20220701154105.jjfutmngoedgiad3%40alvherre.pgsql Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/53cfe403c9d254e1a8b84f92ab5579bc59162621 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-)
pgsql: Avoid shadowing a variable in sync.c.
Avoid shadowing a variable in sync.c. It was confusing to reuse the variable name 'entry' in two scopes. Use distinct variable names. Reported-by: Ranier Vilela Reported-by: Tom Lane Reported-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/CAEudQArDrFyQ15Am3rgWBunGBVZFDb90onTS8SRiFAWHeiLiFA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/57944910585750b52173a0f67c9e0e42639f1c0a Modified Files -- src/backend/storage/sync/sync.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)
pgsql: Tighten up parsing logic in gen_node_support.pl.
Tighten up parsing logic in gen_node_support.pl. Teach this script to handle function pointer fields honestly. Previously they were just silently ignored, but that's not likely to be a behavior we can accept indefinitely. This mostly entails fixing it so that a field declaration spanning multiple lines can be parsed, because we have a bunch of such fields that're laid out that way. But that's a good improvement in its own right. With that change and a minor regex adjustment, the only struct it fails to parse in the node-defining headers is A_Const, because of the embedded union. The path of least resistance is to move that union declaration outside the struct. Having done those things, we can make it error out if it finds any within-struct syntax it doesn't understand, which seems like a pretty important property for robustness. This commit doesn't change the output files at all; it's just in the way of future-proofing. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7c0eb3c622eb0882f460805109f244679b340964 Modified Files -- src/backend/nodes/gen_node_support.pl | 77 +-- src/include/nodes/parsenodes.h| 28 ++--- src/include/nodes/pathnodes.h | 5 ++- 3 files changed, 90 insertions(+), 20 deletions(-)
pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask when under the postmaster. Back-patch to all releases, like 4518c798. Discussion: https://postgr.es/m/CA%2BhUKGKNpK%3D2OMeea_AZwpLg7Bm4%3DgYWk7eDjZ5F6YbozfOf8w%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/80845b7c0b2cf0a26e44d7906d63cddbb4dd586c Modified Files -- src/backend/storage/ipc/dsm_impl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)
pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask when under the postmaster. Back-patch to all releases, like 4518c798. Discussion: https://postgr.es/m/CA%2BhUKGKNpK%3D2OMeea_AZwpLg7Bm4%3DgYWk7eDjZ5F6YbozfOf8w%40mail.gmail.com Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a715c20043c1396bc28f19514e667bfb081e8ad2 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)
pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask when under the postmaster. Back-patch to all releases, like 4518c798. Discussion: https://postgr.es/m/CA%2BhUKGKNpK%3D2OMeea_AZwpLg7Bm4%3DgYWk7eDjZ5F6YbozfOf8w%40mail.gmail.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8383645592de522e9791ba84ddde23f3105366b5 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)
pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask when under the postmaster. Back-patch to all releases, like 4518c798. Discussion: https://postgr.es/m/CA%2BhUKGKNpK%3D2OMeea_AZwpLg7Bm4%3DgYWk7eDjZ5F6YbozfOf8w%40mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/17aa39da50c5ac37436522fe2dd9f25a93673fdd Modified Files -- src/backend/storage/ipc/dsm_impl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)
pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask when under the postmaster. Back-patch to all releases, like 4518c798. Discussion: https://postgr.es/m/CA%2BhUKGKNpK%3D2OMeea_AZwpLg7Bm4%3DgYWk7eDjZ5F6YbozfOf8w%40mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a05f40ef874b95a39471db68a313076cd94e256f Modified Files -- src/backend/storage/ipc/dsm_impl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)
pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask when under the postmaster. Back-patch to all releases, like 4518c798. Discussion: https://postgr.es/m/CA%2BhUKGKNpK%3D2OMeea_AZwpLg7Bm4%3DgYWk7eDjZ5F6YbozfOf8w%40mail.gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/74a9ee034829153c3d5bfa270fd6372aa3147db5 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)
pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask when under the postmaster. Back-patch to all releases, like 4518c798. Discussion: https://postgr.es/m/CA%2BhUKGKNpK%3D2OMeea_AZwpLg7Bm4%3DgYWk7eDjZ5F6YbozfOf8w%40mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e26024bea9e9fe7bb10a00baea631d629c5bd61c Modified Files -- src/backend/storage/ipc/dsm_impl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)
Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.
On 14.07.22 12:05, Peter Eisentraut wrote:
On 13.07.22 20:24, Tom Lane wrote:
Peter Eisentraut writes:
What platforms did this fail on? How can one observe the failure
locally?
wrasse at least:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17
I think possibly you could duplicate the problem with gcc
by using -fkeep-inline-functions, but I've not tried.
Confirmed, -fkeep-inline-functions will catch it. Good to know.
It seems that -fkeep-inline-functions is more demanding than what wrasse
is running on. I need the attached patch to get it to build cleanly.
(The first hunk undoes some parts of
2cd2569c72b8920048e35c31c9be30a6170e1410, but the others are unrelated
and old.)
I think this would be good to apply so that this method of checking
inline functions is available in the future.From 9e57d1d42490ac37e8bd27804a6180ddee0fbf53 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 14 Jul 2022 15:54:40 +0200
Subject: [PATCH] WIP: Support gcc -fkeep-inline-functions
---
src/include/storage/bufpage.h | 24 +---
src/include/utils/rel.h | 2 ++
src/include/utils/snapmgr.h | 2 ++
3 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/src/include/storage/bufpage.h b/src/include/storage/bufpage.h
index fc67d396b6..6a947021ac 100644
--- a/src/include/storage/bufpage.h
+++ b/src/include/storage/bufpage.h
@@ -466,6 +466,15 @@ do { \
#define PIV_LOG_WARNING(1 << 0)
#define PIV_REPORT_STAT(1 << 1)
+#define PageAddItem(page, item, size, offsetNumber, overwrite, is_heap) \
+ PageAddItemExtended(page, item, size, offsetNumber, \
+ ((overwrite) ? PAI_OVERWRITE :
0) | \
+ ((is_heap) ? PAI_IS_HEAP : 0))
+
+#define PageIsVerified(page, blkno) \
+ PageIsVerifiedExtended(page, blkno, \
+ PIV_LOG_WARNING |
PIV_REPORT_STAT)
+
/*
* Check that BLCKSZ is a multiple of sizeof(size_t). In
* PageIsVerifiedExtended(), it is much faster to check if a page is
@@ -480,21 +489,6 @@ extern void PageInit(Page page, Size pageSize, Size
specialSize);
extern bool PageIsVerifiedExtended(Page page, BlockNumber blkno, int flags);
extern OffsetNumber PageAddItemExtended(Page page, Item item, Size size,
OffsetNumber offsetNumber, int flags);
-
-static inline OffsetNumber
-PageAddItem(Page page, Item item, Size size, OffsetNumber offsetNumber, bool
overwrite, bool is_heap)
-{
- return PageAddItemExtended(page, item, size, offsetNumber,
- (overwrite ?
PAI_OVERWRITE : 0) |
- (is_heap ?
PAI_IS_HEAP : 0));
-}
-
-static inline bool
-PageIsVerified(Page page, BlockNumber blkno)
-{
- return PageIsVerifiedExtended(page, blkno, PIV_LOG_WARNING |
PIV_REPORT_STAT);
-}
-
extern Page PageGetTempPage(Page page);
extern Page PageGetTempPageCopy(Page page);
extern Page PageGetTempPageCopySpecial(Page page);
diff --git a/src/include/utils/rel.h b/src/include/utils/rel.h
index 2854839ec2..00b83b8924 100644
--- a/src/include/utils/rel.h
+++ b/src/include/utils/rel.h
@@ -564,6 +564,7 @@ typedef struct ViewOptions
* each time you need to access the SMgrRelation. It's quite cheap in
* comparison to whatever an smgr function is going to do.
*/
+#ifndef FRONTEND
static inline SMgrRelation
RelationGetSmgr(Relation rel)
{
@@ -571,6 +572,7 @@ RelationGetSmgr(Relation rel)
smgrsetowner(&(rel->rd_smgr), smgropen(rel->rd_locator,
rel->rd_backend));
return rel->rd_smgr;
}
+#endif
/*
* RelationCloseSmgr
diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h
index 67b217b1c1..06eafdf118 100644
--- a/src/include/utils/snapmgr.h
+++ b/src/include/utils/snapmgr.h
@@ -97,11 +97,13 @@ extern PGDLLIMPORT SnapshotData CatalogSnapshotData;
((snapshot)->snapshot_type == SNAPSHOT_MVCC || \
(snapshot)->snapshot_type == SNAPSHOT_HISTORIC_MVCC)
+#ifndef FRONTEND
static inline bool
OldSnapshotThresholdActive(void)
{
return old_snapshot_threshold >= 0;
}
+#endif
extern Snapshot GetTransactionSnapshot(void);
extern Snapshot GetLatestSnapshot(void);
--
2.37.0
Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.
Peter Eisentraut writes: > It seems that -fkeep-inline-functions is more demanding than what wrasse > is running on. I need the attached patch to get it to build cleanly. Interesting. I'm not entirely clear on which external references cause wrasse to spit up. > I think this would be good to apply so that this method of checking > inline functions is available in the future. +1 regards, tom lane
pgsql: doc: mention the pg_locks lock names in parentheses
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/88580b63ebe4597b6b3ef6ad23c7370af2e9cadc Modified Files -- doc/src/sgml/mvcc.sgml | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgsql: doc: mention the pg_locks lock names in parentheses
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3e071b2cf584052b0799ebbc4d38ecfdb5bd701a Modified Files -- doc/src/sgml/mvcc.sgml | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgsql: doc: mention the pg_locks lock names in parentheses
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3336b3de34e1b865af358e15a4221523221eb086 Modified Files -- doc/src/sgml/mvcc.sgml | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgsql: doc: mention the pg_locks lock names in parentheses
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8db5026d0a0852ae2f6dfc4bc726a5184b71bafd Modified Files -- doc/src/sgml/mvcc.sgml | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgsql: doc: mention the pg_locks lock names in parentheses
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9d352c4448e98c96167bc8134958de7048697829 Modified Files -- doc/src/sgml/mvcc.sgml | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgsql: doc: mention the pg_locks lock names in parentheses
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/64695a3ce646a2c255c89b268f9876f43c585025 Modified Files -- doc/src/sgml/mvcc.sgml | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgsql: doc: mention the pg_locks lock names in parentheses
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6396ab3d14278746951ea78fb8207534a8825a7e Modified Files -- doc/src/sgml/mvcc.sgml | 16 1 file changed, 8 insertions(+), 8 deletions(-)
pgsql: doc: mention that INSERT can block because of unique indexes
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/106ab8531f2255819256581b8f4d23c6ba0373e7 Modified Files -- doc/src/sgml/ref/insert.sgml | 5 + 1 file changed, 5 insertions(+)
pgsql: doc: mention that INSERT can block because of unique indexes
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6959e971b35e7e6e10d61b95699cec7985d053b1 Modified Files -- doc/src/sgml/ref/insert.sgml | 5 + 1 file changed, 5 insertions(+)
pgsql: doc: mention that INSERT can block because of unique indexes
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5ea92769aa767a87eed74f591540f03b6f260660 Modified Files -- doc/src/sgml/ref/insert.sgml | 5 + 1 file changed, 5 insertions(+)
pgsql: doc: mention that INSERT can block because of unique indexes
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4996786a90aa195025e2ee1fccb9d478740108a6 Modified Files -- doc/src/sgml/ref/insert.sgml | 5 + 1 file changed, 5 insertions(+)
pgsql: doc: mention that INSERT can block because of unique indexes
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ac480b074f4ebad1ae8947b1eeb9790e8925f94e Modified Files -- doc/src/sgml/ref/insert.sgml | 5 + 1 file changed, 5 insertions(+)
pgsql: doc: mention that INSERT can block because of unique indexes
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2d0329b6bdd3b812d22b3d53d5e2b7bda4468a56 Modified Files -- doc/src/sgml/ref/insert.sgml | 5 + 1 file changed, 5 insertions(+)
pgsql: doc: mention that INSERT can block because of unique indexes
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/68044facf2e6069d432bfdf3fbdc20a06e7f75a0 Modified Files -- doc/src/sgml/ref/insert.sgml | 5 + 1 file changed, 5 insertions(+)
pgsql: doc: clarify that "excluded" ON CONFLICT is a single row
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4f63f6aae0cd2bbcbb18c43db79c0351a69f91ad Modified Files -- doc/src/sgml/ref/insert.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: clarify that "excluded" ON CONFLICT is a single row
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1b308c95ace496ce66022f5cf27e85d9dfc1e122 Modified Files -- doc/src/sgml/ref/insert.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: clarify that "excluded" ON CONFLICT is a single row
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ebf06040e52262b876069f3e515c1c09b96084b0 Modified Files -- doc/src/sgml/ref/insert.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: clarify that "excluded" ON CONFLICT is a single row
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/afc8ee1e8ca55e2d058dfb15608dccd033b617cf Modified Files -- doc/src/sgml/ref/insert.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: clarify that "excluded" ON CONFLICT is a single row
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6437e32a23f9683b248e02f4fe621f9d7089d125 Modified Files -- doc/src/sgml/ref/insert.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: clarify that "excluded" ON CONFLICT is a single row
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3bfe26bd4ce11ee5bd2a2f240ee24e220f3f8635 Modified Files -- doc/src/sgml/ref/insert.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: clarify that "excluded" ON CONFLICT is a single row
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5790aa46af8e6f8c6b090a931fc18b42002e4f54 Modified Files -- doc/src/sgml/ref/insert.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: clarify the behavior of identically-named savepoints
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3ba46b35327469d040b7cea703d76bf33104f434 Modified Files -- doc/src/sgml/ref/release_savepoint.sgml | 5 +++-- doc/src/sgml/ref/savepoint.sgml | 30 +- 2 files changed, 32 insertions(+), 3 deletions(-)
pgsql: doc: clarify the behavior of identically-named savepoints
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/85e32877f1d747edf853ced703f6337fadb965a8 Modified Files -- doc/src/sgml/ref/release_savepoint.sgml | 5 +++-- doc/src/sgml/ref/savepoint.sgml | 30 +- 2 files changed, 32 insertions(+), 3 deletions(-)
pgsql: doc: clarify the behavior of identically-named savepoints
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/264f75b53b198a383fb88cfac2efb25e08a71492 Modified Files -- doc/src/sgml/ref/release_savepoint.sgml | 5 +++-- doc/src/sgml/ref/savepoint.sgml | 30 +- 2 files changed, 32 insertions(+), 3 deletions(-)
pgsql: doc: clarify the behavior of identically-named savepoints
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ec1fe23afa93c444546d60c256f25c981c757d7c Modified Files -- doc/src/sgml/ref/release_savepoint.sgml | 5 +++-- doc/src/sgml/ref/savepoint.sgml | 30 +- 2 files changed, 32 insertions(+), 3 deletions(-)
pgsql: doc: clarify the behavior of identically-named savepoints
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8f253ba251b86d6792cb81093e5d84457bc9790a Modified Files -- doc/src/sgml/ref/release_savepoint.sgml | 5 +++-- doc/src/sgml/ref/savepoint.sgml | 30 +- 2 files changed, 32 insertions(+), 3 deletions(-)
pgsql: doc: clarify the behavior of identically-named savepoints
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/890efb49c86f3893c2fe8920ea21e4c7e4d21b1a Modified Files -- doc/src/sgml/ref/release_savepoint.sgml | 5 +++-- doc/src/sgml/ref/savepoint.sgml | 30 +- 2 files changed, 32 insertions(+), 3 deletions(-)
pgsql: doc: clarify the behavior of identically-named savepoints
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d73ea6160ab345ba242f8cfb2830d4fa24ad6787 Modified Files -- doc/src/sgml/ref/release_savepoint.sgml | 5 +++-- doc/src/sgml/ref/savepoint.sgml | 30 +- 2 files changed, 32 insertions(+), 3 deletions(-)
pgsql: doc: move system views section to its own chapter
doc: move system views section to its own chapter Previously it was inside the system catalogs chapter. Reported-by: Peter Smith Discussion: https://postgr.es/m/cahut+psmc18qp60d+l0hjboxrlqt5m88yvacdyxlq34gfph...@mail.gmail.com Backpatch-through: 15 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/64d364bb39cbb1d97ab6dbd6b873a1016a261d4b Modified Files -- doc/src/sgml/catalogs.sgml | 4741 --- doc/src/sgml/filelist.sgml |1 + doc/src/sgml/postgres.sgml |1 + doc/src/sgml/system-views.sgml | 4750 4 files changed, 4752 insertions(+), 4741 deletions(-)
pgsql: doc: move system views section to its own chapter
doc: move system views section to its own chapter Previously it was inside the system catalogs chapter. Reported-by: Peter Smith Discussion: https://postgr.es/m/cahut+psmc18qp60d+l0hjboxrlqt5m88yvacdyxlq34gfph...@mail.gmail.com Backpatch-through: 15 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5766443695d2ee82c2c4b9a23983c0af4b29711f Modified Files -- doc/src/sgml/catalogs.sgml | 4727 --- doc/src/sgml/filelist.sgml |1 + doc/src/sgml/postgres.sgml |1 + doc/src/sgml/system-views.sgml | 4750 4 files changed, 4752 insertions(+), 4727 deletions(-)
pgsql: doc: add documentation about ecpg Oracle-compatibility mode
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bf3d692deba4ffb2d54e7abf2af0d9a4969fb700 Modified Files -- doc/src/sgml/ecpg.sgml | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-)
pgsql: doc: add documentation about ecpg Oracle-compatibility mode
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fc130b8e2d38bc710dbfc052a46ca9e017a5cb02 Modified Files -- doc/src/sgml/ecpg.sgml | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-)
pgsql: doc: add documentation about ecpg Oracle-compatibility mode
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/76fa4bf321c5f13c729f225a465e754958c0a5c5 Modified Files -- doc/src/sgml/ecpg.sgml | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-)
pgsql: doc: add documentation about ecpg Oracle-compatibility mode
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/846ae360ab2d70f934af0603d5fec140059ed26f Modified Files -- doc/src/sgml/ecpg.sgml | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-)
pgsql: doc: add documentation about ecpg Oracle-compatibility mode
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/613e5a31234e4cf14129c2c3684fb4cb859ae716 Modified Files -- doc/src/sgml/ecpg.sgml | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-)
pgsql: doc: add documentation about ecpg Oracle-compatibility mode
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8e97474834e4247886ecb11ffc39d65239eddfe2 Modified Files -- doc/src/sgml/ecpg.sgml | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-)
pgsql: pg_upgrade doc: mention that replication slots must be recreated
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2d4c6437c87e6a036a163b1b4363097ee860cef0 Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgsql: pg_upgrade doc: mention that replication slots must be recreated
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a36882ef94afe8a114cf5c2928b2cb9620ffd855 Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgsql: pg_upgrade doc: mention that replication slots must be recreated
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/47ae6948f0b03cade761b80932c60f208b41f748 Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgsql: pg_upgrade doc: mention that replication slots must be recreated
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/27b8f73fd3475a71b8b9dc10d1854337aa0c7101 Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgsql: pg_upgrade doc: mention that replication slots must be recreated
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0d8db8cf853ceb34c5be1e398fc566b0521bb24e Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgsql: pg_upgrade doc: mention that replication slots must be recreated
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b0ea3e46c63160f4292b4dfe356dd28c7cde4545 Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgsql: pg_upgrade doc: mention that replication slots must be recreated
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e24ea2a97f059aece02925def9889351a3ac3110 Modified Files -- doc/src/sgml/ref/pgupgrade.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgsql: doc: clarify how dropping of extensions affects dependent objs.
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com Backpatch-through: 13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5fe2d4c56edd315780e3c6a00caaa5625a719a87 Modified Files -- doc/src/sgml/ref/alter_function.sgml | 6 -- doc/src/sgml/ref/alter_procedure.sgml | 7 ++- doc/src/sgml/ref/drop_extension.sgml | 10 ++ 3 files changed, 16 insertions(+), 7 deletions(-)
pgsql: doc: clarify how dropping of extensions affects dependent objs.
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com Backpatch-through: 13 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8ef2859163d2355c47e0cce2aef11b0480ca1e5f Modified Files -- doc/src/sgml/ref/alter_function.sgml | 6 -- doc/src/sgml/ref/alter_procedure.sgml | 7 ++- doc/src/sgml/ref/drop_extension.sgml | 10 ++ 3 files changed, 16 insertions(+), 7 deletions(-)
pgsql: doc: clarify how dropping of extensions affects dependent objs.
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com Backpatch-through: 13 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2fc2d805e9c7acd554689782e854cd713faf9575 Modified Files -- doc/src/sgml/ref/alter_function.sgml | 6 -- doc/src/sgml/ref/alter_procedure.sgml | 7 ++- doc/src/sgml/ref/drop_extension.sgml | 10 ++ 3 files changed, 16 insertions(+), 7 deletions(-)
pgsql: doc: clarify how dropping of extensions affects dependent objs.
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com Backpatch-through: 13 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ef9d0cf19cdb74fd9b9f833d8e42ed283e0def23 Modified Files -- doc/src/sgml/ref/alter_function.sgml | 6 -- doc/src/sgml/ref/alter_procedure.sgml | 7 ++- doc/src/sgml/ref/drop_extension.sgml | 10 ++ 3 files changed, 16 insertions(+), 7 deletions(-)
pgsql: docs: make monitoring "phases" table titles consistent
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/65a0cf863270e38755ba2b6d5ae91d560128a107 Modified Files -- doc/src/sgml/monitoring.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: docs: make monitoring "phases" table titles consistent
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ad8c8ee415da2d5437a346f1a57d873467d60812 Modified Files -- doc/src/sgml/monitoring.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: docs: make monitoring "phases" table titles consistent
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e1d5ac3118be2c8f93a7b9c8813027f7a7f8d049 Modified Files -- doc/src/sgml/monitoring.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: docs: make monitoring "phases" table titles consistent
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/582c3e9e8b8d27bec2deb71025c8e85b6257c589 Modified Files -- doc/src/sgml/monitoring.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that pg_dump takes ACCESS SHARE lock
Clarify that pg_dump takes ACCESS SHARE lock Add link to the description of lock levels to avoid confusing "shared locks" with SHARE locks. Florin Irion Reviewed-by: Álvaro Herrera, Tom Lane, and Nathan Bossart Discussion: https://www.postgresql.org/message-id/flat/[email protected] This is a backpatch of 4e2e8d71f, applied through version 14 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b32a588961161ba36d01ff8dbccfc949493232c7 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that pg_dump takes ACCESS SHARE lock
Clarify that pg_dump takes ACCESS SHARE lock Add link to the description of lock levels to avoid confusing "shared locks" with SHARE locks. Florin Irion Reviewed-by: Álvaro Herrera, Tom Lane, and Nathan Bossart Discussion: https://www.postgresql.org/message-id/flat/[email protected] This is a backpatch of 4e2e8d71f, applied through version 14 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2ebb8416cc4c1b8f73481335c2c6ce07286bc938 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Fix inconsistent parameter names between prototype and declarati
Fix inconsistent parameter names between prototype and declaration Noticed while working in this area. This code was introduced in PG15, which is still in beta, so backpatch to there for consistency. Backpatch-through: 15 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/80ad91ea8cfca6c817034423fc889876217c67af Modified Files -- src/include/optimizer/paths.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix inconsistent parameter names between prototype and declarati
Fix inconsistent parameter names between prototype and declaration Noticed while working in this area. This code was introduced in PG15, which is still in beta, so backpatch to there for consistency. Backpatch-through: 15 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8c297dd5f4ff581f7a70c514d1512c22f47989e5 Modified Files -- src/include/optimizer/paths.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
