pgsql: Correct error message for row-level triggers with transition tab

2022-11-04 Thread Etsuro Fujita
Correct error message for row-level triggers with transition tables on 
partitioned tables.

"Triggers on partitioned tables cannot have transition tables." is
incorrect as we allow statement-level triggers on partitioned tables to
have transition tables.

This has been wrong since commit 86f575948; back-patch to v11 where that
commit came in.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/81173264440d7d3bd6479313b1d4611a2bfe8031

Modified Files
--
src/backend/commands/trigger.c | 2 +-
src/test/regress/expected/triggers.out | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: Correct error message for row-level triggers with transition tab

2022-11-04 Thread Etsuro Fujita
Correct error message for row-level triggers with transition tables on 
partitioned tables.

"Triggers on partitioned tables cannot have transition tables." is
incorrect as we allow statement-level triggers on partitioned tables to
have transition tables.

This has been wrong since commit 86f575948; back-patch to v11 where that
commit came in.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/26c1cab4c9fafd5cf7c39d42790d3ca9a3e4688a

Modified Files
--
src/backend/commands/trigger.c | 2 +-
src/test/regress/expected/triggers.out | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: Correct error message for row-level triggers with transition tab

2022-11-04 Thread Etsuro Fujita
Correct error message for row-level triggers with transition tables on 
partitioned tables.

"Triggers on partitioned tables cannot have transition tables." is
incorrect as we allow statement-level triggers on partitioned tables to
have transition tables.

This has been wrong since commit 86f575948; back-patch to v11 where that
commit came in.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/8c7146790811ac4eee23fab2226db14b636e1ac5

Modified Files
--
src/backend/commands/trigger.c | 2 +-
src/test/regress/expected/triggers.out | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: Correct error message for row-level triggers with transition tab

2022-11-04 Thread Etsuro Fujita
Correct error message for row-level triggers with transition tables on 
partitioned tables.

"Triggers on partitioned tables cannot have transition tables." is
incorrect as we allow statement-level triggers on partitioned tables to
have transition tables.

This has been wrong since commit 86f575948; back-patch to v11 where that
commit came in.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/572695bcbcbd887fbf45653138e960831dd71db1

Modified Files
--
src/backend/commands/trigger.c | 2 +-
src/test/regress/expected/triggers.out | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: Correct error message for row-level triggers with transition tab

2022-11-04 Thread Etsuro Fujita
Correct error message for row-level triggers with transition tables on 
partitioned tables.

"Triggers on partitioned tables cannot have transition tables." is
incorrect as we allow statement-level triggers on partitioned tables to
have transition tables.

This has been wrong since commit 86f575948; back-patch to v11 where that
commit came in.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

Branch
--
REL_11_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6f47756d6fa87c1bb155c4a04752d3837620da0c

Modified Files
--
src/backend/commands/trigger.c | 2 +-
src/test/regress/expected/triggers.out | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: Correct error message for row-level triggers with transition tab

2022-11-04 Thread Etsuro Fujita
Correct error message for row-level triggers with transition tables on 
partitioned tables.

"Triggers on partitioned tables cannot have transition tables." is
incorrect as we allow statement-level triggers on partitioned tables to
have transition tables.

This has been wrong since commit 86f575948; back-patch to v11 where that
commit came in.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1699125ca218d4a035b794eef7c7b8872d10f527

Modified Files
--
src/backend/commands/trigger.c | 2 +-
src/test/regress/expected/triggers.out | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^3

2022-11-04 Thread Tom Lane
Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^31.

Commit aa0105141 repeated one of the oldest mistakes in our book:
thinking that OID is the same as int32.  It isn't of course, and
unsurprisingly the first person who came along with a database
OID above 2 billion broke it.  Repair.

Per bug #17677 from Sergey Pankov.  Back-patch to v15.

Discussion: https://postgr.es/m/17677-a99fa067d7ed7...@postgresql.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/34fa0ddae5cf27dd93a5855b30083185d4bb5a5b

Modified Files
--
src/backend/commands/dbcommands.c |  2 +-
src/backend/commands/define.c | 33 +
src/backend/parser/gram.y |  4 ++--
src/include/commands/defrem.h |  1 +
4 files changed, 37 insertions(+), 3 deletions(-)



pgsql: Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^3

2022-11-04 Thread Tom Lane
Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^31.

Commit aa0105141 repeated one of the oldest mistakes in our book:
thinking that OID is the same as int32.  It isn't of course, and
unsurprisingly the first person who came along with a database
OID above 2 billion broke it.  Repair.

Per bug #17677 from Sergey Pankov.  Back-patch to v15.

Discussion: https://postgr.es/m/17677-a99fa067d7ed7...@postgresql.org

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2c6d43650d16d91a3e731d236315beffd98db729

Modified Files
--
src/backend/commands/dbcommands.c |  2 +-
src/backend/commands/define.c | 33 +
src/backend/parser/gram.y |  4 ++--
src/include/commands/defrem.h |  1 +
4 files changed, 37 insertions(+), 3 deletions(-)



Re: pgsql: Resolve partition strategy during early parsing

2022-11-04 Thread Justin Pryzby
On Thu, Nov 03, 2022 at 03:41:56PM +, Alvaro Herrera wrote:
> Resolve partition strategy during early parsing
> 
> This has little practical value, but there's no reason to let the
> partition strategy names travel through DDL as strings.
> 
> Reviewed-by: Japin Li 
> Discussion: https://postgr.es/m/20221021093216.ffupd7epy2mytkux@alvherre.pgsql
> 
> Branch
> --
> master
> 
> Details
> ---
> https://git.postgresql.org/pg/commitdiff/5fca91025e05f803140831953c09a36f08efcef5

This caused a warning in MSVC.

[16:10:46.225] c:\cirrus\src\backend\parser\gram.y(18435) : warning C4715: 
'parsePartitionStrategy': not all control paths return a value

I'll send a patch to make cfbot warn about that soon.




pgsql: First-draft release notes for 15.1.

2022-11-04 Thread Tom Lane
First-draft release notes for 15.1.

As usual, the release notes for other branches will be made by cutting
these down, but put them up for community review first.

Also as usual for a .1 release, there are some entries here that
are not really relevant for v15 because they already appeared in 15.0.
Those'll be removed later.

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bc62182f0afe6b01fec45b8d26df03fc9de4599a

Modified Files
--
doc/src/sgml/release-15.sgml | 1200 ++
1 file changed, 1200 insertions(+)



pgsql: meson: Split 'main' suite into 'regress' and 'isolation'

2022-11-04 Thread Andres Freund
meson: Split 'main' suite into 'regress' and 'isolation'

Several people didn't like the 'main' name and found it confusing that the
main regression and isolation tests were in one suite.

Author: Justin Pryzby 
Discussion: 
https://postgr.es/m/20221001221514.2yy257v4zdfhw...@awork3.anarazel.de
Discussion: https://postgr.es/m/20221021123435.gu16...@telsasoft.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a5ac3e76fe96035db44e8e254f55f333c7a11634

Modified Files
--
src/test/isolation/meson.build | 2 +-
src/test/regress/meson.build   | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: meson: Mark PROVE as not required

2022-11-04 Thread Andres Freund
meson: Mark PROVE as not required

In the meson build the prove binary is currently not even used. It will soon
be, for PGXS compatibility, but even then we should build without it around.

Author: Justin Pryzby 
Discussion: https://postgr.es/m/20221021034040.gt16...@telsasoft.com
Discussion: https://postgr.es/m/20221104235412.ge16...@telsasoft.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ab72a31f6cc58ceda97009a5bfae27bd566a3752

Modified Files
--
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Remove unneeded includes of

2022-11-04 Thread Michael Paquier
Remove unneeded includes of 

Since bfb9dfd, none of the files updated in this commit have any stat()
calls, so these inclusions are not necessary, for the same reasons as
233cf6e.

Per discussion with John Naylor.

Discussion: 
https://postgr.es/m/cafbsxsgggx7kd6rxbnosjzusc8gz3hoxcfhtomlb_hjcm68...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/2a71de8915b41cb1a927fc7870efb138bbcd0b77

Modified Files
--
src/backend/access/heap/rewriteheap.c | 1 -
src/backend/storage/file/copydir.c| 1 -
src/timezone/pgtz.c   | 1 -
3 files changed, 3 deletions(-)