pgsql: Add missing uninstallation rule for BackgroundPsql.pm

2023-05-02 Thread Peter Eisentraut
Add missing uninstallation rule for BackgroundPsql.pm

Commit a4c17c8617 added in the install rule but not the uninstall
rule.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/7039c7cff6736780c3bbb41a90a6dfea0f581ad2

Modified Files
--
src/test/perl/Makefile | 1 +
1 file changed, 1 insertion(+)



pgsql: Update SQL features

2023-05-02 Thread Peter Eisentraut
Update SQL features

Some updates for SQL:2023 and some new features in PostgreSQL 16.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e0bb5d0c5bcada63dc9b8a1a72a344a07bf930ce

Modified Files
--
src/backend/catalog/sql_feature_packages.txt |  1 -
src/backend/catalog/sql_features.txt | 26 +-
2 files changed, 13 insertions(+), 14 deletions(-)



pgsql: Fix overridden callbacks in pg_rewind.

2023-05-02 Thread Daniel Gustafsson
Fix overridden callbacks in pg_rewind.

The _traverse_files functions take a callback for processing
files, but both the local and libpq source implementations called the
function directly without using the callback argument. While there is
no bug right now as the function called is the same as the callback,
fix by calling the callback to reduce the risk of subtle bugs in the
future.

Author: Junwang Zhao 
Reviewed-by: Richard Guo 
Discussion: 
https://postgr.es/m/CAEG8a3Jdwgh+PZr2zh1=t8apa4yz8tkq+uubpqoct14nvwk...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/08237056f84e3a9ed75e8a698428c669f4d35db4

Modified Files
--
src/bin/pg_rewind/libpq_source.c | 2 +-
src/bin/pg_rewind/local_source.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



pgsql: Doc: clarify behavior of row-limit arguments in the PLs' SPI wra

2023-05-02 Thread Tom Lane
Doc: clarify behavior of row-limit arguments in the PLs' SPI wrappers.

plperl, plpython, and pltcl all provide query-execution functions
that are thin wrappers around SPI_execute() or its variants.
The SPI functions document their row-count limit arguments clearly,
as "maximum number of rows to return, or 0 for no limit".  However
the PLs' documentation failed to explain this special behavior of
zero, so that a reader might well assume it means "fetch zero
rows".  Improve that.

Daniel Gustafsson and Tom Lane, per report from Kieran McCusker

Discussion: 
https://postgr.es/m/cagguq6h6qyscctohktq9hlfddoafbkhyugjbz6q_doapnzn...@mail.gmail.com

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/23c7aa865b321b9aba50b105288a5d12ccc35442

Modified Files
--
doc/src/sgml/plperl.sgml   | 21 -
doc/src/sgml/plpython.sgml | 13 +++--
doc/src/sgml/pltcl.sgml|  8 +---
3 files changed, 32 insertions(+), 10 deletions(-)



pgsql: Doc: clarify behavior of row-limit arguments in the PLs' SPI wra

2023-05-02 Thread Tom Lane
Doc: clarify behavior of row-limit arguments in the PLs' SPI wrappers.

plperl, plpython, and pltcl all provide query-execution functions
that are thin wrappers around SPI_execute() or its variants.
The SPI functions document their row-count limit arguments clearly,
as "maximum number of rows to return, or 0 for no limit".  However
the PLs' documentation failed to explain this special behavior of
zero, so that a reader might well assume it means "fetch zero
rows".  Improve that.

Daniel Gustafsson and Tom Lane, per report from Kieran McCusker

Discussion: 
https://postgr.es/m/cagguq6h6qyscctohktq9hlfddoafbkhyugjbz6q_doapnzn...@mail.gmail.com

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/66ab2660e0783fd4f6be5936e17a2c8e12335d0d

Modified Files
--
doc/src/sgml/plperl.sgml   | 21 -
doc/src/sgml/plpython.sgml | 13 +++--
doc/src/sgml/pltcl.sgml|  8 +---
3 files changed, 32 insertions(+), 10 deletions(-)



pgsql: Doc: clarify behavior of row-limit arguments in the PLs' SPI wra

2023-05-02 Thread Tom Lane
Doc: clarify behavior of row-limit arguments in the PLs' SPI wrappers.

plperl, plpython, and pltcl all provide query-execution functions
that are thin wrappers around SPI_execute() or its variants.
The SPI functions document their row-count limit arguments clearly,
as "maximum number of rows to return, or 0 for no limit".  However
the PLs' documentation failed to explain this special behavior of
zero, so that a reader might well assume it means "fetch zero
rows".  Improve that.

Daniel Gustafsson and Tom Lane, per report from Kieran McCusker

Discussion: 
https://postgr.es/m/cagguq6h6qyscctohktq9hlfddoafbkhyugjbz6q_doapnzn...@mail.gmail.com

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b00bae2e9103b4cd4fc97141b3aba2fa0ce532a8

Modified Files
--
doc/src/sgml/plperl.sgml   | 21 -
doc/src/sgml/plpython.sgml | 13 +++--
doc/src/sgml/pltcl.sgml|  8 +---
3 files changed, 32 insertions(+), 10 deletions(-)



pgsql: Doc: clarify behavior of row-limit arguments in the PLs' SPI wra

2023-05-02 Thread Tom Lane
Doc: clarify behavior of row-limit arguments in the PLs' SPI wrappers.

plperl, plpython, and pltcl all provide query-execution functions
that are thin wrappers around SPI_execute() or its variants.
The SPI functions document their row-count limit arguments clearly,
as "maximum number of rows to return, or 0 for no limit".  However
the PLs' documentation failed to explain this special behavior of
zero, so that a reader might well assume it means "fetch zero
rows".  Improve that.

Daniel Gustafsson and Tom Lane, per report from Kieran McCusker

Discussion: 
https://postgr.es/m/cagguq6h6qyscctohktq9hlfddoafbkhyugjbz6q_doapnzn...@mail.gmail.com

Branch
--
REL_11_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/0e0463fc590c6fe55083ed941e28655700b4

Modified Files
--
doc/src/sgml/plperl.sgml   | 21 -
doc/src/sgml/plpython.sgml | 13 +++--
doc/src/sgml/pltcl.sgml|  8 +---
3 files changed, 32 insertions(+), 10 deletions(-)



pgsql: Doc: clarify behavior of row-limit arguments in the PLs' SPI wra

2023-05-02 Thread Tom Lane
Doc: clarify behavior of row-limit arguments in the PLs' SPI wrappers.

plperl, plpython, and pltcl all provide query-execution functions
that are thin wrappers around SPI_execute() or its variants.
The SPI functions document their row-count limit arguments clearly,
as "maximum number of rows to return, or 0 for no limit".  However
the PLs' documentation failed to explain this special behavior of
zero, so that a reader might well assume it means "fetch zero
rows".  Improve that.

Daniel Gustafsson and Tom Lane, per report from Kieran McCusker

Discussion: 
https://postgr.es/m/cagguq6h6qyscctohktq9hlfddoafbkhyugjbz6q_doapnzn...@mail.gmail.com

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/825828956ab3c55bd22259d9c480b5f5d2d84416

Modified Files
--
doc/src/sgml/plperl.sgml   | 21 -
doc/src/sgml/plpython.sgml | 13 +++--
doc/src/sgml/pltcl.sgml|  8 +---
3 files changed, 32 insertions(+), 10 deletions(-)



pgsql: Doc: clarify behavior of row-limit arguments in the PLs' SPI wra

2023-05-02 Thread Tom Lane
Doc: clarify behavior of row-limit arguments in the PLs' SPI wrappers.

plperl, plpython, and pltcl all provide query-execution functions
that are thin wrappers around SPI_execute() or its variants.
The SPI functions document their row-count limit arguments clearly,
as "maximum number of rows to return, or 0 for no limit".  However
the PLs' documentation failed to explain this special behavior of
zero, so that a reader might well assume it means "fetch zero
rows".  Improve that.

Daniel Gustafsson and Tom Lane, per report from Kieran McCusker

Discussion: 
https://postgr.es/m/cagguq6h6qyscctohktq9hlfddoafbkhyugjbz6q_doapnzn...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/6489875ce6b16662142bc70e003437b9753c199f

Modified Files
--
doc/src/sgml/plperl.sgml   | 21 -
doc/src/sgml/plpython.sgml | 13 +++--
doc/src/sgml/pltcl.sgml|  8 +---
3 files changed, 32 insertions(+), 10 deletions(-)



pgsql: Fix assertion failure in apply worker.

2023-05-02 Thread Amit Kapila
Fix assertion failure in apply worker.

During exit, the logical replication apply worker tries to release session
level locks, if any. However, if the apply worker exits due to an error
before its connection is initialized, trying to release locks can lead to
assertion failure. The locks will be acquired once the worker is
initialized, so we don't need to release them till the worker
initialization is complete.

Reported-by: Alexander Lakhin
Author: Hou Zhijie based on inputs from Sawada Masahiko and Amit Kapila
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/2185d65f-5aae-3efa-c48f-fb42b173e...@gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/de63f8dadee4afa152ce177fd3c562d47373a728

Modified Files
--
src/backend/replication/logical/applyparallelworker.c | 4 
src/backend/replication/logical/launcher.c| 5 -
src/backend/replication/logical/worker.c  | 7 +++
src/include/replication/worker_internal.h | 2 ++
4 files changed, 17 insertions(+), 1 deletion(-)