pgsql: Don't use pgbench -j in tests

2023-12-04 Thread Alvaro Herrera
Don't use pgbench -j in tests

It draws an unnecessary error in builds compiled without thread support.

Added by commit 038f586d5f1d, which was backpatched to 14; though in
branch master we no longer support such builds, there's no reason to
have this there, so remove it in all branches since 14.

Reported-by: Michael Paquier 
Discussion: https://postgr.es/m/zw2g9ix4nbklc...@paquier.xyz

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a3f76a3f7e3a670728e2e2bed45499c11acb2936

Modified Files
--
src/bin/pgbench/t/001_pgbench_with_server.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Don't use pgbench -j in tests

2023-12-04 Thread Alvaro Herrera
Don't use pgbench -j in tests

It draws an unnecessary error in builds compiled without thread support.

Added by commit 038f586d5f1d, which was backpatched to 14; though in
branch master we no longer support such builds, there's no reason to
have this there, so remove it in all branches since 14.

Reported-by: Michael Paquier 
Discussion: https://postgr.es/m/zw2g9ix4nbklc...@paquier.xyz

Branch
--
REL_16_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/419cac053b6b27e4111216b8a529a1a0887580bb

Modified Files
--
src/bin/pgbench/t/001_pgbench_with_server.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Don't use pgbench -j in tests

2023-12-04 Thread Alvaro Herrera
Don't use pgbench -j in tests

It draws an unnecessary error in builds compiled without thread support.

Added by commit 038f586d5f1d, which was backpatched to 14; though in
branch master we no longer support such builds, there's no reason to
have this there, so remove it in all branches since 14.

Reported-by: Michael Paquier 
Discussion: https://postgr.es/m/zw2g9ix4nbklc...@paquier.xyz

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/be7b4d976600fe5b52bd0d3a4e61259b55e3c0c2

Modified Files
--
src/bin/pgbench/t/001_pgbench_with_server.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Don't use pgbench -j in tests

2023-12-04 Thread Alvaro Herrera
Don't use pgbench -j in tests

It draws an unnecessary error in builds compiled without thread support.

Added by commit 038f586d5f1d, which was backpatched to 14; though in
branch master we no longer support such builds, there's no reason to
have this there, so remove it in all branches since 14.

Reported-by: Michael Paquier 
Discussion: https://postgr.es/m/zw2g9ix4nbklc...@paquier.xyz

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/25f2a43756443031239a5d212a63ae9b183e4502

Modified Files
--
src/bin/pgbench/t/001_pgbench_with_server.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Remove now-unnecessary Autovacuum[Launcher|Worker]IAm functions

2023-12-04 Thread Heikki Linnakangas
Remove now-unnecessary Autovacuum[Launcher|Worker]IAm functions

After commit fd5e8b440d, InitProcess() is called later in the
EXEC_BACKEND startup sequence, so it's enough to set the
am_autovacuum_[launcher|worker] variables at the same place as in the
!EXEC_BACKEND case.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e7c6efe305afff030b50fe6f792af48deff5cf3e

Modified Files
--
src/backend/postmaster/autovacuum.c | 18 --
src/backend/postmaster/postmaster.c |  6 --
src/include/postmaster/autovacuum.h |  2 --
3 files changed, 26 deletions(-)



pgsql: Teach convert() and friends to avoid copying when possible.

2023-12-04 Thread Nathan Bossart
Teach convert() and friends to avoid copying when possible.

Presently, pg_convert() allocates a new bytea and copies the result
regardless of whether any conversion actually happened.  This
commit adjusts this function to return the source pointer as-is if
no conversion occurred.  This optimization isn't expected to make a
tremendous difference, but it still seems worthwhile to avoid
unnecessary memory allocations.

Author: Yurii Rashkovskii
Reviewed-by: Bertrand Drouvot
Discussion: 
https://postgr.es/m/CA%2BRLCQyknBPSWXRBQGOi6aYEcdQ9RpH9Kch4GjoeY8dQ3D%2Bvhw%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/b14b1eb4da4c97afec24cf8956e842b98ebb2a51

Modified Files
--
src/backend/utils/mb/mbutils.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)



pgsql: Optimize SearchPathCache by saving the last entry.

2023-12-04 Thread Jeff Davis
Optimize SearchPathCache by saving the last entry.

Repeated lookups are common, so it's worth it to check the last entry
before doing another hash lookup.

Discussion: 
https://postgr.es/m/04c8592dbd694e4114a3ed87139a7a04e4363030.camel%40j-davis.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a86c61c9eefaba7dcf375cd60c875c871ed60945

Modified Files
--
src/backend/catalog/namespace.c | 88 ++---
1 file changed, 57 insertions(+), 31 deletions(-)



pgsql: Fix a random failure in 003_logical_slots.pl.

2023-12-04 Thread Amit Kapila
Fix a random failure in 003_logical_slots.pl.

The failed test was trying to validate that the two_phase option for a
slot is retained after the upgrade. The problem was that it didn't get
enabled before the upgrade so expecting to be enabled after the upgrade
was not right in the first place. This is a timing issue because we enable
the two_phase once the initial sync for all the tables is finished.
Normally, we wait for the two_phase state to be enabled but this test
missed that step.

Per buildfarm.

Author: Hayato Kuroda
Discussion: 
https://postgr.es/m/ty3pr01mb98892396d1071fc4320d6b31f5...@ty3pr01mb9889.jpnprd01.prod.outlook.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/63c5df126abb7364b70dafe75fef576dd8eb0bbc

Modified Files
--
src/bin/pg_upgrade/t/003_logical_slots.pl | 6 ++
1 file changed, 6 insertions(+)