[COMMITTERS] pgsql: Exclude pg_internal.init from BASE_BACKUP

2017-11-07 Thread Simon Riggs
Exclude pg_internal.init from BASE_BACKUP

Add docs to explain this for other backup mechanisms

Author: David Steele 
Reviewed-by: Petr Jelinek  et al

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/98267ee83e068afa8bd85c8cc710ab2144e711fa

Modified Files
--
doc/src/sgml/backup.sgml |  6 ++
doc/src/sgml/protocol.sgml   |  5 +
src/backend/replication/basebackup.c |  4 
src/backend/utils/cache/relcache.c   |  5 -
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 10 --
src/include/utils/relcache.h |  5 +
6 files changed, 28 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Grammar typo in security warning about md5

2017-10-02 Thread Simon Riggs
Grammar typo in security warning about md5

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/0703c197adb0bf5fa6c99e8af74b13585bdc9056

Modified Files
--
doc/src/sgml/client-auth.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Exclude special values in recovery_target_time

2017-09-07 Thread Simon Riggs
Exclude special values in recovery_target_time

recovery_target_time accepts timestamp input, though
does not allow use of special values, e.g. “today”.
Report a useful error message for these cases.

Reported-by: Piotr Stefaniak
Author: Simon Riggs
Discussion: 
https://postgr.es/m/canp8+jjdka+bkkylwz9zam16y0s2exbv0wfpawxdtppfwna...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f06588a8e6d1e2bf56f9dfa58d97e7956050ddc7

Modified Files
--
src/backend/access/transam/xlog.c | 12 
1 file changed, 12 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Allow SET STATISTICS on expression indexes

2017-09-06 Thread Simon Riggs
Allow SET STATISTICS on expression indexes

Index columns are referenced by ordinal number rather than name, e.g.
CREATE INDEX coord_idx ON measured (x, y, (z + t));
ALTER INDEX coord_idx ALTER COLUMN 3 SET STATISTICS 1000;

Incompatibility note for release notes:
\d+ for indexes now also displays Stats Target

Authors: Alexander Korotkov, with contribution by Adrien NAYRAT
Review: Adrien NAYRAT, Simon Riggs
Wordsmith: Simon Riggs

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/5b6d13eec72b960eb0f78542199380e49c8583d4

Modified Files
--
doc/src/sgml/ref/alter_index.sgml  | 39 +
src/backend/commands/tablecmds.c   | 55 +++---
src/backend/nodes/copyfuncs.c  |  1 +
src/backend/nodes/equalfuncs.c |  1 +
src/backend/parser/gram.y  | 16 +
src/backend/utils/cache/syscache.c | 46 +
src/bin/psql/describe.c|  2 ++
src/bin/psql/tab-complete.c|  5 ++-
src/include/nodes/parsenodes.h |  2 ++
src/include/utils/syscache.h   |  3 ++
src/test/regress/expected/alter_table.out  | 24 +
src/test/regress/expected/create_index.out |  8 ++---
src/test/regress/sql/alter_table.sql   | 16 +
13 files changed, 201 insertions(+), 17 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.

2017-09-05 Thread Simon Riggs
On 5 September 2017 at 07:51, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Add psql variables showing server version and psql version.
>
> We already had a psql variable VERSION that shows the verbose form of
> psql's own version.  Add VERSION_NAME to show the short form (e.g.,
> "11devel") and VERSION_NUM to show the numeric form (e.g., 11).
> Also add SERVER_VERSION_NAME and SERVER_VERSION_NUM to show the short and
> numeric forms of the server's version.  (We'd probably add SERVER_VERSION
> with the verbose string if it were readily available; but adding another
> network round trip to get it seems too expensive.)
>
> The numeric forms, in particular, are expected to be useful for scripting
> purposes, now that psql can do conditional tests.

This is good.

Please can we backpatch these are far as they will go (easily)?

There is very little risk in doing so and significant benefits in
being able to rely on scripts that know about versions.

Thanks

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Provisional list of Major Features

2017-09-01 Thread Simon Riggs
Provisional list of Major Features

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/2f5ada2710d6e5a668d6d6b27f93ac545a01bafd

Modified Files
--
doc/src/sgml/release-10.sgml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Provisional list of Major Features

2017-09-01 Thread Simon Riggs
On 1 September 2017 at 15:13, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Simon Riggs <si...@2ndquadrant.com> writes:
>> Provisional list of Major Features
>> Branch
>> --
>> REL_10_STABLE
>
> If you don't commit that to HEAD, it's going to disappear the next
> time Bruce or I update the release notes.  The HEAD copy is always
> the authoritative version of any release-notes file.

Done, thanks.


-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid race condition in logical replication test

2017-09-01 Thread Simon Riggs
Avoid race condition in logical replication test

Wait for slot to become inactive before continuing.

Author: Petr Jelinek

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/4f27c674fd9fb5ba1f2952e2db53886bb5954e8b

Modified Files
--
src/test/recovery/t/006_logical_decoding.pl | 5 +
1 file changed, 5 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid race condition in logical replication test

2017-09-01 Thread Simon Riggs
Avoid race condition in logical replication test

Wait for slot to become inactive before continuing.

Author: Petr Jelinek

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/3950e07eb46ebe99331ca82d659269056470f596

Modified Files
--
src/test/recovery/t/006_logical_decoding.pl | 5 +
1 file changed, 5 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Provisional list of Major Features

2017-09-01 Thread Simon Riggs
Provisional list of Major Features

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/44654f3d2555702279d080e87c70730dc0cb7a9d

Modified Files
--
doc/src/sgml/release-10.sgml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add note about diskspace usage of pg_commit_ts

2017-09-01 Thread Simon Riggs
Add note about diskspace usage of pg_commit_ts

Author: Thomas Munro

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/abe85ef1d00187a42e7a757ea0413bc4965a4525

Modified Files
--
doc/src/sgml/maintenance.sgml | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add note about diskspace usage of pg_commit_ts

2017-09-01 Thread Simon Riggs
Add note about diskspace usage of pg_commit_ts

Author: Thomas Munro

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/28915c7db4da4eaffb8eb0dc5c04c87dcf345eb6

Modified Files
--
doc/src/sgml/maintenance.sgml | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix typo in comment in SerializeSnapshot

2017-06-24 Thread Simon Riggs
Fix typo in comment in SerializeSnapshot

Author: Masahiko Sawada

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a15b47df357d6c9ac6ebc2ce63bb24c6faddd44c

Modified Files
--
src/backend/utils/time/snapmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Revert 1f30295eab65eddaa88528876ab66e7095f4bb65

2017-06-24 Thread Simon Riggs
Revert 1f30295eab65eddaa88528876ab66e7095f4bb65

Reported-by: Tom Lane

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/829f12e2690c0442e156069092b05f1edc78b08a

Modified Files
--
src/backend/utils/time/snapmgr.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve replication lag interpolation after idle period

2017-06-23 Thread Simon Riggs
Improve replication lag interpolation after idle period

After sitting idle and fully replayed for a while and then encountering
a new burst of WAL activity, we interpolate between an ancient sample and the
not-yet-reached one for the new traffic. That produced a corner case report
of lag after receiving first new reply from standby, which might sometimes
be a large spike.

Correct this by resetting last_read time and handle that new case.

Author: Thomas Munro

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9ea3c64124af039219aa5030d7af675dce5daa60

Modified Files
--
src/backend/replication/walsender.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Minor corrections to high availability docs

2017-06-23 Thread Simon Riggs
Minor corrections to high availability docs

Startup process is displayed in pg_stat_activity, noted by Yugo Nagata.
Transactions can be resolved at end of recovery.

Author: Yugo Nagata, with addition by me

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a79122b06194927d2b79465f335b94f2b4472816

Modified Files
--
doc/src/sgml/high-availability.sgml | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Lag tracking for logical replication

2017-05-12 Thread Simon Riggs
Lag tracking for logical replication

Lag tracking is called for each commit, but we introduce
a pacing delay to ensure we don't swamp the lag tracker.

Author: Petr Jelinek, with minor pacing delay code from me

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/024711bb544645c8b1061e9f02b261e2e336981d

Modified Files
--
src/backend/replication/logical/logical.c  | 34 ++-
src/backend/replication/logical/logicalfuncs.c |  2 +-
src/backend/replication/pgoutput/pgoutput.c|  2 ++
src/backend/replication/slotfuncs.c|  3 +-
src/backend/replication/walsender.c| 45 --
src/include/replication/logical.h  | 15 ++---
src/include/replication/output_plugin.h|  1 +
7 files changed, 79 insertions(+), 23 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove poorly worded and duplicated comment

2017-05-08 Thread Simon Riggs
Remove poorly worded and duplicated comment

Move line of code to avoid need for duplicated comment

Brought to attention by Masahiko Sawada

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/1f30295eab65eddaa88528876ab66e7095f4bb65

Modified Files
--
src/backend/utils/time/snapmgr.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Always SnapshotResetXmin() during ClearTransaction()

2017-04-06 Thread Simon Riggs
Always SnapshotResetXmin() during ClearTransaction()

Avoid corner cases during 2PC with 6bad580d9e678a0b604883e14d8401d469b06566

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/cd0cebaf7d1ab04427d4045edf7121a8f3753d8b

Modified Files
--
src/backend/access/transam/xact.c |  2 +-
src/backend/utils/time/snapmgr.c  | 15 +++
src/include/utils/snapmgr.h   |  2 +-
3 files changed, 9 insertions(+), 10 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()

2017-04-06 Thread Simon Riggs
On 6 April 2017 at 09:11, Robert Haas <robertmh...@gmail.com> wrote:

> Just like the last time you committed this, it seems to have broken
> the entire buildfarm.

For different reasons, AFAIU. Investigating already.

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()

2017-04-06 Thread Simon Riggs
Avoid SnapshotResetXmin() during AtEOXact_Snapshot()

For normal commits and aborts we already reset PgXact->xmin,
so we can simply avoid running SnapshotResetXmin() twice.

During performance tests by Alexander Korotkov, diagnosis
by Andres Freund showed PgXact array as a bottleneck. After
manual analysis by me of the code paths that touch those
memory locations, I was able to identify extraneous code
in the main transaction commit path.

Avoiding touching highly contented shmem improves concurrent
performance slightly on all workloads, confirmed by tests
run by Ashutosh Sharma and Alexander Korotkov.

Simon Riggs

Discussion: canp8+jjdxe9b+b9f8cqt-luxxo0pbcb-szffmvadp+akqo4...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/6bad580d9e678a0b604883e14d8401d469b06566

Modified Files
--
src/backend/access/transam/xact.c |  6 +++---
src/backend/utils/time/snapmgr.c  | 14 --
src/include/utils/snapmgr.h   |  2 +-
3 files changed, 16 insertions(+), 6 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reduce lock level for CREATE STATISTICS

2017-04-05 Thread Simon Riggs
Reduce lock level for CREATE STATISTICS

In line with other lock reductions related to planning.

Simon Riggs

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/68ea2b7f9b52d35b5fcd9c8d44d88de5a64be3ba

Modified Files
--
doc/src/sgml/mvcc.sgml   | 3 ++-
src/backend/commands/statscmds.c | 8 +++-
2 files changed, 9 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread Simon Riggs
Collect and use multi-column dependency stats

Follow on patch in the multi-variate statistics patch series.

CREATE STATISTICS s1 WITH (dependencies) ON (a, b) FROM t;
ANALYZE;
will collect dependency stats on (a, b) and then use the measured
dependency in subsequent query planning.

Commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b added
CREATE STATISTICS with n-distinct coefficients. These are now
specified using the mutually exclusive option WITH (ndistinct).

Author: Tomas Vondra, David Rowley
Reviewed-by: Kyotaro HORIGUCHI, Álvaro Herrera, Dean Rasheed, Robert Haas
and many other comments and contributions
Discussion: 
https://postgr.es/m/56f40b20-c464-fad2-ff39-06b668fac...@2ndquadrant.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/2686ee1b7ccfb9214064d4d2a98ea77382880306

Modified Files
--
contrib/file_fdw/file_fdw.c  |1 +
contrib/postgres_fdw/postgres_fdw.c  |5 +-
doc/src/sgml/catalogs.sgml   |9 +
doc/src/sgml/planstats.sgml  |  154 +++
doc/src/sgml/ref/create_statistics.sgml  |   42 +-
src/backend/catalog/system_views.sql |3 +-
src/backend/commands/statscmds.c |   17 +-
src/backend/optimizer/path/clausesel.c   |  113 ++-
src/backend/optimizer/path/costsize.c|   25 +-
src/backend/optimizer/util/orclauses.c   |4 +-
src/backend/optimizer/util/plancat.c |   12 +
src/backend/statistics/Makefile  |2 +-
src/backend/statistics/README|   68 +-
src/backend/statistics/README.dependencies   |  119 +++
src/backend/statistics/dependencies.c| 1079 ++
src/backend/statistics/extended_stats.c  |  105 ++-
src/backend/utils/adt/ruleutils.c|   54 +-
src/backend/utils/adt/selfuncs.c |   20 +-
src/bin/psql/describe.c  |   12 +-
src/include/catalog/pg_cast.h|4 +
src/include/catalog/pg_proc.h|9 +
src/include/catalog/pg_statistic_ext.h   |7 +-
src/include/catalog/pg_type.h|4 +
src/include/optimizer/cost.h |6 +-
src/include/statistics/extended_stats_internal.h |5 +
src/include/statistics/statistics.h  |   44 +
src/test/regress/expected/opr_sanity.out |3 +-
src/test/regress/expected/rules.out  |3 +-
src/test/regress/expected/stats_ext.out  |  110 ++-
src/test/regress/expected/type_sanity.out|7 +-
src/test/regress/sql/stats_ext.sql   |   68 ++
31 files changed, 2035 insertions(+), 79 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Allow --with-wal-segsize=n up to n=1024MB

2017-04-05 Thread Simon Riggs
Allow --with-wal-segsize=n up to n=1024MB

Other part of Beena Emerson's patch to allow testing

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/00b6b6feb12cef53737287b67ecef6aff1f1d8ab

Modified Files
--
configure  | 6 +-
configure.in   | 6 +-
doc/src/sgml/installation.sgml | 2 +-
3 files changed, 11 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Spelling mistake in comment in utility.c

2017-04-05 Thread Simon Riggs
Spelling mistake in comment in utility.c

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ed770c325ca374fee7b3b66f5cb29af1a73a1743

Modified Files
--
src/backend/tcop/utility.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make min_wal_size/max_wal_size use MB internally

2017-04-04 Thread Simon Riggs
Make min_wal_size/max_wal_size use MB internally

Previously they were defined using multiples of XLogSegSize.
Remove GUC_UNIT_XSEGS. Introduce GUC_UNIT_MB

Extracted from patch series on XLogSegSize infrastructure.

Beena Emerson

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9a3215026bd6955e88bd8c20542cfe6acffdb1c8

Modified Files
--
src/backend/access/transam/xlog.c | 22 +-
src/backend/utils/misc/guc.c  | 30 ++
src/include/access/xlog.h |  4 ++--
src/include/utils/guc.h   |  2 +-
4 files changed, 30 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix uninitialized variables in twophase.c

2017-04-04 Thread Simon Riggs
Fix uninitialized variables in twophase.c

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/cd740c0dbfb3038eea2e921e82e2f5345d0718c5

Modified Files
--
src/backend/access/transam/twophase.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Speedup 2PC recovery by skipping two phase state files in normal

2017-04-04 Thread Simon Riggs
Speedup 2PC recovery by skipping two phase state files in normal path

2PC state info held in shmem at PREPARE, then cleaned at COMMIT PREPARED/ABORT 
PREPARED,
avoiding writing/fsyncing any state information to disk in the normal path, 
greatly enhancing replay speed.
Prepared transactions that live past one checkpoint redo horizon will be 
written to disk as now.
Similar conceptually to 978b2f65aa1262eb4ecbf8b3785cb1b9cf4db78e and building 
upon
the infrastructure created by that commit.

Authors, in equal measure: Stas Kelvich, Nikhil Sontakke and Michael Paquier
Discussion: 
https://postgr.es/m/CAMGcDxf8Bn9ZPBBJZba9wiyQq-Qk5uqq=vjomnrnw5s+fks...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/728bd991c3c4389fb39c45dcb0fe57e4a1dccd71

Modified Files
--
src/backend/access/transam/twophase.c | 821 ++
src/backend/access/transam/xact.c |  18 +-
src/backend/access/transam/xlog.c |  10 +
src/include/access/twophase.h |   7 +-
4 files changed, 550 insertions(+), 306 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] Add optional JIT support for expression evaluation.

2017-04-01 Thread Simon Riggs
On 1 April 2017 at 08:41, Andres Freund <and...@anarazel.de> wrote:

> Originally slated for v11, discussions at pgconf.us convinced me to
> add this to v10.

+1

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Default monitoring roles

2017-03-30 Thread Simon Riggs
On 30 March 2017 at 19:31, Erik Rijkers <e...@xs4all.nl> wrote:
> On 2017-03-30 20:20, Simon Riggs wrote:
>>
>> Default monitoring roles
>
>
>
> The buildfarm is showing red (the same errors that I get...):
>
>
> pgrowlocks.c: In function ‘pgrowlocks’:
> pgrowlocks.c:105:65: error: expected ‘)’ before ‘;’ token
> is_member_of_role(GetUserId(), DEFAULT_ROLE_STAT_SCAN_TABLES);
>  ^
> [...]

Weird. make check-world just skipped that directory. I guess for Dave also.

Bug fixed, but will look at makefile

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix pgrowlocks minor coding oversight

2017-03-30 Thread Simon Riggs
Fix pgrowlocks minor coding oversight

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ceb3158abe743ddcb213457fc9fcd1a89812194f

Modified Files
--
contrib/pgrowlocks/pgrowlocks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Default monitoring roles

2017-03-30 Thread Simon Riggs
Default monitoring roles

Three nologin roles with non-overlapping privs are created by default
* pg_read_all_settings - read all GUCs.
* pg_read_all_stats - pg_stat_*, pg_database_size(), pg_tablespace_size()
* pg_stat_scan_tables - may lock/scan tables

Top level role - pg_monitor includes all of the above by default, plus others

Author: Dave Page
Reviewed-by: Stephen Frost, Robert Haas, Peter Eisentraut, Simon Riggs

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/25fff40798fc4ac11a241bfd9ab0c45c085e2212

Modified Files
--
contrib/pg_buffercache/Makefile|  5 +--
.../pg_buffercache/pg_buffercache--1.2--1.3.sql|  7 +
contrib/pg_buffercache/pg_buffercache.control  |  2 +-
contrib/pg_freespacemap/Makefile   |  4 +--
.../pg_freespacemap/pg_freespacemap--1.1--1.2.sql  |  7 +
contrib/pg_freespacemap/pg_freespacemap.control|  2 +-
contrib/pg_stat_statements/Makefile|  7 +++--
.../pg_stat_statements--1.4--1.5.sql   |  6 
contrib/pg_stat_statements/pg_stat_statements.c|  8 +++--
.../pg_stat_statements/pg_stat_statements.control  |  2 +-
contrib/pg_visibility/Makefile |  3 +-
contrib/pg_visibility/pg_visibility--1.1--1.2.sql  | 13 
contrib/pg_visibility/pg_visibility.control|  2 +-
contrib/pgrowlocks/pgrowlocks.c|  9 --
contrib/pgstattuple/pgstattuple--1.4--1.5.sql  |  9 ++
doc/src/sgml/catalogs.sgml |  8 +++--
doc/src/sgml/func.sgml | 23 --
doc/src/sgml/pgbuffercache.sgml|  5 +--
doc/src/sgml/pgfreespacemap.sgml   |  5 +--
doc/src/sgml/pgrowlocks.sgml   |  7 +
doc/src/sgml/pgstatstatements.sgml |  9 +++---
doc/src/sgml/pgstattuple.sgml  |  3 +-
doc/src/sgml/pgvisibility.sgml |  5 ++-
doc/src/sgml/user-manag.sgml   | 36 ++
src/backend/catalog/system_views.sql   |  6 
src/backend/replication/walreceiver.c  |  3 +-
src/backend/utils/adt/dbsize.c | 20 
src/backend/utils/adt/pgstatfuncs.c|  6 ++--
src/backend/utils/misc/guc.c   | 21 -
src/include/catalog/pg_authid.h|  8 +
30 files changed, 196 insertions(+), 55 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Correct grammar in error message

2017-03-28 Thread Simon Riggs
Correct grammar in error message

"could not generate" rather than "could not generation"
from commit 818fd4a67d610991757b610755e3065fb99d80a5

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/a99f77021f0c8c1c221af4e36b64ca43abd04389

Modified Files
--
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Cleanup slots during drop database

2017-03-28 Thread Simon Riggs
Cleanup slots during drop database

Automatically drop all logical replication slots associated with a
database when the database is dropped. Previously we threw an ERROR
if a slot existed. Now we throw ERROR only if a slot is active in
the database being dropped.

Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ff539da31691f2cd2694360250571c5c5fb7415e

Modified Files
--
doc/src/sgml/func.sgml |  3 +-
doc/src/sgml/protocol.sgml |  2 +
src/backend/commands/dbcommands.c  | 32 +---
src/backend/replication/slot.c | 88 ++
src/include/replication/slot.h |  1 +
src/test/recovery/t/006_logical_decoding.pl| 40 +-
.../recovery/t/010_logical_decoding_timelines.pl   | 30 +++-
7 files changed, 182 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Report catalog_xmin separately in hot_standby_feedback

2017-03-25 Thread Simon Riggs
Report catalog_xmin separately in hot_standby_feedback

If the upstream walsender is using a physical replication slot, store the
catalog_xmin in the slot's catalog_xmin field. If the upstream doesn't use a
slot and has only a PGPROC entry behaviour doesn't change, as we store the
combined xmin and catalog_xmin in the PGPROC entry.

Author: Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5737c12df0581b3298e3e9586bdef170811ce176

Modified Files
--
doc/src/sgml/protocol.sgml |  33 ++-
src/backend/replication/walreceiver.c  |  43 ++--
src/backend/replication/walsender.c| 108 +++--
src/backend/storage/ipc/procarray.c|  12 ++-
src/include/storage/proc.h |   5 +
src/include/storage/procarray.h|  11 +++
.../recovery/t/010_logical_decoding_timelines.pl   |  38 +++-
7 files changed, 199 insertions(+), 51 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reverting 42b4b0b2413b9b472aaf2112a3bbfd80a6ab4dc5

2017-03-24 Thread Simon Riggs
Reverting 42b4b0b2413b9b472aaf2112a3bbfd80a6ab4dc5

Buildfarm issues and other reported issues

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3428ef79115927c92c6e2ab6f261f5de5dc4e914

Modified Files
--
src/backend/access/transam/xact.c |  6 +++---
src/backend/utils/time/snapmgr.c  | 21 +++--
src/include/utils/snapmgr.h   |  2 +-
3 files changed, 7 insertions(+), 22 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()

2017-03-24 Thread Simon Riggs
Avoid SnapshotResetXmin() during AtEOXact_Snapshot()

For normal commits and aborts we already reset PgXact->xmin
Avoiding touching highly contented shmem improves concurrent
performance.

Simon Riggs

Discussion: canp8+jjdxe9b+b9f8cqt-luxxo0pbcb-szffmvadp+akqo4...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/42b4b0b2413b9b472aaf2112a3bbfd80a6ab4dc5

Modified Files
--
src/backend/access/transam/xact.c |  6 +++---
src/backend/utils/time/snapmgr.c  | 21 ++---
src/include/utils/snapmgr.h   |  2 +-
3 files changed, 22 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Minor spelling correction in comment

2017-03-23 Thread Simon Riggs
Minor spelling correction in comment
Jon Nelson

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/232c532213446701583e015ca55b5afb9c291445

Modified Files
--
src/backend/utils/adt/network.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Replication lag tracking for walsenders

2017-03-23 Thread Simon Riggs
Replication lag tracking for walsenders

Adds write_lag, flush_lag and replay_lag cols to pg_stat_replication.

Implements a lag tracker module that reports the lag times based upon
measurements of the time taken for recent WAL to be written, flushed and
replayed and for the sender to hear about it. These times
represent the commit lag that was (or would have been) introduced by each
synchronous commit level, if the remote server was configured as a
synchronous standby.  For an asynchronous standby, the replay_lag column
approximates the delay before recent transactions became visible to queries.
If the standby server has entirely caught up with the sending server and
there is no more WAL activity, the most recently measured lag times will
continue to be displayed for a short time and then show NULL.

Physical replication lag tracking is automatic. Logical replication tracking
is possible but is the responsibility of the logical decoding plugin.
Tracking is a private module operating within each walsender individually,
with values reported to shared memory. Module not used outside of walsender.

Design and code is good enough now to commit - kudos to the author.
In many ways a difficult topic, with important and subtle behaviour so this
shoudl be expected to generate discussion and multiple open items: Test now!

Author: Thomas Munro, following designs by Fujii Masao and Simon Riggs
Review: Simon Riggs, Ian Barwick and Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/6912acc04f0bbcfdb799a120618507601e862490

Modified Files
--
doc/src/sgml/monitoring.sgml|  69 +++
src/backend/access/transam/xlog.c   |  14 ++
src/backend/catalog/system_views.sql|   3 +
src/backend/replication/walsender.c | 277 +++-
src/include/catalog/pg_proc.h   |   2 +-
src/include/replication/logical.h   |   2 +
src/include/replication/walsender_private.h |   5 +
src/test/regress/expected/rules.out |   5 +-
8 files changed, 370 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Correct erroneous comment in GetOldestXmin()

2017-03-22 Thread Simon Riggs
Correct erroneous comment in GetOldestXmin()

Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c137c68ea6bfe860c3e5f4edee7031e136ba4f0c

Modified Files
--
src/backend/storage/ipc/procarray.c | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Refactor GetOldestXmin() to use flags

2017-03-22 Thread Simon Riggs
Refactor GetOldestXmin() to use flags

Replace ignoreVacuum parameter with more flexible flags.

Author: Eiji Seki
Review: Haribabu Kommi

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/af4b1a0869bd3bb52e5f662e4491554b7f611489

Modified Files
--
contrib/pg_visibility/pg_visibility.c |  4 ++--
contrib/pgstattuple/pgstatapprox.c|  2 +-
src/backend/access/transam/xlog.c |  4 ++--
src/backend/catalog/index.c   |  2 +-
src/backend/commands/analyze.c|  2 +-
src/backend/commands/vacuum.c |  4 ++--
src/backend/replication/walreceiver.c |  2 +-
src/backend/storage/ipc/procarray.c   | 16 +---
src/include/storage/proc.h|  7 ++-
src/include/storage/procarray.h   | 24 +++-
10 files changed, 44 insertions(+), 23 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Assign AccessExclusiveLocks against subxacts in Hot Standby

2017-03-22 Thread Simon Riggs
Assign AccessExclusiveLocks against subxacts in Hot Standby

Previously AELs were registered against the top-level xid, which could
cause locks to be held much longer than necessary in some cases during
Hot Standby replay. We now record locks directly against their appropriate
xids. Requires few code changes because original code allowed for this
situation but didn’t fully implement it.

Discussion: CAKJS1f9vJ841HY=wonnlvbfktwgywdpn72vmxnarcgcjf3s...@mail.gmail.com

Author: Simon Riggs and David Rowley

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/49bff5300d527f28c7670cdfad9e4a1b8f5ccdea

Modified Files
--
src/backend/storage/ipc/standby.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve performance of replay of AccessExclusiveLocks

2017-03-22 Thread Simon Riggs
Improve performance of replay of AccessExclusiveLocks

A hot standby replica keeps a list of Access Exclusive locks for a top
level transaction. These locks are released when the top level transaction
ends. Searching of this list is O(N^2), and each transaction had to pay the
price of searching this list for locks, even if it didn't take any AE
locks itself.

This patch optimizes this case by having the master server track which
transactions took AE locks, and passes that along to the standby server in
the commit/abort record. This allows the standby to only try to release
locks for transactions which actually took any, avoiding the majority of
the performance issue.

Refactor MyXactAccessedTempRel into MyXactFlags to allow minimal additional
cruft with this.

Analysis and initial patch by David Rowley
Author: David Rowley and Simon Riggs

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9b013dc238cefa2860b384a3fa016ad1ceb062e4

Modified Files
--
src/backend/access/heap/heapam.c  |  4 ++--
src/backend/access/transam/twophase.c | 12 ++--
src/backend/access/transam/xact.c | 33 +
src/backend/commands/tablecmds.c  |  2 +-
src/backend/storage/ipc/standby.c |  1 +
src/include/access/xact.h | 27 ---
6 files changed, 59 insertions(+), 20 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Teach xlogreader to follow timeline switches

2017-03-22 Thread Simon Riggs
Teach xlogreader to follow timeline switches

Uses page-based mechanism to ensure we’re using the correct timeline.

Tests are included to exercise the functionality using a cold disk-level copy
of the master that's started up as a replica with slots intact, but the
intended use of the functionality is with later features.

Craig Ringer, reviewed by Simon Riggs and Andres Freund

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/1148e22a82edc96172fc78855da392b6f0015c88

Modified Files
--
src/backend/access/transam/xlogutils.c | 215 +++--
src/backend/replication/logical/logicalfuncs.c |   8 +-
src/backend/replication/walsender.c|  11 +-
src/include/access/xlogreader.h|  16 ++
src/include/access/xlogutils.h |   3 +
src/test/recovery/Makefile |   2 +
.../recovery/t/010_logical_decoding_timelines.pl   | 130 +
7 files changed, 365 insertions(+), 20 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add a pg_recvlogical wrapper to PostgresNode

2017-03-21 Thread Simon Riggs
Add a pg_recvlogical wrapper to PostgresNode

Allows testing of logical decoding using SQL interface and/or pg_recvlogical
Most logical decoding tests are in contrib/test_decoding. This module
is for work that doesn't fit well there, like where server restarts
are required.

Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/eb2a6131beccaad2b39629191508062b70d3a1c6

Modified Files
--
src/test/perl/PostgresNode.pm   | 78 +
src/test/recovery/t/006_logical_decoding.pl | 31 +++-
2 files changed, 108 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Don't scan partitioned tables.

2017-03-21 Thread Simon Riggs
On 21 March 2017 at 13:48, Robert Haas <rh...@postgresql.org> wrote:
> Don't scan partitioned tables.

Sounds good.

> Aside from the obvious advantage of avoiding some work at execution
> time, this has two other advantages.  First, it may improve the
> planner's decision-making in some cases since the empty relation
> might throw things off.

I was surprised to see that an Append node still exists when there is
only one child plan to be appended. I thought removing that was the
whole point of the patch?

> Second, it paves the way to getting rid of
> the storage for partitioned tables altogether.

I thought we already discussed that. Seems strange to mention
something not very important that might happen in the future. We could
save much more space by optimising FSM.

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Allow pg_dumpall to dump roles w/o user passwords

2017-03-07 Thread Simon Riggs
Allow pg_dumpall to dump roles w/o user passwords

Add new option --no-role-passwords which dumps roles without passwords.
Since we don’t need passwords, we choose to use pg_roles in preference
to pg_authid since access may be restricted for security reasons in
some configrations.

Robins Tharakan and Simon Riggs

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9a83d56b38c870ce47b7651385ff2add583bf136

Modified Files
--
doc/src/sgml/ref/pg_dumpall.sgml |  13 
src/bin/pg_dump/pg_dumpall.c | 132 +--
2 files changed, 97 insertions(+), 48 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ensure ThisTimeLineID is valid before START_REPLICATION

2017-03-07 Thread Simon Riggs
Ensure ThisTimeLineID is valid before START_REPLICATION

Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5ee2197767f648bc21e324e751b84d42af573b43

Modified Files
--
src/backend/replication/walsender.c | 5 +
1 file changed, 5 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Enhance docs for ALTER TABLE lock levels of storage parms

2017-03-06 Thread Simon Riggs
Enhance docs for ALTER TABLE lock levels of storage parms

As requested by Robert Haas

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/6f3a13ff058f15d565a30c16c0c2cb14cc994e42

Modified Files
--
doc/src/sgml/ref/alter_table.sgml | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reduce lock levels for table storage params related to planning

2017-03-06 Thread Simon Riggs
Reduce lock levels for table storage params related to planning

The following parameters are now updateable with ShareUpdateExclusiveLock
effective_io_concurrency
parallel_workers
seq_page_cost
random_page_cost
n_distinct
n_distinct_inherited

Simon Riggs and Fabrízio Mello

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/21d4e2e20656381b4652eb675af4f6d65053607f

Modified Files
--
src/backend/access/common/reloptions.c | 50 +-
src/backend/utils/cache/spccache.c | 11 
2 files changed, 54 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Allow partitioned tables to be dropped without CASCADE

2017-03-06 Thread Simon Riggs
Allow partitioned tables to be dropped without CASCADE

Record partitioned table dependencies as DEPENDENCY_AUTO
rather than DEPENDENCY_NORMAL, so that DROP TABLE just works.

Remove all the tests for partitioned tables where earlier
work had deliberately avoided using CASCADE.

Amit Langote, reviewed by Ashutosh Bapat and myself

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/8b4d582d279d784616c228be58af1e39aa430402

Modified Files
--
src/backend/commands/tablecmds.c   | 30 ++
src/test/regress/expected/alter_table.out  | 10 --
src/test/regress/expected/create_table.out |  9 ++---
src/test/regress/expected/inherit.out  | 22 ++
src/test/regress/expected/insert.out   |  7 ++-
src/test/regress/expected/update.out   |  7 +--
src/test/regress/sql/alter_table.sql   | 10 --
src/test/regress/sql/create_table.sql  |  9 ++---
src/test/regress/sql/inherit.sql   |  4 ++--
src/test/regress/sql/insert.sql|  7 ++-
src/test/regress/sql/update.sql|  2 +-
11 files changed, 44 insertions(+), 73 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-03 Thread Simon Riggs
Allow vacuums to report oldestxmin

Allow VACUUM and Autovacuum to report the oldestxmin value they
used while cleaning tables, helping to make better sense out of
the other statistics we report in various cases.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c

Modified Files
--
src/backend/commands/vacuumlazy.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Small correction to BRIN docs

2017-02-21 Thread Simon Riggs
Small correction to BRIN docs

Replace incorrect word "index" with "heap"

Takayuki Tsunakawa

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/0bf41dd1908a0c05833168b9972e1c52cb7547b7

Modified Files
--
doc/src/sgml/brin.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Update ddl.sgml for declarative partitioning syntax

2017-02-10 Thread Simon Riggs
Update ddl.sgml for declarative partitioning syntax

Add a section titled "Partitioned Tables" to describe what are
partitioned tables, partition, their similarities with inheritance.
The existing section on inheritance is retained for clarity.

Then add examples to the partitioning chapter that show syntax for
partitioned tables.  In fact they implement the same partitioning
scheme that is currently shown using inheritance.

Amit Langote, with additional details and explanatory text by me

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9401883a7a598f1f1664c74835821f697932666f

Modified Files
--
doc/src/sgml/ddl.sgml | 458 +++---
1 file changed, 438 insertions(+), 20 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add keywords for partitioning

2017-02-10 Thread Simon Riggs
Add keywords for partitioning

Amit Langote

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/61c9a9dac44c0f0c24342a4fa4f750756ac72f2f

Modified Files
--
doc/src/sgml/keywords.sgml | 21 +
1 file changed, 21 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve CREATE TABLE documentation of partitioning

2017-02-10 Thread Simon Riggs
Improve CREATE TABLE documentation of partitioning

Amit Langote, with corrections by me

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c1369fe2ea79724e56ee55e4c87778afd6016942

Modified Files
--
doc/src/sgml/ref/create_table.sgml | 107 +
1 file changed, 98 insertions(+), 9 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-27 Thread Simon Riggs
Check interrupts during hot standby waits

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/15c54e8363a28ab89e31bafebe6b093a77540b1d

Modified Files
--
src/backend/storage/ipc/standby.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-27 Thread Simon Riggs
Check interrupts during hot standby waits

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/332068a212c0357aa70c187134ba3af32fbd

Modified Files
--
src/backend/storage/ipc/standby.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-27 Thread Simon Riggs
Check interrupts during hot standby waits

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/357e061286d2653737eee509f69d70ea85475e3a

Modified Files
--
src/backend/storage/ipc/standby.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-27 Thread Simon Riggs
Check interrupts during hot standby waits

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/ace2cd80a028fc8775146c946d3aff87810e4392

Modified Files
--
src/backend/storage/ipc/standby.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-27 Thread Simon Riggs
Check interrupts during hot standby waits

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/40b7800da24de920cb9478a22605fa4715dbc30d

Modified Files
--
src/backend/storage/ipc/standby.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart

Hot_standby_feedback could be reset by reload and worked correctly, but if
the server was restarted rather than reloaded the xmin was not reset.
Force reset always if hot_standby_feedback is enabled at startup.

Ants Aasma, Craig Ringer

Reported-by: Ants Aasma

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/048d44175a019cca7e08dac45bf95db680b4ed87

Modified Files
--
src/backend/replication/walreceiver.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart

Hot_standby_feedback could be reset by reload and worked correctly, but if
the server was restarted rather than reloaded the xmin was not reset.
Force reset always if hot_standby_feedback is enabled at startup.

Ants Aasma, Craig Ringer

Reported-by: Ants Aasma

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/800d89a98a59e50cb69049fb91a9122396df64eb

Modified Files
--
src/backend/replication/walreceiver.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart

Hot_standby_feedback could be reset by reload and worked correctly, but if
the server was restarted rather than reloaded the xmin was not reset.
Force reset always if hot_standby_feedback is enabled at startup.

Ants Aasma, Craig Ringer

Reported-by: Ants Aasma

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/99289e50606e7be4202c15c40caf27cf77893d58

Modified Files
--
src/backend/replication/walreceiver.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart

Hot_standby_feedback could be reset by reload and worked correctly, but if
the server was restarted rather than reloaded the xmin was not reset.
Force reset always if hot_standby_feedback is enabled at startup.

Ants Aasma, Craig Ringer

Reported-by: Ants Aasma

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/95d1b41450e93a9af146bc836f7f3b1ad13a1f2a

Modified Files
--
src/backend/replication/walreceiver.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-26 Thread Simon Riggs
Check interrupts during hot standby waits

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/e8ee3d6b859a18d7f7375ceb9e04d256eb18aaec

Modified Files
--
src/backend/storage/ipc/standby.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reset hot standby xmin on master after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin on master after restart

Hot_standby_feedback could be reset by reload and worked correctly, but if
the server was restarted rather than reloaded the xmin was not reset.
Force reset always if hot_standby_feedback is enabled at startup.

Ants Aasma, Craig Ringer

Reported-by: Ants Aasma

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ec4b975016b873292ba5e3d645b414acf1b96c06

Modified Files
--
src/backend/replication/walreceiver.c | 21 ++---
src/test/recovery/t/001_stream_rep.pl | 21 -
2 files changed, 34 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix format for TAP test docs

2017-01-05 Thread Simon Riggs
Fix format for TAP test docs

Small number of fixes to perl docs for TAP tests.
Plus two comments that use "xlog" rather than WAL

Michael Paquier

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/2e44f379bc0219f6864dbfb901129796e6feec44

Modified Files
--
src/test/perl/PostgresNode.pm | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add new TAP tests for pg_recvlogical

2017-01-04 Thread Simon Riggs
Add new TAP tests for pg_recvlogical

Craig Ringer, reviewed by Euler Taveira and Naoki Okano

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3e353a7bc2dd6a9edfffe7e045c810b421f7ecc4

Modified Files
--
src/bin/pg_basebackup/Makefile|  2 ++
src/bin/pg_basebackup/t/030_pg_recvlogical.pl | 46 +++
2 files changed, 48 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add pg_recvlogical —-endpos=LSN

2017-01-04 Thread Simon Riggs
Add pg_recvlogical —-endpos=LSN

Allow pg_recvlogical to specify an ending LSN, complementing
the existing -—startpos=LSN option.

Craig Ringer, reviewed by Euler Taveira and Naoki Okano

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/7c030783a5bd07cadffc2a1018bc33119a4c7505

Modified Files
--
doc/src/sgml/ref/pg_recvlogical.sgml   |  34 
src/bin/pg_basebackup/pg_recvlogical.c | 145 +
2 files changed, 164 insertions(+), 15 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add 18 new recovery TAP tests

2017-01-04 Thread Simon Riggs
Add 18 new recovery TAP tests

Add new tests for physical repl slots and hot standby feedback.

Craig Ringer, reviewed by Aleksander Alekseev and Simon Riggs

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/0813216cb416bf9173ddc7ff3cf495755d943743

Modified Files
--
src/test/recovery/t/001_stream_rep.pl | 105 +-
1 file changed, 104 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification

Daniel Gustafsson

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/9410b711deafeec01672f213ec6b8383c137e759

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification

Daniel Gustafsson

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/75684fc1f5bbcb097f8230cb9d897b689d44eb10

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification

Daniel Gustafsson

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/4b47cb35fa516c1bb380ab4edf3131fb6adfacfe

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification

Daniel Gustafsson

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/4068eb9918cbbeaba8042fa6fe0c1f5382f2f05f

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Identify walsenders in pg_stat_activity

2016-09-12 Thread Simon Riggs
Identify walsenders in pg_stat_activity

Following 8299471c37fff0b walsender procs are now visible in pg_stat_activity.
Set query to ‘walsender’ for walsender procs to allow them to be identified.

Discussion:cab7npqs8c76kpsufk_hsdeyrbtg+zz7d0eekjem6txseucb...@mail.gmail.com

Michael Paquier, issue raised by Fujii Masao, reviewed by Tom Lane

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/fc3d4a44e9375f79709f470cb3c83d4ca28fb370

Modified Files
--
src/backend/replication/walsender.c | 3 +++
1 file changed, 3 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Raise max setting of checkpoint_timeout to 1d

2016-09-11 Thread Simon Riggs
Raise max setting of checkpoint_timeout to 1d

Previously checkpoint_timeout was capped at 3600s
New max setting is 86400s = 24h = 1d

Discussion: 32558.1454471...@sss.pgh.pa.us

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/f2dba881a5e13abc957f0e692749f89c9288134d

Modified Files
--
doc/src/sgml/config.sgml  | 2 +-
src/backend/utils/misc/guc.c  | 2 +-
src/backend/utils/misc/postgresql.conf.sample | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Raise max setting of checkpoint_timeout to 1d

2016-09-11 Thread Simon Riggs
Raise max setting of checkpoint_timeout to 1d

Previously checkpoint_timeout was capped at 3600s
New max setting is 86400s = 24h = 1d

Discussion: 32558.1454471...@sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c3c0d7bd701dae4737c974a59ffa9b366110f9c1

Modified Files
--
doc/src/sgml/config.sgml  | 2 +-
src/backend/utils/misc/guc.c  | 2 +-
src/backend/utils/misc/postgresql.conf.sample | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix corruption of 2PC recovery with subxacts

2016-09-09 Thread Simon Riggs
Fix corruption of 2PC recovery with subxacts

Reading 2PC state files during recovery was borked, causing corruptions during
recovery. Effect limited to servers with 2PC, subtransactions and
recovery/replication.

Stas Kelvich, reviewed by Michael Paquier and Pavan Deolasee

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/1fef3d576e3a8ac69f90faf192997858f1d82f64

Modified Files
--
src/backend/access/transam/twophase.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix corruption of 2PC recovery with subxacts

2016-09-09 Thread Simon Riggs
Fix corruption of 2PC recovery with subxacts

Reading 2PC state files during recovery was borked, causing corruptions during
recovery. Effect limited to servers with 2PC, subtransactions and
recovery/replication.

Stas Kelvich, reviewed by Michael Paquier and Pavan Deolasee

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ec253de1fd2e6002122de80815ac5b963af8277c

Modified Files
--
src/backend/access/transam/twophase.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-09 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

lazy_truncate_heap() was waiting for
VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
not milliseconds as originally intended.

Found by code inspection.

Simon Riggs

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/e1dddf3e89eca53a397f3ceb8deafe6bb87682d7

Modified Files
--
src/backend/commands/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-09 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

lazy_truncate_heap() was waiting for
VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
not milliseconds as originally intended.

Found by code inspection.

Simon Riggs

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/3ed7f54bc46ab2bb39b703b40bc72693c7f1306f

Modified Files
--
src/backend/commands/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-09 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

lazy_truncate_heap() was waiting for
VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
not milliseconds as originally intended.

Found by code inspection.

Simon Riggs

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/eaf6fe7fae390735ddeb9c9bbdebc54918fb416b

Modified Files
--
src/backend/commands/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-09 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

lazy_truncate_heap() was waiting for
VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
not milliseconds as originally intended.

Found by code inspection.

Simon Riggs

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/1fa42debe676146f1f3e4809ef42e9a0f300e112

Modified Files
--
src/backend/commands/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-09 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

lazy_truncate_heap() was waiting for
VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
not milliseconds as originally intended.

Found by code inspection.

Simon Riggs

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/f3b3e871ee694ec050073c9732764c93fb891a31

Modified Files
--
src/backend/commands/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-09 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

lazy_truncate_heap() was waiting for
VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
not milliseconds as originally intended.

Found by code inspection.

Simon Riggs

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/81b0f820472dac93759d21dc8775fa588f473005

Modified Files
--
src/backend/commands/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Correct TABLESAMPLE docs

2016-09-09 Thread Simon Riggs
Correct TABLESAMPLE docs

Revert to original use of word “sample”, though with clarification,
per Tom Lane.

Discussion: 29052.1471015...@sss.pgh.pa.us

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/9796882e68367a9259b6d5e84bd0a227b579d586

Modified Files
--
doc/src/sgml/ref/select.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Correct TABLESAMPLE docs

2016-09-09 Thread Simon Riggs
Correct TABLESAMPLE docs

Revert to original use of word “sample”, though with clarification,
per Tom Lane.

Discussion: 29052.1471015...@sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f66472428a51fc484bc5ca81791924d06a6f096d

Modified Files
--
doc/src/sgml/ref/select.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix minor memory leak in Standby startup

2016-09-08 Thread Simon Riggs
Fix minor memory leak in Standby startup

StandbyRecoverPreparedTransactions() leaked the buffer
used for two phase state file. This was leaked once
at startup and at every shutdown checkpoint seen.

Backpatch to 9.6

Stas Kelvich

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/d7c45172a673be1fc9e51e98e45a44c14d1ee78d

Modified Files
--
src/backend/access/transam/twophase.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix minor memory leak in Standby startup

2016-09-08 Thread Simon Riggs
Fix minor memory leak in Standby startup

StandbyRecoverPreparedTransactions() leaked the buffer
used for two phase state file. This was leaked once
at startup and at every shutdown checkpoint seen.

Backpatch to 9.6

Stas Kelvich

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/67c6bd1ca3ce75778138bf4713444a5a6b46032e

Modified Files
--
src/backend/access/transam/twophase.c | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-06 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

lazy_truncate_heap() was waiting for
VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds
not milliseconds as originally intended.

Found by code inspection.

Simon Riggs

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/dcb12ce8d8691e0e526d3f38d14c4d7fc9c664f5

Modified Files
--
src/backend/commands/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add debug check function LWLockHeldByMeInMode()

2016-09-05 Thread Simon Riggs
Add debug check function LWLockHeldByMeInMode()

Tests whether my process holds a lock in given mode.
Add initial usage in MarkBufferDirty().

Thomas Munro

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/016abf1fb8333de82a259af0cc7572a4b868023b

Modified Files
--
src/backend/storage/buffer/bufmgr.c |  4 ++--
src/backend/storage/lmgr/lwlock.c   | 23 ---
src/include/storage/lwlock.h|  1 +
3 files changed, 23 insertions(+), 5 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Document LSN acronym in WAL Internals

2016-09-05 Thread Simon Riggs
Document LSN acronym in WAL Internals

We previously didn't mention what an LSN actually was.

Simon Riggs and Michael Paquier

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ec03f4121cec6cf885bf40d9dfb53b8368251e99

Modified Files
--
doc/src/sgml/acronyms.sgml | 10 ++
doc/src/sgml/wal.sgml  | 16 
2 files changed, 26 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Dirty replication slots when using sql interface

2016-09-05 Thread Simon Riggs
Dirty replication slots when using sql interface

When pg_logical_slot_get_changes(...) sets confirmed_flush_lsn to the point at
which replay stopped, it doesn't dirty the replication slot.  So if the replay
didn't cause restart_lsn or catalog_xmin to change as well, this change will
not get written out to disk. Even on a clean shutdown.

If Pg crashes or restarts, a subsequent pg_logical_slot_get_changes(...) call
will see the same changes already replayed since it uses the slot's
confirmed_flush_lsn as the start point for fetching changes. The caller can't
specify a start LSN when using the SQL interface.

Mark the slot as dirty after reading changes using the SQL interface so that
users won't see repeated changes after a clean shutdown. Repeated changes still
occur when using the walsender interface or after an unclean shutdown.

Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/d851bef2d60ff9345249ff67c053e37fe4b364cc

Modified Files
--
src/backend/replication/logical/logicalfuncs.c | 15 ++
src/test/recovery/Makefile |  2 ++
src/test/recovery/t/006_logical_decoding.pl| 40 ++
3 files changed, 57 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: New recovery target recovery_target_lsn

2016-09-03 Thread Simon Riggs
New recovery target recovery_target_lsn

Michael Paquier

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/35250b6ad7a8ece5cfe54c0316c180df19f36c13

Modified Files
--
doc/src/sgml/recovery-config.sgml   | 24 +++--
src/backend/access/transam/recovery.conf.sample |  6 ++-
src/backend/access/transam/xlog.c   | 70 +
src/include/access/xlog.h   |  1 +
src/test/recovery/t/003_recovery_targets.pl | 28 --
5 files changed, 120 insertions(+), 9 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix wording of logical decoding concepts

2016-09-03 Thread Simon Riggs
Fix wording of logical decoding concepts

Be specific about conditions under which we emit >1 copy of message

Craig Ringer

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/0c40ab3a88edf654165e562deee0c303a6ebef5e

Modified Files
--
doc/src/sgml/logicaldecoding.sgml | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix wording of logical decoding concepts

2016-09-03 Thread Simon Riggs
Fix wording of logical decoding concepts

Be specific about conditions under which we emit >1 copy of message

Craig Ringer

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/33befe035d86d833a5bc7289612722a4e650227d

Modified Files
--
doc/src/sgml/logicaldecoding.sgml | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix pg_receivexlog --synchronous

2016-08-29 Thread Simon Riggs
Fix pg_receivexlog --synchronous

Make pg_receivexlog work correctly with —-synchronous without slots

Backpatch to 9.5

Gabriele Bartolini, reviewed by Michael Paquier and Simon Riggs

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/9050e5c89dc08fc217895c67b9f99b3b4f4bd539

Modified Files
--
src/bin/pg_basebackup/receivelog.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix pg_receivexlog --synchronous

2016-08-29 Thread Simon Riggs
Fix pg_receivexlog --synchronous

Make pg_receivexlog work correctly with --synchronous without slots

Backpatch to 9.5

Gabriele Bartolini, reviewed by Michael Paquier and Simon Riggs

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/49340627f9821e447f135455d942f7d5e96cae6d

Modified Files
--
src/bin/pg_basebackup/receivelog.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix pg_receivexlog --synchronous

2016-08-29 Thread Simon Riggs
Fix pg_receivexlog --synchronous

Make pg_receivexlog work correctly with —-synchronous without slots

Backpatch to 9.5

Gabriele Bartolini, reviewed by Michael Paquier and Simon Riggs

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/216fd7fe77c693a9595bb7550de2927dde650218

Modified Files
--
src/bin/pg_basebackup/receivelog.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


  1   2   3   4   5   6   7   8   >