[COMMITTERS] pgsql: Fix double shared memory allocation.
Fix double shared memory allocation. SLRU buffer lwlocks are allocated twice by oversight in commit fe702a7b3f9f2bc5bf6d173166d7d55226af82c8 where that locks were moved to separate tranche. The bug doesn't have user-visible effects except small overspending of shared memory. Backpatch to 9.6 where it was introduced. Alexander Korotkov with small editorization by me. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/38a4a5349c8f54a8d835675d395365d11628afac Modified Files -- src/backend/access/transam/slru.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix double shared memory allocation.
Fix double shared memory allocation. SLRU buffer lwlocks are allocated twice by oversight in commit fe702a7b3f9f2bc5bf6d173166d7d55226af82c8 where that locks were moved to separate tranche. The bug doesn't have user-visible effects except small overspending of shared memory. Backpatch to 9.6 where it was introduced. Alexander Korotkov with small editorization by me. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7e1fb4c59e4ac86de2640d0f3453fde270ec1ff8 Modified Files -- src/backend/access/transam/slru.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix potential data corruption during freeze
Fix potential data corruption during freeze Fix oversight in 3b97e6823b94 bug fix. Bitwise AND is used instead of OR and it cleans all bits in t_infomask heap tuple field. Backpatch to 9.3 Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f371cc9e9fffc79ab68185e07013d50147ed2bc9 Modified Files -- src/backend/access/heap/heapam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix potential data corruption during freeze
Fix potential data corruption during freeze Fix oversight in 3b97e6823b94 bug fix. Bitwise AND is used instead of OR and it cleans all bits in t_infomask heap tuple field. Backpatch to 9.3 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b90e4ca3edfd60309e4bc4fcb96e658826a7e20d Modified Files -- src/backend/access/heap/heapam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix potential data corruption during freeze
Fix potential data corruption during freeze Fix oversight in 3b97e6823b94 bug fix. Bitwise AND is used instead of OR and it cleans all bits in t_infomask heap tuple field. Backpatch to 9.3 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fb2d385e6521c221f2d6681125e6e42ff8b28440 Modified Files -- src/backend/access/heap/heapam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix potential data corruption during freeze
Fix potential data corruption during freeze Fix oversight in 3b97e6823b94 bug fix. Bitwise AND is used instead of OR and it cleans all bits in t_infomask heap tuple field. Backpatch to 9.3 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/42f62e4c976e1cf90f5e5a6381c4ee656260f230 Modified Files -- src/backend/access/heap/heapam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix potential data corruption during freeze
Fix potential data corruption during freeze Fix oversight in 3b97e6823b94 bug fix. Bitwise AND is used instead of OR and it cleans all bits in t_infomask heap tuple field. Backpatch to 9.3 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/31b8db8e6c1fa4436116f4be5ca789f3a01b9ebf Modified Files -- src/backend/access/heap/heapam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Implement SortSupport for macaddr data type
Implement SortSupport for macaddr data type Introduces a scheme to produce abbreviated keys for the macaddr type. Bump catalog version. Author: Brandur Leach Reviewed-by: Julien Rouhaud, Peter Geoghegan https://commitfest.postgresql.org/13/743/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f90d23d0c51895e0d7db7910538e85d3d38691f0 Modified Files -- src/backend/utils/adt/mac.c | 212 ++- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_amproc.h | 1 + src/include/catalog/pg_proc.h| 2 + 4 files changed, 215 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Altering default privileges on schemas
Altering default privileges on schemas Extend ALTER DEFAULT PRIVILEGES command to schemas. Author: Matheus Oliveira Reviewed-by: Petr Jelínek, Ashutosh Sharma https://commitfest.postgresql.org/13/887/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ab89e465cb2032017c4888399f47a76ac16eaf40 Modified Files -- doc/src/sgml/ref/alter_default_privileges.sgml | 17 ++- src/backend/catalog/aclchk.c | 21 + src/backend/catalog/objectaddress.c| 14 +- src/backend/catalog/pg_namespace.c | 21 ++--- src/backend/parser/gram.y | 4 +- src/bin/pg_dump/dumputils.c| 4 +- src/bin/pg_dump/pg_dump.c | 3 ++ src/bin/psql/describe.c| 4 +- src/bin/psql/tab-complete.c| 2 +- src/include/catalog/pg_default_acl.h | 1 + src/include/parser/kwlist.h| 1 + src/test/regress/expected/privileges.out | 62 ++ src/test/regress/sql/privileges.sql| 34 ++ 13 files changed, 176 insertions(+), 12 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fsync directory after creating or unlinking file.
Fsync directory after creating or unlinking file. If file was created/deleted just before powerloss it's possible that file system will miss that. To prevent it, call fsync() where creating/ unlinkg file is critical. Author: Michael Paquier Reviewed-by: Ashutosh Bapat, Takayuki Tsunakawa, me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1b02be21f271db6bd3cd43abb23fa596fcb6bac3 Modified Files -- src/backend/access/transam/clog.c | 14 + src/backend/access/transam/commit_ts.c | 12 +++ src/backend/access/transam/twophase.c | 8 src/backend/access/transam/xlog.c | 19 ++--- src/backend/storage/file/fd.c | 37 ++ src/include/storage/fd.h | 1 + 6 files changed, 78 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve performance of find_all_inheritors()
Improve performance of find_all_inheritors() Previous coding uses three nested loops which obviously were a pain for large number of table's children. Patch replaces inner loop with a hashmap. Author: Aleksander Alekseev Reviewed-by: me https://commitfest.postgresql.org/13/1058/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/827d6f977940952ebef4bd21fb0f97be4e20c0c4 Modified Files -- src/backend/catalog/pg_inherits.c | 58 +-- 1 file changed, 44 insertions(+), 14 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve performance of find_tabstat_entry()/get_tabstat_entry()
Improve performance of find_tabstat_entry()/get_tabstat_entry() Patch introduces a hash map reloid -> PgStat_TableStatus which improves performance in case of large number of tables/partitions. Author: Aleksander Alekseev Reviewed-by: Andres Freund, Anastasia Lubennikova, Tels, me https://commitfest.postgresql.org/13/1058/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/090010f2ec9b1f9ac1124dc628b89586f911b641 Modified Files -- src/backend/postmaster/pgstat.c | 139 +++- 1 file changed, 93 insertions(+), 46 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pgbench options -C and -R together
Fix pgbench options -C and -R together The bug is that prior to --rate doCustom was always disconnect/reconnect without exiting, but with rate it returns if it has to wait. However threadRun test whether there is a connection before recalling doCustom, so it was never called. Bug is not existed in head branch because of refactoring at 12788ae49e1933f463bc59a6efe46c4a01701b76, patch only 9.6 Author: Fabien Coelho Reviewed-by: me https://commitfest.postgresql.org/13/970/ Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2ed391f95b34bb88b4d092f0a1d68ce3903df375 Modified Files -- src/bin/pgbench/pgbench.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix backup canceling
Fix backup canceling Assert-enabled build crashes but without asserts it works by wrong way: it may not reset forcing full page write and preventing from starting exclusive backup with the same name as cancelled. Patch replaces pair of booleans nonexclusive_backup_running/exclusive_backup_running to single enum to correctly describe backup state. Backpatch to 9.6 where bug was introduced Reported-by: David Steele Authors: Michael Paquier, David Steele Reviewed-by: Anastasia Lubennikova https://commitfest.postgresql.org/13/1068/ Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8de6278d3b7c810fe5d31486491189d88550a2a6 Modified Files -- src/backend/access/transam/xlog.c | 22 ++ src/backend/access/transam/xlogfuncs.c | 25 ++--- src/include/access/xlog.h | 21 - 3 files changed, 52 insertions(+), 16 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix backup canceling
Fix backup canceling Assert-enabled build crashes but without asserts it works by wrong way: it may not reset forcing full page write and preventing from starting exclusive backup with the same name as cancelled. Patch replaces pair of booleans nonexclusive_backup_running/exclusive_backup_running to single enum to correctly describe backup state. Backpatch to 9.6 where bug was introduced Reported-by: David Steele Authors: Michael Paquier, David Steele Reviewed-by: Anastasia Lubennikova https://commitfest.postgresql.org/13/1068/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/78874531baf99769468dedfff19aa7e2068bc5e5 Modified Files -- src/backend/access/transam/xlog.c | 22 ++ src/backend/access/transam/xlogfuncs.c | 25 ++--- src/include/access/xlog.h | 21 - 3 files changed, 52 insertions(+), 16 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Reduce page locking in GIN vacuum
Reduce page locking in GIN vacuum GIN vacuum during cleaning posting tree can lock this whole tree for a long time with by holding LockBufferForCleanup() on root. Patch changes it with two ways: first, cleanup lock will be taken only if there is an empty page (which should be deleted) and, second, it tries to lock only subtree, not the whole posting tree. Author: Andrey Borodin with minor editorization by me Reviewed-by: Jeff Davis, me https://commitfest.postgresql.org/13/896/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/218f51584d5a9fcdf702bcc7f54b5b65e255c187 Modified Files -- src/backend/access/gin/README | 15 ++- src/backend/access/gin/ginbtree.c | 2 +- src/backend/access/gin/ginvacuum.c | 236 - src/include/access/gin_private.h | 2 + 4 files changed, 145 insertions(+), 110 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix support for some operators (&<, &>, $<|, |&>) in box operato
Fix support for some operators (&<, &>, $<|, |&>) in box operator class of SP-GiST. Bug exists since initial commit of box opclass for SP-GiST, so backpath to 9.6 Author: Nikita Glukhov with minor editorization of tests by me Reviewed-by: Kyotaro Horiguchi, Anastasia Lubennikova https://commitfest.postgresql.org/13/981/ Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a4d07d2e9d94d4516d55ad074236627ab78aa7ca Modified Files -- src/backend/utils/adt/geo_spgist.c | 24 +-- src/test/regress/expected/box.out | 104 + src/test/regress/expected/sanity_check.out | 1 + src/test/regress/sql/box.sql | 47 + 4 files changed, 172 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix support for some operators (&<, &>, $<|, |&>) in box operato
Fix support for some operators (&<, &>, $<|, |&>) in box operator class of SP-GiST. Bug exists since initial commit of box opclass for SP-GiST, so backpath to 9.6 Author: Nikita Glukhov with minor editorization of tests by me Reviewed-by: Kyotaro Horiguchi, Anastasia Lubennikova https://commitfest.postgresql.org/13/981/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d5286aa905c9173b3fc4f911682089149bd3caef Modified Files -- src/backend/utils/adt/geo_spgist.c | 24 +-- src/test/regress/expected/box.out | 104 + src/test/regress/expected/sanity_check.out | 1 + src/test/regress/sql/box.sql | 47 + 4 files changed, 172 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Revert unintentional change in increasing usage count during pin
Revert unintentional change in increasing usage count during pin of buffers, this makes buffer access strategy have no effect. Change was a part of commit 48354581a49c30f5757c203415aa8412d85b0f70 during 9.6 release cycle, so backpath to 9.6 Reported-by: Jim Nasby Author: Alexander Korotkov Reviewed-by: Jim Nasby, Andres Freund https://commitfest.postgresql.org/13/1029/ Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/09f8bb5b3617269eb750b395fb561a2e532af221 Modified Files -- src/backend/storage/buffer/bufmgr.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Revert unintentional change in increasing usage count during pin
Revert unintentional change in increasing usage count during pin of buffers, this makes buffer access strategy have no effect. Change was a part of commit 48354581a49c30f5757c203415aa8412d85b0f70 during 9.6 release cycle, so backpath to 9.6 Reported-by: Jim Nasby Author: Alexander Korotkov Reviewed-by: Jim Nasby, Andres Freund https://commitfest.postgresql.org/13/1029/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9cf6033281fdaf938b826545a643f951086d8671 Modified Files -- src/backend/storage/buffer/bufmgr.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix parsing NOT sequence in tsquery
Fix parsing NOT sequence in tsquery Digging around bug #14245 I found that commit 6734a1cacd44f5b731933cbc93182b135b167d0c missed that NOT operation is right associative in opposite to all other. This miss is resposible for tsquery parser fail on sequence of NOT operations Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/00f304ce2dd86f4b76606225b41e0854a3362628 Modified Files -- src/backend/utils/adt/tsquery.c | 4 +++- src/test/regress/expected/tstypes.out | 36 +++ src/test/regress/sql/tstypes.sql | 6 ++ 3 files changed, 45 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix nested NOT operation cleanup in tsquery.
Fix nested NOT operation cleanup in tsquery. During normalization of tsquery tree it tries to simplify nested NOT operations but there it's obvioulsy missed that subsequent node could be a leaf node (value node) Bug #14245: Segfault on weird to_tsquery Reported by David Kellum. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/19d290155d084754eeb5ebb2569654da06073ee8 Modified Files -- src/backend/utils/adt/tsquery_cleanup.c | 8 +++- src/test/regress/expected/tsearch.out | 12 src/test/regress/sql/tsearch.sql| 3 +++ 3 files changed, 22 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Document precedence of FTS operators in tsquery
Document precedence of FTS operators in tsquery Oleg Bartunov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/73e6bea603548810769fd8ac8b19342f759ef07d Modified Files -- doc/src/sgml/textsearch.sgml | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Change predecence of phrase operator.
Change predecence of phrase operator. <-> operator now have higher predecence than & (AND) operator. This change was motivated by unexpected difference of similar queries: 'a & b <-> c'::tsquery and 'b <-> c & a'. Before first query means (a & b) <-> c and second one - '(b <-> c) & a', now phrase operator evaluates first. Per suggestion from Tom Lane 32260.1465402...@sss.pgh.pa.us Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6734a1cacd44f5b731933cbc93182b135b167d0c Modified Files -- src/backend/utils/adt/tsquery.c | 114 +++- src/backend/utils/adt/tsquery_cleanup.c | 17 - src/include/tsearch/ts_type.h | 16 + src/test/regress/expected/tsdicts.out | 12 ++-- src/test/regress/expected/tsearch.out | 18 ++--- src/test/regress/expected/tstypes.out | 78 +++--- 6 files changed, 121 insertions(+), 134 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Do not fallback to AND for FTS phrase operator.
Do not fallback to AND for FTS phrase operator. If there is no positional information of lexemes then phrase operator will not fallback to AND operator. This change makes needing to modify TS_execute() interface, because somewhere (in indexes, for example) positional information is unaccesible and in this cases we need to force fallback to AND. Per discussion c19fcfec308e6ccd952cdde9e648b...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3dbbd0f02a257d8d5c4cba14726371505f2e7266 Modified Files -- src/backend/utils/adt/tsginidx.c | 2 +- src/backend/utils/adt/tsgistidx.c | 6 -- src/backend/utils/adt/tsrank.c| 6 -- src/backend/utils/adt/tsvector_op.c | 35 +++ src/include/tsearch/ts_utils.h| 19 ++- src/test/regress/expected/tsearch.out | 9 + src/test/regress/sql/tsearch.sql | 3 ++- 7 files changed, 53 insertions(+), 27 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make exact distance match for FTS phrase operator
Make exact distance match for FTS phrase operator Phrase operator now requires exact distance betweens lexems instead of less-or-equal. Per discussion c19fcfec308e6ccd952cdde9e648b...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/028350f619f7688e0453fcd2c4b25abe9ba30fa7 Modified Files -- doc/src/sgml/textsearch.sgml | 6 ++-- src/backend/utils/adt/tsvector_op.c | 67 --- src/test/regress/expected/tstypes.out | 32 ++--- src/test/regress/sql/tstypes.sql | 7 ++-- 4 files changed, 64 insertions(+), 48 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in docs
Fix typo in docs Add missing USING BLOOM in example of contrib/bloom Nikolay Shaplov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6ee7fb8244560b7a3f224784b8ad2351107fa55d Modified Files -- doc/src/sgml/bloom.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Allocate all page images at once in generic wal interface
Allocate all page images at once in generic wal interface That reduces number of allocation. Per gripe from Michael Paquier and Tom Lane suggestion. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7c979c95a3700d0bd34c2831f49a9260d505b0f9 Modified Files -- src/backend/access/transam/generic_xlog.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) Seems, this patch isn't liked by curculio [1] buildfarm member, but I'm confused with diagnostics: 2016-05-17 21:43:19.489 CEST [573b7457.547c:3] LOG: statement: CREATE EXTENSION bloom; 2016-05-17 21:43:19.501 CEST [573b7457.547c:4] ERROR: syntax error in file "/home/pgbf/buildroot/HEAD/inst/share/postgresql/extension/bloom.control" line 1, near token "" Could somebody explain me what's going on? Thank you [1] http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=curculio=2016-05-17+19%3A30%3A09 -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Allocate all page images at once in generic wal interface
Allocate all page images at once in generic wal interface That reduces number of allocation. Per gripe from Michael Paquier and Tom Lane suggestion. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7c979c95a3700d0bd34c2831f49a9260d505b0f9 Modified Files -- src/backend/access/transam/generic_xlog.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Correctly align page's images in generic wal API
Correctly align page's images in generic wal API Page image should be MAXALIGN'ed because existing code could directly align pointers in page instead of align offset from beginning of page. Found during play with indexes as extenstion, Alexander Korotkov and me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7c8345f67f3008a394adccae262f2a2162b6f5c7 Modified Files -- src/backend/access/transam/generic_xlog.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix crash of filter(tsvector)
Fix crash of filter(tsvector) Variable storing a position of lexeme, had a wrong type: char, it's obviously not enough to store 2^14 possible positions. Stas Kelvich Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4bbc1a7ea351f235eb9a4475ceb17d7e37a36473 Modified Files -- src/backend/utils/adt/tsvector_op.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix support of digits in email/hostnames.
Doesn't this invalidate tsvector indexes upgraded by pg_upgrade? Should they be marked as invalid? Directly, it affects on functional indexes i.e. over to_tsvector(). But it affects tsvector column, it should be recreated if it was generated by ts_vector() function. Can you also fix the other two TODO items related to this? Improve handling of dash and plus signs in email address user names, and perhaps improve URL parsing http://www.postgresql.org/message-id/201010122203.o9cm3rw09...@momjian.us http://www.postgresql.org/message-id/e1ri8il-0008ct...@wrigleys.postgresql.org -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Prevent to use magic constants
Prevent to use magic constants Use macroses for definition amstrategies/amsupport fields instead of hardcoded values. Author: Nikolay Shaplov with addition for contrib/bloom Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f8467f7da8685dbc47187864e5afe130d9c63fff Modified Files -- contrib/bloom/blutils.c | 4 ++-- src/backend/access/gin/ginutil.c | 2 +- src/backend/access/gist/gist.c | 2 +- src/backend/access/hash/hash.c | 4 ++-- src/backend/access/nbtree/nbtree.c | 4 ++-- src/backend/access/spgist/spgutils.c | 2 +- src/include/access/hash.h| 1 + src/include/access/nbtree.h | 1 + 8 files changed, 11 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Prevent multiple cleanup process for pending list in GIN.
Prevent multiple cleanup process for pending list in GIN. Previously, ginInsertCleanup could exit early if it detects that someone else is cleaning up the pending list, without waiting for that someone else to finish the job. But in this case vacuum could miss tuples to be deleted. Cleanup process now locks metapage with a help of heavyweight LockPage(ExclusiveLock), and it guarantees that there is no another cleanup process at the same time. Lock is taken differently depending on caller of cleanup process: any vacuums and gin_clean_pending_list() will be blocked until lock becomes available, ordinary insert uses conditional lock to prevent indefinite waiting on lock. Insert into pending list doesn't use this lock, so insertion isn't blocked. Also, patch adds stopping of cleanup process when at-start-cleanup-tail is reached in order to prevent infinite cleanup in case of massive insertion. But it will stop only for automatic maintenance tasks like autovacuum. Patch introduces choice of limit of memory to use: autovacuum_work_mem, maintenance_work_mem or work_mem depending on call path. Patch for previous releases should be reworked due to changes between 9.6 and previous ones in this area. Discover and diagnostics by Jeff Janes and Tomas Vondra Patch by me with some ideas of Jeff Janes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e2c79e14d998cd31f860854bc9210b37b457bb01 Modified Files -- src/backend/access/gin/ginfast.c | 126 - src/backend/access/gin/ginvacuum.c | 11 ++-- src/include/access/gin_private.h | 2 +- 3 files changed, 77 insertions(+), 62 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix tsearch docs
Fix tsearch docs Remove mention of setweight(tsquery) which wasn't included in 9.6. Also replace old forgotten phrase operator to new one. Dmitry Ivanov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f1e3c76066f0066a8a9bb09b80cd97f11e4b2dc4 Modified Files -- doc/src/sgml/textsearch.sgml | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add page id to bloom index
Add page id to bloom index Added to ensure that bloom index pages can be distinguished from other pages by pg_filedump. Because there wasn't any public/production versions before, it doesn't pay attention to any compatibility issues. Per notice from Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/813b456ea21d4cf57b124bf855ec019c7a8099a7 Modified Files -- contrib/bloom/bloom.h | 19 +-- contrib/bloom/blutils.c | 1 + 2 files changed, 18 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Revert CREATE INDEX ... INCLUDING ...
Revert CREATE INDEX ... INCLUDING ... It's not ready yet, revert two commits 690c543550b0d2852060c18d270cdb534d339d9a - unstable test output 386e3d7609c49505e079c40c65919d99feb82505 - patch itself Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8b99edefcab1e82c43139a2c7dc06d31fb27b3e4 Modified Files -- contrib/dblink/dblink.c | 26 +-- contrib/tcn/tcn.c | 6 +- doc/src/sgml/catalogs.sgml| 8 - doc/src/sgml/indexam.sgml | 5 +- doc/src/sgml/indices.sgml | 7 +- doc/src/sgml/ref/create_index.sgml| 41 +--- doc/src/sgml/ref/create_table.sgml| 36 +-- src/backend/access/brin/brin.c| 1 - src/backend/access/common/indextuple.c| 31 --- src/backend/access/gin/ginutil.c | 1 - src/backend/access/gist/gist.c| 1 - src/backend/access/hash/hash.c| 1 - src/backend/access/index/genam.c | 16 +- src/backend/access/nbtree/nbtinsert.c | 45 +--- src/backend/access/nbtree/nbtpage.c | 5 +- src/backend/access/nbtree/nbtree.c| 1 - src/backend/access/nbtree/nbtsearch.c | 2 - src/backend/access/nbtree/nbtsort.c | 48 +--- src/backend/access/nbtree/nbtutils.c | 25 +-- src/backend/access/spgist/spgutils.c | 1 - src/backend/bootstrap/bootparse.y | 2 - src/backend/bootstrap/bootstrap.c | 2 +- src/backend/catalog/heap.c| 3 +- src/backend/catalog/index.c | 45 ++-- src/backend/catalog/indexing.c| 1 - src/backend/catalog/pg_constraint.c | 26 +-- src/backend/catalog/toasting.c| 1 - src/backend/commands/indexcmds.c | 60 ++--- src/backend/commands/matview.c| 6 +- src/backend/commands/tablecmds.c | 9 +- src/backend/commands/trigger.c| 1 - src/backend/commands/typecmds.c | 1 - src/backend/executor/execIndexing.c | 14 +- src/backend/executor/nodeIndexscan.c | 8 +- src/backend/nodes/copyfuncs.c | 2 - src/backend/nodes/equalfuncs.c| 2 - src/backend/nodes/outfuncs.c | 3 - src/backend/optimizer/path/indxpath.c | 2 +- src/backend/optimizer/path/pathkeys.c | 7 - src/backend/optimizer/util/plancat.c | 32 ++- src/backend/parser/analyze.c | 6 +- src/backend/parser/gram.y | 57 ++--- src/backend/parser/parse_relation.c | 2 +- src/backend/parser/parse_target.c | 2 +- src/backend/parser/parse_utilcmd.c| 121 ++- src/backend/utils/adt/ruleutils.c | 32 --- src/backend/utils/adt/selfuncs.c | 4 +- src/backend/utils/cache/relcache.c| 83 +++ src/backend/utils/sort/tuplesort.c| 5 +- src/bin/pg_dump/pg_dump.c | 65 +- src/bin/pg_dump/pg_dump.h | 6 +- src/include/access/amapi.h| 2 - src/include/access/itup.h | 2 - src/include/access/nbtree.h | 3 +- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_constraint.h | 23 +- src/include/catalog/pg_constraint_fn.h| 21 +- src/include/catalog/pg_index.h| 38 ++-- src/include/nodes/execnodes.h | 9 +- src/include/nodes/parsenodes.h| 5 +- src/include/nodes/relation.h | 13 +- src/include/utils/rel.h | 16 +- src/test/regress/expected/create_index.out| 19 -- src/test/regress/expected/index_including.out | 301 -- src/test/regress/parallel_schedule| 2 +- src/test/regress/serial_schedule | 1 - src/test/regress/sql/create_index.sql | 20 -- src/test/regress/sql/index_including.sql | 181 68 files changed, 255 insertions(+), 1320 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: CREATE INDEX ... INCLUDING (column[, ...])
Given those concerns, this *clearly* was not ready to commit. Please revert, Teodor. Will do, sorry. I was a bit confused with quiet discussion -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix possible use of uninitialised value in ts_headline()
Fix possible use of uninitialised value in ts_headline() Found during investigation of failure of skink buildfarm member and its valgrind report. Backpatch to all supported branches Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/bf73016e01f0b9eb7c9ad1916a75d1c3bf78f743 Modified Files -- src/backend/tsearch/wparser_def.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix possible use of uninitialised value in ts_headline()
Fix possible use of uninitialised value in ts_headline() Found during investigation of failure of skink buildfarm member and its valgrind report. Backpatch to all supported branches Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/94cda4f1065bcd21bdce664dc03eaa31faba0442 Modified Files -- src/backend/tsearch/wparser_def.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix possible use of uninitialised value in ts_headline()
Fix possible use of uninitialised value in ts_headline() Found during investigation of failure of skink buildfarm member and its valgrind report. Backpatch to all supported branches Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9d3fb209a07656fdee6f190013ecfcd1c590bedb Modified Files -- src/backend/tsearch/wparser_def.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix possible use of uninitialised value in ts_headline()
Fix possible use of uninitialised value in ts_headline() Found during investigation of failure of skink buildfarm member and its valgrind report. Backpatch to all supported branches Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d1eee9ba85be978c5b137d657dc8e3fd7bc2cebd Modified Files -- src/backend/tsearch/wparser_def.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix possible use of uninitialised value in ts_headline()
Fix possible use of uninitialised value in ts_headline() Found during investigation of failure of skink buildfarm member and its valgrind report. Backpatch to all supported branches Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b2a9e161ddb94daf3fa69e177b7e48ee944ec5a2 Modified Files -- src/backend/tsearch/wparser_def.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix possible use of uninitialised value in ts_headline()
Fix possible use of uninitialised value in ts_headline() Found during investigation of failure of skink buildfarm member and its valgrind report. Backpatch to all supported branches Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cb0c8cbf316f9362c11d7a8356e6f459258ae78e Modified Files -- src/backend/tsearch/wparser_def.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix output of regression test of contrib/tsearch2
Fix output of regression test of contrib/tsearch2 Just forget to add in 1ec4c7c055ca045c5df6352a4cdacd9aa778e598 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/38627f687823eae57e932c3b234656342403e909 Modified Files -- contrib/tsearch2/expected/tsearch2.out | 16 1 file changed, 8 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Restore original tsquery operation numbering.
Restore original tsquery operation numbering. As noticed by Tom Lane changing operation's number in commit bb140506df605fab58f48926ee1db1f80bdafb59 causes on-disk format incompatibility. Revert to previous numbering, that is reason to add special array to store priorities of operation. Also it reverts order of tsquery to previous. Author: Dmitry Ivanov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1ec4c7c055ca045c5df6352a4cdacd9aa778e598 Modified Files -- src/backend/utils/adt/tsquery.c | 12 +--- src/include/tsearch/ts_type.h | 17 + src/test/regress/expected/tsearch.out | 14 +++--- src/test/regress/expected/tstypes.out | 2 +- 4 files changed, 30 insertions(+), 15 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: CREATE INDEX ... INCLUDING (column[, ...])
CREATE INDEX ... INCLUDING (column[, ...]) Now indexes (but only B-tree for now) can contain "extra" column(s) which doesn't participate in index structure, they are just stored in leaf tuples. It allows to use index only scan by using single index instead of two or more indexes. Author: Anastasia Lubennikova with minor editorializing by me Reviewers: David Rowley, Peter Geoghegan, Jeff Janes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/386e3d7609c49505e079c40c65919d99feb82505 Modified Files -- contrib/dblink/dblink.c | 26 +-- contrib/tcn/tcn.c | 6 +- doc/src/sgml/catalogs.sgml| 8 + doc/src/sgml/indexam.sgml | 5 +- doc/src/sgml/indices.sgml | 7 +- doc/src/sgml/ref/create_index.sgml| 41 +++- doc/src/sgml/ref/create_table.sgml| 36 ++- src/backend/access/brin/brin.c| 1 + src/backend/access/common/indextuple.c| 31 +++ src/backend/access/gin/ginutil.c | 1 + src/backend/access/gist/gist.c| 1 + src/backend/access/hash/hash.c| 1 + src/backend/access/index/genam.c | 16 +- src/backend/access/nbtree/nbtinsert.c | 45 +++- src/backend/access/nbtree/nbtpage.c | 5 +- src/backend/access/nbtree/nbtree.c| 1 + src/backend/access/nbtree/nbtsearch.c | 2 + src/backend/access/nbtree/nbtsort.c | 48 +++- src/backend/access/nbtree/nbtutils.c | 25 ++- src/backend/access/spgist/spgutils.c | 1 + src/backend/bootstrap/bootparse.y | 2 + src/backend/bootstrap/bootstrap.c | 2 +- src/backend/catalog/heap.c| 3 +- src/backend/catalog/index.c | 45 ++-- src/backend/catalog/indexing.c| 1 + src/backend/catalog/pg_constraint.c | 26 ++- src/backend/catalog/toasting.c| 1 + src/backend/commands/indexcmds.c | 60 +++-- src/backend/commands/matview.c| 6 +- src/backend/commands/tablecmds.c | 9 +- src/backend/commands/trigger.c| 1 + src/backend/commands/typecmds.c | 1 + src/backend/executor/execIndexing.c | 14 +- src/backend/executor/nodeIndexscan.c | 8 +- src/backend/nodes/copyfuncs.c | 2 + src/backend/nodes/equalfuncs.c| 2 + src/backend/nodes/outfuncs.c | 3 + src/backend/optimizer/path/indxpath.c | 2 +- src/backend/optimizer/path/pathkeys.c | 7 + src/backend/optimizer/util/plancat.c | 32 +-- src/backend/parser/analyze.c | 6 +- src/backend/parser/gram.y | 57 +++-- src/backend/parser/parse_relation.c | 2 +- src/backend/parser/parse_target.c | 2 +- src/backend/parser/parse_utilcmd.c| 121 +-- src/backend/utils/adt/ruleutils.c | 32 +++ src/backend/utils/adt/selfuncs.c | 4 +- src/backend/utils/cache/relcache.c| 83 --- src/backend/utils/sort/tuplesort.c| 5 +- src/bin/pg_dump/pg_dump.c | 65 +- src/bin/pg_dump/pg_dump.h | 6 +- src/include/access/amapi.h| 2 + src/include/access/itup.h | 2 + src/include/access/nbtree.h | 3 +- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_constraint.h | 23 +- src/include/catalog/pg_constraint_fn.h| 21 +- src/include/catalog/pg_index.h| 38 ++-- src/include/nodes/execnodes.h | 9 +- src/include/nodes/parsenodes.h| 5 +- src/include/nodes/relation.h | 13 +- src/include/utils/rel.h | 16 +- src/test/regress/expected/create_index.out| 19 ++ src/test/regress/expected/index_including.out | 301 ++ src/test/regress/parallel_schedule| 2 +- src/test/regress/serial_schedule | 1 + src/test/regress/sql/create_index.sql | 20 ++ src/test/regress/sql/index_including.sql | 181 68 files changed, 1320 insertions(+), 255 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Enhanced custom error in PLPythonu
Enhanced custom error in PLPythonu Patch adds a new, more rich, way to emit error message or exception from PL/Pythonu code. Author: Pavel Stehule Reviewers: Catalin Iacob, Peter Eisentraut, Jim Nasby Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5c3c3cd0a3046339597a03bc708cb5530dc07059 Modified Files -- doc/src/sgml/plpython.sgml | 66 ++--- src/pl/plpython/expected/plpython_test.out | 193 ++- src/pl/plpython/plpy_elog.c| 167 +-- src/pl/plpython/plpy_elog.h| 2 + src/pl/plpython/plpy_plpymodule.c | 206 ++--- src/pl/plpython/plpy_spi.c | 11 +- src/pl/plpython/sql/plpython_test.sql | 137 ++- 7 files changed, 701 insertions(+), 81 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Phrase full text search.
Assuming that I'm right, you need to revert OP_AND/OP_OR/OP_NOT to what they were before, which means you need to give up on the assumption that the numerical values of the OP_xxx constants correspond directly to their syntactic priority. But that assumption was never going to survive the next tsquery expansion anyway. I'd suggest a static const array mapping the OP values into their syntactic priorities. Oh, I see. Will fix. -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Rename comparePos() to compareWordEntryPos()
Rename comparePos() to compareWordEntryPos() Rename comparePos() to compareWordEntryPos() to prevent export of too generic name. Per gripe from Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4e55b3f0335c2aa658cd9d1fda4dea2a1f9ab80d Modified Files -- src/backend/utils/adt/tsvector.c| 4 ++-- src/backend/utils/adt/tsvector_op.c | 2 +- src/include/tsearch/ts_type.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Phrase full text search.
Phrase full text search. Hasn't this patch broken on-disk compatibility of type tsquery by renumbering the values of QueryOperator.operator? I'm looking at the patch delta in ts_type.h. Distance field is placed exactly in hole between two uint8_t fields and uint32_t field, as I known any known platform which we support uses 4-byte aligment for int32 type. Am I wrong? If yes then I will move distance to the end of struct. QueryOpertor struct isn't used directly to store to disk, it's used in union QueryItem. sizeof(QueryItem) = 12 sizeof(QueryOperator) = 8, so we can add distance to the end without growning size of QueryItem. -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Zeroing unused parts ducring tsquery construction.
Zeroing unused parts ducring tsquery construction. Per investigation failure skink buildfarm member and RANDOMIZE_ALLOCATED_MEMORY help Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3308467905aa157139d24375850cfe49ee90a0cf Modified Files -- src/backend/utils/adt/tsquery_cleanup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make testing of phraseto_tsquery independ from value of
Make testing of phraseto_tsquery independ from value of default_text_search_config variable. Per skink buldfarm member Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a7ace3b6d96c7a1539ed0700865d320258a12f73 Modified Files -- src/test/regress/expected/tsearch.out | 10 +- src/test/regress/sql/tsearch.sql | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Phrase full text search.
Phrase full text search. Patch introduces new text search operator (<-> or ) into tsquery. On-disk and binary in/out format of tsquery are backward compatible. It has two side effect: - change order for tsquery, so, users, who has a btree index over tsquery, should reindex it - less number of parenthesis in tsquery output, and tsquery becomes more readable Authors: Teodor Sigaev, Oleg Bartunov, Dmitry Ivanov Reviewers: Alexander Korotkov, Artur Zakirov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bb140506df605fab58f48926ee1db1f80bdafb59 Modified Files -- contrib/tsearch2/expected/tsearch2.out | 56 ++--- doc/src/sgml/datatype.sgml | 9 +- doc/src/sgml/func.sgml | 39 doc/src/sgml/textsearch.sgml| 182 ++- src/backend/tsearch/to_tsany.c | 187 +++ src/backend/tsearch/ts_parse.c | 15 +- src/backend/tsearch/ts_selfuncs.c | 3 +- src/backend/tsearch/wparser_def.c | 31 ++- src/backend/utils/adt/tsginidx.c| 57 +++-- src/backend/utils/adt/tsgistidx.c | 4 +- src/backend/utils/adt/tsquery.c | 311 +++-- src/backend/utils/adt/tsquery_cleanup.c | 362 +++-- src/backend/utils/adt/tsquery_op.c | 54 - src/backend/utils/adt/tsquery_util.c| 11 +- src/backend/utils/adt/tsrank.c | 263 ++--- src/backend/utils/adt/tsvector.c| 2 +- src/backend/utils/adt/tsvector_op.c | 326 +++--- src/backend/utils/adt/tsvector_parser.c | 10 +- src/include/catalog/catversion.h| 2 +- src/include/catalog/pg_operator.h | 3 + src/include/catalog/pg_proc.h | 7 + src/include/tsearch/ts_public.h | 22 +- src/include/tsearch/ts_type.h | 30 ++- src/include/tsearch/ts_utils.h | 15 +- src/test/regress/expected/tsdicts.out | 36 ++- src/test/regress/expected/tsearch.out | 395 +--- src/test/regress/expected/tstypes.out | 369 - src/test/regress/sql/tsdicts.sql| 3 + src/test/regress/sql/tsearch.sql| 101 src/test/regress/sql/tstypes.sql| 75 +- 30 files changed, 2536 insertions(+), 444 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add jsonb_insert
Add jsonb_insert It inserts a new value into an jsonb array at arbitrary position or a new key to jsonb object. Author: Dmitry Dolgov Reviewers: Petr Jelinek, Vitaly Burovoy, Andrew Dunstan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0b62fd036e1ac48a8432bb9664b21e1f036c1b08 Modified Files -- doc/src/sgml/func.sgml | 45 ++-- src/backend/catalog/system_views.sql | 8 +++ src/backend/utils/adt/jsonfuncs.c| 134 --- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h| 2 + src/include/utils/jsonb.h| 3 + src/test/regress/expected/jsonb.out | 129 + src/test/regress/sql/jsonb.sql | 30 8 files changed, 324 insertions(+), 29 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo
Fix typo Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/eb7308d29875df773b5b52b06ed3d8b60f1b8242 Modified Files -- contrib/bloom/blutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: fix typo
fix typo Andreas Ulbrich Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9b27aebe7124210c1b0dbacac657edfefa16a006 Modified Files -- doc/src/sgml/generic-wal.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix condition in e9e441c9fac6cbc0510cded6abb9d0e6b646ecaf
Fix condition in e9e441c9fac6cbc0510cded6abb9d0e6b646ecaf Comment is right, but if - not. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9c50372d20aabdb23963f8d28651728d546acefb Modified Files -- contrib/bloom/blvacuum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Prevent mark as deleted and as 'has free space' page in bloom mo
Prevent mark as deleted and as 'has free space' page in bloom module Vacuum might put page into list of pages with some free space and mark as deleted at the same time. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e9e441c9fac6cbc0510cded6abb9d0e6b646ecaf Modified Files -- contrib/bloom/blvacuum.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fixes in bloom contrib module
Fixes in bloom contrib module Looking at result of buildfarm member jaguarundi it seems to me that BloomOptions isn't inited sometime, but I don't see yet how it's possible. Nevertheless, check of signature length's is missed, so, add a limit of it. Also add missed GenericXLogAbort() in case of already deleted page in vacuum + minor code refactoring. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/80afb62db0f118f70367a357cef0509a2ebb Modified Files -- contrib/bloom/bloom.h| 6 ++ contrib/bloom/blutils.c | 11 +++ contrib/bloom/blvacuum.c | 13 +++-- 3 files changed, 20 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fixes in bloom contrib module missed during review
Fixes in bloom contrib module missed during review - macroses llike (var & FLAG) are changed to ((var & FLAG) != 0) - do not copy uninitialized part of notFullPage array to page Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/27f3bbfad46e694fcbf2fa39cb621110d46ec95c Modified Files -- contrib/bloom/bloom.h| 12 contrib/bloom/blvacuum.c | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix English in bloom module documentation
Fix English in bloom module documentation Author: Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a361c22ebfa8c87683f07f83f55a8456e7892e6d Modified Files -- doc/src/sgml/bloom.sgml | 72 ++--- 1 file changed, 38 insertions(+), 34 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Bloom index contrib module
Several non-x86 members of pgbuildfarm aren't happy with it, we are investigating the problem Teodor Sigaev wrote: Bloom index contrib module Module provides new access method. It is actually a simple Bloom filter implemented as pgsql's index. It could give some benefits on search with large number of columns. Module is a single way to test generic WAL interface committed earlier. Author: Teodor Sigaev, Alexander Korotkov Reviewers: Aleksander Alekseev, Michael Paquier, Jim Nasby Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9ee014fc899a28a198492b074e32b60ed8915ea9 Modified Files -- contrib/Makefile | 1 + contrib/bloom/.gitignore | 4 + contrib/bloom/Makefile | 24 ++ contrib/bloom/blcost.c | 48 contrib/bloom/blinsert.c | 313 ++ contrib/bloom/bloom--1.0.sql | 19 ++ contrib/bloom/bloom.control | 5 + contrib/bloom/bloom.h| 178 +++ contrib/bloom/blscan.c | 175 +++ contrib/bloom/blutils.c | 463 +++ contrib/bloom/blvacuum.c | 212 ++ contrib/bloom/blvalidate.c | 220 +++ contrib/bloom/expected/bloom.out | 122 +++ contrib/bloom/sql/bloom.sql | 47 contrib/bloom/t/001_wal.pl | 75 +++ doc/src/sgml/bloom.sgml | 218 ++ doc/src/sgml/contrib.sgml| 1 + doc/src/sgml/filelist.sgml | 1 + 18 files changed, 2126 insertions(+) -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Bloom index contrib module
Bloom index contrib module Module provides new access method. It is actually a simple Bloom filter implemented as pgsql's index. It could give some benefits on search with large number of columns. Module is a single way to test generic WAL interface committed earlier. Author: Teodor Sigaev, Alexander Korotkov Reviewers: Aleksander Alekseev, Michael Paquier, Jim Nasby Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9ee014fc899a28a198492b074e32b60ed8915ea9 Modified Files -- contrib/Makefile | 1 + contrib/bloom/.gitignore | 4 + contrib/bloom/Makefile | 24 ++ contrib/bloom/blcost.c | 48 contrib/bloom/blinsert.c | 313 ++ contrib/bloom/bloom--1.0.sql | 19 ++ contrib/bloom/bloom.control | 5 + contrib/bloom/bloom.h| 178 +++ contrib/bloom/blscan.c | 175 +++ contrib/bloom/blutils.c | 463 +++ contrib/bloom/blvacuum.c | 212 ++ contrib/bloom/blvalidate.c | 220 +++ contrib/bloom/expected/bloom.out | 122 +++ contrib/bloom/sql/bloom.sql | 47 contrib/bloom/t/001_wal.pl | 75 +++ doc/src/sgml/bloom.sgml | 218 ++ doc/src/sgml/contrib.sgml| 1 + doc/src/sgml/filelist.sgml | 1 + 18 files changed, 2126 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in generic wal docs
Fix typo in generic wal docs Markus Nullmeier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4e56e5a6de766a6983ce723b1945d68a4e098a06 Modified Files -- doc/src/sgml/generic-wal.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add Generic WAL interface
Add Generic WAL interface This interface is designed to give an access to WAL for extensions which could implement new access method, for example. Previously it was impossible because restoring from custom WAL would need to access system catalog to find a redo custom function. This patch suggests generic way to describe changes on page with standart layout. Bump XLOG_PAGE_MAGIC because of new record type. Author: Alexander Korotkov with a help of Petr Jelinek, Markus Nullmeier and minor editorization by my Reviewers: Petr Jelinek, Alvaro Herrera, Teodor Sigaev, Jim Nasby, Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/65578341af1ae50e52e0f45e691ce88ad5a1b9b1 Modified Files -- doc/src/sgml/filelist.sgml| 1 + doc/src/sgml/generic-wal.sgml | 141 ++ doc/src/sgml/postgres.sgml| 1 + src/backend/access/rmgrdesc/Makefile | 6 +- src/backend/access/rmgrdesc/genericdesc.c | 58 src/backend/access/transam/Makefile | 4 +- src/backend/access/transam/generic_xlog.c | 431 ++ src/backend/access/transam/rmgr.c | 1 + src/backend/replication/logical/decode.c | 1 + src/bin/pg_xlogdump/.gitignore| 1 + src/bin/pg_xlogdump/rmgrdesc.c| 1 + src/include/access/generic_xlog.h | 42 +++ src/include/access/rmgrlist.h | 1 + src/include/access/xlog_internal.h| 2 +- 14 files changed, 685 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Bump catalog version, forget in acdf2a8b372aec1da09370fca77ff7dc
Bump catalog version, forget in acdf2a8b372aec1da09370fca77ff7dccac7646d Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2d02a856e8331329121ac2fa2c0b5dab0d106ca0 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Introduce SP-GiST operator class over box.
Introduce SP-GiST operator class over box. Patch implements quad-tree over boxes, naive approach of 2D quad tree will not work for any non-point objects because splitting space on node is not efficient. The idea of pathc is treating 2D boxes as 4D points, so, object will not overlap (in 4D space). The performance tests reveal that this technique especially beneficial with too much overlapping objects, so called "spaghetti data". Author: Alexander Lebedev with editorization by Emre Hasegeli and me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/acdf2a8b372aec1da09370fca77ff7dccac7646d Modified Files -- doc/src/sgml/spgist.sgml | 18 + src/backend/utils/adt/Makefile | 4 +- src/backend/utils/adt/geo_spgist.c | 699 +++ src/include/catalog/pg_amop.h| 16 + src/include/catalog/pg_amproc.h | 5 + src/include/catalog/pg_opclass.h | 1 + src/include/catalog/pg_opfamily.h| 1 + src/include/catalog/pg_proc.h| 11 + src/include/utils/geo_decls.h| 6 + src/test/regress/expected/box.out| 240 +++ src/test/regress/expected/opr_sanity.out | 6 +- src/test/regress/sql/box.sql | 62 +++ 12 files changed, 1066 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Use traversalValue in SP-GiST range opclass.
Use traversalValue in SP-GiST range opclass. Author: Alexander Lebedev Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/87545f541278ffde4fa1ccf396affbc4e9d59a23 Modified Files -- src/backend/utils/adt/rangetypes_spgist.c | 34 +++ 1 file changed, 25 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Introduce traversalValue for SP-GiST scan
Introduce traversalValue for SP-GiST scan During scan sometimes it would be very helpful to know some information about parent node or all ancestor nodes. Right now reconstructedValue could be used but it's not a right usage of it (range opclass uses that). traversalValue is arbitrary piece of memory in separate MemoryContext while reconstructedVale should have the same type as indexed column. Subsequent patches for range opclass and quad4d tree will use it. Author: Alexander Lebedev, Teodor Sigaev Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ccd6eb49a4ae924290ab7eba5540218f5beb48b8 Modified Files -- doc/src/sgml/spgist.sgml| 15 +++ src/backend/access/spgist/spgscan.c | 18 ++ src/include/access/spgist.h | 4 3 files changed, 37 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix support of digits in email/hostnames.
Fix support of digits in email/hostnames. When tsearch was implemented I did several mistakes in hostname/email definition rules: 1) allow underscore in hostname what prohibited by RFC 2) forget to allow leading digits separated by hyphen (like 123-x.com) in hostname 3) do no allow underscore/hyphen after leading digits in localpart of email Artur's patch resolves two last issues, but by the way allows hosts name like 123_x.com together with 123-x.com. RFC forbids underscore usage in hostname but pg allows that since initial tsearch version in core, although only for non-digits. Patch syncs support digits and nondigits in both hostname and email. Forbidding underscore in hostname may break existsing usage of tsearch and, anyhow, it should be done by separate patch. Author: Artur Zakirov BUG: #13964 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/61d66c44f18c73094a50a2ef97d26cc03e171dc0 Modified Files -- src/backend/tsearch/wparser_def.c | 3 +++ src/test/regress/expected/tsearch.out | 22 ++ src/test/regress/sql/tsearch.sql | 6 +++--- 3 files changed, 20 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: psql tab-complete for CREATE/DROP ACCESS METHOD
psql tab-complete for CREATE/DROP ACCESS METHOD Alexander Korotkov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/559e7a0a6d4450c09825055e3d255d30ee869c67 Modified Files -- src/bin/psql/tab-complete.c | 13 + 1 file changed, 13 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix comment in pg_dump.
Fix comment in pg_dump. It was missed in 473b93287040b20017cc25a157cffdc5b978c254, CREATE ACCESS METHOD Alexander Korotkov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dabd255d584785c61b1187f10b7bdbf99022ae2d Modified Files -- src/bin/pg_dump/pg_dump.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve docs of pg_trgm changes
Improve docs of pg_trgm changes Artur Zakirov, per gripe from Jeff Janes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f6bd0da63bf40bc324eec6fd47f3d3d301f44dab Modified Files -- doc/src/sgml/pgtrgm.sgml | 58 ++-- 1 file changed, 37 insertions(+), 21 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve script generating unaccent rules
Improve script generating unaccent rules Script now use the standard Unicode transliterator Latin-ASCII. Author: Leonard Benedetti Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9a206d063c410df7cd5da01b169b23bff413fef5 Modified Files -- contrib/unaccent/generate_unaccent_rules.py | 144 -- contrib/unaccent/unaccent.rules | 674 +++- 2 files changed, 762 insertions(+), 56 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Introduce parse_ident()
Introduce parse_ident() SQL-layer function to split qualified identifier into array parts. Author: Pavel Stehule with minor editorization by me and Jim Nasby Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3187d6de0e5a9e805b27c48437897e8c39071d45 Modified Files -- doc/src/sgml/func.sgml | 26 src/backend/catalog/system_views.sql | 7 ++ src/backend/parser/scansup.c | 12 +- src/backend/utils/adt/misc.c | 224 +++ src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h| 3 + src/include/parser/scansup.h | 3 + src/include/utils/builtins.h | 1 + src/test/regress/expected/name.out | 66 +++ src/test/regress/sql/name.sql| 33 ++ 10 files changed, 375 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Introduce parse_ident()
Fixed a typo and added 'the' a few times. Thank you, committed -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add word_similarity to pg_trgm contrib module.
Add word_similarity to pg_trgm contrib module. Patch introduces a concept of similarity over string and just a word from another string. Version of extension is not changed because 1.2 was already introduced in 9.6 release cycle, so, there wasn't a public version. Author: Alexander Korotkov, Artur Zakirov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f576b17cd6ba653bdace1f0da9a3b57f4984e460 Modified Files -- contrib/pg_trgm/Makefile | 2 +- contrib/pg_trgm/expected/pg_trgm.out | 4 +- contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 - contrib/pg_trgm/pg_trgm--1.2.sql | 64 + contrib/pg_trgm/sql/pg_trgm.sql | 4 +- contrib/pg_trgm/trgm.h| 30 +- contrib/pg_trgm/trgm_gin.c| 20 +- contrib/pg_trgm/trgm_gist.c | 33 ++- contrib/pg_trgm/trgm_op.c | 501 ++ doc/src/sgml/pgtrgm.sgml | 79 ++ 10 files changed, 726 insertions(+), 75 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
GUC variable pg_trgm.similarity_threshold insead of set_limit() Use GUC variable pg_trgm.similarity_threshold insead of set_limit()/show_limit() which was introduced when defining GUC varuables by modules was absent. Author: Artur Zakirov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5871b88487cfd07966e2ce08609a4d6d5ee9718e Modified Files -- contrib/pg_trgm/pg_trgm--1.2.sql | 4 +++- contrib/pg_trgm/trgm.h | 2 +- contrib/pg_trgm/trgm_gin.c | 8 +-- contrib/pg_trgm/trgm_gist.c | 6 -- contrib/pg_trgm/trgm_op.c| 45 ++-- doc/src/sgml/pgtrgm.sgml | 28 ++--- 6 files changed, 78 insertions(+), 15 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add files forgotten in f576b17cd6ba653bdace1f0da9a3b57f4984e460
Add files forgotten in f576b17cd6ba653bdace1f0da9a3b57f4984e460 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e4b523e5b52a84010a34fc0796904ce39116e56c Modified Files -- contrib/pg_trgm/data/trgm2.data | 696 +++ contrib/pg_trgm/expected/pg_word_trgm.out | 1044 + contrib/pg_trgm/sql/pg_word_trgm.sql | 42 ++ 3 files changed, 1782 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: pg_trgm's set_limit() now uses SetConfigOption()
pg_trgm's set_limit() now uses SetConfigOption() Deprecated set_limit() is modified to use SetConfigOption() to set similarity_threshold which is actually an instance of pg_trgm.similarity_threshold GUC variable. Previous coding directly sets similarity_threshold what could cause an inconsistency between states of actual variable and GUC representation. Per gripe from Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/aa698d753566f68bdd54881d30b1a515b0327b0e Modified Files -- contrib/pg_trgm/trgm_op.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
It should go through SetConfigOption(); compare for example tsa_set_curcfg_byname(). Which would also mean you could drop the Seems, also show_limit() should use GetConfigOption()? -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
If that's to be an actual GUC variable, it's not okay for set_limit() to just do this: similarity_threshold = nlimit; It should go through SetConfigOption(); compare for example tsa_set_curcfg_byname(). Which would also mean you could drop the range-checking code there, because guc.c would enforce it. will fix -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add word_similarity to pg_trgm contrib module.
contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 - contrib/pg_trgm/pg_trgm--1.2.sql | 64 + This is completely, utterly wrong. You do not add stuff to an extension module by redefining what version 1.2 means. You do it by creating a 1.3 version and providing a 1.2--1.3 update script. http://www.postgresql.org/message-id/25977.1452717...@sss.pgh.pa.us You had an opposite opinion three months ago. And I still agree with that. -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve support of Hunspell
Improve support of Hunspell - allow to use non-ascii characters as affix flag. Non-numeric affix flags now are stored as string instead of numeric value of character. - allow to use 0 as affix flag in numeric encoded affixes That adds support for arabian, hungarian, turkish and brazilian portuguese languages. Author: Artur Zakirov with heavy editorization by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f4ceed6ceba31a72ed7a726fef05d211641f283c Modified Files -- src/backend/tsearch/spell.c | 431 +++--- src/include/tsearch/dicts/spell.h | 44 +++- 2 files changed, 302 insertions(+), 173 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: fix typo in comment
fix typo in comment Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ce91b9209f221f9555d340b40e02aaf8cdc777e4 Modified Files -- contrib/unaccent/generate_unaccent_rules.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix a typo
Fix a typo Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/61d2ebdbf9155d80f83281d8c5729c8f8f0949bc Modified Files -- doc/src/sgml/func.sgml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix Windows build broken in 6943a946c7e5eb72d53c0ce71f08a81a1335
Fix Windows build broken in 6943a946c7e5eb72d53c0ce71f08a81a133503bd Also it fixes dynamic array allocation disallowed by ANSI-C. Author: Stas Kelvich Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b1fdc727c37b23da947b4b0d440f723f31beb84d Modified Files -- src/backend/utils/adt/tsvector_op.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix merge affixes for numeric ones
Fix merge affixes for numeric ones Some dictionaries have duplicated base words with different affix set, we just merge that sets into one set. But previously merging of sets of affixes was actually a concatenation of strings but it's wrong for numeric representation of affixes because such representation uses comma to separate affixes. Author: Artur Zakirov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8829af47ef63d3c484f2e1f97a85a7a76b1baba6 Modified Files -- src/backend/tsearch/spell.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Bump catalog version missed in 6943a946c7e5eb72d53c0ce71f08a81a1
Bump catalog version missed in 6943a946c7e5eb72d53c0ce71f08a81a133503bd Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a9eb6c83efd258bb7a658fefa0074e0e65efd673 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Tsvector editing functions
Tsvector editing functions Adds several tsvector editting function: convert tsvector to/from text array, set weight for given lexemes, delete lexeme(s), unnest, filter lexemes with given weights Author: Stas Kelvich with some editorization by me Reviewers: Tomas Vondram, Teodor Sigaev Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6943a946c7e5eb72d53c0ce71f08a81a133503bd Modified Files -- doc/src/sgml/func.sgml| 91 +- doc/src/sgml/textsearch.sgml | 4 + src/backend/utils/adt/tsvector_op.c | 563 ++ src/include/catalog/pg_proc.h | 18 +- src/include/tsearch/ts_type.h | 7 + src/test/regress/expected/tstypes.out | 221 - src/test/regress/sql/tstypes.sql | 47 ++- 7 files changed, 933 insertions(+), 18 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Improve support of Hunspell in ispell dictionary.
Thank you, pushed Artur Zakirov wrote: Thank you for commit. This commit did not pass regression tests in Windows Server in pgbuildfarm. Attached patch fix it. On 04.03.2016 20:08, Teodor Sigaev wrote: Improve support of Hunspell in ispell dictionary. Now it's possible to load recent version of Hunspell for several languages. To handle these dictionaries Hunspell patch adds support for: * FLAG long - sets the double extended ASCII character flag type * FLAG num - sets the decimal number flag type (from 1 to 65535) * AF parameter - alias for flag's set Also it moves test dictionaries into separate directory. Author: Artur Zakirov with editorization by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d78a7d9c7fa3e9cd494b906f065fe7b7fe9fb9a5 Modified Files -- doc/src/sgml/textsearch.sgml | 148 - src/backend/tsearch/Makefile | 7 +- src/backend/tsearch/dicts/hunspell_sample.affix| 24 + .../tsearch/dicts/hunspell_sample_long.affix | 35 ++ .../tsearch/dicts/hunspell_sample_long.dict| 8 + .../tsearch/dicts/hunspell_sample_num.affix| 26 + src/backend/tsearch/dicts/hunspell_sample_num.dict | 8 + src/backend/tsearch/dicts/ispell_sample.affix | 26 + src/backend/tsearch/dicts/ispell_sample.dict | 8 + src/backend/tsearch/dicts/synonym_sample.syn | 5 + src/backend/tsearch/dicts/thesaurus_sample.ths | 17 + src/backend/tsearch/hunspell_sample.affix | 24 - src/backend/tsearch/ispell_sample.affix| 26 - src/backend/tsearch/ispell_sample.dict | 8 - src/backend/tsearch/spell.c| 611 ++--- src/backend/tsearch/synonym_sample.syn | 5 - src/backend/tsearch/thesaurus_sample.ths | 17 - src/include/tsearch/dicts/spell.h | 51 +- src/test/regress/expected/tsdicts.out | 234 src/test/regress/sql/tsdicts.sql | 64 +++ 20 files changed, 1183 insertions(+), 169 deletions(-) -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix Windows build broken by d78a7d9c7fa3e9cd494b906f065fe7b7fe9f
Fix Windows build broken by d78a7d9c7fa3e9cd494b906f065fe7b7fe9fb9a5 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0e7557dc8d5b2008b0b096cd730d16c8562690fc Modified Files -- src/tools/msvc/Install.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve support of Hunspell in ispell dictionary.
Improve support of Hunspell in ispell dictionary. Now it's possible to load recent version of Hunspell for several languages. To handle these dictionaries Hunspell patch adds support for: * FLAG long - sets the double extended ASCII character flag type * FLAG num - sets the decimal number flag type (from 1 to 65535) * AF parameter - alias for flag's set Also it moves test dictionaries into separate directory. Author: Artur Zakirov with editorization by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d78a7d9c7fa3e9cd494b906f065fe7b7fe9fb9a5 Modified Files -- doc/src/sgml/textsearch.sgml | 148 - src/backend/tsearch/Makefile | 7 +- src/backend/tsearch/dicts/hunspell_sample.affix| 24 + .../tsearch/dicts/hunspell_sample_long.affix | 35 ++ .../tsearch/dicts/hunspell_sample_long.dict| 8 + .../tsearch/dicts/hunspell_sample_num.affix| 26 + src/backend/tsearch/dicts/hunspell_sample_num.dict | 8 + src/backend/tsearch/dicts/ispell_sample.affix | 26 + src/backend/tsearch/dicts/ispell_sample.dict | 8 + src/backend/tsearch/dicts/synonym_sample.syn | 5 + src/backend/tsearch/dicts/thesaurus_sample.ths | 17 + src/backend/tsearch/hunspell_sample.affix | 24 - src/backend/tsearch/ispell_sample.affix| 26 - src/backend/tsearch/ispell_sample.dict | 8 - src/backend/tsearch/spell.c| 611 ++--- src/backend/tsearch/synonym_sample.syn | 5 - src/backend/tsearch/thesaurus_sample.ths | 17 - src/include/tsearch/dicts/spell.h | 51 +- src/test/regress/expected/tsdicts.out | 234 src/test/regress/sql/tsdicts.sql | 64 +++ 20 files changed, 1183 insertions(+), 169 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve error reporting in format()
Improve error reporting in format() Clarify invalid format conversion type error message and add hint. Author: Jim Nasby Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/07d25a964b2fb78169a4a34c6f6893736f69903a Modified Files -- src/backend/utils/adt/varlena.c| 15 +-- src/test/regress/expected/text.out | 9 ++--- 2 files changed, 15 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix lossy KNN GiST when ordering operator returns non-float8 val
Fix lossy KNN GiST when ordering operator returns non-float8 value. KNN GiST with recheck flag should return to executor the same type as ordering operator, GiST detects this type by looking to return type of function which implements ordering operator. But occasionally detecting code works after replacing ordering operator function to distance support function. Distance support function always returns float8, so, detecting code get float8 instead of actual return type of ordering operator. Built-in opclasses don't have ordering operator which doesn't return non-float8 value, so, tests are impossible here, at least now. Backpatch to 9.5 where lozzy KNN was introduced. Author: Alexander Korotkov Report by: Artur Zakirov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f25d07d99f4acf136baed4ef29ea97faad7337db Modified Files -- src/backend/access/gist/gistscan.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix lossy KNN GiST when ordering operator returns non-float8 val
Fix lossy KNN GiST when ordering operator returns non-float8 value. KNN GiST with recheck flag should return to executor the same type as ordering operator, GiST detects this type by looking to return type of function which implements ordering operator. But occasionally detecting code works after replacing ordering operator function to distance support function. Distance support function always returns float8, so, detecting code get float8 instead of actual return type of ordering operator. Built-in opclasses don't have ordering operator which doesn't return non-float8 value, so, tests are impossible here, at least now. Backpatch to 9.5 where lozzy KNN was introduced. Author: Alexander Korotkov Report by: Artur Zakirov Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/62e0ade9aa89c8f88ce506e1cb4be6e3697ee2d0 Modified Files -- src/backend/access/gist/gistscan.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve the gin index scan performance in pg_trgm.
Improve the gin index scan performance in pg_trgm. Previous coding assumes too pessimistic upper bound of similarity in consistent method of GIN. Author: Fornaroli Christophe with comments by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/25bfa7efd037a3c44d6a2989d18f55758090e8a9 Modified Files -- contrib/pg_trgm/trgm_gin.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Cube extension kNN support
Cube extension kNN support Introduce distance operators over cubes: <#> taxicab distance <-> euclidean distance <=> chebyshev distance Also add kNN support of those distances in GiST opclass. Author: Stas Kelvich Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/33bd250f6c4cc309f4eeb657da80f1e7743b3e5c Modified Files -- contrib/cube/Makefile|2 +- contrib/cube/cube--1.0--1.1.sql | 60 ++ contrib/cube/cube--1.0.sql | 325 contrib/cube/cube--1.1.sql | 379 ++ contrib/cube/cube.c | 208 + contrib/cube/cube.control|2 +- contrib/cube/cubedata.h |5 + contrib/cube/expected/cube.out | 301 ++ contrib/cube/expected/cube_1.out | 301 ++ contrib/cube/expected/cube_2.out | 301 ++ contrib/cube/expected/cube_3.out | 301 ++ contrib/cube/sql/cube.sql| 53 ++ doc/src/sgml/cube.sgml | 96 ++ 13 files changed, 2007 insertions(+), 327 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Allow to omit boundaries in array subscript
Allow to omit boundaries in array subscript Allow to omiy lower or upper or both boundaries in array subscript for selecting slice of array. Author: YUriy Zhuravlev Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9246af6799819847faa33baf441251003acbb8fe Modified Files -- doc/src/sgml/array.sgml | 20 ++ src/backend/executor/execQual.c | 44 +++--- src/backend/nodes/copyfuncs.c|2 ++ src/backend/nodes/equalfuncs.c |2 ++ src/backend/nodes/outfuncs.c |2 ++ src/backend/parser/gram.y| 31 + src/backend/parser/parse_node.c | 49 ++ src/backend/parser/parse_target.c|2 +- src/include/nodes/parsenodes.h |2 ++ src/test/regress/expected/arrays.out | 40 +++ src/test/regress/output/misc.source |3 ++- src/test/regress/sql/arrays.sql | 15 +++ 12 files changed, 184 insertions(+), 28 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
