[COMMITTERS] pgsql: Add some test coverage of EvalPlanQual with non-locked tables.
Add some test coverage of EvalPlanQual with non-locked tables. A Salesforce colleague of mine griped that the regression tests don't exercise EvalPlanQualFetchRowMarks() and allied routines. Which is a fair complaint. Add test cases that go through the REFERENCE and COPY code paths. Unfortunately we don't have sufficient infrastructure right now to exercise the FDW code path in the isolation tests, but this is surely better than before. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/342a1ffa2177c0b260b68d7891b0d04598a58432 Modified Files -- src/test/isolation/expected/eval-plan-qual.out | 40 src/test/isolation/specs/eval-plan-qual.spec | 16 ++ 2 files changed, 56 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add some test coverage of EvalPlanQual with non-locked tables.
Add some test coverage of EvalPlanQual with non-locked tables. A Salesforce colleague of mine griped that the regression tests don't exercise EvalPlanQualFetchRowMarks() and allied routines. Which is a fair complaint. Add test cases that go through the REFERENCE and COPY code paths. Unfortunately we don't have sufficient infrastructure right now to exercise the FDW code path in the isolation tests, but this is surely better than before. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3ef1a682d5e4a919dcaddc8256ea65de91654d1c Modified Files -- src/test/isolation/expected/eval-plan-qual.out | 40 src/test/isolation/specs/eval-plan-qual.spec | 16 ++ 2 files changed, 56 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add some test coverage of EvalPlanQual with non-locked tables.
Tom Lane wrote: Add some test coverage of EvalPlanQual with non-locked tables. A Salesforce colleague of mine griped that the regression tests don't exercise EvalPlanQualFetchRowMarks() and allied routines. Which is a fair complaint. Add test cases that go through the REFERENCE and COPY code paths. Unfortunately we don't have sufficient infrastructure right now to exercise the FDW code path in the isolation tests, but this is surely better than before. FWIW the test_decoding module has isolation tests (pretty ugly admittedly). I guess you could do something similar in the postgres_fdw module. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
