Re: [COMMITTERS] pgsql: Fix mistaken failure to allow parallelism in corner case.

[Tom Lane]

Robert Haas  writes:
> Fix mistaken failure to allow parallelism in corner case.

You can't insert fields into the middle of a widely-known struct
in the back branches.  In v10, this broke ABI compatibility for
any extension touching estate->es_query_dsa, which seems unlikely
to be the empty set.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix mistaken failure to allow parallelism in corner case.

[Robert Haas]

Fix mistaken failure to allow parallelism in corner case.

If we try to run a parallel plan in serial mode because, for example,
it's going to be scanned via a cursor, but for some reason we're
already in parallel mode (for example because an outer query is
running in parallel), we'd incorrectly try to launch workers.
Fix by adding a flag to the EState, so that we can be certain that
ExecutePlan() and ExecGather()/ExecGatherMerge() will have the same
idea about whether we are executing serially or in parallel.

Report and fix by Amit Kapila with help from Kuntal Ghosh.  A few
tweaks by me.

Discussion: 
http://postgr.es/m/caa4ek1+_buzrmvceua5eqnm4co9daxdm5hpaoe2j19epbr9...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/639c1a6bb9ee08fe4757a6fab1ddbd01291515e1

Modified Files
--
src/backend/executor/execMain.c| 1 +
src/backend/executor/execUtils.c   | 2 ++
src/backend/executor/nodeGather.c  | 2 +-
src/backend/executor/nodeGatherMerge.c | 2 +-
src/include/nodes/execnodes.h  | 2 ++
5 files changed, 7 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix mistaken failure to allow parallelism in corner case.

[Robert Haas]

Fix mistaken failure to allow parallelism in corner case.

If we try to run a parallel plan in serial mode because, for example,
it's going to be scanned via a cursor, but for some reason we're
already in parallel mode (for example because an outer query is
running in parallel), we'd incorrectly try to launch workers.
Fix by adding a flag to the EState, so that we can be certain that
ExecutePlan() and ExecGather()/ExecGatherMerge() will have the same
idea about whether we are executing serially or in parallel.

Report and fix by Amit Kapila with help from Kuntal Ghosh.  A few
tweaks by me.

Discussion: 
http://postgr.es/m/caa4ek1+_buzrmvceua5eqnm4co9daxdm5hpaoe2j19epbr9...@mail.gmail.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/036b6bd50365b9ae6ec0b4cb21d172510ef440a9

Modified Files
--
src/backend/executor/execMain.c   | 5 +
src/backend/executor/execUtils.c  | 2 ++
src/backend/executor/nodeGather.c | 2 +-
src/include/nodes/execnodes.h | 2 ++
4 files changed, 6 insertions(+), 5 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix mistaken failure to allow parallelism in corner case.

[Robert Haas]

Fix mistaken failure to allow parallelism in corner case.

If we try to run a parallel plan in serial mode because, for example,
it's going to be scanned via a cursor, but for some reason we're
already in parallel mode (for example because an outer query is
running in parallel), we'd incorrectly try to launch workers.
Fix by adding a flag to the EState, so that we can be certain that
ExecutePlan() and ExecGather()/ExecGatherMerge() will have the same
idea about whether we are executing serially or in parallel.

Report and fix by Amit Kapila with help from Kuntal Ghosh.  A few
tweaks by me.

Discussion: 
http://postgr.es/m/caa4ek1+_buzrmvceua5eqnm4co9daxdm5hpaoe2j19epbr9...@mail.gmail.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/965a16fa9f8c316c30f4ada3c1c98b5dd4666f25

Modified Files
--
src/backend/executor/execMain.c| 1 +
src/backend/executor/execUtils.c   | 2 ++
src/backend/executor/nodeGather.c  | 2 +-
src/backend/executor/nodeGatherMerge.c | 2 +-
src/include/nodes/execnodes.h  | 2 ++
5 files changed, 7 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers