[COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

2017-09-08 Thread Tom Lane
Fix more portability issues in new pgbench TAP tests.

Not completely sure, but I think bowerbird is spitting up on attempting
to include ">" in a temporary file name.  (Why in the world are we
writing this stuff into files at all?  A hash would be a better answer.)

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f25000c832f2e147986110116d4ba1a57b9d9256

Modified Files
--
src/bin/pgbench/t/001_pgbench_with_server.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

2017-09-08 Thread Fabien COELHO



Fix more portability issues in new pgbench TAP tests.


Sorry for all these issues unforeseen issues. Thanks to the farm!


* Remove no-such-user test case, output isn't stable, and we really
don't need to be testing such cases here anyway.


Ok.


* Fix the process exit code test logic to match PostgresNode::psql
(but I didn't bother with looking at the "core" flag).


Ok. At least it is consistent.


* Give up on inf/nan tests.


Too bad, I liked them!

Thanks for the fixes.

--
Fabien.


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

2017-09-08 Thread Tom Lane
Fix more portability issues in new pgbench TAP tests.

Strike two on the --bad-option test.
Three strikes and it's out.

Fabien Coelho, per buildfarm

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/933851033becf0848e0bb903f310bbd725e19489

Modified Files
--
src/bin/pgbench/t/002_pgbench_no_server.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

2017-09-08 Thread Tom Lane
Fix more portability issues in new pgbench TAP tests.

* Remove no-such-user test case, output isn't stable, and we really
don't need to be testing such cases here anyway.

* Fix the process exit code test logic to match PostgresNode::psql
(but I didn't bother with looking at the "core" flag).

* Give up on inf/nan tests.

Per buildfarm.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/77d63b7eafd44469c2766c1f29b75533981e4911

Modified Files
--
src/bin/pgbench/t/001_pgbench_with_server.pl | 20 +++-
src/test/perl/TestLib.pm | 14 --
2 files changed, 11 insertions(+), 23 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers