Re: [COMMITTERS] Vendor LLVM 4.0.

[Jan de Visser]

On Saturday, April 1, 2017 3:01:18 PM EDT Andres Freund wrote:
> On 2017-04-01 10:21:27 -0400, Robert Haas wrote:
> > On Sat, Apr 1, 2017 at 3:41 AM, Andres Freund  wrote:
> > > For the upcoming JIT support LLVM is required.  To avoid issues with
> > > having to support multiple LLVM versions, add a vendored version of
> > > LLVM.
> > > 
> > > The large size of LLVM makes this not great, but I think it's better
> > > than the alternatives.  And I'll forever have the most lines added to
> > > postgres.
> > > 
> > > Author: Andres Freund
> > > Discussion:
> > > http://postgr.es/m/20161206034955.bh33paeralxbt...@alap3.anarazel.de> 
> > This commit appears to violate the well-known PostgreSQL community
> > policy against committing the entire LLVM source tree to PostgreSQL.
> > Accordingly, the release management team has voted to revert this
> > commit, all of the other commits that you've ever made, every patch
> > you've ever reviewed or commented on, and all patches which depend on
> > those patches.
> 
> Well worth the price.  Now I'll never have to fix a bug again.
> 
> - Andres

I got my paradigms confused and was looking for the "Like" button.



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] Vendor LLVM 4.0.

[Andres Freund]

On 2017-04-01 21:27:42 +1300, Thomas Munro wrote:
> On Sat, Apr 1, 2017 at 8:41 PM, Andres Freund  wrote:
> > For the upcoming JIT support LLVM is required.  To avoid issues with
> > having to support multiple LLVM versions, add a vendored version of
> > LLVM.
> >
> > The large size of LLVM makes this not great, but I think it's better
> > than the alternatives.  And I'll forever have the most lines added to
> > postgres.
> >
> > Author: Andres Freund
> > Discussion: 
> > http://postgr.es/m/20161206034955.bh33paeralxbt...@alap3.anarazel.de
> >
> > Branch
> > --
> > master
> >
> > Details
> > ---
> > http://git.postgresql.org/pg/commitdiff/d31084e9d1118b25fd16580d9d8c2924b5740dff
> 
> This has broken VAX build farm members "poisson" and "davril".  One
> minor nitpick, I think it needs to rewritten in C so that pgindent can
> handle it.

You probably missed the existance of pgcppindent, added way back when:

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=d54ae2aff24c3aa9df605e5ec3d09042b7458a6c


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] Vendor LLVM 4.0.

[Andres Freund]

On 2017-04-01 10:21:27 -0400, Robert Haas wrote:
> On Sat, Apr 1, 2017 at 3:41 AM, Andres Freund  wrote:
> > For the upcoming JIT support LLVM is required.  To avoid issues with
> > having to support multiple LLVM versions, add a vendored version of
> > LLVM.
> >
> > The large size of LLVM makes this not great, but I think it's better
> > than the alternatives.  And I'll forever have the most lines added to
> > postgres.
> >
> > Author: Andres Freund
> > Discussion: 
> > http://postgr.es/m/20161206034955.bh33paeralxbt...@alap3.anarazel.de
> 
> This commit appears to violate the well-known PostgreSQL community
> policy against committing the entire LLVM source tree to PostgreSQL.
> Accordingly, the release management team has voted to revert this
> commit, all of the other commits that you've ever made, every patch
> you've ever reviewed or commented on, and all patches which depend on
> those patches.

Well worth the price.  Now I'll never have to fix a bug again.

- Andres


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] Vendor LLVM 4.0.

[Robert Haas]

On Sat, Apr 1, 2017 at 3:41 AM, Andres Freund  wrote:
> For the upcoming JIT support LLVM is required.  To avoid issues with
> having to support multiple LLVM versions, add a vendored version of
> LLVM.
>
> The large size of LLVM makes this not great, but I think it's better
> than the alternatives.  And I'll forever have the most lines added to
> postgres.
>
> Author: Andres Freund
> Discussion: 
> http://postgr.es/m/20161206034955.bh33paeralxbt...@alap3.anarazel.de

This commit appears to violate the well-known PostgreSQL community
policy against committing the entire LLVM source tree to PostgreSQL.
Accordingly, the release management team has voted to revert this
commit, all of the other commits that you've ever made, every patch
you've ever reviewed or commented on, and all patches which depend on
those patches.  Furthermore, we have decided that you will be taken to
the Dune Sea and cast into the Pit of Carkoon, the nesting place of
the all-powerful Sarlacc.  In his belly, you will find a new
definition of pain and suffering, as you are slowly digested over a
thousand years.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] Vendor LLVM 4.0.

[Michael Paquier]

On Sat, Apr 1, 2017 at 5:27 PM, Thomas Munro
 wrote:
> On Sat, Apr 1, 2017 at 8:41 PM, Andres Freund  wrote:
>> For the upcoming JIT support LLVM is required.  To avoid issues with
>> having to support multiple LLVM versions, add a vendored version of
>> LLVM.
>>
>> The large size of LLVM makes this not great, but I think it's better
>> than the alternatives.  And I'll forever have the most lines added to
>> postgres.
>>
>> Author: Andres Freund
>> Discussion: 
>> http://postgr.es/m/20161206034955.bh33paeralxbt...@alap3.anarazel.de
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>> http://git.postgresql.org/pg/commitdiff/d31084e9d1118b25fd16580d9d8c2924b5740dff
>
> This has broken VAX build farm members "poisson" and "davril".  One
> minor nitpick, I think it needs to rewritten in C so that pgindent can
> handle it.

That may not be the only problem. So this has been committed but it is
not present in the tree?
-- 
Michael


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] Vendor LLVM 4.0.

[Thomas Munro]

On Sat, Apr 1, 2017 at 8:41 PM, Andres Freund  wrote:
> For the upcoming JIT support LLVM is required.  To avoid issues with
> having to support multiple LLVM versions, add a vendored version of
> LLVM.
>
> The large size of LLVM makes this not great, but I think it's better
> than the alternatives.  And I'll forever have the most lines added to
> postgres.
>
> Author: Andres Freund
> Discussion: 
> http://postgr.es/m/20161206034955.bh33paeralxbt...@alap3.anarazel.de
>
> Branch
> --
> master
>
> Details
> ---
> http://git.postgresql.org/pg/commitdiff/d31084e9d1118b25fd16580d9d8c2924b5740dff

This has broken VAX build farm members "poisson" and "davril".  One
minor nitpick, I think it needs to rewritten in C so that pgindent can
handle it.

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers