[COMMITTERS] pgsql: Fix psql history handling so 'execute' backslash commands (\g)
Log Message: --- Fix psql history handling so 'execute' backslash commands (\g) remain as part of the multi-line query. Modified Files: -- pgsql/src/bin/psql: mainloop.c (r1.72 -> r1.73) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/mainloop.c.diff?r1=1.72&r2=1.73) ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
[COMMITTERS] pgsql: Add for ecpg: > o Add COPY TO STDIN / STDOUT handling
Log Message: --- Add for ecpg: > o Add COPY TO STDIN / STDOUT handling Modified Files: -- pgsql/doc: TODO (r1.1784 -> r1.1785) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.diff?r1=1.1784&r2=1.1785) pgsql/doc/src/FAQ: TODO.html (r1.288 -> r1.289) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/FAQ/TODO.html.diff?r1=1.288&r2=1.289) ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
[COMMITTERS] pgsql: Add WSACancelBlockingCall TODO.detail item.
Log Message: --- Add WSACancelBlockingCall TODO.detail item. Added Files: --- pgsql/doc/TODO.detail: win32intr (r1.1) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.detail/win32intr?rev=1.1&content-type=text/x-cvsweb-markup) ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[COMMITTERS] pgsql: Add for Win32: > o Check WSACancelBlockingCall() for interrupts
Log Message: --- Add for Win32: > o Check WSACancelBlockingCall() for interrupts (win32intr) > Modified Files: -- pgsql/doc: TODO (r1.1785 -> r1.1786) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.diff?r1=1.1785&r2=1.1786) pgsql/doc/src/FAQ: TODO.html (r1.289 -> r1.290) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/FAQ/TODO.html.diff?r1=1.289&r2=1.290) ---(end of broadcast)--- TIP 6: explain analyze is your friend
[COMMITTERS] pgsql: Update item.
Log Message: --- Update item. Modified Files: -- pgsql/doc/TODO.detail: win32intr (r1.1 -> r1.2) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.detail/win32intr.diff?r1=1.1&r2=1.2) ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[COMMITTERS] pgsql: Add: > o Prevent parent tables from altering or dropping
Log Message: --- Add: > o Prevent parent tables from altering or dropping constraints > like CHECK that are inherited by child tables > > Dropping constraints should only be possible with CASCADE. > Modified Files: -- pgsql/doc: TODO (r1.1786 -> r1.1787) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.diff?r1=1.1786&r2=1.1787) pgsql/doc/src/FAQ: TODO.html (r1.290 -> r1.291) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/FAQ/TODO.html.diff?r1=1.290&r2=1.291) ---(end of broadcast)--- TIP 6: explain analyze is your friend
[COMMITTERS] pgsql: This patch adds native LDAP auth, for those platforms that don't
Log Message: --- This patch adds native LDAP auth, for those platforms that don't have PAM (such as Win32, but also unixen without PAM). On Unix, uses OpenLDAP. On win32, uses the builin WinLDAP library. Magnus Hagander Modified Files: -- pgsql: configure (r1.484 -> r1.485) (http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.diff?r1=1.484&r2=1.485) configure.in (r1.454 -> r1.455) (http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.in.diff?r1=1.454&r2=1.455) pgsql/src/backend/libpq: auth.c (r1.134 -> r1.135) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/auth.c.diff?r1=1.134&r2=1.135) hba.c (r1.150 -> r1.151) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/hba.c.diff?r1=1.150&r2=1.151) pg_hba.conf.sample (r1.60 -> r1.61) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/pg_hba.conf.sample.diff?r1=1.60&r2=1.61) pgsql/src/include: pg_config.h.in (r1.94 -> r1.95) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/pg_config.h.in.diff?r1=1.94&r2=1.95) pgsql/src/include/libpq: hba.h (r1.41 -> r1.42) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/libpq/hba.h.diff?r1=1.41&r2=1.42) ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
[COMMITTERS] pgsql: * Stephen Frost ([EMAIL PROTECTED]) wrote: > I've now tested
Log Message: --- * Stephen Frost ([EMAIL PROTECTED]) wrote: > I've now tested this patch at home w/ 8.2HEAD and it seems to fix the > bug. I plan on testing it under 8.1.2 at work tommorow with > mod_auth_krb5, etc, and expect it'll work there. Assuming all goes > well and unless someone objects I'll forward the patch to -patches. > It'd be great to have this fixed as it'll allow us to use Kerberos to > authenticate to phppgadmin and other web-based tools which use > Postgres. While playing with this patch under 8.1.2 at home I discovered a mistake in how I manually applied one of the hunks to fe-auth.c. Basically, the base code had changed and so the patch needed to be modified slightly. This is because the code no longer either has a freeable pointer under 'name' or has 'name' as NULL. The attached patch correctly frees the string from pg_krb5_authname (where it had been strdup'd) if and only if pg_krb5_authname returned a string (as opposed to falling through and having name be set using name = pw->name;). Also added a comment to this effect. Backpatch to 8.1.X. Stephen Frost Modified Files: -- pgsql/src/interfaces/libpq: fe-auth.c (r1.113 -> r1.114) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-auth.c.diff?r1=1.113&r2=1.114) ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[COMMITTERS] pgsql: * Stephen Frost ([EMAIL PROTECTED]) wrote: > I've now tested
Log Message: --- * Stephen Frost ([EMAIL PROTECTED]) wrote: > I've now tested this patch at home w/ 8.2HEAD and it seems to fix the > bug. I plan on testing it under 8.1.2 at work tommorow with > mod_auth_krb5, etc, and expect it'll work there. Assuming all goes > well and unless someone objects I'll forward the patch to -patches. > It'd be great to have this fixed as it'll allow us to use Kerberos to > authenticate to phppgadmin and other web-based tools which use > Postgres. While playing with this patch under 8.1.2 at home I discovered a mistake in how I manually applied one of the hunks to fe-auth.c. Basically, the base code had changed and so the patch needed to be modified slightly. This is because the code no longer either has a freeable pointer under 'name' or has 'name' as NULL. The attached patch correctly frees the string from pg_krb5_authname (where it had been strdup'd) if and only if pg_krb5_authname returned a string (as opposed to falling through and having name be set using name = pw->name;). Also added a comment to this effect. Backpatch to 8.1.X. Stephen Frost Tags: REL8_1_STABLE Modified Files: -- pgsql/src/interfaces/libpq: fe-auth.c (r1.107.2.1 -> r1.107.2.2) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-auth.c.diff?r1=1.107.2.1&r2=1.107.2.2) ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
[COMMITTERS] pgsql: Update comment on how sighup signal affects postgresql.conf
Log Message: --- Update comment on how sighup signal affects postgresql.conf reload. Markus Bertheau Modified Files: -- pgsql/src/include/utils: guc.h (r1.64 -> r1.65) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc.h.diff?r1=1.64&r2=1.65) ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[COMMITTERS] pgsql: Enable standard_conforming_strings to be turned on.
Log Message: --- Enable standard_conforming_strings to be turned on. Kevin Grittner Modified Files: -- pgsql/doc/src/sgml: config.sgml (r1.49 -> r1.50) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml.diff?r1=1.49&r2=1.50) pgsql/src/backend/parser: scan.l (r1.130 -> r1.131) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/scan.l.diff?r1=1.130&r2=1.131) pgsql/src/backend/utils/misc: guc.c (r1.312 -> r1.313) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.312&r2=1.313) postgresql.conf.sample (r1.173 -> r1.174) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/postgresql.conf.sample.diff?r1=1.173&r2=1.174) pgsql/src/bin/psql: common.c (r1.114 -> r1.115) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/common.c.diff?r1=1.114&r2=1.115) common.h (r1.46 -> r1.47) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/common.h.diff?r1=1.46&r2=1.47) psqlscan.l (r1.16 -> r1.17) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/psqlscan.l.diff?r1=1.16&r2=1.17) pgsql/src/include/utils: guc.h (r1.65 -> r1.66) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc.h.diff?r1=1.65&r2=1.66) pgsql/src/interfaces/ecpg/preproc: pgc.l (r1.144 -> r1.145) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/preproc/pgc.l.diff?r1=1.144&r2=1.145) pgsql/src/test/regress/expected: strings.out (r1.26 -> r1.27) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/strings.out.diff?r1=1.26&r2=1.27) pgsql/src/test/regress/sql: strings.sql (r1.17 -> r1.18) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/strings.sql.diff?r1=1.17&r2=1.18) ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[COMMITTERS] pgsql: Attached is the new patch.
Log Message: --- Attached is the new patch. To summarize: - new function justify_interval(interval) - modified function justify_hours(interval) - modified function justify_days(interval) These functions are defined to meet the requirements as discussed in this thread. Specifically: - justify_hours makes certain the sign bit on the hours matches the sign bit on the days. It only checks the sign bit on the days, and not the months, when determining if the hours should be positive or negative. After the call, -24 < hours < 24. - justify_days makes certain the sign bit on the days matches the sign bit on the months. It's behavior does not depend on the hours, nor does it modify the hours. After the call, -30 < days < 30. - justify_interval makes sure the sign bits on all three fields months, days, and hours are all the same. After the call, -24 < hours < 24 AND -30 < days < 30. Mark Dilger Modified Files: -- pgsql/doc/src/sgml: func.sgml (r1.309 -> r1.310) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml.diff?r1=1.309&r2=1.310) pgsql/src/backend/utils/adt: timestamp.c (r1.161 -> r1.162) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/timestamp.c.diff?r1=1.161&r2=1.162) pgsql/src/include/catalog: catversion.h (r1.318 -> r1.319) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h.diff?r1=1.318&r2=1.319) pg_proc.h (r1.400 -> r1.401) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h.diff?r1=1.400&r2=1.401) pgsql/src/include/utils: timestamp.h (r1.58 -> r1.59) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/timestamp.h.diff?r1=1.58&r2=1.59) pgsql/src/test/regress/expected: interval.out (r1.14 -> r1.15) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/interval.out.diff?r1=1.14&r2=1.15) pgsql/src/test/regress/sql: interval.sql (r1.8 -> r1.9) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/interval.sql.diff?r1=1.8&r2=1.9) ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
[COMMITTERS] pgsql: Done though the second is default so off in 8.2: > * -Eventually
Log Message: --- Done though the second is default so off in 8.2: > * -Eventually enable escape_string_warning and standard_conforming_strings Modified Files: -- pgsql/doc: TODO (r1.1787 -> r1.1788) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.diff?r1=1.1787&r2=1.1788) pgsql/doc/src/FAQ: TODO.html (r1.291 -> r1.292) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/FAQ/TODO.html.diff?r1=1.291&r2=1.292) ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
[COMMITTERS] pgsql: Default to ON for 8.2, as announced in the release notes:
Log Message: --- Default to ON for 8.2, as announced in the release notes: escape_string_warning = on Modified Files: -- pgsql/src/backend/utils/misc: postgresql.conf.sample (r1.174 -> r1.175) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/postgresql.conf.sample.diff?r1=1.174&r2=1.175) ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[COMMITTERS] pgsql: SGML typo fix.
Log Message: --- SGML typo fix. Modified Files: -- pgsql/doc/src/sgml: func.sgml (r1.310 -> r1.311) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml.diff?r1=1.310&r2=1.311) ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [COMMITTERS] pgsql: Default to ON for 8.2, as announced in the release notes:
[EMAIL PROTECTED] (Bruce Momjian) writes: > Log Message: > --- > Default to ON for 8.2, as announced in the release notes: > escape_string_warning = on Please fix the ensuing buildfarm breakage. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [COMMITTERS] pgsql: * Stephen Frost ([EMAIL PROTECTED]) wrote: > I've now tested
[EMAIL PROTECTED] (Bruce Momjian) writes: > Log Message: > --- > * Stephen Frost ([EMAIL PROTECTED]) wrote: >> I've now tested this patch at home w/ 8.2HEAD and it seems to fix the >> bug. I plan on testing it under 8.1.2 at work tommorow with >> mod_auth_krb5, etc, and expect it'll work there. Assuming all goes >> well and unless someone objects I'll forward the patch to -patches. >> It'd be great to have this fixed as it'll allow us to use Kerberos to >> authenticate to phppgadmin and other web-based tools which use >> Postgres. > While playing with this patch under 8.1.2 at home I discovered a > mistake in how I manually applied one of the hunks to fe-auth.c. > Basically, the base code had changed and so the patch needed to be > modified slightly. This is because the code no longer either has a > freeable pointer under 'name' or has 'name' as NULL. > The attached patch correctly frees the string from pg_krb5_authname > (where it had been strdup'd) if and only if pg_krb5_authname returned > a string (as opposed to falling through and having name be set using > name = pw->name;). Also added a comment to this effect. Bruce, people would appreciate it if you made some effort to ensure that commit messages describe the main purposes of the patch, rather than being just the verbatim text of the last message in the thread. The above log message is not merely overly verbose, but completely useless. One might guess that the change had something to do with Kerberos, but what? regards, tom lane ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [COMMITTERS] pgsql: Default to ON for 8.2, as announced in the release notes:
[EMAIL PROTECTED] (Bruce Momjian) writes: > Log Message: > --- > Default to ON for 8.2, as announced in the release notes: > escape_string_warning = on > Modified Files: > -- > pgsql/src/backend/utils/misc: > postgresql.conf.sample (r1.174 -> r1.175) > > (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/postgresql.conf.sample.diff?r1=1.174&r2=1.175) BTW, I can't help noticing that this commit failed to touch either guc.c or any documentation. What's more, the change to the sample file is wrong. Please do it properly. regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend
[COMMITTERS] pgsql: 'make clean' should NOT remove *~ files.
Log Message: --- 'make clean' should NOT remove *~ files. Modified Files: -- pgsql/src/interfaces/ecpg/preproc: Makefile (r1.119 -> r1.120) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/preproc/Makefile.diff?r1=1.119&r2=1.120) ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
[COMMITTERS] pgsql: Remove the stub support we had for UNION JOIN; per discussion,
Log Message: --- Remove the stub support we had for UNION JOIN; per discussion, this is not likely ever to be implemented seeing it's been removed from SQL2003. This allows getting rid of the 'filter' version of yylex() that we had in parser.c, which should save at least a few microseconds in parsing. Modified Files: -- pgsql/src/backend/optimizer/path: clausesel.c (r1.78 -> r1.79) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/clausesel.c.diff?r1=1.78&r2=1.79) pgsql/src/backend/optimizer/plan: initsplan.c (r1.115 -> r1.116) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/initsplan.c.diff?r1=1.115&r2=1.116) pgsql/src/backend/optimizer/prep: prepjointree.c (r1.36 -> r1.37) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/prep/prepjointree.c.diff?r1=1.36&r2=1.37) pgsql/src/backend/parser: gram.y (r2.533 -> r2.534) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/gram.y.diff?r1=2.533&r2=2.534) Makefile (r1.42 -> r1.43) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/Makefile.diff?r1=1.42&r2=1.43) parser.c (r1.64 -> r1.65) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parser.c.diff?r1=1.64&r2=1.65) scan.l (r1.131 -> r1.132) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/scan.l.diff?r1=1.131&r2=1.132) pgsql/src/backend/utils/adt: ruleutils.c (r1.213 -> r1.214) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c.diff?r1=1.213&r2=1.214) pgsql/src/include/nodes: nodes.h (r1.183 -> r1.184) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/nodes.h.diff?r1=1.183&r2=1.184) pgsql/src/include/parser: gramparse.h (r1.32 -> r1.33) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/parser/gramparse.h.diff?r1=1.32&r2=1.33) pgsql/src/test/regress/expected: join.out (r1.25 -> r1.26) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out.diff?r1=1.25&r2=1.26) join_1.out (r1.6 -> r1.7) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join_1.out.diff?r1=1.6&r2=1.7) pgsql/src/test/regress/sql: join.sql (r1.17 -> r1.18) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql.diff?r1=1.17&r2=1.18) pgsql/src/interfaces/ecpg/preproc: preproc.y (r1.320 -> r1.321) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/preproc/preproc.y.diff?r1=1.320&r2=1.321) ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[COMMITTERS] pgsql: Make all our flex and bison files use %option prefix or
Log Message: --- Make all our flex and bison files use %option prefix or %name-prefix (respectively) to rename yylex and related symbols. Some were doing it this way already, while others used not-too-reliable sed hacks in the Makefiles. It's all nice and consistent now. Modified Files: -- pgsql/contrib/cube: cubeparse.y (r1.14 -> r1.15) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/cubeparse.y.diff?r1=1.14&r2=1.15) Makefile (r1.16 -> r1.17) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/Makefile.diff?r1=1.16&r2=1.17) pgsql/contrib/seg: Makefile (r1.15 -> r1.16) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/seg/Makefile.diff?r1=1.15&r2=1.16) segparse.y (r1.15 -> r1.16) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/seg/segparse.y.diff?r1=1.15&r2=1.16) pgsql/src/backend/bootstrap: bootparse.y (r1.79 -> r1.80) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootparse.y.diff?r1=1.79&r2=1.80) bootscanner.l (r1.41 -> r1.42) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootscanner.l.diff?r1=1.41&r2=1.42) bootstrap.c (r1.212 -> r1.213) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootstrap.c.diff?r1=1.212&r2=1.213) Makefile (r1.33 -> r1.34) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/Makefile.diff?r1=1.33&r2=1.34) pgsql/src/backend/utils/misc: guc-file.l (r1.36 -> r1.37) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc-file.l.diff?r1=1.36&r2=1.37) Makefile (r1.24 -> r1.25) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/Makefile.diff?r1=1.24&r2=1.25) pgsql/src/include/bootstrap: bootstrap.h (r1.40 -> r1.41) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/bootstrap/bootstrap.h.diff?r1=1.40&r2=1.41) pgsql/src/pl/plpgsql/src: gram.y (r1.85 -> r1.86) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/gram.y.diff?r1=1.85&r2=1.86) Makefile (r1.28 -> r1.29) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/Makefile.diff?r1=1.28&r2=1.29) pl_comp.c (r1.98 -> r1.99) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_comp.c.diff?r1=1.98&r2=1.99) plpgsql.h (r1.67 -> r1.68) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/plpgsql.h.diff?r1=1.67&r2=1.68) scan.l (r1.43 -> r1.44) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/scan.l.diff?r1=1.43&r2=1.44) ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [COMMITTERS] pgsql: * Stephen Frost ([EMAIL PROTECTED]) wrote:
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Log Message: > > --- > > * Stephen Frost ([EMAIL PROTECTED]) wrote: > >> I've now tested this patch at home w/ 8.2HEAD and it seems to fix the > >> bug. I plan on testing it under 8.1.2 at work tommorow with > >> mod_auth_krb5, etc, and expect it'll work there. Assuming all goes > >> well and unless someone objects I'll forward the patch to -patches. > >> It'd be great to have this fixed as it'll allow us to use Kerberos to > >> authenticate to phppgadmin and other web-based tools which use > >> Postgres. > > > While playing with this patch under 8.1.2 at home I discovered a > > mistake in how I manually applied one of the hunks to fe-auth.c. > > Basically, the base code had changed and so the patch needed to be > > modified slightly. This is because the code no longer either has a > > freeable pointer under 'name' or has 'name' as NULL. > > > The attached patch correctly frees the string from pg_krb5_authname > > (where it had been strdup'd) if and only if pg_krb5_authname returned > > a string (as opposed to falling through and having name be set using > > name = pw->name;). Also added a comment to this effect. > > Bruce, people would appreciate it if you made some effort to ensure > that commit messages describe the main purposes of the patch, rather > than being just the verbatim text of the last message in the thread. > The above log message is not merely overly verbose, but completely > useless. One might guess that the change had something to do with > Kerberos, but what? First I am hearing a complaint. I will try to clean them up. -- Bruce Momjian http://candle.pha.pa.us SRA OSS, Inc. http://www.sraoss.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[COMMITTERS] pgsql: Properly set "escape_string_warning" to default to true.
Log Message: --- Properly set "escape_string_warning" to default to true. Modified Files: -- pgsql/doc/src/sgml: config.sgml (r1.50 -> r1.51) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml.diff?r1=1.50&r2=1.51) pgsql/src/backend/utils/misc: guc.c (r1.313 -> r1.314) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.313&r2=1.314) ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [COMMITTERS] pgsql: Default to ON for 8.2, as announced in the release
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Log Message: > > --- > > Default to ON for 8.2, as announced in the release notes: > > escape_string_warning = on > > > Modified Files: > > -- > > pgsql/src/backend/utils/misc: > > postgresql.conf.sample (r1.174 -> r1.175) > > > > (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/postgresql.conf.sample.diff?r1=1.174&r2=1.175) > > BTW, I can't help noticing that this commit failed to touch either guc.c > or any documentation. What's more, the change to the sample file is > wrong. Please do it properly. Docs and guc.c updated. -- Bruce Momjian http://candle.pha.pa.us SRA OSS, Inc. http://www.sraoss.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[COMMITTERS] pgsql: Back out comment update about sighup, original was accurate.
Log Message: --- Back out comment update about sighup, original was accurate. Modified Files: -- pgsql/src/include/utils: guc.h (r1.66 -> r1.67) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc.h.diff?r1=1.66&r2=1.67) ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
[COMMITTERS] pgsql: Use SetConfigOption() to turn off "zero_damaged_pages" in
Log Message: --- Use SetConfigOption() to turn off "zero_damaged_pages" in autovacuum. Modified Files: -- pgsql/src/backend/postmaster: autovacuum.c (r1.13 -> r1.14) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/autovacuum.c.diff?r1=1.13&r2=1.14) ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [COMMITTERS] pgsql: * Stephen Frost ([EMAIL PROTECTED]) wrote:
Bruce Momjian wrote: Bruce, people would appreciate it if you made some effort to ensure that commit messages describe the main purposes of the patch, rather than being just the verbatim text of the last message in the thread. The above log message is not merely overly verbose, but completely useless. One might guess that the change had something to do with Kerberos, but what? First I am hearing a complaint. I will try to clean them up. Well, not everyone is as assertive as Tom :-) One other thing: it's important that the first words in your commit mesage summarise the contents of the commit, because that's what gets put in the subject line of the committers email message. Recent examples can be seen here: http://archives.postgresql.org/pgsql-committers/2006-03/index.php I don't read every committers message, and the subject lines can help me filter them intelligently. cheers andrew ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [COMMITTERS] pgsql: * Stephen Frost ([EMAIL PROTECTED]) wrote:
OK. --- Andrew Dunstan wrote: > Bruce Momjian wrote: > > >>Bruce, people would appreciate it if you made some effort to ensure > >>that commit messages describe the main purposes of the patch, rather > >>than being just the verbatim text of the last message in the thread. > >>The above log message is not merely overly verbose, but completely > >>useless. One might guess that the change had something to do with > >>Kerberos, but what? > >> > >> > > > >First I am hearing a complaint. I will try to clean them up. > > > > > > > > Well, not everyone is as assertive as Tom :-) > > One other thing: it's important that the first words in your commit > mesage summarise the contents of the commit, because that's what gets > put in the subject line of the committers email message. Recent examples > can be seen here: > http://archives.postgresql.org/pgsql-committers/2006-03/index.php > > I don't read every committers message, and the subject lines can help me > filter them intelligently. > > cheers > > andrew > -- Bruce Momjian http://candle.pha.pa.us SRA OSS, Inc. http://www.sraoss.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [COMMITTERS] pgsql: * Stephen Frost ([EMAIL PROTECTED]) wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes: > One other thing: it's important that the first words in your commit > mesage summarise the contents of the commit, because that's what gets > put in the subject line of the committers email message. One thing I've been a bit mystified by is the effect of punctuation on the email subjects. I do compose my commit messages with some thought to what the subject will look like, but I got burnt recently here: http://archives.postgresql.org/pgsql-committers/2006-03/msg00056.php where the subject got truncated at a period. It seems to sometimes truncate at punctuation and sometimes not --- there are plenty of other examples where periods don't end the subject. Does anyone know the exact rules the message-bot is using? regards, tom lane ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
