[COMMITTERS] pgsql: Fix obscure segfault condition in PL/Python In PLy_output(),

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Fix obscure segfault condition in PL/Python

In PLy_output(), when the elog() call in the TRY branch throws an exception
(this can happen when a statement timeout kicks in, for example), the
PyErr_SetString() call in the CATCH branch can cause a segfault, because the
Py_XDECREF(so) call before it releases memory that is still used by the sv
variable that PyErr_SetString() uses as argument, because sv points into
memory owned by so.

Backpatched back to 8.0, where this code was introduced.

I also threw in a couple of volatile declarations for variables that are used
before and after the TRY.  I don't think they caused the crash that I
observed, but they could become issues.

Tags:

REL8_1_STABLE

Modified Files:
--
pgsql/src/pl/plpython:
plpython.c (r1.66.2.6 -> r1.66.2.7)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.66.2.6&r2=1.66.2.7)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix obscure segfault condition in PL/Python In PLy_output(),

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Fix obscure segfault condition in PL/Python

In PLy_output(), when the elog() call in the TRY branch throws an exception
(this can happen when a statement timeout kicks in, for example), the
PyErr_SetString() call in the CATCH branch can cause a segfault, because the
Py_XDECREF(so) call before it releases memory that is still used by the sv
variable that PyErr_SetString() uses as argument, because sv points into
memory owned by so.

Backpatched back to 8.0, where this code was introduced.

I also threw in a couple of volatile declarations for variables that are used
before and after the TRY.  I don't think they caused the crash that I
observed, but they could become issues.

Tags:

REL8_2_STABLE

Modified Files:
--
pgsql/src/pl/plpython:
plpython.c (r1.90.2.4 -> r1.90.2.5)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.90.2.4&r2=1.90.2.5)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix obscure segfault condition in PL/Python In PLy_output(),

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Fix obscure segfault condition in PL/Python

In PLy_output(), when the elog() call in the TRY branch throws an exception
(this can happen when a statement timeout kicks in, for example), the
PyErr_SetString() call in the CATCH branch can cause a segfault, because the
Py_XDECREF(so) call before it releases memory that is still used by the sv
variable that PyErr_SetString() uses as argument, because sv points into
memory owned by so.

Backpatched back to 8.0, where this code was introduced.

I also threw in a couple of volatile declarations for variables that are used
before and after the TRY.  I don't think they caused the crash that I
observed, but they could become issues.

Tags:

REL8_3_STABLE

Modified Files:
--
pgsql/src/pl/plpython:
plpython.c (r1.106 -> r1.106.2.1)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.106&r2=1.106.2.1)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix obscure segfault condition in PL/Python In PLy_output(),

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Fix obscure segfault condition in PL/Python

In PLy_output(), when the elog() call in the TRY branch throws an exception
(this can happen when a statement timeout kicks in, for example), the
PyErr_SetString() call in the CATCH branch can cause a segfault, because the
Py_XDECREF(so) call before it releases memory that is still used by the sv
variable that PyErr_SetString() uses as argument, because sv points into
memory owned by so.

Backpatched back to 8.0, where this code was introduced.

I also threw in a couple of volatile declarations for variables that are used
before and after the TRY.  I don't think they caused the crash that I
observed, but they could become issues.

Tags:

REL8_4_STABLE

Modified Files:
--
pgsql/src/pl/plpython:
plpython.c (r1.122 -> r1.122.2.1)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.122&r2=1.122.2.1)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix obscure segfault condition in PL/Python In PLy_output(),

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Fix obscure segfault condition in PL/Python

In PLy_output(), when the elog() call in the TRY branch throws an exception
(this can happen when a statement timeout kicks in, for example), the
PyErr_SetString() call in the CATCH branch can cause a segfault, because the
Py_XDECREF(so) call before it releases memory that is still used by the sv
variable that PyErr_SetString() uses as argument, because sv points into
memory owned by so.

Backpatched back to 8.0, where this code was introduced.

I also threw in a couple of volatile declarations for variables that are used
before and after the TRY.  I don't think they caused the crash that I
observed, but they could become issues.

Modified Files:
--
pgsql/src/pl/plpython:
plpython.c (r1.130 -> r1.131)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.130&r2=1.131)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: In psql, show view definition only with \d+, not with \d The

2009-11-03 Thread Peter Eisentraut
Log Message:
---
In psql, show view definition only with \d+, not with \d

The rationale is that view definitions tend to be long and obscure the
main information about the view.

Modified Files:
--
pgsql/src/bin/psql:
describe.c (r1.229 -> r1.230)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.c?r1=1.229&r2=1.230)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve PL/Python elog output When the elog functions (plpy.info

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Improve PL/Python elog output

When the elog functions (plpy.info etc.) get a single argument, just print
that argument instead of printing the single-member tuple like ('foo',).

Modified Files:
--
pgsql/src/pl/plpython:
plpython.c (r1.131 -> r1.132)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.131&r2=1.132)
pgsql/src/pl/plpython/expected:
plpython_import.out (r1.2 -> r1.3)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/expected/plpython_import.out?r1=1.2&r2=1.3)
plpython_spi.out (r1.3 -> r1.4)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/expected/plpython_spi.out?r1=1.3&r2=1.4)
plpython_test.out (r1.12 -> r1.13)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/expected/plpython_test.out?r1=1.12&r2=1.13)
plpython_trigger.out (r1.5 -> r1.6)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/expected/plpython_trigger.out?r1=1.5&r2=1.6)
pgsql/src/pl/plpython/sql:
plpython_test.sql (r1.8 -> r1.9)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/sql/plpython_test.sql?r1=1.8&r2=1.9)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: In psql, show view definition only with \d+, not with \d The

2009-11-03 Thread Tom Lane
[email protected] (Peter Eisentraut) writes:
> In psql, show view definition only with \d+, not with \d

This broke the regression tests.

regards, tom lane

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix regression tests for psql \d view patch

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Fix regression tests for psql \d view patch

Modified Files:
--
pgsql/src/test/regress/expected:
polymorphism.out (r1.21 -> r1.22)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/polymorphism.out?r1=1.21&r2=1.22)
pgsql/src/test/regress/sql:
polymorphism.sql (r1.12 -> r1.13)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/polymorphism.sql?r1=1.12&r2=1.13)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Build bzip2 tarball in dist target as well

2009-11-03 Thread Peter Eisentraut
Log Message:
---
Build bzip2 tarball in dist target as well

Modified Files:
--
pgsql:
GNUmakefile.in (r1.54 -> r1.55)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/GNUmakefile.in?r1=1.54&r2=1.55)
pgsql/src:
Makefile.global.in (r1.258 -> r1.259)

(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.global.in?r1=1.258&r2=1.259)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pllolcode - pllolcode: Add support for PostgreSQL 8.5's INLINE functions

2009-11-03 Thread User Eggyknap
Log Message:
---
Add support for PostgreSQL 8.5's INLINE functions

Modified Files:
--
pllolcode:
DOC (r1.32 -> r1.33)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pllolcode/pllolcode/DOC?r1=1.32&r2=1.33)
pllolcode.c (r1.32 -> r1.33)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pllolcode/pllolcode/pllolcode.c?r1=1.32&r2=1.33)
testFuncs.sql (r1.9 -> r1.10)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pllolcode/pllolcode/testFuncs.sql?r1=1.9&r2=1.10)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers