[COMMITTERS] pgsql: Fix the size of predicate lock manager's shared memory hash tabl

2011-04-11 Thread Heikki Linnakangas
Fix the size of predicate lock manager's shared memory hash tables at creation.

This way they don't compete with the regular lock manager for the slack shared
memory, making the behavior more predictable.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/7c797e7194d969f974abf579cacf30ffdccdbb95

Modified Files
--
src/backend/storage/lmgr/predicate.c |   22 +-
src/backend/utils/hash/dynahash.c|6 ++
src/include/utils/hsearch.h  |1 +
3 files changed, 16 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: TransferPredicateLocksToNewTarget should initialize a new lock

2011-04-11 Thread Heikki Linnakangas
TransferPredicateLocksToNewTarget should initialize a new lock
entry's commitSeqNo to that of the old one being transferred, or take
the minimum commitSeqNo if it is merging two lock entries.

Also, CreatePredicateLock should initialize commitSeqNo for to
InvalidSerCommitSeqNo instead of to 0. (I don't think using 0 would
actually affect anything, but we should be consistent.)

I also added a couple of assertions I used to track this down: a
lock's commitSeqNo should never be zero, and it should be
InvalidSerCommitSeqNo if and only if the lock is not held by
OldCommittedSxact.

Dan Ports, to fix leak of predicate locks reported by YAMAMOTO Takashi.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/dad1f4638235e5ff5696b948b88ba24cd99b415e

Modified Files
--
src/backend/storage/lmgr/predicate.c |   18 --
1 files changed, 16 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Teach pattern_fixed_prefix() about collations.

2011-04-11 Thread Tom Lane
Teach pattern_fixed_prefix() about collations.

This is necessary, not optional, now that ILIKE and regexes are collation
aware --- else we might derive a wrong comparison constant for index
optimized pattern matches.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3c381a55b0fa1c4ca328211e39df8e1a715129cb

Modified Files
--
src/backend/optimizer/path/indxpath.c |   34 +
src/backend/utils/adt/selfuncs.c  |  137 +++--
src/include/utils/selfuncs.h  |1 +
3 files changed, 117 insertions(+), 55 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] libpqtypes - libpqtypes: added PQclearTypes, PQclearSpecs, PQinitTypes,

2011-04-11 Thread User Achernow
Log Message:
---
added PQclearTypes, PQclearSpecs, PQinitTypes, deprecated PQtypesRegister, 
added SO version info to Makefile.am, bunped version to 1.5.0, and removed 
automatic re-registration of types during a PQresetXXX

Modified Files:
--
libpqtypes:
ChangeLog (r1.56 -> r1.57)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/ChangeLog?r1=1.56&r2=1.57)
Makefile.am (r1.20 -> r1.21)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/Makefile.am?r1=1.20&r2=1.21)
configure.ac (r1.26 -> r1.27)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/configure.ac?r1=1.26&r2=1.27)
libpqtypes/docs/man3:
PQregisterTypes.3 (r1.1 -> r1.2)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQregisterTypes.3?r1=1.1&r2=1.2)
PQspecPrepare.3 (r1.12 -> r1.13)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQspecPrepare.3?r1=1.12&r2=1.13)
PQtypesRegister.3 (r1.4 -> r1.5)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQtypesRegister.3?r1=1.4&r2=1.5)
libpqtypes/src:
events.c (r1.14 -> r1.15)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/events.c?r1=1.14&r2=1.15)
handler.c (r1.24 -> r1.25)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/handler.c?r1=1.24&r2=1.25)
libpqtypes-int.h (r1.20 -> r1.21)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/libpqtypes-int.h?r1=1.20&r2=1.21)
libpqtypes.h (r1.33 -> r1.34)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/libpqtypes.h?r1=1.33&r2=1.34)
regression-test.c (r1.26 -> r1.27)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/regression-test.c?r1=1.26&r2=1.27)
spec.c (r1.7 -> r1.8)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/spec.c?r1=1.7&r2=1.8)

Added Files:
---
libpqtypes/docs/man3:
PQclearSpecs.3 (r1.1)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQclearSpecs.3?rev=1.1&content-type=text/x-cvsweb-markup)
PQclearTypes.3 (r1.1)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQclearTypes.3?rev=1.1&content-type=text/x-cvsweb-markup)
PQinitTypes.3 (r1.1)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQinitTypes.3?rev=1.1&content-type=text/x-cvsweb-markup)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] libpqtypes - libpqtypes: removed expandRegisterTypes, changed return

2011-04-11 Thread User Achernow
Log Message:
---
removed expandRegisterTypes, changed return type of pqt_cleartypes to void, 
passed -avoid-version and -no-undefined to linker in Makefile.am

Modified Files:
--
libpqtypes:
Makefile.am (r1.21 -> r1.22)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/Makefile.am?r1=1.21&r2=1.22)
libpqtypes/src:
events.c (r1.15 -> r1.16)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/events.c?r1=1.15&r2=1.16)
handler.c (r1.25 -> r1.26)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/handler.c?r1=1.25&r2=1.26)
libpqtypes-int.h (r1.21 -> r1.22)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/libpqtypes-int.h?r1=1.21&r2=1.22)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] libpqtypes - libpqtypes: updated PQclearTypes.3 to point at PQinitTypes

2011-04-11 Thread User Achernow
Log Message:
---
updated PQclearTypes.3 to point at PQinitTypes rather than PQregisterTypes man 
page

Modified Files:
--
libpqtypes/docs/man3:
PQclearTypes.3 (r1.1 -> r1.2)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/docs/man3/PQclearTypes.3?r1=1.1&r2=1.2)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Clean up most -Wunused-but-set-variable warnings from gcc 4.6

2011-04-11 Thread Peter Eisentraut
Clean up most -Wunused-but-set-variable warnings from gcc 4.6

This warning is new in gcc 4.6 and part of -Wall.  This patch cleans
up most of the noise, but there are some still warnings that are
trickier to remove.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5caa3479c2efd31fca1b271db687e5e57c7de2d4

Modified Files
--
contrib/isn/isn.c |   10 ++
contrib/pageinspect/fsmfuncs.c|2 -
contrib/pgcrypto/pgp-s2k.c|   12 ++--
contrib/pgcrypto/px-hmac.c|2 -
contrib/pgcrypto/px.c |6 +---
contrib/seg/seg.c |3 +-
src/backend/access/gist/gistvacuum.c  |5 ---
src/backend/access/nbtree/nbtpage.c   |3 +-
src/backend/catalog/pg_proc.c |4 --
src/backend/catalog/toasting.c|3 +-
src/backend/commands/explain.c|2 -
src/backend/commands/tablecmds.c  |2 -
src/backend/commands/tsearchcmds.c|4 +--
src/backend/commands/vacuum.c |6 +---
src/backend/executor/nodeHashjoin.c   |2 -
src/backend/executor/nodeMergejoin.c  |2 -
src/backend/executor/nodeRecursiveunion.c |7 +---
src/backend/foreign/foreign.c |3 --
src/backend/libpq/auth.c  |7 ++--
src/backend/optimizer/geqo/geqo_main.c|   11 --
src/backend/parser/parse_utilcmd.c|3 +-
src/backend/rewrite/rewriteDefine.c   |3 +-
src/backend/storage/ipc/standby.c |4 --
src/backend/storage/smgr/md.c |3 +-
src/backend/utils/adt/ri_triggers.c   |3 --
src/backend/utils/adt/selfuncs.c  |6 
src/bin/pg_dump/common.c  |   45 +---
src/bin/pg_dump/pg_backup_custom.c|3 +-
src/bin/pg_dump/pg_dump.c |   37 ++--
src/bin/pg_dump/pg_dumpall.c  |   12 ++--
src/bin/psql/psqlscan.l   |7 +---
src/interfaces/ecpg/ecpglib/descriptor.c  |   23 ++
src/interfaces/libpq/fe-auth.c|5 +--
src/pl/plpgsql/src/pl_exec.c  |2 -
34 files changed, 64 insertions(+), 188 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] libpqtypes - libpqtypes: updated changelog to reflect the correct

2011-04-11 Thread User Achernow
Log Message:
---
updated changelog to reflect the correct changes made to Makefile.am

Modified Files:
--
libpqtypes:
ChangeLog (r1.57 -> r1.58)

(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/ChangeLog?r1=1.57&r2=1.58)

-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix RI_Initial_Check to use a COLLATE clause when needed in its

2011-04-11 Thread Tom Lane
Fix RI_Initial_Check to use a COLLATE clause when needed in its query.

If the referencing and referenced columns have different collations,
the parser will be unable to resolve which collation to use unless it's
helped out in this way.  The effects are sometimes masked, if we end up
using a non-collation-sensitive plan; but if we do use a mergejoin
we'll see a failure, as recently noted by Robert Haas.

The SQL spec states that the referenced column's collation should be used
to resolve RI checks, so that's what we do.  Note however that we currently
don't append a COLLATE clause when writing a query that examines only the
referencing column.  If we ever support collations that have varying
notions of equality, that will have to be changed.  For the moment, though,
it's preferable to leave it off so that we can use a normal index on the
referencing column.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/921b993677e165607029a52e7f866bbd112345a5

Modified Files
--
src/backend/parser/parse_relation.c   |   18 ++
src/backend/utils/adt/ri_triggers.c   |   57 +
src/include/parser/parse_relation.h   |1 +
src/test/regress/expected/collate.out |   29 -
src/test/regress/sql/collate.sql  |   24 ++
5 files changed, 128 insertions(+), 1 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Be more wary of missing statistics in eqjoinsel_semi().

2011-04-11 Thread Tom Lane
Be more wary of missing statistics in eqjoinsel_semi().

In particular, if we don't have real ndistinct estimates for both sides,
fall back to assuming that half of the left-hand rows have join partners.
This is what was done in 8.2 and 8.3 (cf nulltestsel() in those versions).
It's pretty stupid but it won't lead us to think that an antijoin produces
no rows out, as seen in recent example from Uwe Schroeder.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3f5d2fe3029b181fe773a02f1d4b34624c357634

Modified Files
--
src/backend/utils/adt/selfuncs.c |   49 -
1 files changed, 32 insertions(+), 17 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Be more wary of missing statistics in eqjoinsel_semi().

2011-04-11 Thread Tom Lane
Be more wary of missing statistics in eqjoinsel_semi().

In particular, if we don't have real ndistinct estimates for both sides,
fall back to assuming that half of the left-hand rows have join partners.
This is what was done in 8.2 and 8.3 (cf nulltestsel() in those versions).
It's pretty stupid but it won't lead us to think that an antijoin produces
no rows out, as seen in recent example from Uwe Schroeder.

Branch
--
REL9_0_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/159c47dc7170110a39f8a16b1d0b7811f5556f87

Modified Files
--
src/backend/utils/adt/selfuncs.c |   49 -
1 files changed, 32 insertions(+), 17 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Be more wary of missing statistics in eqjoinsel_semi().

2011-04-11 Thread Tom Lane
Be more wary of missing statistics in eqjoinsel_semi().

In particular, if we don't have real ndistinct estimates for both sides,
fall back to assuming that half of the left-hand rows have join partners.
This is what was done in 8.2 and 8.3 (cf nulltestsel() in those versions).
It's pretty stupid but it won't lead us to think that an antijoin produces
no rows out, as seen in recent example from Uwe Schroeder.

Branch
--
REL8_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/0ae8b300388c2a3eaf90e6e6f13d6be1f4d4ac2d

Modified Files
--
src/backend/utils/adt/selfuncs.c |   49 -
1 files changed, 32 insertions(+), 17 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Suppress compiler warnings about "value computed is not used".

2011-04-11 Thread Tom Lane
Suppress compiler warnings about "value computed is not used".

The recent patch to remove gcc 4.6 warnings created some new ones, at
least on my rather old gcc version.  Try to make everybody happy by
casting to "void" when we just want to discard the result.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/88543ecfec9c754b5f14b898bccbc68d941748b3

Modified Files
--
src/interfaces/ecpg/ecpglib/descriptor.c |   16 
1 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers