[COMMITTERS] pgsql: PublishStartupProcessInformation() to avoid rare hang in recover
PublishStartupProcessInformation() to avoid rare hang in recovery. Bgwriter could cause hang in recovery during page concurrent cleaning. Bug report and testing by Bernd Helmle, fix by me Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7c24bac64c3828d651abfd5e34bd0e0031ab9946 Modified Files -- src/backend/access/transam/xlog.c |2 + src/backend/storage/lmgr/proc.c | 43 - src/include/storage/proc.h|6 + 3 files changed, 50 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Buffering GiST index build algorithm.
Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random I/O that would otherwise be needed to traverse all the way down the tree to the find right leaf page for tuple. Alexander Korotkov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5edb24a8983e4a103e26153853d91141f818227c Modified Files -- doc/src/sgml/gist.sgml | 34 + doc/src/sgml/ref/create_index.sgml | 20 + src/backend/access/common/reloptions.c | 11 + src/backend/access/gist/Makefile |2 +- src/backend/access/gist/README | 135 src/backend/access/gist/gist.c | 211 +- src/backend/access/gist/gistbuild.c| 1068 src/backend/access/gist/gistbuildbuffers.c | 787 src/backend/access/gist/gistutil.c | 27 +- src/backend/access/gist/gistxlog.c |6 +- src/include/access/gist_private.h | 182 +- 11 files changed, 2297 insertions(+), 186 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.
On 8 September 2011 15:56, Heikki Linnakangas wrote: > Buffering GiST index build algorithm. > > When building a GiST index that doesn't fit in cache, buffers are attached > to some internal nodes in the index. This speeds up the build by avoiding > random I/O that would otherwise be needed to traverse all the way down the > tree to the find right leaf page for tuple. Sorry Heikki... s/additionaly/additionally/ -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo and reword the sentence.
Fix typo and reword the sentence. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/86ab71d58d4ee7e183e501db75714ad59feef8a5 Modified Files -- doc/src/sgml/ref/create_index.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.
On 08.09.2011 18:04, Thom Brown wrote: On 8 September 2011 15:56, Heikki Linnakangas wrote: Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random I/O that would otherwise be needed to traverse all the way down the tree to the find right leaf page for tuple. Sorry Heikki... s/additionaly/additionally/ Sigh, fixed. I also reworded the sentence a bit. Thanks once again, Thom. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Add missing format argument to ecpg_log() call Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/33e111f2258af78f8816dae2eef49c371b94da77 Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Add missing format argument to ecpg_log() call Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ba24de13f6b4a1a2ceb6230840330e4192312e09 Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Add missing format argument to ecpg_log() call Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cf15fb5cabfbc71e07be23cfbc813daee6c5014f Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Add missing format argument to ecpg_log() call Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c10d1de4191710cf459873a373e54ffd4e49acb3 Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Add missing format argument to ecpg_log() call Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ba7ef09a3bb49e38fda0b872bf85e46421c251d3 Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Add missing format argument to ecpg_log() call Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7f7ed1716dea32ebe1f504c16538a175a075c758 Modified Files -- src/interfaces/ecpg/ecpglib/execute.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add missing format argument to ecpg_log() call
Peter Eisentraut writes: > Add missing format argument to ecpg_log() call Oh, fun. So why isn't there an __attribute__((format...)) decoration on ecpg_log()? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Tweak string for uniformity
Tweak string for uniformity Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/295e7dc929c346d53e0b55aaed539b0b0d59059f Modified Files -- src/backend/replication/basebackup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.
On 09/08/2011 10:56 AM, Heikki Linnakangas wrote: Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random I/O that would otherwise be needed to traverse all the way down the tree to the find right leaf page for tuple. This seems to have broken MSVC builds: "C:\prog\bf\root\HEAD\pgsql.5584\pgsql.sln" (default target) (1) -> (postgres target) -> .\src\backend\access\gist\gistbuild.c(423): warning C4013: 'round' undefined; assuming extern returning int "C:\prog\bf\root\HEAD\pgsql.5584\pgsql.sln" (default target) (1) -> (postgres target) -> gistbuild.obj : error LNK2019: unresolved external symbol round referenced in function calculatePagesPerBuffer .\Debug\postgres\postgres.exe : fatal error LNK1120: 1 unresolved externals Maybe we need to include math.h. And while we're about it, should the result of round() be cast to an int, since that's what the function returns? cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Translation updates for 9.1.0
Translation updates for 9.1.0 Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/bd6db68f714d8e4609c0b22425590ab632a14812 Modified Files -- src/backend/nls.mk |2 +- src/backend/po/de.po| 798 +- src/backend/po/es.po|19069 --- src/backend/po/fr.po| 7965 +- src/backend/po/pt_BR.po |26392 --- src/backend/po/tr.po|16230 --- src/bin/initdb/nls.mk |2 +- src/bin/initdb/po/cs.po | 380 +- src/bin/initdb/po/es.po | 306 +- src/bin/initdb/po/ja.po | 13 +- src/bin/initdb/po/pl.po | 875 + src/bin/initdb/po/pt_BR.po | 300 +- src/bin/initdb/po/ta.po | 782 - src/bin/initdb/po/tr.po | 329 +- src/bin/pg_basebackup/nls.mk|2 +- src/bin/pg_basebackup/po/cs.po | 384 + src/bin/pg_basebackup/po/es.po | 107 +- src/bin/pg_basebackup/po/fr.po | 118 +- src/bin/pg_basebackup/po/ja.po | 141 +- src/bin/pg_basebackup/po/pl.po | 380 + src/bin/pg_basebackup/po/pt_BR.po | 381 + src/bin/pg_config/nls.mk|2 +- src/bin/pg_config/po/cs.po | 321 + src/bin/pg_config/po/ja.po |4 +- src/bin/pg_config/po/pl.po | 303 + src/bin/pg_config/po/pt_BR.po |4 +- src/bin/pg_controldata/nls.mk |2 +- src/bin/pg_controldata/po/cs.po | 347 + src/bin/pg_controldata/po/ja.po |6 +- src/bin/pg_controldata/po/pl.po | 350 + src/bin/pg_controldata/po/pt_BR.po |8 +- src/bin/pg_controldata/po/sv.po | 279 - src/bin/pg_controldata/po/ta.po | 267 - src/bin/pg_controldata/po/tr.po | 54 +- src/bin/pg_ctl/nls.mk |2 +- src/bin/pg_ctl/po/cs.po | 836 + src/bin/pg_ctl/po/es.po | 56 +- src/bin/pg_ctl/po/it.po | 661 - src/bin/pg_ctl/po/ja.po |6 +- src/bin/pg_ctl/po/ko.po | 592 - src/bin/pg_ctl/po/pl.po | 791 + src/bin/pg_ctl/po/pt_BR.po | 404 +- src/bin/pg_ctl/po/sv.po | 636 - src/bin/pg_ctl/po/ta.po | 619 - src/bin/pg_ctl/po/tr.po | 448 +- src/bin/pg_ctl/po/zh_CN.po | 656 - src/bin/pg_dump/nls.mk |2 +- src/bin/pg_dump/po/cs.po| 2521 +++ src/bin/pg_dump/po/de.po| 428 +- src/bin/pg_dump/po/es.po| 1060 +- src/bin/pg_dump/po/fr.po| 492 +- src/bin/pg_dump/po/ja.po| 21 +- src/bin/pg_dump/po/pl.po| 2210 +++ src/bin/pg_dump/po/pt_BR.po | 1078 +- src/bin/pg_dump/po/tr.po| 1348 +- src/bin/pg_resetxlog/nls.mk |2 +- src/bin/pg_resetxlog/po/cs.po | 481 + src/bin/pg_resetxlog/po/ja.po |6 +- src/bin/pg_resetxlog/po/pl.po | 460 + src/bin/pg_resetxlog/po/pt_BR.po|4 +- src/bin/psql/nls.mk |2 +- src/bin/psql/po/cs.po | 4341 +++--- src/bin/psql/po/es.po | 2358 ++-- src/bin/psql/po/fr.po | 1780 ++-- src/bin/psql/po/ja.po | 865 +- src/bin/psql/po/pl.po | 4059 + src/bin/psql/po/pt_BR.po| 2296 ++-- src/bin/psql/po/sv.po | 5567 --- src/bin/psql/po/tr.po | 8052 ++ src/bin/scripts/nls.mk |2 +- src/bin/scripts/po/cs.po| 260 +- src/bin/scripts/po/pl.po| 925 ++ src/bin/scripts/po/pt_BR.po |4 +- src/interfaces/ecpg/ecpglib/nls.mk |2 +- src/interfaces/ecpg/ecpglib/po/cs.po| 174 + src/interfaces/ecpg/ecpglib/po/pl.po| 176 + src/interfaces/ecpg/ecpglib/po/pt_BR.po |4 +- src/interfaces/ecpg/preproc/nls.mk |2 +- src/interfaces/ecpg/preproc/po/cs.po| 624 + src/interfaces/ecpg/preproc/po/pl.po| 618 + src/interfaces/ecpg/preproc/po/pt_BR.po |4 +- src/interfaces/libpq/nls.mk |2 +- src/interfaces/libpq/po/cs.po | 531 +- src/interfaces/libpq/po/es.po | 210 +- src/interfaces/libpq/po/fr.po | 288 +- src/interfaces/libpq/po/pl.po | 923 ++ src/interfaces/libpq/po/pt_BR.po| 136 +- src/interfaces/libpq/po/ta.po | 794 - src/interfaces/libpq/po/tr.po | 482 +- src/pl/plperl/nls.mk|2 +- src/pl/plperl/po/cs.po | 191 + src/pl/plperl/po/es.po | 98 +- src/pl/plperl/po/it.po | 113 - src/pl/plperl/po/pl.po | 190 + src/pl/plperl/po/tr.po
Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.
On 09/08/2011 04:13 PM, Andrew Dunstan wrote: On 09/08/2011 10:56 AM, Heikki Linnakangas wrote: Buffering GiST index build algorithm. When building a GiST index that doesn't fit in cache, buffers are attached to some internal nodes in the index. This speeds up the build by avoiding random I/O that would otherwise be needed to traverse all the way down the tree to the find right leaf page for tuple. This seems to have broken MSVC builds: "C:\prog\bf\root\HEAD\pgsql.5584\pgsql.sln" (default target) (1) -> (postgres target) -> .\src\backend\access\gist\gistbuild.c(423): warning C4013: 'round' undefined; assuming extern returning int "C:\prog\bf\root\HEAD\pgsql.5584\pgsql.sln" (default target) (1) -> (postgres target) -> gistbuild.obj : error LNK2019: unresolved external symbol round referenced in function calculatePagesPerBuffer .\Debug\postgres\postgres.exe : fatal error LNK1120: 1 unresolved externals Maybe we need to include math.h. And while we're about it, should the result of round() be cast to an int, since that's what the function returns? Or use rint(), which we certainly have. cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: round() is not portable. Use rint().
round() is not portable. Use rint(). Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d63de337f3e235f02d79a1df79dddbb002e9fd4e Modified Files -- src/backend/access/gist/gistbuild.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.
Andrew Dunstan writes: >> Maybe we need to include math.h. And while we're about it, should the >> result of round() be cast to an int, since that's what the function >> returns? > Or use rint(), which we certainly have. Yeah, this broke the build on my old HPUX box too. I committed a quick fix using rint(), but on reflection I wonder if it shouldn't be ceil(). regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Stamp 9.1.0.
Stamp 9.1.0. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1f43001424a9da624a89b213d0be606a8212a50a Modified Files -- configure | 18 +- configure.in |2 +- doc/bug.template |2 +- src/include/pg_config.h.win32 |6 +++--- 4 files changed, 14 insertions(+), 14 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.
On 08.09.2011 23:44, Tom Lane wrote: Andrew Dunstan writes: Maybe we need to include math.h. And while we're about it, should the result of round() be cast to an int, since that's what the function returns? Or use rint(), which we certainly have. Yeah, this broke the build on my old HPUX box too. I committed a quick fix using rint(), Thanks! but on reflection I wonder if it shouldn't be ceil(). Doesn't really matter. The exact value of that parameter isn't critical to the algorithm, and it can't go down to 0. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
