[COMMITTERS] pgsql: Remove comment that was intended to have been removed before com

2015-01-08 Thread Andres Freund
Remove comment that was intended to have been removed before commit.

Noticed by Amit Kapila

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f454144a34c2288418292ae7b01495724cfda359

Modified Files
--
src/backend/storage/lmgr/lwlock.c |1 -
1 file changed, 1 deletion(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix logging of pages skipped due to pins during vacuum.

2015-01-08 Thread Andres Freund
Fix logging of pages skipped due to pins during vacuum.

The new logging introduced in 35192f06 made the incorrect assumption
that scan_all vacuums would always wait for buffer pins; but they only
do so if the page actually needs to be frozen.

Fix that inaccuracy by removing the difference in log output based on
scan_all and just always remove the same message.  I chose to keep the
split log message from the original commit for now, it seems likely
that it'll be of use in the future.

Also merge the line about buffer pins in autovacuum's log output into
the existing "pages: ..." line. It seems odd to have a separate line
about pins, without the "topic: " prefix others have.

Also rename the new 'pinned_pages' variable to 'pinskipped_pages'
because it actually tracks the number of pages that could *not* be
pinned.

Discussion: [email protected]

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/17eaae9897781c6dcc622b9327899329e4d2a4df

Modified Files
--
src/backend/commands/vacuumlazy.c |   32 
1 file changed, 8 insertions(+), 24 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Move comment about sun cc's __machine_rw_barrier being a full ba

2015-01-08 Thread Andres Freund
Move comment about sun cc's __machine_rw_barrier being a full barrier.

I'd accidentally written the comment besides the read barrier, instead
of the full barrier, implementation.

Noticed by Oskari Saarenmaa

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/93be0950070b5bcb22600cb1cbb62f93c058a5dd

Modified Files
--
src/include/port/atomics/generic-sunpro.h |8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Protect against XLogReaderAllocate() failing to allocate memory.

2015-01-08 Thread Andres Freund
Protect against XLogReaderAllocate() failing to allocate memory.

logical.c's StartupDecodingContext() forgot to check whether
XLogReaderAllocate() returns NULL indicating a memory allocation
failure.  This could lead, although quite unlikely, lead to a NULL
pointer dereference.

This only applies to 9.4 as earlier versions don't do logical
decoding, and later versions don't return NULL after allocation
failures in XLogReaderAllocate().

Michael Paquier, with minor changes by me.

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/ed5b0f79512aa37fc92d2097bc9a0b93a27eaee2

Modified Files
--
src/backend/replication/logical/logical.c |5 +
1 file changed, 5 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Move rowsecurity event trigger test

2015-01-08 Thread Stephen Frost
Move rowsecurity event trigger test

The event trigger test for rowsecurity can cause problems for other
tests which are run in parallel with it.  Instead of running that test
in the rowsecurity set, move it to the event_trigger set, which runs
isolated from other tests.

Also reverts 7161b08, which moved rowsecurity into its own test group.
That's no longer necessary, now that the event trigger test is gone from
the rowsecurity set of tests.

Pointed out by Tom.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c219cbfed339122303266a01150c4fb8dde73fd1

Modified Files
--
src/test/regress/expected/event_trigger.out |   43 +
src/test/regress/expected/rowsecurity.out   |   45 ---
src/test/regress/parallel_schedule  |7 ++---
src/test/regress/serial_schedule|2 +-
src/test/regress/sql/event_trigger.sql  |   43 +
src/test/regress/sql/rowsecurity.sql|   45 ---
6 files changed, 89 insertions(+), 96 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers