[COMMITTERS] pgsql: Fix overeager pushdown of HAVING clauses when grouping sets are

2016-02-08 Thread Andres Freund
Fix overeager pushdown of HAVING clauses when grouping sets are used.

In 61444bfb we started to allow HAVING clauses to be fully pushed down
into WHERE, even when grouping sets are in use. That turns out not to
work correctly, because grouping sets can "produce" NULLs, meaning that
filtering in WHERE and HAVING can have different results, even when no
aggregates or volatile functions are involved.

Instead only allow pushdown of empty grouping sets.

It'd be nice to do better, but the exact mechanics of deciding which
cases are safe are still being debated. It's important to give correct
results till we find a good solution, and such a solution might not be
appropriate for backpatching anyway.

Bug: #13863
Reported-By: 'wrb'
Diagnosed-By: Dean Rasheed
Author: Andrew Gierth
Reviewed-By: Dean Rasheed and Andres Freund
Discussion: 20160113183558.12989.56...@wrigleys.postgresql.org
Backpatch: 9.5, where grouping sets were introduced

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/a6897efab92bc7e645b6c6d15274b8d61c53fe8f

Modified Files
--
src/backend/optimizer/plan/planner.c   | 23 -
src/test/regress/expected/groupingsets.out | 54 ++
src/test/regress/sql/groupingsets.sql  | 12 +++
3 files changed, 81 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix overeager pushdown of HAVING clauses when grouping sets are

2016-02-08 Thread Andres Freund
Fix overeager pushdown of HAVING clauses when grouping sets are used.

In 61444bfb we started to allow HAVING clauses to be fully pushed down
into WHERE, even when grouping sets are in use. That turns out not to
work correctly, because grouping sets can "produce" NULLs, meaning that
filtering in WHERE and HAVING can have different results, even when no
aggregates or volatile functions are involved.

Instead only allow pushdown of empty grouping sets.

It'd be nice to do better, but the exact mechanics of deciding which
cases are safe are still being debated. It's important to give correct
results till we find a good solution, and such a solution might not be
appropriate for backpatching anyway.

Bug: #13863
Reported-By: 'wrb'
Diagnosed-By: Dean Rasheed
Author: Andrew Gierth
Reviewed-By: Dean Rasheed and Andres Freund
Discussion: 20160113183558.12989.56...@wrigleys.postgresql.org
Backpatch: 9.5, where grouping sets were introduced

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/87dbc72a79bbd84aaba3a8c543a093106392da8d

Modified Files
--
src/backend/optimizer/plan/planner.c   | 23 -
src/test/regress/expected/groupingsets.out | 54 ++
src/test/regress/sql/groupingsets.sql  | 12 +++
3 files changed, 81 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Backpatch of 7a58d19b0 to 9.4, previously omitted.

2016-02-08 Thread Andres Freund
Backpatch of 7a58d19b0 to 9.4, previously omitted.

Apparently by accident the above commit was backpatched to all supported
branches, except 9.4. This appears to be an error, as the issue is just
as present there.
Given the short amount of time before the next minor release, and given
the issue is documented to be fixed for 9.4, it seems like a good idea
to push this now.

Original-Author: Michael Meskes
Discussion: 75db81beea95b445ae6d576a0a5c9e9364cbc...@bpxm05gp.gisp.nec.co.jp

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/33b26426ebe993b0f59e9b7683db2dcf2f7ad2dd

Modified Files
--
src/interfaces/ecpg/include/datetime.h | 4 ++--
src/interfaces/ecpg/include/decimal.h  | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Backpatch of 7a58d19b0 to 9.4, previously omitted.

2016-02-08 Thread Tom Lane
Andres Freund  writes:
> Backpatch of 7a58d19b0 to 9.4, previously omitted.
> Apparently by accident the above commit was backpatched to all supported
> branches, except 9.4. This appears to be an error, as the issue is just
> as present there.
> Given the short amount of time before the next minor release, and given
> the issue is documented to be fixed for 9.4, it seems like a good idea
> to push this now.

[ scratches head... ]  I don't know how I missed noticing while preparing
the release notes that there wasn't a REL9_4_STABLE line for that.
Thanks for taking care of it.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make GIN regression test stable.

2016-02-08 Thread Fujii Masao
Make GIN regression test stable.

Commit 7f46eaf added the regression test which checks that
gin_clean_pending_list() cleans up the GIN pending list and returns >0.
This usually works fine. But if autovacuum comes along and cleans
the list before gin_clean_pending_list() starts, the function may
return 0, and then the regression test may fail.

To fix the problem, this commit disables autovacuum on the target
index of gin_clean_pending_list() by setting autovacuum_enabled
reloption to off when creating the table.

Also this commit sets gin_pending_list_limit reloption to 4MB on
the target index. Otherwise when running "make installcheck" with
small gin_pending_list_limit GUC, insertions of data may trigger
the cleanup of pending list before gin_clean_pending_list() starts
and the function may return 0. This could cause the regression test
to fail.

Per buildfarm member spoonbill.

Reported-By: Tom Lane

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f8a1c1d5a30003c9c24b00870d5a0f02f1c81e65

Modified Files
--
src/test/regress/expected/gin.out | 5 +++--
src/test/regress/sql/gin.sql  | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Add gin_clean_pending_list function to clean up GIN pending list

2016-02-08 Thread Fujii Masao
On Mon, Feb 8, 2016 at 2:19 AM, Fujii Masao  wrote:
> On Sat, Feb 6, 2016 at 1:09 PM, Tom Lane  wrote:
>> Fujii Masao  writes:
>>> Add gin_clean_pending_list function to clean up GIN pending list
>>
>> The regression test case added by this commit is unstable, as per
>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spoonbill&dt=2016-02-06%2000%3A00%3A06
>>
>> I imagine what happened there is that autovacuum came along and cleared
>> the pending-list before the test query could.
>
> Thanks for the report! Yes, that's possible. I'm thinking to disable
> autovacuum for the index which pg_clean_pending_list() is working on
> by setting autovacuum_enabled reloption when creating the table.
> Patch attached. This patch also sets gin_pending_list_limit reloption
> to 4MB, just to be safe, so that "make installcheck" will not fail
> even when gin_pending_list_limit GUC is very small.
>
> Barring objection, I'll push this patch.

Okay, pushed.

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Use %u not %d to print OIDs.

2016-02-08 Thread Tom Lane
Use %u not %d to print OIDs.

Oversight in commit 96198d94c.

Etsuro Fujita

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/63828969c822449744e63b76bff993ccd1d3245e

Modified Files
--
contrib/postgres_fdw/connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Translation updates

2016-02-08 Thread Peter Eisentraut
Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: f323fead9293175a0c3320116c97e4be56b9be61

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/477bee7dc66e5c227f621564b5c448ba8948406b

Modified Files
--
src/backend/po/de.po |  592 
src/backend/po/pl.po |  357 ++---
src/backend/po/ru.po |  255 ++--
src/bin/initdb/nls.mk|2 +-
src/bin/initdb/po/ko.po  | 1043 +
src/bin/pg_basebackup/nls.mk |2 +-
src/bin/pg_basebackup/po/ko.po   | 1226 
src/bin/pg_controldata/nls.mk|2 +-
src/bin/pg_controldata/po/ko.po  |  449 ++
src/bin/pg_controldata/po/pl.po  |   26 +-
src/bin/pg_ctl/nls.mk|2 +-
src/bin/pg_ctl/po/ko.po  |  829 +++
src/bin/pg_dump/nls.mk   |2 +-
src/bin/pg_dump/po/de.po |  676 -
src/bin/pg_dump/po/ko.po | 2650 ++
src/bin/pg_dump/po/pl.po |  293 ++--
src/bin/pg_dump/po/ru.po |  730 +-
src/bin/pg_resetxlog/nls.mk  |2 +-
src/bin/pg_resetxlog/po/ko.po|  616 
src/bin/pg_resetxlog/po/pl.po|   60 +-
src/bin/pg_rewind/nls.mk |2 +-
src/bin/pg_rewind/po/ko.po   |  816 +++
src/bin/psql/po/pl.po| 1147 +++
src/bin/psql/po/ru.po|  965 ++---
src/bin/scripts/nls.mk   |2 +-
src/bin/scripts/po/ko.po | 1143 +++
src/interfaces/ecpg/ecpglib/nls.mk   |2 +-
src/interfaces/ecpg/ecpglib/po/ko.po |  198 +++
src/interfaces/libpq/nls.mk  |2 +-
src/interfaces/libpq/po/ko.po| 1021 +
src/pl/plperl/nls.mk |2 +-
src/pl/plperl/po/ko.po   |  229 +++
src/pl/plpgsql/src/nls.mk|2 +-
src/pl/plpgsql/src/po/ko.po  |  819 +++
src/pl/plpython/po/de.po |  140 +-
src/pl/plpython/po/ru.po |  144 +-
src/pl/tcl/nls.mk|2 +-
src/pl/tcl/po/ko.po  |   91 ++
38 files changed, 13776 insertions(+), 2765 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Translation updates

2016-02-08 Thread Peter Eisentraut
Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: 85e9ea36e147944d4852fe2647c95a26e909bb19

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/454994a9ed73713ea38635ab2bfbf5ace48bcf0a

Modified Files
--
src/backend/po/de.po| 471 +
src/backend/po/pl.po|   8 +-
src/backend/po/ru.po| 887 
src/bin/pg_controldata/po/ru.po |  12 +-
src/bin/pg_ctl/po/de.po | 276 +-
src/bin/pg_ctl/po/ru.po | 289 ++-
src/bin/pg_dump/po/de.po| 465 -
src/bin/pg_dump/po/ru.po| 488 +-
src/bin/pg_resetxlog/po/ru.po   |   8 +-
src/bin/psql/po/de.po   |   4 +-
src/bin/psql/po/ru.po   | 157 +++---
src/interfaces/ecpg/preproc/po/pt_BR.po |   2 +-
src/pl/plperl/po/ru.po  |  16 +-
src/pl/plpython/po/de.po|  46 +-
src/pl/plpython/po/ru.po|  44 +-
15 files changed, 1621 insertions(+), 1552 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Translation updates

2016-02-08 Thread Peter Eisentraut
Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: e640b67db0ef2d766eb6b5ec60dc3ba5ed4e2ede

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/6a10dd08006e8f0ce9c1dc2f45379bb17f428e27

Modified Files
--
src/backend/po/de.po| 373 ++-
src/backend/po/pl.po|   4 +-
src/backend/po/ru.po| 617 
src/bin/pg_controldata/po/ru.po |  12 +-
src/bin/pg_ctl/po/de.po | 282 +++
src/bin/pg_ctl/po/ru.po | 289 +++
src/bin/pg_dump/po/de.po| 417 ++---
src/bin/pg_dump/po/ru.po| 447 +++
src/bin/pg_resetxlog/po/ru.po   |   8 +-
src/bin/psql/po/de.po   |   4 +-
src/bin/psql/po/ru.po   |   6 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |   2 +-
src/pl/plperl/po/ru.po  |  16 +-
src/pl/plpython/po/de.po|  46 ++-
src/pl/plpython/po/ru.po|  44 ++-
15 files changed, 1315 insertions(+), 1252 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Translation updates

2016-02-08 Thread Peter Eisentraut
Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: bbedbfae7586389e1f43b8116d76af3ac528c211

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/862b4a427c18579327a7cfff4ac0377ef762dfa7

Modified Files
--
src/backend/po/de.po| 5230 ++-
src/backend/po/pl.po|   13 +-
src/backend/po/ru.po| 1604 +-
src/bin/pg_ctl/po/de.po |  360 +--
src/bin/pg_ctl/po/ru.po |  287 +-
src/bin/pg_dump/po/de.po|  926 +++---
src/bin/pg_dump/po/ru.po|  475 +--
src/bin/pg_resetxlog/po/ru.po   |8 +-
src/bin/psql/po/de.po   |4 +-
src/bin/psql/po/ru.po   |6 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |2 +-
src/pl/plperl/po/ru.po  |   16 +-
12 files changed, 3476 insertions(+), 5455 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Translation updates

2016-02-08 Thread Peter Eisentraut
Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: 97f0f075b2d3e9dac26db78dbd79c32d80eb8f33

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/b101dca62b38a374dcb1dd4232f6ade9f7390cfc

Modified Files
--
src/backend/po/de.po| 1612 ++--
src/backend/po/id.po|   12 +-
src/backend/po/pl.po|   14 +-
src/backend/po/ru.po| 2455 ---
src/bin/pg_controldata/po/ru.po |7 +-
src/bin/pg_ctl/po/de.po |  278 ++--
src/bin/pg_ctl/po/ru.po |  295 ++--
src/bin/pg_dump/po/de.po|  465 +++---
src/bin/pg_dump/po/ru.po|  490 +++---
src/bin/pg_resetxlog/po/ru.po   |8 +-
src/bin/psql/po/de.po   |4 +-
src/bin/psql/po/ru.po   |  160 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |2 +-
src/pl/plperl/po/ru.po  |   16 +-
src/pl/plpython/po/de.po|   46 +-
src/pl/plpython/po/ru.po|   46 +-
16 files changed, 2984 insertions(+), 2926 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Re-pgindent varlena.c.

2016-02-08 Thread Tom Lane
Re-pgindent varlena.c.

Just to make sure previous commit worked ...

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/0231f838565d2921a0960407c4240237ba1d56ae

Modified Files
--
src/backend/utils/adt/varlena.c | 58 +
1 file changed, 30 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Rename typedef "string" to "VarString".

2016-02-08 Thread Tom Lane
Rename typedef "string" to "VarString".

Since pgindent treats typedef names as global, the original coding of
b47b4dbf683f13e6 would have had rather nasty effects on the formatting
of other files in which "string" is used as a variable or field name.
Use a less generic name for this typedef, and rename some other
identifiers to match.

Peter Geoghegan, per gripe from me

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/58e797216ff52c0656d3c343d0732a2530cafb71

Modified Files
--
src/backend/utils/adt/varlena.c | 32 
1 file changed, 16 insertions(+), 16 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Stamp 9.5.1.

2016-02-08 Thread Tom Lane
Stamp 9.5.1.

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/616eaa396a9bf82d8208a79367d784590be9370d

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Stamp 9.4.6.

2016-02-08 Thread Tom Lane
Stamp 9.4.6.

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/a1efb790fb99e989e5cd3ff5ae8cc6df3e250516

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Stamp 9.3.11.

2016-02-08 Thread Tom Lane
Stamp 9.3.11.

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/de07063c05b8ffa86e804c6cc8117a8e8e5cff9b

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Stamp 9.2.15.

2016-02-08 Thread Tom Lane
Stamp 9.2.15.

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/a0606058016b7d20406910b7a73e60ddb3e4c9ff

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Stamp 9.1.20.

2016-02-08 Thread Tom Lane
Stamp 9.1.20.

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/3dca6f36fcd694c8c49d26e7c4971194dee2754a

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] Michael Paquier

2016-02-08 Thread Andrew Dunstan


This came up today in connection with buildfarm database access. My 
policy (before the server move) has been that access is granted to 
committers who are also on the -security list. However, Michael is not a 
committer, and has requested access.


I've actually thought for some time that there is plenty of reason to 
give him a commit bit, so at Stephen's suggestion I'm raising that 
question. He's done plenty of good work, including on Windows where we 
still need plenty of help from time to time, and managed a commitfest or 
two, so he seems quite well qualified.


cheers

andrew


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] Michael Paquier

2016-02-08 Thread Robert Haas
On Mon, Feb 8, 2016 at 4:42 PM, Andrew Dunstan  wrote:
> This came up today in connection with buildfarm database access. My policy
> (before the server move) has been that access is granted to committers who
> are also on the -security list. However, Michael is not a committer, and has
> requested access.
>
> I've actually thought for some time that there is plenty of reason to give
> him a commit bit, so at Stephen's suggestion I'm raising that question. He's
> done plenty of good work, including on Windows where we still need plenty of
> help from time to time, and managed a commitfest or two, so he seems quite
> well qualified.

You have sent this email to the public list rather than the private
one which you probably intended.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] Michael Paquier

2016-02-08 Thread Andrew Dunstan



On 02/08/2016 04:47 PM, Robert Haas wrote:

On Mon, Feb 8, 2016 at 4:42 PM, Andrew Dunstan  wrote:

This came up today in connection with buildfarm database access. My policy
(before the server move) has been that access is granted to committers who
are also on the -security list. However, Michael is not a committer, and has
requested access.

I've actually thought for some time that there is plenty of reason to give
him a commit bit, so at Stephen's suggestion I'm raising that question. He's
done plenty of good work, including on Windows where we still need plenty of
help from time to time, and managed a commitfest or two, so he seems quite
well qualified.

You have sent this email to the public list rather than the private
one which you probably intended.




I know. *sigh* Multitasking again.

cheers

andrew


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Temporarily make pg_ctl and server shutdown a whole lot chattier

2016-02-08 Thread Tom Lane
Temporarily make pg_ctl and server shutdown a whole lot chattier.

This is a quick hack, due to be reverted when its purpose has been served,
to try to gather information about why some of the buildfarm critters
regularly fail with "postmaster does not shut down" complaints.  Maybe they
are just really overloaded, but maybe something else is going on.  Hence,
instrument pg_ctl to print the current time when it starts waiting for
postmaster shutdown and when it gives up, and add a lot of logging of the
current time in the server's checkpoint and shutdown code paths.

No attempt has been made to make this pretty.  I'm not even totally sure
if it will build on Windows, but we'll soon find out.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3971f64843b02e4a55d854156bd53e46a0588e45

Modified Files
--
src/backend/access/transam/xlog.c   | 43 +++--
src/backend/postmaster/autovacuum.c |  3 ++-
src/backend/postmaster/postmaster.c |  9 +---
src/backend/storage/buffer/bufmgr.c | 13 +++
src/backend/utils/init/miscinit.c   | 28 
src/bin/pg_ctl/pg_ctl.c | 36 +--
src/include/miscadmin.h |  1 +
7 files changed, 125 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers