[COMMITTERS] pgsql: Clarify the new Red-Black post-order traversal code a bit.

2016-09-04 Thread Heikki Linnakangas
Clarify the new Red-Black post-order traversal code a bit.

Coverity complained about the for(;;) loop, because it never actually
iterated. It was used just to be able to use "break" to exit it early. I
agree with Coverity, that's a bit confusing, so refactor the code to
use if-else instead.

While we're at it, use a local variable to hold the "current" node. That's
shorter and clearer than referring to "iter->last_visited" all the time.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/e21db14b8a6696a2b704b89df9c4be9cd0ea8a33

Modified Files
--
src/backend/lib/rbtree.c | 46 --
1 file changed, 24 insertions(+), 22 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove useless pg_strdup() operations.

2016-09-04 Thread Tom Lane
Remove useless pg_strdup() operations.

split_to_stringlist() doesn't modify its first argument nor expect it
to remain valid after exit, so there's no need to duplicate the optarg
string at the call sites.  Per Coverity.  (This has been wrong all along,
but commit 052cc223d changed the useless calls from "strdup" to
"pg_strdup", which apparently made Coverity think it's a new bug.
It's not, but it's also not worth back-patching.)

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/a2d75b67bccd24d17e328360080e4877d23bc369

Modified Files
--
src/test/regress/pg_regress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Update release notes to mention need for ALTER EXTENSION UPDATE.

2016-09-04 Thread Tom Lane
Update release notes to mention need for ALTER EXTENSION UPDATE.

Maybe we ought to make pg_upgrade do this for you, but it won't happen
in 9.6, so call out the need for it as a migration consideration.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5a072244919a92b2c757b2e3985191f02d674627

Modified Files
--
doc/src/sgml/release-9.6.sgml | 20 
1 file changed, 20 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Update release notes to mention need for ALTER EXTENSION UPDATE.

2016-09-04 Thread Tom Lane
Update release notes to mention need for ALTER EXTENSION UPDATE.

Maybe we ought to make pg_upgrade do this for you, but it won't happen
in 9.6, so call out the need for it as a migration consideration.

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/7bdf63ccdc70e7168740bdc426195b3b5d508f29

Modified Files
--
doc/src/sgml/release-9.6.sgml | 20 
1 file changed, 20 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database".

Commit b2cbced9e instituted a policy of referring to the timezone database
as the "IANA timezone database" in our user-facing documentation.
Propagate that wording into a couple of places that were still using "zic"
to refer to the database, which is definitely not right (zic is the
compilation tool, not the data).

Back-patch, not because this is very important in itself, but because
we routinely cherry-pick updates to the tznames files and I don't want
to risk future merge failures.

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/27d3e766cff0b6e0a5c3f8f09218c02db43bd5a1

Modified Files
--
src/timezone/tznames/Africa.txt|  2 +-
src/timezone/tznames/America.txt   | 12 
src/timezone/tznames/Asia.txt  | 12 
src/timezone/tznames/Australia | 12 
src/timezone/tznames/Australia.txt | 36 +++---
src/timezone/tznames/Default   | 62 +++---
src/timezone/tznames/Etc.txt   |  2 +-
src/timezone/tznames/Europe.txt|  8 ++---
src/timezone/tznames/Pacific.txt   | 12 
src/tools/RELEASE_CHANGES  |  2 +-
10 files changed, 80 insertions(+), 80 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database".

Commit b2cbced9e instituted a policy of referring to the timezone database
as the "IANA timezone database" in our user-facing documentation.
Propagate that wording into a couple of places that were still using "zic"
to refer to the database, which is definitely not right (zic is the
compilation tool, not the data).

Back-patch, not because this is very important in itself, but because
we routinely cherry-pick updates to the tznames files and I don't want
to risk future merge failures.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/da6ea70c32bed99ca040a5e04d83c0edd5dfc615

Modified Files
--
src/timezone/tznames/Africa.txt|  2 +-
src/timezone/tznames/America.txt   | 12 
src/timezone/tznames/Asia.txt  | 12 
src/timezone/tznames/Australia | 12 
src/timezone/tznames/Australia.txt | 36 +++---
src/timezone/tznames/Default   | 62 +++---
src/timezone/tznames/Etc.txt   |  2 +-
src/timezone/tznames/Europe.txt|  8 ++---
src/timezone/tznames/Pacific.txt   | 12 
src/tools/RELEASE_CHANGES  |  2 +-
10 files changed, 80 insertions(+), 80 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database".

Commit b2cbced9e instituted a policy of referring to the timezone database
as the "IANA timezone database" in our user-facing documentation.
Propagate that wording into a couple of places that were still using "zic"
to refer to the database, which is definitely not right (zic is the
compilation tool, not the data).

Back-patch, not because this is very important in itself, but because
we routinely cherry-pick updates to the tznames files and I don't want
to risk future merge failures.

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/06b185d181897c4a9672e26b93d5abc89de52f85

Modified Files
--
src/timezone/tznames/Africa.txt|  2 +-
src/timezone/tznames/America.txt   | 12 
src/timezone/tznames/Asia.txt  | 12 
src/timezone/tznames/Australia | 12 
src/timezone/tznames/Australia.txt | 36 +++---
src/timezone/tznames/Default   | 62 +++---
src/timezone/tznames/Etc.txt   |  2 +-
src/timezone/tznames/Europe.txt|  8 ++---
src/timezone/tznames/Pacific.txt   | 12 
src/tools/RELEASE_CHANGES  |  2 +-
10 files changed, 80 insertions(+), 80 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database".

Commit b2cbced9e instituted a policy of referring to the timezone database
as the "IANA timezone database" in our user-facing documentation.
Propagate that wording into a couple of places that were still using "zic"
to refer to the database, which is definitely not right (zic is the
compilation tool, not the data).

Back-patch, not because this is very important in itself, but because
we routinely cherry-pick updates to the tznames files and I don't want
to risk future merge failures.

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/88c3f56f0986f4a9f2471fb2eb33424fa6954679

Modified Files
--
src/timezone/tznames/Africa.txt|  2 +-
src/timezone/tznames/America.txt   | 12 
src/timezone/tznames/Asia.txt  | 12 
src/timezone/tznames/Australia | 12 
src/timezone/tznames/Australia.txt | 36 +++---
src/timezone/tznames/Default   | 62 +++---
src/timezone/tznames/Etc.txt   |  2 +-
src/timezone/tznames/Europe.txt|  8 ++---
src/timezone/tznames/Pacific.txt   | 12 
src/tools/RELEASE_CHANGES  |  2 +-
10 files changed, 80 insertions(+), 80 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database".

Commit b2cbced9e instituted a policy of referring to the timezone database
as the "IANA timezone database" in our user-facing documentation.
Propagate that wording into a couple of places that were still using "zic"
to refer to the database, which is definitely not right (zic is the
compilation tool, not the data).

Back-patch, not because this is very important in itself, but because
we routinely cherry-pick updates to the tznames files and I don't want
to risk future merge failures.

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/c26a3aba7d58724377030a2ab6d44681f0d0ec23

Modified Files
--
src/timezone/tznames/Africa.txt|  2 +-
src/timezone/tznames/America.txt   | 12 
src/timezone/tznames/Asia.txt  | 12 
src/timezone/tznames/Australia | 12 
src/timezone/tznames/Australia.txt | 36 +++---
src/timezone/tznames/Default   | 62 +++---
src/timezone/tznames/Etc.txt   |  2 +-
src/timezone/tznames/Europe.txt|  8 ++---
src/timezone/tznames/Pacific.txt   | 12 
src/tools/RELEASE_CHANGES  |  2 +-
10 files changed, 80 insertions(+), 80 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database".

Commit b2cbced9e instituted a policy of referring to the timezone database
as the "IANA timezone database" in our user-facing documentation.
Propagate that wording into a couple of places that were still using "zic"
to refer to the database, which is definitely not right (zic is the
compilation tool, not the data).

Back-patch, not because this is very important in itself, but because
we routinely cherry-pick updates to the tznames files and I don't want
to risk future merge failures.

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/0397fbaa67213647b65e5f8b50987f9b4eb22a43

Modified Files
--
src/timezone/tznames/Africa.txt|  2 +-
src/timezone/tznames/America.txt   | 12 
src/timezone/tznames/Asia.txt  | 12 
src/timezone/tznames/Australia | 12 
src/timezone/tznames/Australia.txt | 36 +++---
src/timezone/tznames/Default   | 62 +++---
src/timezone/tznames/Etc.txt   |  2 +-
src/timezone/tznames/Europe.txt|  8 ++---
src/timezone/tznames/Pacific.txt   | 12 
src/tools/RELEASE_CHANGES  |  2 +-
10 files changed, 80 insertions(+), 80 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database".

Commit b2cbced9e instituted a policy of referring to the timezone database
as the "IANA timezone database" in our user-facing documentation.
Propagate that wording into a couple of places that were still using "zic"
to refer to the database, which is definitely not right (zic is the
compilation tool, not the data).

Back-patch, not because this is very important in itself, but because
we routinely cherry-pick updates to the tznames files and I don't want
to risk future merge failures.

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/891ed9317d329aed4fe247f8b2a40cc6dbeab1c7

Modified Files
--
src/timezone/tznames/Africa.txt|  2 +-
src/timezone/tznames/America.txt   | 12 
src/timezone/tznames/Asia.txt  | 12 
src/timezone/tznames/Australia | 12 
src/timezone/tznames/Australia.txt | 36 +++---
src/timezone/tznames/Default   | 62 +++---
src/timezone/tznames/Etc.txt   |  2 +-
src/timezone/tznames/Europe.txt|  8 ++---
src/timezone/tznames/Pacific.txt   | 12 
src/tools/RELEASE_CHANGES  |  2 +-
10 files changed, 80 insertions(+), 80 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets.

After further reflection about the mess cleaned up in commit 39b691f25,
I decided the main bit of test coverage that was still missing was to
check that the non-default abbreviation-set files we supply are usable.
Add that.

Back-patch to supported branches, just because it seems like a good
idea to keep this all in sync.

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/cfa193d981a38f1e41c53df0378a1aa2cd86a9b2

Modified Files
--
src/test/regress/expected/timestamptz.out | 15 +++
src/test/regress/sql/timestamptz.sql  |  5 +
src/timezone/README   |  5 +
3 files changed, 25 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets.

After further reflection about the mess cleaned up in commit 39b691f25,
I decided the main bit of test coverage that was still missing was to
check that the non-default abbreviation-set files we supply are usable.
Add that.

Back-patch to supported branches, just because it seems like a good
idea to keep this all in sync.

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/512c197b21aa86b1827bfc433f4aebc1469648fe

Modified Files
--
src/test/regress/expected/timestamptz.out | 15 +++
src/test/regress/sql/timestamptz.sql  |  5 +
src/timezone/README   |  5 +
3 files changed, 25 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets.

After further reflection about the mess cleaned up in commit 39b691f25,
I decided the main bit of test coverage that was still missing was to
check that the non-default abbreviation-set files we supply are usable.
Add that.

Back-patch to supported branches, just because it seems like a good
idea to keep this all in sync.

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/942ad33b20b7b57290902463dea3c460f5289ea8

Modified Files
--
src/test/regress/expected/timestamptz.out | 15 +++
src/test/regress/sql/timestamptz.sql  |  5 +
src/timezone/README   |  5 +
3 files changed, 25 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets.

After further reflection about the mess cleaned up in commit 39b691f25,
I decided the main bit of test coverage that was still missing was to
check that the non-default abbreviation-set files we supply are usable.
Add that.

Back-patch to supported branches, just because it seems like a good
idea to keep this all in sync.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c7f68bea22bf680a4eab4b8b1592b3c90bc634ac

Modified Files
--
src/test/regress/expected/timestamptz.out | 15 +++
src/test/regress/sql/timestamptz.sql  |  5 +
src/timezone/README   |  5 +
3 files changed, 25 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets.

After further reflection about the mess cleaned up in commit 39b691f25,
I decided the main bit of test coverage that was still missing was to
check that the non-default abbreviation-set files we supply are usable.
Add that.

Back-patch to supported branches, just because it seems like a good
idea to keep this all in sync.

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/0ce080147a52dec71774c6eacbf855721926c448

Modified Files
--
src/test/regress/expected/timestamptz.out | 15 +++
src/test/regress/sql/timestamptz.sql  |  5 +
src/timezone/README   |  5 +
3 files changed, 25 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets.

After further reflection about the mess cleaned up in commit 39b691f25,
I decided the main bit of test coverage that was still missing was to
check that the non-default abbreviation-set files we supply are usable.
Add that.

Back-patch to supported branches, just because it seems like a good
idea to keep this all in sync.

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/c8d2bd4e43914f0101e8b6ab53f45520eea13039

Modified Files
--
src/test/regress/expected/timestamptz.out | 15 +++
src/test/regress/sql/timestamptz.sql  |  5 +
src/timezone/README   |  5 +
3 files changed, 25 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets.

After further reflection about the mess cleaned up in commit 39b691f25,
I decided the main bit of test coverage that was still missing was to
check that the non-default abbreviation-set files we supply are usable.
Add that.

Back-patch to supported branches, just because it seems like a good
idea to keep this all in sync.

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/0499bd26915f2b4119560142855db3df59d1b8a4

Modified Files
--
src/test/regress/expected/timestamptz.out | 15 +++
src/test/regress/sql/timestamptz.sql  |  5 +
src/timezone/README   |  5 +
3 files changed, 25 insertions(+)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove duplicate code from ReorderBufferCleanupTXN().

2016-09-04 Thread Tom Lane
Remove duplicate code from ReorderBufferCleanupTXN().

Andres is apparently the only hacker who thinks this code is better as-is.
I (tgl) follow some of his logic, but the fact that it's setting off
warnings from static code analyzers seems like a sufficient reason to
put the complexity into a comment rather than the code.

Aleksander Alekseev

Discussion: <20160404190345.54d84ee8@fujitsu>

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/b6182081be4a795d70b966be2542ad32d1ffbc20

Modified Files
--
src/backend/replication/logical/reorderbuffer.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)


-- 
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers