[COMMITTERS] pgsql: Fix typo in comment
Fix typo in comment Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8afb811088c2a8bfa2b68bd24c05471b8ea4a8ce Modified Files -- src/backend/executor/execParallel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in comment
Fix typo in comment Thomas Munro Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/81f92a55c7bb920a7b915ae0e022a8488126ec22 Modified Files -- src/backend/executor/execParallel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Check for pending trigger events on far end when dropping an FK
Check for pending trigger events on far end when dropping an FK constraint. When dropping a foreign key constraint with ALTER TABLE DROP CONSTRAINT, we refuse the drop if there are any pending trigger events on the named table; this ensures that we won't remove the pg_trigger row that will be consulted by those events. But we should make the same check for the referenced relation, else we might remove a due-to-be-referenced pg_trigger row for that relation too, resulting in "could not find trigger NNN" or "relation NNN has no triggers" errors at commit. Per bug #14431 from Benjie Gillam. Back-patch to all supported branches. Report: <20161124114911.6530.31...@wrigleys.postgresql.org> Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6a363a4c252329f1f97d80526eb55b3301abf1f2 Modified Files -- src/backend/commands/tablecmds.c | 18 ++ src/test/regress/expected/foreign_key.out | 13 + src/test/regress/sql/foreign_key.sql | 13 + 3 files changed, 44 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Check for pending trigger events on far end when dropping an FK
Check for pending trigger events on far end when dropping an FK constraint. When dropping a foreign key constraint with ALTER TABLE DROP CONSTRAINT, we refuse the drop if there are any pending trigger events on the named table; this ensures that we won't remove the pg_trigger row that will be consulted by those events. But we should make the same check for the referenced relation, else we might remove a due-to-be-referenced pg_trigger row for that relation too, resulting in "could not find trigger NNN" or "relation NNN has no triggers" errors at commit. Per bug #14431 from Benjie Gillam. Back-patch to all supported branches. Report: <20161124114911.6530.31...@wrigleys.postgresql.org> Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4e026b32d4024b03856b4981b26c747b7fef7afb Modified Files -- src/backend/commands/tablecmds.c | 18 ++ src/test/regress/expected/foreign_key.out | 13 + src/test/regress/sql/foreign_key.sql | 13 + 3 files changed, 44 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Check for pending trigger events on far end when dropping an FK
Check for pending trigger events on far end when dropping an FK constraint. When dropping a foreign key constraint with ALTER TABLE DROP CONSTRAINT, we refuse the drop if there are any pending trigger events on the named table; this ensures that we won't remove the pg_trigger row that will be consulted by those events. But we should make the same check for the referenced relation, else we might remove a due-to-be-referenced pg_trigger row for that relation too, resulting in "could not find trigger NNN" or "relation NNN has no triggers" errors at commit. Per bug #14431 from Benjie Gillam. Back-patch to all supported branches. Report: <20161124114911.6530.31...@wrigleys.postgresql.org> Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/05bef7b0884d85c25a3c8a5060c6389e6da52531 Modified Files -- src/backend/commands/tablecmds.c | 18 ++ src/test/regress/expected/foreign_key.out | 13 + src/test/regress/sql/foreign_key.sql | 13 + 3 files changed, 44 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Check for pending trigger events on far end when dropping an FK
Check for pending trigger events on far end when dropping an FK constraint. When dropping a foreign key constraint with ALTER TABLE DROP CONSTRAINT, we refuse the drop if there are any pending trigger events on the named table; this ensures that we won't remove the pg_trigger row that will be consulted by those events. But we should make the same check for the referenced relation, else we might remove a due-to-be-referenced pg_trigger row for that relation too, resulting in "could not find trigger NNN" or "relation NNN has no triggers" errors at commit. Per bug #14431 from Benjie Gillam. Back-patch to all supported branches. Report: <20161124114911.6530.31...@wrigleys.postgresql.org> Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/bf5fe7bfa0e8bdc87be94b98bbdcb26054a6b75c Modified Files -- src/backend/commands/tablecmds.c | 18 ++ src/test/regress/expected/foreign_key.out | 13 + src/test/regress/sql/foreign_key.sql | 13 + 3 files changed, 44 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Check for pending trigger events on far end when dropping an FK
Check for pending trigger events on far end when dropping an FK constraint. When dropping a foreign key constraint with ALTER TABLE DROP CONSTRAINT, we refuse the drop if there are any pending trigger events on the named table; this ensures that we won't remove the pg_trigger row that will be consulted by those events. But we should make the same check for the referenced relation, else we might remove a due-to-be-referenced pg_trigger row for that relation too, resulting in "could not find trigger NNN" or "relation NNN has no triggers" errors at commit. Per bug #14431 from Benjie Gillam. Back-patch to all supported branches. Report: <20161124114911.6530.31...@wrigleys.postgresql.org> Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6cbe84c826b51a159825e9843184c7b4a740e4ae Modified Files -- src/backend/commands/tablecmds.c | 18 ++ src/test/regress/expected/foreign_key.out | 13 + src/test/regress/sql/foreign_key.sql | 13 + 3 files changed, 44 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Check for pending trigger events on far end when dropping an FK
Check for pending trigger events on far end when dropping an FK constraint. When dropping a foreign key constraint with ALTER TABLE DROP CONSTRAINT, we refuse the drop if there are any pending trigger events on the named table; this ensures that we won't remove the pg_trigger row that will be consulted by those events. But we should make the same check for the referenced relation, else we might remove a due-to-be-referenced pg_trigger row for that relation too, resulting in "could not find trigger NNN" or "relation NNN has no triggers" errors at commit. Per bug #14431 from Benjie Gillam. Back-patch to all supported branches. Report: <20161124114911.6530.31...@wrigleys.postgresql.org> Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f7166ce243aec3f5df454377d81b67032d85f35c Modified Files -- src/backend/commands/tablecmds.c | 18 ++ src/test/regress/expected/foreign_key.out | 13 + src/test/regress/sql/foreign_key.sql | 13 + 3 files changed, 44 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Mark a query's topmost Paths parallel-unsafe if they will have i
Mark a query's topmost Paths parallel-unsafe if they will have initPlans. Andreas Seltenreich found another case where we were being too optimistic about allowing a plan to be considered parallelizable despite it containing initPlans. It seems like the real issue here is that if we know we are going to tack initPlans onto the topmost Plan node for a subquery, we had better mark that subquery's result Paths as not-parallel-safe. That fixes this problem and allows reversion of a kluge (added in commit 7b67a0a49 and extended in f24cf960d) to not trust the parallel_safe flag at top level. Discussion: <874m2w4k5d@ex.ansel.ydns.eu> Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/474de765a8003bc58f5736f626bf533147cc1e68 Modified Files -- src/backend/optimizer/plan/planner.c | 15 ++- src/backend/optimizer/plan/subselect.c | 9 ++--- 2 files changed, 12 insertions(+), 12 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Mark a query's topmost Paths parallel-unsafe if they will have i
Mark a query's topmost Paths parallel-unsafe if they will have initPlans. Andreas Seltenreich found another case where we were being too optimistic about allowing a plan to be considered parallelizable despite it containing initPlans. It seems like the real issue here is that if we know we are going to tack initPlans onto the topmost Plan node for a subquery, we had better mark that subquery's result Paths as not-parallel-safe. That fixes this problem and allows reversion of a kluge (added in commit 7b67a0a49 and extended in f24cf960d) to not trust the parallel_safe flag at top level. Discussion: <874m2w4k5d@ex.ansel.ydns.eu> Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ab77a5a4561fad847af4a101a29c922c66449870 Modified Files -- src/backend/optimizer/plan/planner.c | 15 ++- src/backend/optimizer/plan/subselect.c | 9 ++--- 2 files changed, 12 insertions(+), 12 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Bring some clarity to the defaults for the xxx_flush_after param
Bring some clarity to the defaults for the xxx_flush_after parameters. Instead of confusingly stating platform-dependent defaults for these parameters in the comments in postgresql.conf.sample (with the main entry being a lie on Linux), teach initdb to install the correct platform-dependent value in postgresql.conf, similarly to the way we handle other platform-dependent defaults. This won't do anything for existing 9.6 installations, but since it's effectively only a documentation improvement, that seems OK. Since this requires initdb to have access to the default values, move the #define's for those to pg_config_manual.h; the original placement in bufmgr.h is unworkable because that file can't be included by frontend programs. Adjust the default value for wal_writer_flush_after so that it is 1MB regardless of XLOG_BLCKSZ, conforming to what is stated in both the SGML docs and postgresql.conf. (We could alternatively make it scale with XLOG_BLCKSZ, but I'm not sure I see the point.) Copy-edit related SGML documentation. Fabien Coelho and Tom Lane, per a gripe from Tomas Vondra. Discussion: <30ebc6e3-8358-09cf-44a8-578252938...@2ndquadrant.com> Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/255bcd27f635a1b9682e7e0dfd348b0f8b268df1 Modified Files -- doc/src/sgml/config.sgml | 33 ++- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 8 +++ src/backend/utils/misc/postgresql.conf.sample | 12 -- src/bin/initdb/initdb.c | 21 + src/include/pg_config_manual.h| 18 +++ src/include/storage/bufmgr.h | 11 - 7 files changed, 65 insertions(+), 40 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Bring some clarity to the defaults for the xxx_flush_after param
Bring some clarity to the defaults for the xxx_flush_after parameters. Instead of confusingly stating platform-dependent defaults for these parameters in the comments in postgresql.conf.sample (with the main entry being a lie on Linux), teach initdb to install the correct platform-dependent value in postgresql.conf, similarly to the way we handle other platform-dependent defaults. This won't do anything for existing 9.6 installations, but since it's effectively only a documentation improvement, that seems OK. Since this requires initdb to have access to the default values, move the #define's for those to pg_config_manual.h; the original placement in bufmgr.h is unworkable because that file can't be included by frontend programs. Adjust the default value for wal_writer_flush_after so that it is 1MB regardless of XLOG_BLCKSZ, conforming to what is stated in both the SGML docs and postgresql.conf. (We could alternatively make it scale with XLOG_BLCKSZ, but I'm not sure I see the point.) Copy-edit related SGML documentation. Fabien Coelho and Tom Lane, per a gripe from Tomas Vondra. Discussion: <30ebc6e3-8358-09cf-44a8-578252938...@2ndquadrant.com> Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dbdfd114f34443f1e4ad16ce2721f9817d3b3d80 Modified Files -- doc/src/sgml/config.sgml | 33 ++- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 8 +++ src/backend/utils/misc/postgresql.conf.sample | 10 src/bin/initdb/initdb.c | 25 ++-- src/include/pg_config_manual.h| 18 +++ src/include/storage/bufmgr.h | 11 - 7 files changed, 66 insertions(+), 41 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
