[COMMITTERS] pgsql: Update some obsolete comments.
Update some obsolete comments. Fix a few stray references to expression eval functions that don't exist anymore or don't take the same input representation they used to. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/244dd95ce9d9831f8498f5746860325f7adcecbf Modified Files -- src/backend/optimizer/util/clauses.c | 4 ++-- src/backend/utils/cache/relcache.c | 2 +- src/pl/plpgsql/src/pl_exec.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing break
Add missing break Noticed by Coverity Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6a101b0aed78e09b51e2162e6b68a4aeab52b61e Modified Files -- src/backend/tcop/utility.c | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: doc: Clean up bibliography rendering for XSLT
doc: Clean up bibliography rendering for XSLT In the DSSSL stylesheets, we had an extensive customization of the bibliography rendering. Since the bibliography isn't that used much, it doesn't seem worth doing an elaborate porting of that to XSLT. So this just moves some things around, removes some unused things, and does some minimal XSLT stylesheet customizations to make things look clean. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d63762452434a3a046e8c7d130d5a77c594176e4 Modified Files -- doc/src/sgml/biblio.sgml | 120 - doc/src/sgml/stylesheet-fo.xsl | 17 ++ doc/src/sgml/stylesheet.xsl| 21 3 files changed, 71 insertions(+), 87 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: doc: Fix oldhtml/old PDF build
doc: Fix oldhtml/old PDF build "xref to REFSECT1 unsupported" with the DSSSL stylesheets. Reported-by: Devrim Gündüz Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e259e1f748c7a6d67e307a90d6c27b8ab8b90df8 Modified Files -- doc/src/sgml/ref/alter_collation.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve implementation of EEOP_BOOLTEST_* opcodes.
Improve implementation of EEOP_BOOLTEST_* opcodes. Both Andres and I were happy with "*op->resvalue = *op->resvalue;", but Coverity isn't; and it has a point, because some compilers might not be smart enough to elide that. So remove it. In passing, also avoid doing unnecessary assignments to *op->resnull when it's already known to have the right value. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d77f014efa7eda4357fbc851dbf25c6b256ddf35 Modified Files -- src/backend/executor/execExprInterp.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements. On an alignment-picky machine this would lead to bus errors. To fix, declare the local variable honestly, and then cast its address to char * for use in the I/O calls. Given the lack of field complaints, there must be very few if any people affected; but nonetheless this is a clear portability issue, so back-patch to all supported branches. Noted while looking at a Coverity complaint in the same code. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/24fc43d40aad5f888f22af9a543113a168a08307 Modified Files -- src/backend/libpq/auth.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix some minor resource leaks in PerformRadiusTransaction().
Fix some minor resource leaks in PerformRadiusTransaction(). Failure to free serveraddrs pointed out by Coverity, failure to close socket noted by code-reading. These bugs seem to be quite old, but given the low probability of taking these error-exit paths and the minimal consequences of the leaks (since the process would presumably exit shortly anyway), it doesn't seem worth back-patching. Michael Paquier and Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7cbd944662854a0a5264895bcba3ce7f9bfd1c1f Modified Files -- src/backend/libpq/auth.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements. On an alignment-picky machine this would lead to bus errors. To fix, declare the local variable honestly, and then cast its address to char * for use in the I/O calls. Given the lack of field complaints, there must be very few if any people affected; but nonetheless this is a clear portability issue, so back-patch to all supported branches. Noted while looking at a Coverity complaint in the same code. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4c051c41d63e8462971c13956a38030de9c35c51 Modified Files -- src/backend/libpq/auth.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements. On an alignment-picky machine this would lead to bus errors. To fix, declare the local variable honestly, and then cast its address to char * for use in the I/O calls. Given the lack of field complaints, there must be very few if any people affected; but nonetheless this is a clear portability issue, so back-patch to all supported branches. Noted while looking at a Coverity complaint in the same code. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c804c00d38f6a848f0d7e57a05ea5468fc5762b2 Modified Files -- src/backend/libpq/auth.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements. On an alignment-picky machine this would lead to bus errors. To fix, declare the local variable honestly, and then cast its address to char * for use in the I/O calls. Given the lack of field complaints, there must be very few if any people affected; but nonetheless this is a clear portability issue, so back-patch to all supported branches. Noted while looking at a Coverity complaint in the same code. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3455ddbfa6b7c38d55d2638d062f311343b8f053 Modified Files -- src/backend/libpq/auth.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements. On an alignment-picky machine this would lead to bus errors. To fix, declare the local variable honestly, and then cast its address to char * for use in the I/O calls. Given the lack of field complaints, there must be very few if any people affected; but nonetheless this is a clear portability issue, so back-patch to all supported branches. Noted while looking at a Coverity complaint in the same code. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/55c642c92b974362ece5ddf100fa2fa90b3442c9 Modified Files -- src/backend/libpq/auth.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix unportable disregard of alignment requirements in RADIUS cod
Fix unportable disregard of alignment requirements in RADIUS code. The compiler is entitled to store a char[] local variable with no particular alignment requirement. Our RADIUS code cavalierly took such a local variable and cast its address to a struct type that does have alignment requirements. On an alignment-picky machine this would lead to bus errors. To fix, declare the local variable honestly, and then cast its address to char * for use in the I/O calls. Given the lack of field complaints, there must be very few if any people affected; but nonetheless this is a clear portability issue, so back-patch to all supported branches. Noted while looking at a Coverity complaint in the same code. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5fe937f38b493f7c94c4ef8b0940e034afbd78a6 Modified Files -- src/backend/libpq/auth.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typos in logical replication support for initial data copy.
Fix typos in logical replication support for initial data copy. Fix an incorrect assert condition (noted by Coverity), and spell the new name of the function correctly. Typos introduced in commit 7c4f52409. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5459cfd3ad52b87a1e2ed293ae55e733c6964715 Modified Files -- src/backend/replication/logical/snapbuild.c | 8 src/backend/replication/walsender.c | 2 +- src/include/replication/snapbuild.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Use ExecPrepareExpr in place of ExecPrepareCheck where appropria
Use ExecPrepareExpr in place of ExecPrepareCheck where appropriate. Change one more place where ExecInitCheck/ExecPrepareCheck's insistence on getting implicit-AND-format quals wasn't really helpful, because the caller had to do make_ands_implicit() for no reason that it cared about. Using ExecPrepareExpr directly simplifies the code and saves cycles. The only remaining use of these functions is to process resultRelInfo->ri_PartitionCheck quals. However, implicit-AND format does seem to be what we want for that, so leave it alone. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9b95f2fa1e2684fa209a3594db2254b8841bf380 Modified Files -- src/backend/catalog/partition.c | 6 +- src/backend/commands/tablecmds.c | 22 ++ 2 files changed, 15 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix cpluspluscheck warning
Fix cpluspluscheck warning Structure tag cannot be the same as a typedef that is a pointer to that struct. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/895f93701fd78b6faab6b437685357298a91dfe3 Modified Files -- src/include/utils/pg_locale.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve performance of ExecEvalWholeRowVar.
Improve performance of ExecEvalWholeRowVar. In commit b8d7f053c, we needed to fix ExecEvalWholeRowVar to not change the state of the slot it's copying. The initial quick hack at that required two rounds of tuple construction, which is not very nice. To fix, add another primitive to tuptoaster.c that does precisely what we need. (I initially tried to do this by refactoring one of the existing functions into two pieces; but it looked like that might hurt performance for the existing case, and the amount of code that could be shared is not very large, so I gave up on that.) Discussion: https://postgr.es/m/26088.1490315...@sss.pgh.pa.us Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2f0903ea196503fc8af373a9de46b1e01a23508c Modified Files -- src/backend/access/heap/tuptoaster.c | 68 +++ src/backend/executor/execExprInterp.c | 22 ++-- src/include/access/tuptoaster.h | 11 ++ 3 files changed, 90 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Show more processes in pg_stat_activity.
Show more processes in pg_stat_activity. Previously, auxiliary processes and background workers not connected to a database (such as the logical replication launcher) weren't shown. Include them, so that we can see the associated wait state information. Add a new column to identify the processes type, so that people can filter them out easily using SQL if they wish. Before this patch was written, there was discussion about whether we should expose this information in a separate view, so as to avoid contaminating pg_stat_activity with things people might not want to see. But putting everything in pg_stat_activity was a more popular choice, so that's what the patch does. Kuntal Ghosh, reviewed by Amit Langote and Michael Paquier. Some revisions and bug fixes by me. Discussion: http://postgr.es/m/ca+tgmoyes5nhkegw9nzxu8_fha8xem8ntm3-so+3ml1b81h...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fc70a4b0df38bda6a13941f1581f25fbb643c7f3 Modified Files -- doc/src/sgml/monitoring.sgml | 15 ++- src/backend/bootstrap/bootstrap.c| 4 + src/backend/catalog/system_views.sql | 3 +- src/backend/postmaster/pgstat.c | 194 ++- src/backend/postmaster/startup.c | 1 + src/backend/replication/walsender.c | 4 +- src/backend/storage/lmgr/proc.c | 27 + src/backend/utils/adt/pgstatfuncs.c | 60 --- src/backend/utils/init/postinit.c| 8 ++ src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h| 2 +- src/include/pgstat.h | 26 + src/include/storage/proc.h | 3 +- src/test/regress/expected/rules.out | 9 +- 14 files changed, 305 insertions(+), 53 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix comment.
Fix comment. Cut-and-paste led to something silly. Ashutosh Sharma, reviewed by Amit Kapila and by me Discussion: http://postgr.es/m/cae9k0pmubvqsby7kwn_okuqbyyhrxbx-c1zkuagr5vgf0ge...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f0a6046bcb15c2fe48384ef547df2bfb5d7f0a89 Modified Files -- src/backend/access/hash/hashpage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Support hashed aggregation with grouping sets.
Support hashed aggregation with grouping sets. This extends the Aggregate node with two new features: HashAggregate can now run multiple hashtables concurrently, and a new strategy MixedAggregate populates hashtables while doing sorted grouping. The planner will now attempt to save as many sorts as possible when planning grouping sets queries, while not exceeding work_mem for the estimated combined sizes of all hashtables used. No SQL-level changes are required. There should be no user-visible impact other than the new EXPLAIN output and possible changes to result ordering when ORDER BY was not used (which affected a few regression tests). The enable_hashagg option is respected. Author: Andrew Gierth Reviewers: Mark Dilger, Andres Freund Discussion: https://postgr.es/m/87vatszyhj@news-spur.riddles.org.uk Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b5635948ab165b6070e7d05d111f966e07570d81 Modified Files -- contrib/postgres_fdw/expected/postgres_fdw.out | 61 +- src/backend/commands/explain.c | 25 +- src/backend/executor/nodeAgg.c | 861 + src/backend/lib/Makefile | 4 +- src/backend/lib/knapsack.c | 114 src/backend/nodes/bitmapset.c | 30 + src/backend/nodes/outfuncs.c | 34 +- src/backend/optimizer/path/costsize.c | 7 +- src/backend/optimizer/plan/createplan.c| 83 +-- src/backend/optimizer/plan/planner.c | 861 - src/backend/optimizer/util/pathnode.c | 150 +++-- src/include/lib/knapsack.h | 17 + src/include/nodes/bitmapset.h | 6 + src/include/nodes/execnodes.h | 21 +- src/include/nodes/nodes.h | 5 +- src/include/nodes/plannodes.h | 2 +- src/include/nodes/relation.h | 30 +- src/include/optimizer/pathnode.h | 4 +- src/test/regress/expected/groupingsets.out | 616 +- src/test/regress/expected/tsrf.out | 50 +- src/test/regress/sql/groupingsets.sql | 155 - src/test/regress/sql/tsrf.sql | 2 + 22 files changed, 2544 insertions(+), 594 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix a couple of problems in pg_get_statisticsextdef
Fix a couple of problems in pg_get_statisticsextdef There was a thinko whereby we tested the wrong tuple after fetching it from cache; avoid that by using generate_relation_name instead, which is simpler. Also, the statistics name was not qualified, so add that. (It could be argued that qualification should be conditional on the schema not being on search path. We can add that later, but at least this form is correct.) Author: David Rowley, Álvaro Herrera Discussion: https://postgr.es/m/cakjs1f8rjlevzj2+93pdqguzjebf-ifshafmr-q-6-z0qxa...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2c3e47527a6f53cd1d98887fdb9e770c118954ca Modified Files -- src/backend/utils/adt/ruleutils.c | 20 +--- src/test/regress/expected/rules.out | 6 ++ src/test/regress/expected/stats_ext.out | 7 +++ src/test/regress/sql/rules.sql | 1 + src/test/regress/sql/stats_ext.sql | 4 5 files changed, 23 insertions(+), 15 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Support hashed aggregation with grouping sets.
> "Andrew" == Andrew Gierth writes: Andrew> Support hashed aggregation with grouping sets. Looks like some regression test plans aren't as stable as I hoped. On it. -- Andrew (irc:RhodiumToad) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Support hashed aggregation with grouping sets.
Andrew Gierth writes: > Support hashed aggregation with grouping sets. Looks like this needs a bit more work to ensure the plans chosen for the regression test examples are stable ... regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Attempt to stabilize grouping sets regression test plans.
Attempt to stabilize grouping sets regression test plans. Per buildfarm members dromedary and arapaima. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de4da168d57de812bb30d359394b7913635d21a9 Modified Files -- src/test/regress/expected/groupingsets.out | 1 + src/test/regress/sql/groupingsets.sql | 1 + 2 files changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix a couple of problems in pg_get_statisticsextdef
> "Alvaro" == Alvaro Herrera writes: Alvaro> Fix a couple of problems in pg_get_statisticsextdef Alvaro> src/test/regress/expected/stats_ext.out | 7 +++ Missed an update to stats_ext_1.out ? -- Andrew (irc:RhodiumToad) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
