Re: [COMMITTERS] pgsql: hash: Immediately after a bucket split, try to clean the old buc

[Ashutosh Sharma]

Hi,

I could see some diff getting generated after running pgindent script
on 'src/backend/access/hash/hashpage.c' file and from the diff it
looks like it got introduced as a part of this commit. Below is the
diff observed,

/*
 * If possible, clean up the old bucket.  We might not be able
to do this
 * if someone else has a pin on it, but if not then we can go
ahead.  This
-* isn't absolutely necessary, but it reduces bloat; if we
don't do it now,
-* VACUUM will do it eventually, but maybe not until new overflow pages
-* have been allocated.  Note that there's no need to clean up the new
-* bucket.
+* isn't absolutely necessary, but it reduces bloat; if we don't do it
+* now, VACUUM will do it eventually, but maybe not until new overflow
+* pages have been allocated.  Note that there's no need to clean up the
+* new bucket.
 */

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

On Sat, Aug 5, 2017 at 6:24 AM, Robert Haas  wrote:
> hash: Immediately after a bucket split, try to clean the old bucket.
>
> If it works, then we won't be storing two copies of all the tuples
> that were just moved.  If not, VACUUM will still take care of it
> eventually.  Per a report from AP and analysis from Amit Kapila, it
> seems that a bulk load can cause splits fast enough that VACUUM won't
> deal with the problem in time to prevent bloat.
>
> Amit Kapila; I rewrote the comment.
>
> Discussion: http://postgr.es/m/20170704105728.mwb72jebfmok2...@zip.com.au
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/pg/commitdiff/ff98a5e1e49de061600feb6b4de5ce0a22d386af
>
> Modified Files
> --
> src/backend/access/hash/hashpage.c | 45 --
> 1 file changed, 34 insertions(+), 11 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Downgrade subscription refresh messages to DEBUG1

[Peter Eisentraut]

Downgrade subscription refresh messages to DEBUG1

The NOTICE messages about tables being added or removed during
subscription refresh would be incorrect and possibly confusing if the
transaction rolls back, so silence them but keep them available for
debugging.

Discussion: 
https://www.postgresql.org/message-id/CAD21AoAvaXizc2h7aiNyK_i0FQSa-tmhpdOGwbhh7Jy544Ad4Q%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/6f81306e4d1716bdf19aa8629b4004966918c56e

Modified Files
--
src/backend/commands/subscriptioncmds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Improve wording of subscription refresh debug messages

[Peter Eisentraut]

Improve wording of subscription refresh debug messages

Reported-by: Yugo Nagata 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ad2ca3cba6e14dbd7b9f388b1e101cd5e2a2c210

Modified Files
--
src/backend/commands/subscriptioncmds.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix function name in code comment

[Peter Eisentraut]

Fix function name in code comment

Reported-by: Peter Geoghegan 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/86524f038799db9e18c86df0ea6fb40c8102c0ab

Modified Files
--
src/backend/commands/collationcmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Add support for ICU 4.2

[Peter Eisentraut]

On 8/6/17 20:40, Peter Geoghegan wrote:
> On Sat, Aug 5, 2017 at 6:36 AM, Peter Eisentraut  wrote:
>> In ICU 4.2, ucol_getKeywordsForLocale() sometimes returns values that
>> will not be accepted by uloc_toLanguageTag().  Skip loading keyword
>> variants in that version.
> 
> This should be spelled ucol_getKeywordValuesForLocale() in both the
> commit message and the code comment. There is no
> ucol_getKeywordsForLocale() function.

Fixed, thanks.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix handling of dropped columns in logical replication

[Peter Eisentraut]

Fix handling of dropped columns in logical replication

The relation attribute map was not initialized for dropped columns,
leading to errors later on.

Author: Petr Jelinek 
Reported-by: Scott Milliken 
Bug: #14769

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/0e58455dd48ca9cbc9987c47b8297d10f1c307b0

Modified Files
--
src/backend/replication/logical/relation.c | 3 +++
1 file changed, 3 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix local/remote attribute mix-up in logical replication

[Peter Eisentraut]

Fix local/remote attribute mix-up in logical replication

This would lead to failures if local and remote tables have a different
column order.  The tests previously didn't catch that because they only
tested the initial data copy.  So add another test that exercises the
apply worker.

Author: Petr Jelinek 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/fca17a933b4b3cedcd41f14b0fe4d3fb439ea4a4

Modified Files
--
src/backend/replication/logical/worker.c   | 3 ++-
src/test/subscription/t/001_rep_changes.pl | 5 -
2 files changed, 6 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Translation updates

[Peter Eisentraut]

Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: 1a0b5e655d7871506c2b1c7ba562c2de6b6a55de

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f7668b2b3532b627ec951e1f0a28944f30cc4a1b

Modified Files
--
src/backend/po/es.po | 4 +-
src/backend/po/fr.po | 14696 +++--
src/bin/initdb/po/es.po  | 4 +-
src/bin/initdb/po/sv.po  |   790 +-
src/bin/pg_archivecleanup/nls.mk | 2 +-
src/bin/pg_archivecleanup/po/de.po   |   173 +
src/bin/pg_archivecleanup/po/es.po   | 2 +-
src/bin/pg_archivecleanup/po/sv.po   |   176 +
src/bin/pg_basebackup/nls.mk | 2 +-
src/bin/pg_basebackup/po/de.po   |   241 +-
src/bin/pg_basebackup/po/es.po   | 4 +-
src/bin/pg_basebackup/po/fr.po   |   312 +-
src/bin/pg_basebackup/po/he.po   |  1405 
src/bin/pg_config/nls.mk | 2 +-
src/bin/pg_config/po/es.po   | 4 +-
src/bin/pg_config/po/he.po   |   316 +
src/bin/pg_config/po/sv.po   |   103 +-
src/bin/pg_controldata/po/de.po  | 9 +-
src/bin/pg_controldata/po/es.po  | 4 +-
src/bin/pg_controldata/po/sv.po  |   256 +-
src/bin/pg_ctl/nls.mk| 2 +-
src/bin/pg_ctl/po/de.po  |   412 +-
src/bin/pg_ctl/po/es.po  |   342 +-
src/bin/pg_ctl/po/he.po  |   884 ++
src/bin/pg_ctl/po/sv.po  |   606 +-
src/bin/pg_dump/nls.mk   | 2 +-
src/bin/pg_dump/po/de.po |   440 +-
src/bin/pg_dump/po/es.po |   227 +-
src/bin/pg_dump/po/fr.po |   460 +-
src/bin/pg_dump/po/sv.po |  2920 +++
src/bin/pg_resetwal/po/de.po |   267 +-
src/bin/pg_resetwal/po/es.po |13 +-
src/bin/pg_resetwal/po/sv.po |   396 +-
src/bin/pg_rewind/nls.mk | 2 +-
src/bin/pg_rewind/po/es.po   |17 +-
src/bin/pg_rewind/po/fr.po   |62 +-
src/bin/pg_rewind/po/sv.po   |   880 ++
src/bin/pg_test_fsync/nls.mk | 2 +-
src/bin/pg_test_fsync/po/es.po   | 2 +-
src/bin/pg_test_fsync/po/sv.po   |   176 +
src/bin/pg_test_timing/nls.mk| 2 +-
src/bin/pg_test_timing/po/es.po  | 2 +-
src/bin/pg_test_timing/po/fr.po  |10 +-
src/bin/pg_test_timing/po/sv.po  |77 +
src/bin/pg_upgrade/nls.mk| 2 +-
src/bin/pg_upgrade/po/fr.po  |  1631 
src/bin/pg_waldump/nls.mk| 2 +-
src/bin/pg_waldump/po/es.po  | 2 +-
src/bin/pg_waldump/po/sv.po  |   246 +
src/bin/psql/nls.mk  | 2 +-
src/bin/psql/po/es.po| 4 +-
src/bin/psql/po/fr.po|   957 ++-
src/bin/psql/po/sv.po|  7450 +
src/bin/scripts/po/es.po |40 +-
src/bin/scripts/po/sv.po |   719 +-
src/interfaces/ecpg/ecpglib/po/es.po | 4 +-
src/interfaces/ecpg/preproc/po/es.po | 4 +-
src/interfaces/libpq/nls.mk  | 2 +-
src/interfaces/libpq/po/de.po|   272 +-
src/interfaces/libpq/po/es.po|   185 +-
src/interfaces/libpq/po/fr.po|   236 +-
src/interfaces/libpq/po/he.po|  1087 +++
src/interfaces/libpq/po/sv.po|  1173 +++
src/pl/plperl/po/es.po   | 4 +-
src/pl/plperl/po/sv.po   |   160 +-
src/pl/plpgsql/src/nls.mk| 2 +-
src/pl/plpgsql/src/po/es.po  | 4 +-
src/pl/plpgsql/src/po/sv.po  |   820 ++
src/pl/plpython/nls.mk   | 2 +-
src/pl/plpython/po/de.po |   117 +-
src/pl/plpython/po/es.po | 4 +-
src/pl/plpython/po/sv.po |   464 ++
src/pl/tcl/nls.mk| 2 +-
src/pl/tcl/po/es.po  | 4 +-
src/pl/tcl/po/sv.po  |   105 +
75 files changed, 32377 insertions(+), 10037 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Translation updates

[Peter Eisentraut]

Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: 6535410ecbfd22426b13c2ddb1302145d66c1b4d

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/5fa4515a6a8536684285bc4837ec352fe2afe012

Modified Files
--
src/backend/po/es.po| 7911 ---
src/backend/po/fr.po| 1257 ++---
src/backend/po/it.po|  712 +--
src/backend/po/pt_BR.po | 1377 +++---
src/backend/po/ru.po|  759 +--
src/bin/initdb/po/es.po |  377 +-
src/bin/pg_basebackup/po/es.po  |  347 +-
src/bin/pg_basebackup/po/ru.po  |2 +-
src/bin/pg_config/po/es.po  |   58 +-
src/bin/pg_controldata/po/es.po |   11 +-
src/bin/pg_ctl/po/es.po |  369 +-
src/bin/pg_ctl/po/it.po |   14 +-
src/bin/pg_dump/po/es.po| 1256 +++--
src/bin/pg_dump/po/pt_BR.po |  388 +-
src/bin/pg_dump/po/ru.po|  386 +-
src/bin/pg_resetxlog/po/de.po   |  212 +-
src/bin/pg_resetxlog/po/es.po   |   43 +-
src/bin/pg_resetxlog/po/fr.po   |  222 +-
src/bin/pg_resetxlog/po/pt_BR.po|  214 +-
src/bin/psql/po/de.po   |  932 ++--
src/bin/psql/po/es.po   |  531 +--
src/bin/psql/po/fr.po   | 3654 +++---
src/bin/psql/po/it.po   |  288 +-
src/bin/psql/po/pt_BR.po|  935 ++--
src/bin/psql/po/ru.po   |   27 +-
src/bin/scripts/po/es.po|  253 +-
src/interfaces/ecpg/ecpglib/po/es.po|   15 +-
src/interfaces/ecpg/preproc/po/es.po|   52 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |  110 +-
src/interfaces/ecpg/preproc/po/ru.po|   30 +-
src/interfaces/libpq/po/de.po   |  164 +-
src/interfaces/libpq/po/es.po   |  409 +-
src/interfaces/libpq/po/fr.po   |  420 +-
src/interfaces/libpq/po/it.po   |   66 +-
src/interfaces/libpq/po/pt_BR.po|  339 +-
src/interfaces/libpq/po/ru.po   |   68 +-
src/pl/plperl/po/es.po  |  104 +-
src/pl/plpgsql/src/po/es.po |  138 +-
src/pl/plpython/po/es.po|  154 +-
src/pl/tcl/po/es.po |   16 +-
40 files changed, 10999 insertions(+), 13621 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Translation updates

[Peter Eisentraut]

Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: d81b8e4ab322171b7ea691c01513ede1cf398404

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/aa0f366d557c32aa29a1cae9d13d6d078b514abd

Modified Files
--
src/backend/po/es.po| 8407 +++
src/backend/po/fr.po| 2945 ++-
src/backend/po/it.po| 2133 
src/bin/initdb/po/es.po |  263 +-
src/bin/pg_basebackup/po/es.po  |  420 +-
src/bin/pg_basebackup/po/fr.po  |  512 +-
src/bin/pg_basebackup/po/it.po  |  420 +-
src/bin/pg_basebackup/po/pt_BR.po   |  402 +-
src/bin/pg_config/po/es.po  |2 +-
src/bin/pg_config/po/sv.po  |   18 +-
src/bin/pg_controldata/po/es.po |2 +-
src/bin/pg_ctl/po/es.po |2 +-
src/bin/pg_ctl/po/it.po |   14 +-
src/bin/pg_dump/po/de.po|  538 +-
src/bin/pg_dump/po/es.po|  882 ++--
src/bin/pg_dump/po/fr.po| 1355 +++--
src/bin/pg_dump/po/pt_BR.po |  757 +--
src/bin/pg_resetxlog/po/de.po   |  240 +-
src/bin/pg_resetxlog/po/es.po   |2 +-
src/bin/pg_resetxlog/po/fr.po   |  270 +-
src/bin/pg_resetxlog/po/pt_BR.po|  238 +-
src/bin/pg_rewind/po/es.po  |  198 +-
src/bin/pg_rewind/po/fr.po  |   48 +-
src/bin/pg_rewind/po/pt_BR.po   |   46 +-
src/bin/psql/nls.mk |2 +-
src/bin/psql/po/de.po   | 1321 ++---
src/bin/psql/po/es.po   | 2888 ++-
src/bin/psql/po/fr.po   | 3621 ++---
src/bin/psql/po/it.po   |   24 +-
src/bin/psql/po/pt_BR.po| 1347 ++---
src/bin/psql/po/sv.po   | 5542 
src/bin/scripts/po/es.po|  184 +-
src/interfaces/ecpg/ecpglib/po/es.po|2 +-
src/interfaces/ecpg/preproc/po/es.po|  133 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |  120 +-
src/interfaces/libpq/po/de.po   |  205 +-
src/interfaces/libpq/po/es.po   |  369 +-
src/interfaces/libpq/po/fr.po   |  439 +-
src/interfaces/libpq/po/it.po   |   57 +-
src/interfaces/libpq/po/pt_BR.po|  336 +-
src/pl/plperl/po/es.po  |   10 +-
src/pl/plpgsql/src/po/es.po |  244 +-
src/pl/plpython/po/es.po|  101 +-
src/pl/plpython/po/pt_BR.po |   89 +-
src/pl/tcl/po/es.po |   22 +-
45 files changed, 21234 insertions(+), 15936 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Translation updates

[Peter Eisentraut]

Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: 0858deb5ec238f269d1311ff1299f003fc168cab

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/61f52850f5809ff62b8d2605ded0503f6a822ec9

Modified Files
--
src/backend/po/es.po| 3669 ---
src/backend/po/fr.po| 1329 +--
src/backend/po/it.po|  716 +++---
src/backend/po/pt_BR.po | 1473 +++--
src/backend/po/ru.po|  763 +++
src/bin/initdb/po/es.po |  434 ++--
src/bin/pg_basebackup/po/es.po  |  446 ++--
src/bin/pg_basebackup/po/fr.po  |  370 ++--
src/bin/pg_basebackup/po/it.po  |  270 +--
src/bin/pg_basebackup/po/pt_BR.po   |  278 ++-
src/bin/pg_basebackup/po/ru.po  |   12 +-
src/bin/pg_config/po/es.po  |   74 +-
src/bin/pg_controldata/po/es.po |   11 +-
src/bin/pg_ctl/po/es.po |  376 ++--
src/bin/pg_ctl/po/it.po |   14 +-
src/bin/pg_dump/po/de.po|  427 ++--
src/bin/pg_dump/po/es.po| 1412 ++--
src/bin/pg_dump/po/fr.po|  726 +++---
src/bin/pg_dump/po/pt_BR.po |  431 ++--
src/bin/pg_dump/po/ru.po|  382 ++--
src/bin/pg_resetxlog/po/de.po   |  216 +-
src/bin/pg_resetxlog/po/es.po   |   47 +-
src/bin/pg_resetxlog/po/fr.po   |  232 +-
src/bin/pg_resetxlog/po/pt_BR.po|  218 +-
src/bin/psql/po/de.po   |  746 +++
src/bin/psql/po/es.po   | 1077 -
src/bin/psql/po/fr.po   | 3374 ++--
src/bin/psql/po/it.po   |   22 +-
src/bin/psql/po/pt_BR.po|  743 ---
src/bin/psql/po/ru.po   |   27 +-
src/bin/scripts/po/es.po|  255 +--
src/interfaces/ecpg/ecpglib/po/es.po|   13 +-
src/interfaces/ecpg/preproc/po/es.po|   52 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |  119 +-
src/interfaces/ecpg/preproc/po/ru.po|   30 +-
src/interfaces/libpq/po/de.po   |  192 +-
src/interfaces/libpq/po/es.po   |  541 ++---
src/interfaces/libpq/po/fr.po   |  426 ++--
src/interfaces/libpq/po/it.po   |   96 +-
src/interfaces/libpq/po/pt_BR.po|  361 ++-
src/interfaces/libpq/po/ru.po   |   98 +-
src/pl/plperl/po/es.po  |  104 +-
src/pl/plpgsql/src/po/es.po |  156 +-
src/pl/plpython/po/es.po|  154 +-
src/pl/tcl/po/es.po |   16 +-
45 files changed, 11178 insertions(+), 11750 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Translation updates

[Peter Eisentraut]

Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: d316c7f205275603a833ab9758ce51a76846ec58

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/caada7c9bdbc41f4204516a099e25b85cd846004

Modified Files
--
src/backend/po/es.po| 7319 ---
src/backend/po/fr.po| 2122 -
src/backend/po/it.po| 1564 +++
src/backend/po/ru.po| 1619 +++
src/bin/initdb/po/es.po |  296 +-
src/bin/initdb/po/ru.po |6 +-
src/bin/pg_basebackup/po/es.po  |  426 +-
src/bin/pg_basebackup/po/fr.po  |  506 +--
src/bin/pg_basebackup/po/it.po  |  416 +-
src/bin/pg_basebackup/po/pt_BR.po   |  420 +-
src/bin/pg_basebackup/po/ru.po  |  104 +-
src/bin/pg_config/po/es.po  |2 +-
src/bin/pg_controldata/po/es.po |   10 +-
src/bin/pg_controldata/po/ru.po |2 +-
src/bin/pg_ctl/po/es.po |  312 +-
src/bin/pg_ctl/po/it.po |   14 +-
src/bin/pg_ctl/po/ru.po |2 +-
src/bin/pg_dump/po/de.po|  512 ++-
src/bin/pg_dump/po/es.po| 1030 ++---
src/bin/pg_dump/po/fr.po| 2016 +
src/bin/pg_dump/po/pt_BR.po |  731 +--
src/bin/pg_dump/po/ru.po|  390 +-
src/bin/pg_resetxlog/po/de.po   |  236 +-
src/bin/pg_resetxlog/po/es.po   |   18 +-
src/bin/pg_resetxlog/po/fr.po   |  270 +-
src/bin/pg_resetxlog/po/pt_BR.po|  238 +-
src/bin/pg_rewind/po/es.po  |  221 +-
src/bin/pg_rewind/po/fr.po  |  314 +-
src/bin/pg_rewind/po/pt_BR.po   |   46 +-
src/bin/pg_rewind/po/ru.po  |2 +-
src/bin/psql/po/de.po   | 1001 ++---
src/bin/psql/po/es.po   | 2045 -
src/bin/psql/po/fr.po   | 4346 +-
src/bin/psql/po/it.po   |   22 +-
src/bin/psql/po/pt_BR.po| 1001 ++---
src/bin/psql/po/ru.po   |   29 +-
src/bin/scripts/po/es.po|  190 +-
src/bin/scripts/po/ru.po|2 +-
src/interfaces/ecpg/ecpglib/po/es.po|2 +-
src/interfaces/ecpg/ecpglib/po/ru.po|2 +-
src/interfaces/ecpg/preproc/po/es.po|   54 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |  123 +-
src/interfaces/ecpg/preproc/po/ru.po|   34 +-
src/interfaces/libpq/po/de.po   |  198 +-
src/interfaces/libpq/po/es.po   |  416 +-
src/interfaces/libpq/po/fr.po   |  432 +-
src/interfaces/libpq/po/it.po   |   54 +-
src/interfaces/libpq/po/pt_BR.po|  435 +-
src/interfaces/libpq/po/ru.po   |   56 +-
src/pl/plperl/po/es.po  |   46 +-
src/pl/plperl/po/ru.po  |2 +-
src/pl/plpgsql/src/po/es.po |  148 +-
src/pl/plpgsql/src/po/ru.po |2 +-
src/pl/plpython/po/es.po|   70 +-
src/pl/plpython/po/pt_BR.po |   37 +-
src/pl/plpython/po/ru.po|2 +-
src/pl/tcl/po/es.po |   22 +-
src/pl/tcl/po/ru.po |2 +-
58 files changed, 16285 insertions(+), 15652 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Translation updates

[Peter Eisentraut]

Translation updates

Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git
Source-Git-Hash: b2b00a01f84ab4de02d4a4c954ca664bcb67becc

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/7ba2831555e71a5c8ad63bdca9f8006684772a16

Modified Files
--
src/backend/po/es.po| 8014 ---
src/backend/po/fr.po| 1636 +++
src/backend/po/it.po| 1107 ++---
src/backend/po/pt_BR.po | 1859 +++
src/backend/po/ru.po| 1161 ++---
src/bin/initdb/po/es.po |  316 +-
src/bin/pg_basebackup/po/es.po  |  422 +-
src/bin/pg_basebackup/po/fr.po  |  503 +-
src/bin/pg_basebackup/po/it.po  |  411 +-
src/bin/pg_basebackup/po/pt_BR.po   |  416 +-
src/bin/pg_basebackup/po/ru.po  |  102 +-
src/bin/pg_config/po/es.po  |2 +-
src/bin/pg_controldata/po/es.po |2 +-
src/bin/pg_ctl/po/es.po |  292 +-
src/bin/pg_ctl/po/it.po |   14 +-
src/bin/pg_dump/po/de.po|  489 +-
src/bin/pg_dump/po/es.po|  948 ++--
src/bin/pg_dump/po/fr.po| 1614 +++
src/bin/pg_dump/po/pt_BR.po |  493 +-
src/bin/pg_dump/po/ru.po|  376 +-
src/bin/pg_resetxlog/po/de.po   |  238 +-
src/bin/pg_resetxlog/po/es.po   |2 +-
src/bin/pg_resetxlog/po/fr.po   |  254 +-
src/bin/pg_resetxlog/po/pt_BR.po|  240 +-
src/bin/psql/po/de.po   |  906 ++--
src/bin/psql/po/es.po   | 1665 +++
src/bin/psql/po/fr.po   | 4257 
src/bin/psql/po/it.po   |   22 +-
src/bin/psql/po/pt_BR.po|  908 ++--
src/bin/psql/po/ru.po   |   27 +-
src/bin/scripts/po/es.po|  132 +-
src/interfaces/ecpg/ecpglib/po/es.po|4 +-
src/interfaces/ecpg/preproc/po/es.po|   54 +-
src/interfaces/ecpg/preproc/po/pt_BR.po |  123 +-
src/interfaces/ecpg/preproc/po/ru.po|   32 +-
src/interfaces/libpq/po/de.po   |  198 +-
src/interfaces/libpq/po/es.po   |  418 +-
src/interfaces/libpq/po/fr.po   |  440 +-
src/interfaces/libpq/po/it.po   |  102 +-
src/interfaces/libpq/po/pt_BR.po|  367 +-
src/interfaces/libpq/po/ru.po   |  104 +-
src/pl/plperl/po/es.po  |   40 +-
src/pl/plpgsql/src/po/es.po |   14 +-
src/pl/plpython/po/es.po|   66 +-
src/pl/tcl/po/es.po |   16 +-
45 files changed, 15543 insertions(+), 15263 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Andrew Dunstan]

On 07/31/2017 01:02 PM, Tom Lane wrote:
> Record full paths of programs sought by "configure".
>
> Previously we had a mix of uses of AC_CHECK_PROG[S] and AC_PATH_PROG[S].
> The only difference between those macros is that the latter emits the
> full path to the program it finds, eg "/usr/bin/prove", whereas the
> former emits just "prove".  Let's standardize on always emitting the
> full path; this is better for documentation of the build, and it might
> prevent some types of failures if later build steps are done with
> a different PATH setting.
>
> I did not touch the AC_CHECK_PROG[S] calls in ax_pthread.m4 and
> ax_prog_perl_modules.m4.  There seems no need to make those diverge from
> upstream, since we do not record the programs sought by the former, while
> the latter's call to AC_CHECK_PROG(PERL,...) will never be reached.
>
> Discussion: https://postgr.es/m/25937.1501433...@sss.pgh.pa.us


The problem with this commit, as jacana is demonstrating, is that on Msys it 
finds the wrong prove. configure needs to run against the perl we build 
against, i.e. a native Windows perl, but prove needs to run with the perl from 
the MSys DTK that understands MSys virtualized paths. I have a hack that will 
allow the buildfarm to overcome the difficulty, (essentially it passes 
'PROVE=prove' to make) but that's fairly ugly and certainly non-intuitive for 
someone running an MSys build and TAP tests without the buildfarm client.

cheers

andrew 


-- 
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Update SQL features list

[Peter Eisentraut]

Update SQL features list

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/cdc47d1f3942451952e2d8409069a5d1fa741fa8

Modified Files
--
src/backend/catalog/sql_features.txt | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Tom Lane]

Andrew Dunstan  writes:
> On 07/31/2017 01:02 PM, Tom Lane wrote:
>> Record full paths of programs sought by "configure".

> The problem with this commit, as jacana is demonstrating, is that on
> Msys it finds the wrong prove. configure needs to run against the perl
> we build against, i.e. a native Windows perl, but prove needs to run
> with the perl from the MSys DTK that understands MSys virtualized
> paths. I have a hack that will allow the buildfarm to overcome the
> difficulty, (essentially it passes 'PROVE=prove' to make) but that's
> fairly ugly and certainly non-intuitive for someone running an MSys
> build and TAP tests without the buildfarm client.

I'm confused.  AFAIK, that commit did not change which "prove" would
be used --- at least not unless you change PATH between configure and
make.  It only changed how specifically that program would be named in
Makefile.global.  Please clarify how that broke anything.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Andrew Dunstan]

On 08/07/2017 03:21 PM, Tom Lane wrote:
> Andrew Dunstan  writes:
>> On 07/31/2017 01:02 PM, Tom Lane wrote:
>>> Record full paths of programs sought by "configure".
>> The problem with this commit, as jacana is demonstrating, is that on
>> Msys it finds the wrong prove. configure needs to run against the perl
>> we build against, i.e. a native Windows perl, but prove needs to run
>> with the perl from the MSys DTK that understands MSys virtualized
>> paths. I have a hack that will allow the buildfarm to overcome the
>> difficulty, (essentially it passes 'PROVE=prove' to make) but that's
>> fairly ugly and certainly non-intuitive for someone running an MSys
>> build and TAP tests without the buildfarm client.
> I'm confused.  AFAIK, that commit did not change which "prove" would
> be used --- at least not unless you change PATH between configure and
> make.  It only changed how specifically that program would be named in
> Makefile.global.  Please clarify how that broke anything.
>
>   




That's exactly what we do. See
 at
line 1649.

cheers

andrew


-- 
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Tom Lane]

Andrew Dunstan  writes:
> On 08/07/2017 03:21 PM, Tom Lane wrote:
>> I'm confused.  AFAIK, that commit did not change which "prove" would
>> be used --- at least not unless you change PATH between configure and
>> make.  It only changed how specifically that program would be named in
>> Makefile.global.  Please clarify how that broke anything.

> That's exactly what we do. See
>  at
> line 1649.

My goodness, that's ugly.  Is it really better than injecting
"PROVE=prove"?  (I'd suggest saying that to configure, not make,
so that the configure log bears some resemblance to what you
want done.)

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Andrew Dunstan]

On 08/07/2017 03:36 PM, Tom Lane wrote:
> Andrew Dunstan  writes:
>> On 08/07/2017 03:21 PM, Tom Lane wrote:
>>> I'm confused.  AFAIK, that commit did not change which "prove" would
>>> be used --- at least not unless you change PATH between configure and
>>> make.  It only changed how specifically that program would be named in
>>> Makefile.global.  Please clarify how that broke anything.
>> That's exactly what we do. See
>>  at
>> line 1649.
> My goodness, that's ugly.  Is it really better than injecting
> "PROVE=prove"?  (I'd suggest saying that to configure, not make,
> so that the configure log bears some resemblance to what you
> want done.)
>
>   



This is what we had to do BEFORE the change in this commit. Now it's no
longer sufficient.

It would certainly be better if we could tell configure a path to prove
and a path to the perl we need to test IPC::Run against.

e.g. PROVE=/usr/bin/prove PROVE_PERL=/usr/bin/perl configure ...

The problem in all this is that we're assuming incorrectly that the perl
we use to build against is the same as the perl we need to run the build
with. On Msys that's emphatically not true.

cheers

andrew

-- 
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Tom Lane]

Andrew Dunstan  writes:
> On 08/07/2017 03:36 PM, Tom Lane wrote:
>> My goodness, that's ugly.  Is it really better than injecting
>> "PROVE=prove"?  (I'd suggest saying that to configure, not make,
>> so that the configure log bears some resemblance to what you
>> want done.)

> This is what we had to do BEFORE the change in this commit. Now it's no
> longer sufficient.

Sorry, I was imprecise.  What I'm suggesting is that you drop the
runtime PATH-foolery and instead put this in configure's environment:

PROVE=$perlpathdir/prove

Otherwise you're basically lying to configure about what you're going
to use, and that's always going to break eventually.

> It would certainly be better if we could tell configure a path to prove
> and a path to the perl we need to test IPC::Run against.

Hm, yeah, the IPC::Run test would need to deal with this as well.
A PROVE_PERL environment variable is one way.  Or maybe simpler,
just skip the probe for IPC::Run if PROVE has been specified
externally; assume the user knows what he's doing in that case.
Are there any other gotchas in the build sequence?

> The problem in all this is that we're assuming incorrectly that the perl
> we use to build against is the same as the perl we need to run the build

... I think you meant "TAP tests" here ? --- ^

> with. On Msys that's emphatically not true.

Do we have/need any explicit references to the test version of "perl",
or is "prove" a sufficient API?

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Andrew Dunstan]

On 08/07/2017 04:07 PM, Tom Lane wrote:
> Andrew Dunstan  writes:
>> On 08/07/2017 03:36 PM, Tom Lane wrote:
>>> My goodness, that's ugly.  Is it really better than injecting
>>> "PROVE=prove"?  (I'd suggest saying that to configure, not make,
>>> so that the configure log bears some resemblance to what you
>>> want done.)
>> This is what we had to do BEFORE the change in this commit. Now it's no
>> longer sufficient.
> Sorry, I was imprecise.  What I'm suggesting is that you drop the
> runtime PATH-foolery and instead put this in configure's environment:
>
> PROVE=$perlpathdir/prove
>
> Otherwise you're basically lying to configure about what you're going
> to use, and that's always going to break eventually.



Hmm, you're saying this should work now? OK, I'll try it when I get a
minute to spare.


>
>> It would certainly be better if we could tell configure a path to prove
>> and a path to the perl we need to test IPC::Run against.
> Hm, yeah, the IPC::Run test would need to deal with this as well.
> A PROVE_PERL environment variable is one way.  Or maybe simpler,
> just skip the probe for IPC::Run if PROVE has been specified
> externally; assume the user knows what he's doing in that case.


WFM

> Are there any other gotchas in the build sequence?
>


Not that I can think of.

> Do we have/need any explicit references to the test version of "perl",
> or is "prove" a sufficient API?
>
>   


Probably sufficient.

cheers

andrew


-- 
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Tom Lane]

Andrew Dunstan  writes:
> On 08/07/2017 04:07 PM, Tom Lane wrote:
>> Sorry, I was imprecise.  What I'm suggesting is that you drop the
>> runtime PATH-foolery and instead put this in configure's environment:
>> 
>> PROVE=$perlpathdir/prove
>> 
>> Otherwise you're basically lying to configure about what you're going
>> to use, and that's always going to break eventually.

> Hmm, you're saying this should work now? OK, I'll try it when I get a
> minute to spare.

I'm pretty sure it's always worked, at least in the sense that you could
override what configure would put into Makefile.global that way.  I'm not
quite clear on whether providing an exact path to "prove" there is enough
to fix your problem.  If we have any places where we need to invoke the
corresponding version of "perl", then we have more things to fix.

>> Hm, yeah, the IPC::Run test would need to deal with this as well.
>> A PROVE_PERL environment variable is one way.  Or maybe simpler,
>> just skip the probe for IPC::Run if PROVE has been specified
>> externally; assume the user knows what he's doing in that case.

> WFM

OK, I'll go make that happen.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

[Andrew Dunstan]

On 08/07/2017 04:20 PM, Tom Lane wrote:
> Andrew Dunstan  writes:
>> On 08/07/2017 04:07 PM, Tom Lane wrote:
>>> Sorry, I was imprecise.  What I'm suggesting is that you drop the
>>> runtime PATH-foolery and instead put this in configure's environment:
>>>
>>> PROVE=$perlpathdir/prove
>>>
>>> Otherwise you're basically lying to configure about what you're going
>>> to use, and that's always going to break eventually.
>> Hmm, you're saying this should work now? OK, I'll try it when I get a
>> minute to spare.
> I'm pretty sure it's always worked, at least in the sense that you could
> override what configure would put into Makefile.global that way.  I'm not
> quite clear on whether providing an exact path to "prove" there is enough
> to fix your problem.  If we have any places where we need to invoke the
> corresponding version of "perl", then we have more things to fix.


I'm pretty sure that's all we need. But we can find out ;-)


>
>>> Hm, yeah, the IPC::Run test would need to deal with this as well.
>>> A PROVE_PERL environment variable is one way.  Or maybe simpler,
>>> just skip the probe for IPC::Run if PROVE has been specified
>>> externally; assume the user knows what he's doing in that case.
>> WFM
> OK, I'll go make that happen.
>
>   



OK, thanks.

cheers

andrew

-- 
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Skip test for IPC::Run if user is overriding our search for PROV

[Tom Lane]

Skip test for IPC::Run if user is overriding our search for PROVE.

The check for IPC::Run we added in commit c254970ad is useful in simple
cases, but there are real use-cases where "prove" is coming from a
different Perl installation than the "perl" we want to use to build.
In such cases asking whether "perl" knows about IPC::Run is irrelevant
and can cause an unnecessary configure failure.  Hence, if user has
specified a value for PROVE, skip the IPC::Run check.  Per discussion
with Andrew Dunstan.

Discussion: https://postgr.es/m/e1dce5n-0005sk...@gemulon.postgresql.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/8014d2afa7b817c98544cace7efc337ee891aa57

Modified Files
--
configure| 123 ++-
configure.in |  15 +---
2 files changed, 72 insertions(+), 66 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Stamp 10beta3.

[Tom Lane]

Stamp 10beta3.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/8d6442377df5451a8db598788847e6a70b3b49ef

Modified Files
--
configure | 18 +-
configure.in  |  2 +-
doc/bug.template  |  2 +-
src/include/pg_config.h.win32 |  6 +++---
4 files changed, 14 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Stamp 9.6.4.

[Tom Lane]

Stamp 9.6.4.

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/eca2f8a7dd9bda862a25fcc57ddf77f7c0dc3afe

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Stamp 9.5.8.

[Tom Lane]

Stamp 9.5.8.

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/029386ccbddd0a33d481b94e511f5219b03e6636

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Stamp 9.4.13.

[Tom Lane]

Stamp 9.4.13.

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6d81d0a215a5b843bf003b0a1c4b43f6d278

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Stamp 9.3.18.

[Tom Lane]

Stamp 9.3.18.

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/a5915db2fab1fbe555b6410440df5177a247a2f2

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Stamp 9.2.22.

[Tom Lane]

Stamp 9.2.22.

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/56fc4f7c9c8168b93b45ccf48781d77073d271dc

Modified Files
--
configure| 18 +-
configure.in |  2 +-
doc/bug.template |  2 +-
src/include/pg_config.h.win32|  8 
src/interfaces/libpq/libpq.rc.in |  8 
src/port/win32ver.rc |  4 ++--
6 files changed, 21 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Disclaim xmltable() support for non-UTF8 databases.

[Noah Misch]

Disclaim xmltable() support for non-UTF8 databases.

The xmltable() implementation mirrors xpath(), including its lack of
character encoding awareness.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/b4a2eea030ba74ea84335c7d5bc999f693ffd9a4

Modified Files
--
doc/src/sgml/datatype.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers