[COMMITTERS] pgsql: Translation updates
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: ba86fd34c722d76964b1b1fcf14ea18435172529 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2800df278b3914044285980826b5c9db308971f Modified Files -- src/bin/pg_basebackup/po/sv.po | 75 +- src/bin/pg_dump/po/es.po| 909 --- src/bin/pg_rewind/po/es.po | 221 +- src/bin/pg_rewind/po/fr.po | 42 +- src/bin/pg_test_fsync/po/es.po | 121 +- src/bin/pg_test_timing/po/fr.po | 24 +- src/bin/pg_upgrade/po/fr.po | 108 +- src/bin/psql/po/de.po | 10 +- src/bin/psql/po/fr.po | 4959 --- src/bin/psql/po/sv.po | 2835 +++--- src/interfaces/libpq/po/fr.po | 168 +- 11 files changed, 4941 insertions(+), 4531 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove dead external links from documentation
Remove dead external links from documentation Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d31892e2105cf48d8430807d74d5fdf1434af541 Modified Files -- doc/src/sgml/installation.sgml | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove dead external links from documentation
Remove dead external links from documentation Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4f75e3bbd96fcb73e4995428c595b2698471871a Modified Files -- doc/src/sgml/installation.sgml | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update some dead external links in the documentation
Update some dead external links in the documentation Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b17c894293d0c3ed944da76aeb9bc2bb02a6db6 Modified Files -- doc/src/sgml/sepgsql.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update some dead external links in the documentation
Update some dead external links in the documentation Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/90906b855e8867f001339259ae5abd2048b92ac6 Modified Files -- doc/src/sgml/sepgsql.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix, or at least ameliorate, bugs in logicalrep_worker_launch().
Fix, or at least ameliorate, bugs in logicalrep_worker_launch(). If we failed to get a background worker slot, the code just walked away from the logicalrep-worker slot it already had, leaving that looking like the worker is still starting up. This led to an indefinite hang in subscription startup, as reported by Thomas Munro. We must release the slot on failure. Also fix a thinko: we must capture the worker slot's generation before releasing LogicalRepWorkerLock the first time, else testing to see if it's changed is pretty meaningless. BTW, the CHECK_FOR_INTERRUPTS() in WaitForReplicationWorkerAttach is a ticking time bomb, even without considering the possibility of elog(ERROR) in one of the other functions it calls. Really, this entire business needs a redesign with some actual thought about error recovery. But for now I'm just band-aiding the case observed in testing. Back-patch to v10 where this code was added. Discussion: https://postgr.es/m/CAEepm=2bp3tbmfbarp6o20azarduwjmnjcjt22hsdna-evr...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c1bde0747983993a695d12c4403a730b2be579d2 Modified Files -- src/backend/replication/logical/launcher.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix, or at least ameliorate, bugs in logicalrep_worker_launch().
Fix, or at least ameliorate, bugs in logicalrep_worker_launch(). If we failed to get a background worker slot, the code just walked away from the logicalrep-worker slot it already had, leaving that looking like the worker is still starting up. This led to an indefinite hang in subscription startup, as reported by Thomas Munro. We must release the slot on failure. Also fix a thinko: we must capture the worker slot's generation before releasing LogicalRepWorkerLock the first time, else testing to see if it's changed is pretty meaningless. BTW, the CHECK_FOR_INTERRUPTS() in WaitForReplicationWorkerAttach is a ticking time bomb, even without considering the possibility of elog(ERROR) in one of the other functions it calls. Really, this entire business needs a redesign with some actual thought about error recovery. But for now I'm just band-aiding the case observed in testing. Back-patch to v10 where this code was added. Discussion: https://postgr.es/m/CAEepm=2bp3tbmfbarp6o20azarduwjmnjcjt22hsdna-evr...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3e1683d37e1d751eb2df9a5cb0507bebc6cf7d05 Modified Files -- src/backend/replication/logical/launcher.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make DatumGetFoo/PG_GETARG_FOO/PG_RETURN_FOO macro names more co
Make DatumGetFoo/PG_GETARG_FOO/PG_RETURN_FOO macro names more consistent. By project convention, these names should include "P" when dealing with a pointer type; that is, if the result of a GETARG macro is of type FOO *, it should be called PG_GETARG_FOO_P not just PG_GETARG_FOO. Some newer types such as JSONB and ranges had not followed the convention, and a number of contrib modules hadn't gotten that memo either. Rename the offending macros to improve consistency. In passing, fix a few places that thought PG_DETOAST_DATUM() returns a Datum; it does not, it returns "struct varlena *". Applying DatumGetPointer to that happens not to cause any bad effects today, but it's formally wrong. Also, adjust an ltree macro that was designed without any thought for what pgindent would do with it. This is all cosmetic and shouldn't have any impact on generated code. Mark Dilger, some further tweaks by me Discussion: https://postgr.es/m/ea5676f4-766f-4f38-8348-ecc7db427...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4bd1994650fddf49e717e35f1930d62208845974 Modified Files -- contrib/btree_gist/btree_text.c | 2 +- contrib/btree_gist/btree_utils_var.c | 6 +- contrib/cube/cube.c | 151 +- contrib/cube/cubedata.h | 6 +- contrib/hstore/hstore.h | 2 +- contrib/hstore/hstore_gin.c | 4 +- contrib/hstore/hstore_gist.c | 2 +- contrib/hstore/hstore_io.c| 14 +-- contrib/hstore/hstore_op.c| 50 - contrib/hstore_plperl/hstore_plperl.c | 2 +- contrib/hstore_plpython/hstore_plpython.c | 2 +- contrib/ltree/_ltree_gist.c | 2 +- contrib/ltree/_ltree_op.c | 16 +-- contrib/ltree/lquery_op.c | 6 +- contrib/ltree/ltree.h | 21 +++- contrib/ltree/ltree_gist.c| 26 ++--- contrib/ltree/ltree_io.c | 4 +- contrib/ltree/ltree_op.c | 68 ++-- contrib/ltree/ltxtquery_io.c | 2 +- contrib/ltree/ltxtquery_op.c | 4 +- contrib/ltree_plpython/ltree_plpython.c | 2 +- src/backend/tsearch/to_tsany.c| 6 +- src/backend/tsearch/wparser.c | 4 +- src/backend/utils/adt/array_expanded.c| 4 +- src/backend/utils/adt/arrayfuncs.c| 46 src/backend/utils/adt/jsonb.c | 8 +- src/backend/utils/adt/jsonb_gin.c | 12 +- src/backend/utils/adt/jsonb_op.c | 48 src/backend/utils/adt/jsonfuncs.c | 94 src/backend/utils/adt/rangetypes.c| 134 +++ src/backend/utils/adt/rangetypes_gist.c | 96 src/backend/utils/adt/rangetypes_selfuncs.c | 4 +- src/backend/utils/adt/rangetypes_spgist.c | 54 - src/backend/utils/adt/rangetypes_typanalyze.c | 2 +- src/backend/utils/adt/tsgistidx.c | 4 +- src/include/utils/array.h | 4 +- src/include/utils/jsonb.h | 8 +- src/include/utils/rangetypes.h| 12 +- 38 files changed, 471 insertions(+), 461 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make ExplainOpenGroup and ExplainCloseGroup public.
Make ExplainOpenGroup and ExplainCloseGroup public. Extensions with custom plan nodes might like to use these in their EXPLAIN output. Hadi Moshayedi Discussion: https://postgr.es/m/CA+_kT_dU-rHCN0u6pjA6bN5CZniMfD=-wvqpy4qlrkuy_uj...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/66917bfaa7bb0b6bae52a5fe631a8b6443203f55 Modified Files -- src/backend/commands/explain.c | 8 ++-- src/include/commands/explain.h | 5 + 2 files changed, 7 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Minor code-cleanliness improvements for btree.
Minor code-cleanliness improvements for btree. Make the btree page-flags test macros (P_ISLEAF and friends) return clean boolean values, rather than values that might not fit in a bool. Use them in a few places that were randomly referencing the flag bits directly. In passing, change access/nbtree/'s only direct use of BUFFER_LOCK_SHARE to BT_READ. (Some think we should go the other way, but as long as we have BT_READ/BT_WRITE, let's use them consistently.) Masahiko Sawada, reviewed by Doug Doole Discussion: https://postgr.es/m/CAD21AoBmWPeN=wbb5jvyz_nt3rmw1ebuyank3zbjp3rmxal...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb5c404b17752ca566947f12cb702438dcccdcb1 Modified Files -- contrib/amcheck/verify_nbtree.c | 4 ++-- contrib/pgstattuple/pgstattuple.c | 2 +- src/backend/access/nbtree/nbtpage.c | 6 +++--- src/backend/access/nbtree/nbtxlog.c | 4 ++-- src/include/access/nbtree.h | 16 5 files changed, 16 insertions(+), 16 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e5b8b771e7a98e3620679cd9873ad2507ab87fb5 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/149cfdb3a2e9969cbadc1d6b5bfee88f974086f4 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/59b5a3e5c72e4b91876df226eab09dc97c6e190e Modified Files -- src/interfaces/ecpg/preproc/ecpg.header | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/75fbf8ad1209e3711704dd6194926a2d60a8d849 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3a5aa7de311788d9f5ae2fb235801738ae888b50 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Stamp 10rc1.
Stamp 10rc1. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dc28213c3e0b8f2b71d75bb8c779b9dd0fce5670 Modified Files -- configure | 18 +- configure.in | 2 +- doc/bug.template | 2 +- src/include/pg_config.h.win32 | 6 +++--- 4 files changed, 14 insertions(+), 14 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add test for postmaster crash restarts.
Add test for postmaster crash restarts. Given that I managed to break this... We probably should extend the tests to also cover other sub-processes dying, but that's something for later. Author: Andres Freund Discussion: https://postgr.es/m/20170917080752.rcmihzfmgbeuq...@alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a1924a4ea29399111e5155532ca24c9c51d3c82d Modified Files -- src/test/recovery/t/013_crash_restart.pl | 192 +++ 1 file changed, 192 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix crash restart bug introduced in 8356753c212.
Fix crash restart bug introduced in 8356753c212. The bug was caused by not re-reading the control file during crash recovery restarts, which lead to an attempt to pfree() shared memory contents. The fix is to re-read the control file, which seems good anyway. It's unclear as of this moment, whether we want to keep the refactoring introduced in the commit referenced above, or come up with an alternative approach. But fixing the bug in the mean time seems like a good idea regardless. A followup commit will introduce regression test coverage for crash restarts. Reported-By: Tom Lane Discussion: https://postgr.es/m/14134.1505572...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ec9e05b3c392ba9587f283507459737684539574 Modified Files -- src/backend/access/transam/xlog.c | 44 +++-- src/backend/postmaster/postmaster.c | 13 --- src/backend/tcop/postgres.c | 2 +- src/include/access/xlog.h | 2 +- 4 files changed, 39 insertions(+), 22 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix uninitialized variable in dshash.c.
Fix uninitialized variable in dshash.c. A bugfix for commit 8c0d7bafad36434cb08ac2c78e69ae72c194ca20. The code would have crashed if hashtable->size_log2 ever had the same value as hashtable->control->size_log2 by coincidence. Per Valgrind. Author: Thomas Munro Reported-By: Tomas Vondra Discussion: https://postgr.es/m/e72fb33c-4f31-f276-e972-263d9b59554d%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0fb9e4ace5ce4d479d839a720f32b99fdc87f455 Modified Files -- src/backend/lib/dshash.c | 9 + 1 file changed, 9 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Rearm statement_timeout after each executed query.
Rearm statement_timeout after each executed query. Previously statement_timeout, in the extended protocol, affected all messages till a Sync message. For clients that pipeline/batch query execution that's problematic. Instead disable timeout after each Execute message, and enable, if necessary, the timer in start_xact_command(). As that's done only for Execute and not Parse / Bind, pipelining the latter two could still cause undesirable timeouts. But a survey of protocol implementations shows that all drivers issue Sync messages when preparing, and adding timeout rearming to both is fairly expensive for the common parse / bind / execute sequence. Author: Tatsuo Ishii, editorialized by Andres Freund Reviewed-By: Takayuki Tsunakawa, Andres Freund Discussion: https://postgr.es/m/20170222.115044.1665674502985097185.t-is...@sraoss.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f8e5f156b30efee5d0038b03e38735773abcb7ed Modified Files -- src/backend/tcop/postgres.c | 77 ++--- 1 file changed, 65 insertions(+), 12 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.
Andres Freund writes: > Add test for postmaster crash restarts. Hm, calliphoridae doesn't like this. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.
On September 18, 2017 8:55:35 PM PDT, Tom Lane wrote: >Andres Freund writes: >> Add test for postmaster crash restarts. > >Hm, calliphoridae doesn't like this. Yea. Not clear to me why yet. The machine ran a number of instances with nearly the same config successfully. Can't imagine that copyparse makes a difference here. I suspect it's somehow load related... Ran a good number of iterations locally, didn't reproduce, even under high load. Think I'll add bit more error reporting. Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
