[COMMITTERS] pgsql: Fix trivial mistake in README.

2017-09-26 Thread Robert Haas
Fix trivial mistake in README.

You might think I (Robert) could manage to count to five without
messing it up, but if you did, you would be wrong.

Amit Kapila

Discussion: 
http://postgr.es/m/CAA4eK1JxqqcuC5Un7YLQVhOYSZBS+t=3xqzuekt5ryquyux...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/79a4a665c046af91d4216fe69b535c429039d0d0

Modified Files
--
src/backend/access/hash/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove lsn from HashScanPosData.

2017-09-26 Thread Robert Haas
Remove lsn from HashScanPosData.

This was intended as infrastructure for weakening VACUUM's locking
requirements, similar to what was done for btree indexes in commit
2ed5b87f96d473962ec5230fd820abfeaccb2069.  However, for hash indexes,
it seems that the improvements which are possible are actually
extremely marginal.  Furthermore, performing the LSN cross-check will
end up skipping cleanup far more often than is necessary; we only care
about page modifications due to a VACUUM, but the LSN check will fail
if ANY modification has occurred.  So, rather than pressing forward
with that "optimization", just rip the LSN field out.

Patch by me, reviewed by Ashutosh Sharma and Amit Kapila

Discussion: 
http://postgr.es/m/CAA4eK1JxqqcuC5Un7YLQVhOYSZBS+t=3xqzuekt5ryquyux...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/22c5e73562c53437979efec4c26cd9fff408777c

Modified Files
--
src/backend/access/hash/hashsearch.c |  8 
src/backend/access/hash/hashutil.c   | 27 +++
src/include/access/hash.h|  2 --
3 files changed, 7 insertions(+), 30 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Handle heap rewrites better in logical replication

2017-09-26 Thread Peter Eisentraut
Handle heap rewrites better in logical replication

A FOR ALL TABLES publication naturally considers all base tables to be a
candidate for replication.  This includes transient heaps that are
created during a table rewrite during DDL.  This causes failures on the
subscriber side because it will not have a table like pg_temp_16386 to
receive data (and if it did, it would be the wrong table).

The prevent this problem, we filter out any tables that match this
naming pattern and match an actual table from FOR ALL TABLES
publications.  This is only a heuristic, meaning that user tables that
match that naming could accidentally be omitted.  A more robust solution
might require an explicit marking of such tables in pg_class somehow.

Reported-by: yxq 
Bug: #14785
Reviewed-by: Andres Freund 
Reviewed-by: Petr Jelinek 

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1a499c252049dad9016a04bcbab27b8c616d4d03

Modified Files
--
src/backend/replication/pgoutput/pgoutput.c | 26 ++
src/test/subscription/t/006_rewrite.pl  | 73 +
2 files changed, 99 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Handle heap rewrites better in logical replication

2017-09-26 Thread Peter Eisentraut
Handle heap rewrites better in logical replication

A FOR ALL TABLES publication naturally considers all base tables to be a
candidate for replication.  This includes transient heaps that are
created during a table rewrite during DDL.  This causes failures on the
subscriber side because it will not have a table like pg_temp_16386 to
receive data (and if it did, it would be the wrong table).

The prevent this problem, we filter out any tables that match this
naming pattern and match an actual table from FOR ALL TABLES
publications.  This is only a heuristic, meaning that user tables that
match that naming could accidentally be omitted.  A more robust solution
might require an explicit marking of such tables in pg_class somehow.

Reported-by: yxq 
Bug: #14785
Reviewed-by: Andres Freund 
Reviewed-by: Petr Jelinek 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ab28feae2bd3d4629bd73ae3548e671c57d785f0

Modified Files
--
src/backend/replication/pgoutput/pgoutput.c | 26 ++
src/test/subscription/t/006_rewrite.pl  | 73 +
2 files changed, 99 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Sort pg_basebackup options better

2017-09-26 Thread Peter Eisentraut
Sort pg_basebackup options better

The --slot option somehow ended up under options controlling the output,
and some other options were in a nonsensical place or were not moved
after recent renamings, so tidy all that up a bit.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/15a8010ed691f190aad19c0a205f4a17868591e9

Modified Files
--
doc/src/sgml/ref/pg_basebackup.sgml   | 100 +-
src/bin/pg_basebackup/pg_basebackup.c |   6 +-
2 files changed, 53 insertions(+), 53 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Use a blacklist to distinguish original from add-on enum values.

2017-09-26 Thread Tom Lane
Use a blacklist to distinguish original from add-on enum values.

Commit 15bc038f9 allowed ALTER TYPE ADD VALUE to be executed inside
transaction blocks, by disallowing the use of the added value later
in the same transaction, except under limited circumstances.  However,
the test for "limited circumstances" was heuristic and could reject
references to enum values that were created during CREATE TYPE AS ENUM,
not just later.  This breaks the use-case of restoring pg_dump scripts
in a single transaction, as reported in bug #14825 from Balazs Szilfai.

We can improve this by keeping a "blacklist" table of enum value OIDs
created by ALTER TYPE ADD VALUE during the current transaction.  Any
visible-but-uncommitted value whose OID is not in the blacklist must
have been created by CREATE TYPE AS ENUM, and can be used safely
because it could not have a lifespan shorter than its parent enum type.

This change also removes the restriction that a renamed enum value
can't be used before being committed (unless it was on the blacklist).

Andrew Dunstan, with cosmetic improvements by me.
Back-patch to v10.

Discussion: 
https://postgr.es/m/20170922185904.1448.16...@wrigleys.postgresql.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/1635e80d30b16df98aebead12f2b82f17efd9bc8

Modified Files
--
doc/src/sgml/ref/alter_type.sgml   |  2 --
src/backend/access/transam/xact.c  |  4 +++
src/backend/catalog/pg_enum.c  | 64 ++
src/backend/utils/adt/enum.c   |  9 ++
src/include/catalog/pg_enum.h  |  2 ++
src/test/regress/expected/enum.out | 21 +
src/test/regress/sql/enum.sql  | 13 
7 files changed, 113 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Use a blacklist to distinguish original from add-on enum values.

2017-09-26 Thread Tom Lane
Use a blacklist to distinguish original from add-on enum values.

Commit 15bc038f9 allowed ALTER TYPE ADD VALUE to be executed inside
transaction blocks, by disallowing the use of the added value later
in the same transaction, except under limited circumstances.  However,
the test for "limited circumstances" was heuristic and could reject
references to enum values that were created during CREATE TYPE AS ENUM,
not just later.  This breaks the use-case of restoring pg_dump scripts
in a single transaction, as reported in bug #14825 from Balazs Szilfai.

We can improve this by keeping a "blacklist" table of enum value OIDs
created by ALTER TYPE ADD VALUE during the current transaction.  Any
visible-but-uncommitted value whose OID is not in the blacklist must
have been created by CREATE TYPE AS ENUM, and can be used safely
because it could not have a lifespan shorter than its parent enum type.

This change also removes the restriction that a renamed enum value
can't be used before being committed (unless it was on the blacklist).

Andrew Dunstan, with cosmetic improvements by me.
Back-patch to v10.

Discussion: 
https://postgr.es/m/20170922185904.1448.16...@wrigleys.postgresql.org

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/175774d2932d969875b0709ec5f400ba19000c99

Modified Files
--
doc/src/sgml/ref/alter_type.sgml   |  2 --
src/backend/access/transam/xact.c  |  4 +++
src/backend/catalog/pg_enum.c  | 64 ++
src/backend/utils/adt/enum.c   |  9 ++
src/include/catalog/pg_enum.h  |  2 ++
src/test/regress/expected/enum.out | 21 +
src/test/regress/sql/enum.sql  | 13 
7 files changed, 113 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove heuristic same-transaction test from check_safe_enum_use(

2017-09-26 Thread Tom Lane
Remove heuristic same-transaction test from check_safe_enum_use().

The blacklist mechanism added by the preceding commit directly fixes
most of the practical cases that the same-transaction test was meant
to cover.  What remains is use-cases like

begin;
create type e as enum('x');
alter type e add value 'y';
-- use 'y' somehow
commit;

However, because the same-transaction test is heuristic, it fails on
small variants of that, such as renaming the type or changing its
owner.  Rather than try to explain the behavior to users, let's
remove it and just have a rule that the newly added value can't be
used before being committed, full stop.  Perhaps later it will be
worth the implementation effort and overhead to have a more accurate
test for type-was-created-in-this-transaction.  We'll wait for some
field experience with v10 before deciding to do that.

Back-patch to v10.

Discussion: 
https://postgr.es/m/20170922185904.1448.16...@wrigleys.postgresql.org

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/01c5de88ff242b379a033e46e4da6476f2213029

Modified Files
--
doc/src/sgml/ref/alter_type.sgml   |  3 +--
src/backend/utils/adt/enum.c   | 41 +-
src/test/regress/expected/enum.out | 18 -
src/test/regress/sql/enum.sql  | 11 +-
4 files changed, 24 insertions(+), 49 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Remove heuristic same-transaction test from check_safe_enum_use(

2017-09-26 Thread Tom Lane
Remove heuristic same-transaction test from check_safe_enum_use().

The blacklist mechanism added by the preceding commit directly fixes
most of the practical cases that the same-transaction test was meant
to cover.  What remains is use-cases like

begin;
create type e as enum('x');
alter type e add value 'y';
-- use 'y' somehow
commit;

However, because the same-transaction test is heuristic, it fails on
small variants of that, such as renaming the type or changing its
owner.  Rather than try to explain the behavior to users, let's
remove it and just have a rule that the newly added value can't be
used before being committed, full stop.  Perhaps later it will be
worth the implementation effort and overhead to have a more accurate
test for type-was-created-in-this-transaction.  We'll wait for some
field experience with v10 before deciding to do that.

Back-patch to v10.

Discussion: 
https://postgr.es/m/20170922185904.1448.16...@wrigleys.postgresql.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/984c92074d84a81dc17e9865fc79e264eb50ad61

Modified Files
--
doc/src/sgml/ref/alter_type.sgml   |  3 +--
src/backend/utils/adt/enum.c   | 41 +-
src/test/regress/expected/enum.out | 18 -
src/test/regress/sql/enum.sql  | 11 +-
4 files changed, 24 insertions(+), 49 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c.

posix_fallocate() is not quite a drop-in replacement for fallocate(),
because it is defined to return the error code as its function result,
not in "errno".  I (tgl) missed this because RHEL6's version seems
to set errno as well.  That is not the case on more modern Linuxen,
though, as per buildfarm results.

Aside from fixing the return-convention confusion, remove the test
for ENOSYS; we expect that glibc will mask that for posix_fallocate,
though it does not for fallocate.  Keep the test for EINTR, because
POSIX specifies that as a possible result, and buildfarm results
suggest that it can happen in practice.

Back-patch to 9.4, like the previous commit.

Thomas Munro

Discussion: 
https://postgr.es/m/1002664500.12301802.1471008223422.javamail.ya...@mail.yahoo.com

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/e5c058e2eed865114886823d010cece747914f8d

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c.

posix_fallocate() is not quite a drop-in replacement for fallocate(),
because it is defined to return the error code as its function result,
not in "errno".  I (tgl) missed this because RHEL6's version seems
to set errno as well.  That is not the case on more modern Linuxen,
though, as per buildfarm results.

Aside from fixing the return-convention confusion, remove the test
for ENOSYS; we expect that glibc will mask that for posix_fallocate,
though it does not for fallocate.  Keep the test for EINTR, because
POSIX specifies that as a possible result, and buildfarm results
suggest that it can happen in practice.

Back-patch to 9.4, like the previous commit.

Thomas Munro

Discussion: 
https://postgr.es/m/1002664500.12301802.1471008223422.javamail.ya...@mail.yahoo.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/5ea96efaa0100e96b6b927eb1e67869143e1db4e

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c.

posix_fallocate() is not quite a drop-in replacement for fallocate(),
because it is defined to return the error code as its function result,
not in "errno".  I (tgl) missed this because RHEL6's version seems
to set errno as well.  That is not the case on more modern Linuxen,
though, as per buildfarm results.

Aside from fixing the return-convention confusion, remove the test
for ENOSYS; we expect that glibc will mask that for posix_fallocate,
though it does not for fallocate.  Keep the test for EINTR, because
POSIX specifies that as a possible result, and buildfarm results
suggest that it can happen in practice.

Back-patch to 9.4, like the previous commit.

Thomas Munro

Discussion: 
https://postgr.es/m/1002664500.12301802.1471008223422.javamail.ya...@mail.yahoo.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/12ac252f9014a96c0b7159912659fa4d0f9cbc07

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c.

posix_fallocate() is not quite a drop-in replacement for fallocate(),
because it is defined to return the error code as its function result,
not in "errno".  I (tgl) missed this because RHEL6's version seems
to set errno as well.  That is not the case on more modern Linuxen,
though, as per buildfarm results.

Aside from fixing the return-convention confusion, remove the test
for ENOSYS; we expect that glibc will mask that for posix_fallocate,
though it does not for fallocate.  Keep the test for EINTR, because
POSIX specifies that as a possible result, and buildfarm results
suggest that it can happen in practice.

Back-patch to 9.4, like the previous commit.

Thomas Munro

Discussion: 
https://postgr.es/m/1002664500.12301802.1471008223422.javamail.ya...@mail.yahoo.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d29f30d8c3b2a9d8c57324355df8a8d9da1d9c12

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c.

posix_fallocate() is not quite a drop-in replacement for fallocate(),
because it is defined to return the error code as its function result,
not in "errno".  I (tgl) missed this because RHEL6's version seems
to set errno as well.  That is not the case on more modern Linuxen,
though, as per buildfarm results.

Aside from fixing the return-convention confusion, remove the test
for ENOSYS; we expect that glibc will mask that for posix_fallocate,
though it does not for fallocate.  Keep the test for EINTR, because
POSIX specifies that as a possible result, and buildfarm results
suggest that it can happen in practice.

Back-patch to 9.4, like the previous commit.

Thomas Munro

Discussion: 
https://postgr.es/m/1002664500.12301802.1471008223422.javamail.ya...@mail.yahoo.com

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/06852f21544c061cb4d4b53bbe16a647a12dd311

Modified Files
--
src/backend/storage/ipc/dsm_impl.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-26 Thread Tom Lane
"David G. Johnston"  writes:
> On Mon, Sep 25, 2017 at 1:50 PM, Peter Eisentraut <
> peter.eisentr...@2ndquadrant.com> wrote:
>> On 9/25/17 15:09, Tom Lane wrote:
>>> Hm, reads fine to me, and I'd still rather include "is" in the
>>> revised wording.  Anybody else agree with Peter's wording?

>> Note a big deal.  I'm just working off existing error messages:

> ​About half of those, especially the "appears" ones, seem unhelpful for
> deciding whether to add "is" here; "is appears" just doesn't work.

Peter's evidence is pretty conclusive that using "is" is not consistent
with our message style precedents, but there's still room to choose
which precedent to follow ;-).

> The middle ground would be writing: column "i" of relation "vaccluster"
> appears more than once; I'm good with using appears instead of deciding
> between [is] specified.

Yeah, I like "appears more than once" too.  It does not leave one feeling
that "is" has been left out.  Also, "specified" seems like an
unnecessarily formal word here.  Per Mark Twain, "Don't use a five-dollar
word when a fifty-cent word will do."

I'll make this change in the back-patched patch, but Peter's list suggests
that it'd be worth trying to make a lot of these other usages more
consistent in HEAD.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010.

Per suggestions from Peter Eisentraut and David Johnston.
Back-patch, like the previous commit.

Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9a50a93c7b1427f6182ed1f21ed76da5b1d6a57c

Modified Files
--
src/backend/commands/analyze.c   | 2 +-
src/test/regress/expected/vacuum.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010.

Per suggestions from Peter Eisentraut and David Johnston.
Back-patch, like the previous commit.

Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/9d0d0fe5781430930957ab12fa270e5351d2

Modified Files
--
src/backend/commands/analyze.c   | 2 +-
src/test/regress/expected/vacuum.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010.

Per suggestions from Peter Eisentraut and David Johnston.
Back-patch, like the previous commit.

Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6c77b47b2e8edbe6446a42adc6099d1543e69214

Modified Files
--
src/backend/commands/analyze.c   | 2 +-
src/test/regress/expected/vacuum.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010.

Per suggestions from Peter Eisentraut and David Johnston.
Back-patch, like the previous commit.

Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f4aac742c8293b1a0535a8133f926d46474300f0

Modified Files
--
src/backend/commands/analyze.c   | 2 +-
src/test/regress/expected/vacuum.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010.

Per suggestions from Peter Eisentraut and David Johnston.
Back-patch, like the previous commit.

Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/14f94ac697cf6b70d939a1263d79d32a3362760b

Modified Files
--
src/backend/commands/analyze.c   | 2 +-
src/test/regress/expected/vacuum.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010.

Per suggestions from Peter Eisentraut and David Johnston.
Back-patch, like the previous commit.

Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bd797eaa9a056d95e9a1b657755d3abc2d93a6c8

Modified Files
--
src/backend/commands/analyze.c   | 2 +-
src/test/regress/expected/vacuum.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010.

Per suggestions from Peter Eisentraut and David Johnston.
Back-patch, like the previous commit.

Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/9ebc7781444fd15d56ed16e5312a954483e85cd9

Modified Files
--
src/backend/commands/analyze.c   | 2 +-
src/test/regress/expected/vacuum.out | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Turn on log_replication_commands in PostgresNode

2017-09-26 Thread Peter Eisentraut
Turn on log_replication_commands in PostgresNode

This is useful for example for the pg_basebackup and related tests.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/43588f58aa045c736af168267e0f1c5934333e15

Modified Files
--
src/test/perl/PostgresNode.pm | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add some more pg_receivewal tests

2017-09-26 Thread Peter Eisentraut
Add some more pg_receivewal tests

Add some more tests for the --create-slot and --drop-slot options,
verifying that the right kind of slot was created and that the slot was
dropped.  While working on an unrelated patch for pg_basebackup, some of
this was temporarily broken without any tests noticing.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/fa41461205ae4eb417045825583c3209e5a4f339

Modified Files
--
src/bin/pg_basebackup/t/020_pg_receivewal.pl | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b5ee5328bdd086fa7db1845928ef0bc87b495aaf

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
doc/src/sgml/release-9.6.sgml | 44 ---
5 files changed, 185 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6525a3a70968007666b5fce440f57b8bf7e6303f

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
1 file changed, 37 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/59597e6485847ae40eab2e80ff04af3e8663f2d8

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
doc/src/sgml/release-9.6.sgml | 44 ---
5 files changed, 185 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bfd551570265049ea17f18f65a156c1d8ba66a23

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
doc/src/sgml/release-9.6.sgml | 44 ---
5 files changed, 185 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2e7f6b6b2a214f8f5fa8ec448807c3a1a2c8b897

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
4 files changed, 148 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/c8178929c55e5424b6c47014579bfbf68886f444

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
3 files changed, 111 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/43661926deb7d412ae3a22a43dadb9def7b7e46c

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
2 files changed, 74 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers