Re: [COMMITTERS] pgsql: Exit from base backups when shutdown is requested
On Fri, 2011-01-14 at 11:37 +, Magnus Hagander wrote: > Exit from base backups when shutdown is requested > > When the exit waits until the whole backup completes, it may take > a very long time. > > In passing, add back an error check in the main loop so we detect > clients that disconnect much earlier if the backup is large. Please make that the last commit in this area for next week. I want to get a base from which to solidify the sync rep code, and associated patches. I'm not saying there will be a code clash, but there may be a clash of detail or intention that will make life more difficult for testing. Thanks, -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix error code for canceling statement due to conflict with reco
Fix error code for canceling statement due to conflict with recovery. All retryable conflict errors now have an error code that indicates that a retry is possible, correcting my incomplete fix of 2010/05/12 Tatsuo Ishii and Simon Riggs, input from Robert Haas and Florian Pflug Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=8585ad36254199ca63700707ee78890da1755e4d Modified Files -- src/backend/storage/ipc/standby.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix error code for canceling statement due to conflict with reco
Fix error code for canceling statement due to conflict with recovery. All retryable conflict errors now have an error code that indicates that a retry is possible, correcting my incomplete fix of 2010/05/12 Tatsuo Ishii and Simon Riggs, input from Robert Haas and Florian Pflug Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6bfa6b0867c370d72cbaeba18d6d3a5d80eae0e7 Modified Files -- src/backend/storage/ipc/standby.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Create new errcode for recovery conflict caused by db drop on ma
Create new errcode for recovery conflict caused by db drop on master. Previously reported as ERRCODE_ADMIN_SHUTDOWN, this case is now reported as ERRCODE_T_R_DATABASE_DROPPED. No message text change. Unlikely to happen on most servers, so low impact change to allow session poolers to correctly handle this situation. Tatsuo Ishii, edits by me, review by Robert Haas Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9e95c9ad558bafa26efbab50f77929de4ade5f90 Modified Files -- doc/src/sgml/errcodes.sgml |5 + src/backend/tcop/postgres.c |4 +++- src/include/utils/errcodes.h|1 + src/pl/plpgsql/src/plerrcodes.h |4 4 files changed, 13 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Re-classify ERRCODE_DATABASE_DROPPED to 57P04
Re-classify ERRCODE_DATABASE_DROPPED to 57P04 Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=56b21b7ae38bc1efb701e7ebfd208e2e194e7998 Modified Files -- doc/src/sgml/errcodes.sgml | 11 ++- src/backend/tcop/postgres.c |2 +- src/include/utils/errcodes.h|2 +- src/pl/plpgsql/src/plerrcodes.h |8 4 files changed, 12 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Create new errcode for recovery conflict caused by db drop on ma
Create new errcode for recovery conflict caused by db drop on master. Previously reported as ERRCODE_ADMIN_SHUTDOWN, this case is now reported as ERRCODE_DATABASE_DROPPED. No message text change. Unlikely to happen on most servers, so low impact change to allow session poolers to correctly handle this situation. Tatsuo Ishii and Simon Riggs Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d6c1dc176a422ed19d698bb8ff9ed7b38c04a320 Modified Files -- doc/src/sgml/errcodes.sgml |6 ++ src/backend/tcop/postgres.c |2 +- src/include/utils/errcodes.h|1 + src/pl/plpgsql/src/plerrcodes.h |4 4 files changed, 12 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Extend ALTER TABLE to allow Foreign Keys to be added without ini
Extend ALTER TABLE to allow Foreign Keys to be added without initial validation. FK constraints that are marked NOT VALID may later be VALIDATED, which uses an ShareUpdateExclusiveLock on constraint table and RowShareLock on referenced table. Significantly reduces lock strength and duration when adding FKs. New state visible from psql. Simon Riggs, with reviews from Marko Tiikkaja and Robert Haas Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=722bf7017bbe796decc79c1fde03e7a83dae9ada Modified Files -- doc/src/sgml/ref/alter_table.sgml | 22 ++- src/backend/catalog/heap.c|1 + src/backend/catalog/index.c |1 + src/backend/catalog/pg_constraint.c |2 + src/backend/commands/tablecmds.c | 105 +++-- src/backend/commands/trigger.c|1 + src/backend/commands/typecmds.c |1 + src/backend/parser/gram.y | 28 +++- src/backend/utils/adt/ri_triggers.c |7 ++- src/bin/psql/describe.c |9 ++- src/include/catalog/pg_constraint.h | 40 ++- src/include/nodes/parsenodes.h|2 + src/include/parser/kwlist.h |1 + src/test/regress/expected/alter_table.out | 12 +++ src/test/regress/sql/alter_table.sql | 15 15 files changed, 215 insertions(+), 32 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove rare corner case for data loss when triggering standby se
Remove rare corner case for data loss when triggering standby server. If the standby was streaming when trigger file arrives, check also in the archive for additional WAL files. This is a corner case since it is unlikely that we would trigger a failover while the master is still available and sending data to standby, while at the same time running in archive mode and also while the streaming standby has fallen behind archive. Someone would eventually be unlucky; we must plug all gaps however small. Fujii Masao Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=faa0550572583f51dba25611ab0f1d1c31de559b Modified Files -- src/backend/access/transam/xlog.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,
Basic Recovery Control functions for use in Hot Standby. Pause, Resume, Status check functions only. Also, new recovery.conf parameter to pause_at_recovery_target, default on. Simon Riggs, reviewed by Fujii Masao Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=8c6e3adbf792c2bba448e88cbf2c8e03fb802e73 Modified Files -- doc/src/sgml/func.sgml | 58 +++ doc/src/sgml/recovery-config.sgml | 25 +++ src/backend/access/transam/xlog.c | 137 src/include/access/xlog_internal.h |3 + src/include/catalog/pg_proc.h |7 ++ 5 files changed, 230 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Named restore points in recovery. Users can record named points,
Named restore points in recovery. Users can record named points, then new recovery.conf parameter recovery_target_name allows PITR to specify named points as recovery targets. Jaime Casanova, reviewed by Euler Taveira de Oliveira, plus minor edits Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c016ce728139be95bb0dc7c4e5640507334c2339 Modified Files -- doc/src/sgml/backup.sgml|7 +- doc/src/sgml/func.sgml | 10 ++ doc/src/sgml/recovery-config.sgml | 25 +++- src/backend/access/transam/recovery.conf.sample |7 +- src/backend/access/transam/xlog.c | 170 +-- src/include/access/xlog.h |4 +- src/include/access/xlog_internal.h |1 + src/include/catalog/pg_control.h|1 + src/include/catalog/pg_proc.h |1 + 9 files changed, 209 insertions(+), 17 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Continue long tradition of bumping the catalog version a little
Continue long tradition of bumping the catalog version a little late. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=7a7d36ec3363d10e0450209a9b451d86a2328b47 Modified Files -- src/include/catalog/catversion.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Suppress some compiler warnings in recent commits.
On Tue, 2011-02-08 at 23:12 +, Tom Lane wrote: > Also clean up logic in ATExecValidateConstraint to make it easier to read > and less likely to provoke "variable might be used uninitialized in this > function" warnings. Thanks. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add version-sensitive SQL for psql when constraints NOT VALID
Add version-sensitive SQL for psql when constraints NOT VALID Bug report and fix by Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f0b8a79c4bea7bfa89245ee03abf994b027da411 Modified Files -- src/bin/psql/describe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PITR can stop at a named restore point when recovery target = ti
PITR can stop at a named restore point when recovery target = time though must not update the last transaction timestamp. Plus comment and message cleanup for recent named restore point. Fujii Masao, minor changes by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5c588be729399af5cb8ec66901e3b578936823a3 Modified Files -- src/backend/access/transam/xlog.c | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Additional required docs for pg_constraint catalog entry
Additional required docs for pg_constraint catalog entry Noted by Bernd Helmle Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0ff1b7350984b9e4055e9d3a37d3b875c0663ac4 Modified Files -- doc/src/sgml/catalogs.sgml |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Hot Standby feedback for avoidance of cleanup conflicts on stand
Hot Standby feedback for avoidance of cleanup conflicts on standby. Standby optionally sends back information about oldestXmin of queries which is then checked and applied to the WALSender's proc->xmin. GetOldestXmin() is modified slightly to agree with GetSnapshotData(), so that all backends on primary include WALSender within their snapshots. Note this does nothing to change the snapshot xmin on either master or standby. Feedback piggybacks on the standby reply message. vacuum_defer_cleanup_age is no longer used on standby, though parameter still exists on primary, since some use cases still exist. Simon Riggs, review comments from Fujii Masao, Heikki Linnakangas, Robert Haas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bca8b7f16a3e720794cb0afbdb3733be4f8d9c2c Modified Files -- doc/src/sgml/config.sgml | 20 +++ doc/src/sgml/high-availability.sgml | 44 +++ src/backend/access/transam/xlog.c | 58 +++-- src/backend/replication/walreceiver.c | 36 +++- src/backend/replication/walsender.c | 71 - src/backend/storage/ipc/procarray.c | 45 +-- src/backend/utils/misc/guc.c |9 +++ src/backend/utils/misc/postgresql.conf.sample |1 + src/include/access/xlog.h |1 + src/include/replication/walprotocol.h |9 +++ src/include/replication/walreceiver.h |1 + 11 files changed, 245 insertions(+), 50 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.
Separate messages for standby replies and hot standby feedback. Allow messages to be sent at different times, and greatly reduce the frequency of hot standby feedback. Refactor to allow additional message types. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/06828c5febf3a8f9e94bce5bd84634ce990d299f Modified Files -- src/backend/replication/walreceiver.c | 104 src/backend/replication/walsender.c | 124 + src/include/replication/walprotocol.h | 15 - 3 files changed, 168 insertions(+), 75 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make a hard state change from catchup to streaming mode.
Make a hard state change from catchup to streaming mode. More useful state change for monitoring purposes, plus a required change for synchronous replication patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bc76695c4c44e21aed94ee2bea81c4cdcedf1390 Modified Files -- src/backend/replication/walsender.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.
On Fri, 2011-02-18 at 20:22 +0200, Heikki Linnakangas wrote: > On 18.02.2011 13:34, Simon Riggs wrote: > > Separate messages for standby replies and hot standby feedback. > > Allow messages to be sent at different times, and greatly reduce > > the frequency of hot standby feedback. Refactor to allow additional > > message types. > > Please update the docs too, these messages are briefly explained at > http://developer.postgresql.org/pgdocs/postgres/protocol-replication.html Hadn't forgotten, just working thru things in priority order. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.
Efficient transaction-controlled synchronous replication. If a standby is broadcasting reply messages and we have named one or more standbys in synchronous_standby_names then allow users who set synchronous_replication to wait for commit, which then provides strict data integrity guarantees. Design avoids sending and receiving transaction state information so minimises bookkeeping overheads. We synchronize with the highest priority standby that is connected and ready to synchronize. Other standbys can be defined to takeover in case of standby failure. This version has very strict behaviour; more relaxed options may be added at a later date. Simon Riggs and Fujii Masao, with reviews by Yeb Havinga, Jaime Casanova, Heikki Linnakangas and Robert Haas, plus the assistance of many other design reviewers. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a8a8a3e0965201df88bdfdff08f50e5c06c552b7 Modified Files -- doc/src/sgml/config.sgml | 86 +++ doc/src/sgml/high-availability.sgml | 203 + doc/src/sgml/monitoring.sgml |7 +- src/backend/access/transam/twophase.c | 25 +++ src/backend/access/transam/xact.c | 11 ++- src/backend/catalog/system_views.sql |4 +- src/backend/postmaster/autovacuum.c |7 + src/backend/postmaster/postmaster.c |3 + src/backend/replication/Makefile |2 +- src/backend/replication/walreceiver.c |9 +- src/backend/replication/walsender.c | 65 +++- src/backend/storage/ipc/shmqueue.c| 21 +++- src/backend/storage/lmgr/proc.c | 12 ++ src/backend/utils/misc/guc.c | 19 +++ src/backend/utils/misc/postgresql.conf.sample | 11 ++- src/include/catalog/pg_proc.h |2 +- src/include/replication/walsender.h | 22 +++ src/include/storage/lwlock.h |1 + src/include/storage/proc.h| 14 ++ src/include/storage/shmem.h |3 + src/test/regress/expected/rules.out |2 +- 21 files changed, 507 insertions(+), 22 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add new files for syncrep missed in previous commit
Add new files for syncrep missed in previous commit Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/966fb05b588ab33a6c99c6a26308941e1b3a1188 Modified Files -- src/backend/replication/syncrep.c | 589 + src/include/replication/syncrep.h | 48 +++ 2 files changed, 637 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Catversion increment for pg_stat_replication changes for syncrep
Catversion increment for pg_stat_replication changes for syncrep Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dcfe3f60c12880c52fd3cb9b5d51ff44c946dd6c Modified Files -- src/include/catalog/catversion.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.
On Sun, 2011-03-06 at 18:28 -0500, Tom Lane wrote: > Simon Riggs writes: > > Efficient transaction-controlled synchronous replication. > > This patch broke the build. Kindly fix or revert at once. I think that's fixed it now. I was in the middle of doing that when your last commit hit, so I had to rewind and try again. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Dynamic array required within pg_stat_replication.
Dynamic array required within pg_stat_replication. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cae4974e3d4c0cb1237568b55a2cee4482d42f40 Modified Files -- src/backend/replication/walsender.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.
On Mon, 2011-03-07 at 17:27 +0900, Fujii Masao wrote: > On Mon, Mar 7, 2011 at 7:51 AM, Simon Riggs wrote: > And,, I found one bug ;) You seem to have wrongly removed the check > of max_wal_senders in SyncRepWaitForLSN. This can make the > backend wait for replication even if max_wal_senders = 0. I could produce > this problematic situation in my machine. The attached patch fixes this > problem. There may be a bug, but that's not the fix. I spotted that issue myself in testing. I put in a protection to stop setting synchronous_standby_names if max_wal_senders is zero, with error message. Are you saying the committed version doesn't trigger that ERROR? -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: synchronous_standby_names is a string parameter.
On Wed, 2011-03-09 at 10:50 +, Itagaki Takahiro wrote: > synchronous_standby_names is a string parameter. Thanks! That bug was already fixed earlier, so it must have crept back in when we were chopping patches up into pieces. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update docs to say you need fsync to make sync rep work fast.
Update docs to say you need fsync to make sync rep work fast. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6e8e7cc580665ddd43c8ca2acc6d60f345570a57 Modified Files -- doc/src/sgml/high-availability.sgml |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make FKs valid at creation when added as column constraints.
Make FKs valid at creation when added as column constraints. Bug report from Alvaro Herrera Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ec497a5ad6a0849efa3fb2fd05988bd8e0c0865d Modified Files -- src/backend/commands/tablecmds.c |2 +- src/backend/nodes/copyfuncs.c |1 + src/backend/nodes/equalfuncs.c |1 + src/backend/nodes/outfuncs.c |1 + src/backend/parser/gram.y |3 +++ src/backend/parser/parse_utilcmd.c |1 + src/include/nodes/parsenodes.h |1 + 7 files changed, 9 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Prevent intermittent hang in recovery from bgwriter interaction.
Prevent intermittent hang in recovery from bgwriter interaction. Startup process waited for cleanup lock but when hot_standby = off the pid was not registered, so that the bgwriter would not wake the waiting process as intended. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b98ac467f5d35970edade4ad65c767fc89059026 Modified Files -- src/backend/access/transam/xlog.c |2 ++ src/backend/storage/ipc/standby.c |5 - 2 files changed, 2 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Prevent intermittent hang in recovery from bgwriter interaction.
Prevent intermittent hang in recovery from bgwriter interaction. Startup process waited for cleanup lock but when hot_standby = off the pid was not registered, so that the bgwriter would not wake the waiting process as intended. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9bb1ddec4cd998c5fbac278a54d8ad5a5011e4e1 Modified Files -- src/backend/access/transam/xlog.c |2 ++ src/backend/storage/ipc/standby.c |5 - 2 files changed, 2 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Minor changes to recovery pause behaviour.
Minor changes to recovery pause behaviour. Change location LOG message so it works each time we pause, not just for final pause. Ensure that we pause only if we are in Hot Standby and can connect to allow us to run resume function. This change supercedes the code to override parameter recoveryPauseAtTarget to false if not attempting to enter Hot Standby, which is now removed. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b5f2f2a712e56fe1edf7d5665c07ee97be464c0b Modified Files -- src/backend/access/transam/xlog.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Additional test for each commit in sync rep path to plug minute
Additional test for each commit in sync rep path to plug minute possibility of race condition that would effect performance only. Requested by Robert Haas. Re-arrange related comments. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/92f4786fa9b730fd12cbfe973eb96addc6e98924 Modified Files -- src/backend/replication/syncrep.c | 25 - 1 files changed, 16 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update comments and credit doc proofreaders
Update comments and credit doc proofreaders Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/35d2a660fea51f8acae6aa0895875757fa09cb26 Modified Files -- doc/src/sgml/release-9.1.sgml | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Centralise release note items related to recovery and replicatio
Centralise release note items related to recovery and replication Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/479ee1b962ca2d479310af762c21d7c2056fdeca Modified Files -- doc/src/sgml/release-9.1.sgml | 183 +++-- 1 files changed, 104 insertions(+), 79 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Avoid assuming there will be only 3 states for synchronous_commi
Avoid assuming there will be only 3 states for synchronous_commit. Also avoid hardcoding the current default state by giving it the name "on" and replace with a meaningful name that reflects its behaviour. Coding only, no change in behaviour. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/88f32b7ca29982f286b61a9d0dd29be4b8a01c25 Modified Files -- src/backend/access/transam/xact.c |2 +- src/backend/postmaster/autovacuum.c |2 +- src/backend/utils/misc/guc.c|2 +- src/include/access/xact.h |9 ++--- src/include/replication/syncrep.h |2 +- 5 files changed, 10 insertions(+), 7 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Respect Hot Standby controls while recycling btree index pages.
Respect Hot Standby controls while recycling btree index pages. Btree pages were recycled after VACUUM deletes all records on a page and then a subsequent VACUUM occurs after the RecentXmin horizon is reached. Using RecentXmin meant that we did not respond correctly to the user controls provide to avoid Hot Standby conflicts and so spurious conflicts could be generated in some workload combinations. We now reuse pages only when we reach RecentGlobalXmin, which can be much later in the presence of long running queries and is also controlled by vacuum_defer_cleanup_age. Noah Misch and Simon Riggs Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1c7ddbf3501e989d6b783dc516c44c3535dbe03f Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Respect Hot Standby controls while recycling btree index pages.
Respect Hot Standby controls while recycling btree index pages. Btree pages were recycled after VACUUM deletes all records on a page and then a subsequent VACUUM occurs after the RecentXmin horizon is reached. Using RecentXmin meant that we did not respond correctly to the user controls provide to avoid Hot Standby conflicts and so spurious conflicts could be generated in some workload combinations. We now reuse pages only when we reach RecentGlobalXmin, which can be much later in the presence of long running queries and is also controlled by vacuum_defer_cleanup_age and hot_standby_feedback. Noah Misch and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/758bd2a433d64bed00ca084203b3e5ccfdea4499 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Respect Hot Standby controls while recycling btree index pages.
Respect Hot Standby controls while recycling btree index pages. Btree pages were recycled after VACUUM deletes all records on a page and then a subsequent VACUUM occurs after the RecentXmin horizon is reached. Using RecentXmin meant that we did not respond correctly to the user controls provide to avoid Hot Standby conflicts and so spurious conflicts could be generated in some workload combinations. We now reuse pages only when we reach RecentGlobalXmin, which can be much later in the presence of long running queries and is also controlled by vacuum_defer_cleanup_age and hot_standby_feedback. Noah Misch and Simon Riggs Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9340e643e4cbc11a7a5aaea0297236e9a8c07600 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Reduce impact of btree page reuse on Hot Standby by fixing off-b
Reduce impact of btree page reuse on Hot Standby by fixing off-by-1 error. WAL records of type XLOG_BTREE_REUSE_PAGE were generated using a latestRemovedXid one higher than actually needed because xid used was page opaque->btpo.xact rather than an actually removed xid. Noticed on an otherwise quiet system by Noah Misch. Noah Misch and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e1cd66f74862936d84acf3008118d6094c56ad58 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Reduce impact of btree page reuse on Hot Standby by fixing off-b
Reduce impact of btree page reuse on Hot Standby by fixing off-by-1 error. WAL records of type XLOG_BTREE_REUSE_PAGE were generated using a latestRemovedXid one higher than actually needed because xid used was page opaque->btpo.xact rather than an actually removed xid. Noticed on an otherwise quiet system by Noah Misch. Noah Misch and Simon Riggs Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ca7e04b0b9943d5c33d2e993ff685d45b5bddbbd Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Reduce impact of btree page reuse on Hot Standby by fixing off-b
Reduce impact of btree page reuse on Hot Standby by fixing off-by-1 error. WAL records of type XLOG_BTREE_REUSE_PAGE were generated using a latestRemovedXid one higher than actually needed because xid used was page opaque->btpo.xact rather than an actually removed xid. Noticed on an otherwise quiet system by Noah Misch. Noah Misch and Simon Riggs Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5cd81b8df0a9f3e4cb407e815b9a789138fd0356 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Introduce compact WAL record for the common case of commit (non-
Introduce compact WAL record for the common case of commit (non-DDL). XLOG_XACT_COMMIT_COMPACT leaves out invalidation messages and relfilenodes, saving considerable space for the vast majority of transaction commits. XLOG_XACT_COMMIT keeps same definition as XLOG_PAGE_MAGIC 0xD067 and earlier. Leonardo Francalanci and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/465883b0a2b4236ba6b31b648a9eabef3b7cdddb Modified Files -- src/backend/access/transam/xact.c | 245 +--- src/backend/access/transam/xlog.c | 11 ++- src/include/access/xact.h | 15 ++- src/include/access/xlog_internal.h |2 +- 4 files changed, 192 insertions(+), 81 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. Locks on inheritance parent remain at lower level, as they were before. Remove entry from 9.1 release notes. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1f7056099728035b55efcd8f889c7b705a68b6de Modified Files -- doc/src/sgml/release-9.1.sgml| 17 + src/backend/commands/tablecmds.c | 28 2 files changed, 29 insertions(+), 16 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. Locks on inheritance parent remain at lower level, as they were before. Remove entry from 9.1 release notes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2c3d9db56d5d49bdc777b174982251c01348e3d8 Modified Files -- doc/src/sgml/release-9.1.sgml| 17 + src/backend/commands/tablecmds.c | 28 2 files changed, 29 insertions(+), 16 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Alter test results to comply with new ALTER TABLE behaviour.
Alter test results to comply with new ALTER TABLE behaviour. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/677f146307a95f862c0c7b51819c79a00af61f95 Modified Files -- src/test/regress/expected/alter_table.out | 72 ++--- src/test/regress/sql/alter_table.sql |2 - 2 files changed, 35 insertions(+), 39 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Alter test results to comply with new ALTER TABLE behaviour.
Alter test results to comply with new ALTER TABLE behaviour. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f563afd433e07a2eb7db614005141f21613d4d61 Modified Files -- src/test/regress/expected/alter_table.out | 72 ++--- src/test/regress/sql/alter_table.sql |2 - 2 files changed, 35 insertions(+), 39 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs wrote: > Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. > Locks on inheritance parent remain at lower level, as they were before. > Remove entry from 9.1 release notes. This commit caused pgbuildfarm failures on 15 machines this morning. Later commit fixes this, I forgot that the lock level is specifically mentioned in regression test results. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
On Tue, Jul 5, 2011 at 2:46 PM, Robert Haas wrote: > On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: >> On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs wrote: >>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >>> Locks on inheritance parent remain at lower level, as they were before. >>> Remove entry from 9.1 release notes. >> >> This commit caused pgbuildfarm failures on 15 machines this morning. >> Later commit fixes this, I forgot that the lock level is specifically >> mentioned in regression test results. > > I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite(). Thanks. Will address. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
On Thu, Jul 7, 2011 at 6:17 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: >>>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >>>> Locks on inheritance parent remain at lower level, as they were before. >>>> Remove entry from 9.1 release notes. > >> I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite(). > > I took care of this. Thanks. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Cascading replication feature for streaming log-based replicatio
Cascading replication feature for streaming log-based replication. Standby servers can now have WALSender processes, which can work with either WALReceiver or archive_commands to pass data. Fully updated docs, including new conceptual terms of sending server, upstream and downstream servers. WALSenders terminated when promote to master. Fujii Masao, review, rework and doc rewrite by Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5286105800c7d5902f98f32e11b209c471c0c69c Modified Files -- doc/src/sgml/config.sgml | 127 ++-- doc/src/sgml/high-availability.sgml | 62 - src/backend/access/transam/xlog.c | 265 +++-- src/backend/postmaster/postmaster.c | 20 +++ src/backend/replication/basebackup.c |5 + src/backend/replication/syncrep.c |7 + src/backend/replication/walreceiver.c |7 +- src/backend/replication/walsender.c | 108 ++--- src/include/access/xlog.h |6 +- src/include/replication/walsender.h |5 +- 10 files changed, 423 insertions(+), 189 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Introduce sending servers as new category for replication params
Introduce sending servers as new category for replication params Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4bd8ed31b76fde16ee00c123751e25019e4d9854 Modified Files -- src/backend/utils/misc/guc.c | 10 ++ src/backend/utils/misc/postgresql.conf.sample | 11 --- src/include/utils/guc_tables.h|1 + 3 files changed, 15 insertions(+), 7 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Minor doc additions for cascading replication.
Minor doc additions for cascading replication. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6ba77bce9378cb9c5fb89a4d30bf77c2a17b0d64 Modified Files -- doc/src/sgml/config.sgml |2 +- doc/src/sgml/monitoring.sgml |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove O(N^2) performance issue with multiple SAVEPOINTs.
Remove O(N^2) performance issue with multiple SAVEPOINTs. Subtransaction locks now released en masse at main commit, rather than repeatedly re-scanning for locks as we ascend the nested transaction tree. Split transaction state TBLOCK_SUBEND into two states, TBLOCK_SUBCOMMIT and TBLOCK_SUBRELEASE to allow the commit path to be optimised using the existing code in ResourceOwnerRelease() which appears to have been intended for this usage, judging from comments therein. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7cb7122800ec996d4849ce9b4ad3065db19a2aae Modified Files -- src/backend/access/transam/xact.c | 102 + 1 files changed, 70 insertions(+), 32 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
On Tue, Aug 2, 2011 at 6:24 PM, Tom Lane wrote: > Fix incorrect initialization of ProcGlobal->startupBufferPinWaitBufId. > > It was initialized in the wrong place and to the wrong value. With bad > luck this could result in incorrect query-cancellation failures in hot > standby sessions, should a HS backend be holding pin on buffer number 1 > while trying to acquire a lock. Did I miss a bug report? -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
On Tue, Aug 2, 2011 at 8:23 PM, Tom Lane wrote: > Simon Riggs writes: >> On Tue, Aug 2, 2011 at 6:24 PM, Tom Lane wrote: >>> Fix incorrect initialization of ProcGlobal->startupBufferPinWaitBufId. >>> >>> It was initialized in the wrong place and to the wrong value. With bad >>> luck this could result in incorrect query-cancellation failures in hot >>> standby sessions, should a HS backend be holding pin on buffer number 1 >>> while trying to acquire a lock. > >> Did I miss a bug report? > > No, this was something I happened across in code-reading a few weeks ago > and had a note to myself to fix. While looking at it today I found more > problems ... see second commit. I'm happy to fix problems I've caused that are reported to me. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Emit cascaded standby message on shutdown only when appropriate.
Emit cascaded standby message on shutdown only when appropriate. Adds additional test for active walsenders and closes a race condition for when we failover when a new walsender was connecting. Reported and fixed bu Fujii Masao. Review by Heikki Linnakangas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dde70cc313683e47e71997759c6029b4220f71c0 Modified Files -- src/backend/postmaster/postmaster.c |5 +++-- src/backend/replication/walsender.c | 29 + 2 files changed, 32 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Partially revoke attempt to improve performance with many savepo
Partially revoke attempt to improve performance with many savepoints. Maintain difference between subtransaction release and commit introduced by earlier patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/df383b03e6f761c9b5bb12aa2339795ab44aa054 Modified Files -- src/backend/access/transam/xact.c | 27 --- 1 files changed, 12 insertions(+), 15 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PublishStartupProcessInformation() to avoid rare hang in recover
PublishStartupProcessInformation() to avoid rare hang in recovery. Bgwriter could cause hang in recovery during page concurrent cleaning. Bug report and testing by Bernd Helmle, fix by me Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7c24bac64c3828d651abfd5e34bd0e0031ab9946 Modified Files -- src/backend/access/transam/xlog.c |2 + src/backend/storage/lmgr/proc.c | 43 - src/include/storage/proc.h|6 + 3 files changed, 50 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: synchronous_commit is an enum not a boolean.
synchronous_commit is an enum not a boolean. Jaime Casanova Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8ab067da917398e6bcf733fcb835c5d4852ff03b Modified Files -- doc/src/sgml/config.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: synchronous_commit is an enum not a boolean.
synchronous_commit is an enum not a boolean. Jaime Casanova Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5e2f7b0546c0409323af262bdd17a8e19ca3836 Modified Files -- doc/src/sgml/config.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: More cleanup after failed reduced-lock-levels-for-DDL feature.
On Fri, Oct 21, 2011 at 6:50 PM, Tom Lane wrote: > More cleanup after failed reduced-lock-levels-for-DDL feature. > > Turns out that use of ShareUpdateExclusiveLock or ShareRowExclusiveLock > to protect DDL changes had gotten copied into several places that were > not touched by either of Simon's original patches for the feature, and > thus neither he nor I thought to revert them. (Indeed, it appears that > two of these uses were committed *after* the reversion, which just goes > to show that git merging is no panacea.) Change these places to use > AccessExclusiveLock again. If we ever manage to resurrect that feature, > we're going to have to think a bit harder about how to keep lock level > usage in sync for DDL operations that aren't within the AlterTable > infrastructure. > > Two of these bugs are only in HEAD, but one is in the 9.1 branch too. > Alvaro found one of them, I found the other two. Very cool, thanks. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Split work of bgwriter between 2 processes: bgwriter and checkpo
Split work of bgwriter between 2 processes: bgwriter and checkpointer. bgwriter is now a much less important process, responsible for page cleaning duties only. checkpointer is now responsible for checkpoints and so has a key role in shutdown. Later patches will correct doc references to the now old idea that bgwriter performs checkpoints. Has beneficial effect on performance at high write rates, but mainly refactoring to more easily allow changes for power reduction by simplifying previously tortuous code around required to allow page cleaning and checkpointing to time slice in the same process. Patch by me, Review by Dickson Guedes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/806a2aee3791244bf0f916729bfdb5489936e068 Modified Files -- src/backend/bootstrap/bootstrap.c |8 + src/backend/postmaster/Makefile |2 +- src/backend/postmaster/bgwriter.c | 944 +-- src/backend/postmaster/postmaster.c | 99 +++- src/backend/storage/buffer/bufmgr.c |6 +- src/backend/storage/smgr/md.c | 38 +- src/include/access/xlog_internal.h |2 +- src/include/bootstrap/bootstrap.h |1 + src/include/postmaster/bgwriter.h |1 + src/include/storage/proc.h |8 +- src/include/storage/procsignal.h|2 +- 11 files changed, 124 insertions(+), 987 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Comment changes to show bgwriter no longer performs checkpoints.
Comment changes to show bgwriter no longer performs checkpoints. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f3ebaad45b473f3a53de2cd2a5252cd653aa46f3 Modified Files -- src/backend/access/transam/xlog.c |6 +++--- src/backend/commands/dbcommands.c |8 src/backend/postmaster/bgwriter.c |9 ++--- src/backend/replication/README|2 +- 4 files changed, 10 insertions(+), 15 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add new file for checkpointer.c
Add new file for checkpointer.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bf405ba8e460051e715d0a91442b579e590328ce Modified Files -- src/backend/postmaster/checkpointer.c | 1236 + 1 files changed, 1236 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Have checkpointer send stats once each processing loop.
Have checkpointer send stats once each processing loop. Noted by Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3ba182056faac66012aad8dedf2cb50ba511d989 Modified Files -- src/backend/postmaster/checkpointer.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix timing of Startup CLOG and MultiXact during Hot Standby
Fix timing of Startup CLOG and MultiXact during Hot Standby Patch by me, bug report by Chris Redekop, analysis by Florian Pflug Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2f55c535e1f026929cf20855b3790d3632062d42 Modified Files -- src/backend/access/transam/clog.c | 19 +++ src/backend/access/transam/multixact.c |2 +- src/backend/access/transam/xlog.c | 17 - src/include/access/clog.h |1 + 4 files changed, 33 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix timing of Startup CLOG and MultiXact during Hot Standby
Fix timing of Startup CLOG and MultiXact during Hot Standby Patch by me, bug report by Chris Redekop, analysis by Florian Pflug Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9e5fe4d49227c5c5297410d54d6551a726814adc Modified Files -- src/backend/access/transam/clog.c | 19 +++ src/backend/access/transam/multixact.c |2 +- src/backend/access/transam/xlog.c | 17 - src/include/access/clog.h |1 + 4 files changed, 33 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix timing of Startup CLOG and MultiXact during Hot Standby
Fix timing of Startup CLOG and MultiXact during Hot Standby Patch by me, bug report by Chris Redekop, analysis by Florian Pflug Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f8409b39d1dae28f063b378b9edee1a657845503 Modified Files -- src/backend/access/transam/clog.c | 19 +++ src/backend/access/transam/multixact.c |2 +- src/backend/access/transam/xlog.c | 17 - src/backend/utils/init/postinit.c |1 + src/include/access/clog.h |1 + 5 files changed, 34 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Start Hot Standby faster when initial snapshot is incomplete.
Start Hot Standby faster when initial snapshot is incomplete. If the initial snapshot had overflowed then we can start whenever the latest snapshot is empty, not overflowed or as we did already, start when the xmin on primary was higher than xmax of our starting snapshot, which proves we have full snapshot data. Bug report by Chris Redekop Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ff8451aa14c8513e429cbef09ddc72e79da366a5 Modified Files -- src/backend/storage/ipc/procarray.c | 52 +- 1 files changed, 32 insertions(+), 20 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove spurious entry from missed catch while patch juggling
Remove spurious entry from missed catch while patch juggling Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2296e62a326dfd16ecae590f2f29773fd4348e7f Modified Files -- src/backend/utils/init/postinit.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Start Hot Standby faster when initial snapshot is incomplete.
Start Hot Standby faster when initial snapshot is incomplete. If the initial snapshot had overflowed then we can start whenever the latest snapshot is empty, not overflowed or as we did already, start when the xmin on primary was higher than xmax of our starting snapshot, which proves we have full snapshot data. Bug report by Chris Redekop Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/93b915b3d1c1a325a6458f9553a37b89d244262b Modified Files -- src/backend/storage/ipc/procarray.c | 50 +- 1 files changed, 31 insertions(+), 19 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Start Hot Standby faster when initial snapshot is incomplete.
Start Hot Standby faster when initial snapshot is incomplete. If the initial snapshot had overflowed then we can start whenever the latest snapshot is empty, not overflowed or as we did already, start when the xmin on primary was higher than xmax of our starting snapshot, which proves we have full snapshot data. Bug report by Chris Redekop Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/10b7c686e52a6d1bb10194ebf9331ef06f044d46 Modified Files -- src/backend/storage/ipc/procarray.c | 50 +- 1 files changed, 31 insertions(+), 19 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Derive oldestActiveXid at correct time for Hot Standby.
Derive oldestActiveXid at correct time for Hot Standby. There was a timing window between when oldestActiveXid was derived and when it should have been derived that only shows itself under heavy load. Move code around to ensure correct timing of derivation. No change to StartupSUBTRANS() code, which is where this failed. Bug report by Chris Redekop Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/bf70bf4c7177bdd5c6644da65c0ccea47405d5f3 Modified Files -- src/backend/access/transam/xlog.c | 14 +++-- src/backend/storage/ipc/procarray.c | 57 +++ src/backend/storage/ipc/standby.c |3 +- src/include/storage/procarray.h |1 + src/include/storage/standby.h |2 +- 5 files changed, 71 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Derive oldestActiveXid at correct time for Hot Standby.
Derive oldestActiveXid at correct time for Hot Standby. There was a timing window between when oldestActiveXid was derived and when it should have been derived that only shows itself under heavy load. Move code around to ensure correct timing of derivation. No change to StartupSUBTRANS() code, which is where this failed. Bug report by Chris Redekop Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/656bba95af3950b26e9e97d86d29787d89e2b423 Modified Files -- src/backend/access/transam/xlog.c | 14 +++-- src/backend/storage/ipc/procarray.c | 57 +++ src/backend/storage/ipc/standby.c |3 +- src/include/storage/procarray.h |1 + src/include/storage/standby.h |2 +- 5 files changed, 71 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Derive oldestActiveXid at correct time for Hot Standby.
Derive oldestActiveXid at correct time for Hot Standby. There was a timing window between when oldestActiveXid was derived and when it should have been derived that only shows itself under heavy load. Move code around to ensure correct timing of derivation. No change to StartupSUBTRANS() code, which is where this failed. Bug report by Chris Redekop Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/86e33648992cfc104836ab1fbb6e654308beb4a5 Modified Files -- src/backend/access/transam/xlog.c | 14 +++-- src/backend/storage/ipc/procarray.c | 57 +++ src/backend/storage/ipc/standby.c |3 +- src/include/storage/procarray.h |1 + src/include/storage/standby.h |2 +- 5 files changed, 71 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Refactor xlog.c to create src/backend/postmaster/startup.c
Refactor xlog.c to create src/backend/postmaster/startup.c Startup process now has its own dedicated file, just like all other special/background processes. Reduces role and size of xlog.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9aceb6ab3c202a5bf00d5f00436bb6ad285fc0bf Modified Files -- src/backend/access/transam/xlog.c | 200 +- src/backend/bootstrap/bootstrap.c |1 + src/backend/postmaster/Makefile|2 +- src/backend/postmaster/startup.c | 259 src/backend/replication/walreceiverfuncs.c |2 + src/include/access/xlog.h |2 - src/include/postmaster/startup.h | 22 +++ 7 files changed, 291 insertions(+), 197 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Reduce checkpoints and WAL traffic on low activity database serv
Reduce checkpoints and WAL traffic on low activity database server Previously, we skipped a checkpoint if no WAL had been written since last checkpoint, though this does not appear in user documentation. As of now, we skip a checkpoint until we have written at least one enough WAL to switch the next WAL file. This greatly reduces the level of activity and number of WAL messages generated by a very low activity server. This is safe because the purpose of a checkpoint is to act as a starting place for a recovery, in case of crash. This patch maintains minimal WAL volume for replay in case of crash, thus maintaining very low crash recovery time. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/18fb9d8d21a28caddb72c7ffbdd7b96d52ff9724 Modified Files -- src/backend/access/transam/xlog.c | 28 +++- 1 files changed, 15 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Reduce checkpoints and WAL traffic on low activity database serv
On Wed, Nov 2, 2011 at 4:15 PM, Robert Haas wrote: > On Wed, Nov 2, 2011 at 11:39 AM, Simon Riggs wrote: >> Reduce checkpoints and WAL traffic on low activity database server >> Previously, we skipped a checkpoint if no WAL had been written since >> last checkpoint, though this does not appear in user documentation. >> As of now, we skip a checkpoint until we have written at least one >> enough WAL to switch the next WAL file. This greatly reduces the >> level of activity and number of WAL messages generated by a very >> low activity server. This is safe because the purpose of a checkpoint >> is to act as a starting place for a recovery, in case of crash. >> This patch maintains minimal WAL volume for replay in case of crash, >> thus maintaining very low crash recovery time. > > I think you need to update the docs, for checkpoint_timeout if nothing else. Checkpoints have always been skipped, if no activity. So the docs don't need changing. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update more comments about checkpoints being done by bgwriter
Update more comments about checkpoints being done by bgwriter Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/750f70b0fe91258f9f99b1d04a510e5b035e9249 Modified Files -- src/backend/access/transam/xlog.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve docs for timing and skipping of checkpoints
Improve docs for timing and skipping of checkpoints Greg Smith Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/43342891861cc2d08dea2b1c8b190e15e5a36551 Modified Files -- doc/src/sgml/wal.sgml | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Move user functions related to WAL into xlogfuncs.c
Move user functions related to WAL into xlogfuncs.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a030bfa6e41edae8a9a68dc8cef7fc7813f69a0a Modified Files -- src/backend/access/transam/Makefile|3 +- src/backend/access/transam/xlog.c | 470 ++-- src/backend/access/transam/xlogfuncs.c | 467 +++ src/include/access/xlog.h |5 + 4 files changed, 499 insertions(+), 446 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Wakeup WALWriter as needed for asynchronous commit performance.
Wakeup WALWriter as needed for asynchronous commit performance. Previously we waited for wal_writer_delay before flushing WAL. Now we also wake WALWriter as soon as a WAL buffer page has filled. Significant effect observed on performance of asynchronous commits by Robert Haas, attributed to the ability to set hint bits on tuples earlier and so reducing contention caused by clog lookups. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4de82f7d7c50a81ec8e70e2cb0ab413ab9134c0b Modified Files -- src/backend/access/transam/xlog.c | 33 - src/backend/postmaster/walwriter.c | 27 ++- src/include/access/xlog.h |2 ++ 3 files changed, 44 insertions(+), 18 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Avoid marking buffer dirty when VACUUM has no work to do.
Avoid marking buffer dirty when VACUUM has no work to do. When wal_level = 'hot_standby' we touched the last page of the relation during a VACUUM, even if nothing else had happened. That would alter the LSN of the last block and set the mtime of the relation file unnecessarily. Noted by Thom Brown. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c1458cc495ff800cd176a1c2e56d8b62680d9b71 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Continue to allow VACUUM to mark last block of index dirty
Continue to allow VACUUM to mark last block of index dirty even when there is no work to do. Further analysis required. Revert of patch c1458cc495ff800cd176a1c2e56d8b62680d9b71 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2d2841a56c8fa37a5dd5c6d33488ba6ca37116ff Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Send new protocol keepalive messages to standby servers. Allows streaming replication users to calculate transfer latency and apply delay via internal functions. No external functions yet. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/64233902d22ba42846397cb7551894217522fad4 Modified Files -- doc/src/sgml/protocol.sgml | 48 + src/backend/access/transam/xlog.c | 43 +++ src/backend/replication/walreceiver.c | 47 - src/backend/replication/walreceiverfuncs.c | 63 src/backend/replication/walsender.c| 42 --- src/include/access/xlog.h |1 + src/include/replication/walprotocol.h | 22 ++ src/include/replication/walreceiver.h |8 8 files changed, 258 insertions(+), 16 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Minor but necessary improvements to WAL keepalives
Minor but necessary improvements to WAL keepalives Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3f1787c253967617a0e34fa4bfb7b2ab184ad484 Modified Files -- src/backend/replication/walreceiver.c |3 ++- src/backend/replication/walsender.c |5 + 2 files changed, 7 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.
Correctly initialise shared recoveryLastRecPtr in recovery. Previously we used ReadRecPtr rather than EndRecPtr, which was not a serious error but caused pg_stat_replication to report incorrect replay_location until at least one WAL record is replayed. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5530623d0326e96e40b8d54275da256ca0fb6856 Modified Files -- src/backend/access/transam/xlog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Typo fix.
On Fri, Jan 13, 2012 at 1:22 PM, Robert Haas wrote: > Typo fix. Hmm, how strange. I fixed that bug immediately before commit, so must have skipped a step while committing. Thanks. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Typo fix.
On Fri, Jan 13, 2012 at 1:39 PM, Dave Page wrote: > On Fri, Jan 13, 2012 at 1:29 PM, Simon Riggs wrote: >> On Fri, Jan 13, 2012 at 1:22 PM, Robert Haas wrote: >> >>> Typo fix. >> >> Hmm, how strange. I fixed that bug immediately before commit, so must >> have skipped a step while committing. > > If you modify a file after git-adding it, you have to re-add it before > committing. Possible cause? No, dumber than that. I compiled a new version, just skipped the bit where I updated the new patch version, so the old one just got applied. I keep separate dev and write repositories and use patches to move between them. Which gives me less chance of committing dev code accidentally (like I just did). Is there a better way? -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Typo fix.
On Fri, Jan 13, 2012 at 2:26 PM, Magnus Hagander wrote: > Just FWIW, I use a separate development repository as well. But I have > it added as a remote from the "commit repository", and thus just do a > "git merge --squash" instead of manually moving them with "patch". > > But I am very much a fan of keeping the repos separate for just that > reason - don't want to accidentally commit dev code. OK thanks. My patch foo seems occasionally faulty, but git merge --disaster is something I'm happy to avoid. I'll work on my hand grenade juggling skills before I do that. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Typo fix.
On Fri, Jan 13, 2012 at 4:05 PM, Alvaro Herrera wrote: >> How you work is up to you, but "git merge --squash" is pretty safe, >> since it doesn't actually commit anything. > > And if things go wrong you can always do git merge --abort. > > I, too, used to be scared of some of the options that git gives us, but > after experimentation I found some of them to be hugely useful and safe > enough that I now very rarely run use patches anymore. Gets better and better - very positive. OK, will give it a try. Thanks guys. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: ALTER [IF EXISTS] ... allows silent DDL if required,
ALTER [IF EXISTS] ... allows silent DDL if required, e.g. ALTER FOREIGN TABLE IF EXISTS foo RENAME TO bar Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b8a91d9d1c7ec75aaecf13df687ec7b5b0ed35a6 Modified Files -- doc/src/sgml/ref/alter_foreign_table.sgml | 18 ++- doc/src/sgml/ref/alter_index.sgml | 18 ++- doc/src/sgml/ref/alter_sequence.sgml | 18 ++- doc/src/sgml/ref/alter_table.sgml | 18 ++- doc/src/sgml/ref/alter_view.sgml | 24 +++- src/backend/commands/sequence.c| 10 ++- src/backend/commands/tablecmds.c | 34 - src/backend/nodes/copyfuncs.c |4 + src/backend/nodes/equalfuncs.c |4 + src/backend/parser/gram.y | 216 src/backend/parser/parse_utilcmd.c | 10 ++- src/backend/tcop/utility.c | 53 --- src/include/nodes/parsenodes.h |4 + src/test/regress/expected/alter_table.out | 46 ++ src/test/regress/expected/foreign_data.out | 44 ++ src/test/regress/expected/sequence.out |3 + src/test/regress/sql/alter_table.sql | 32 src/test/regress/sql/foreign_data.sql | 26 src/test/regress/sql/sequence.sql |4 + 19 files changed, 534 insertions(+), 52 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.
Resolve timing issue with logging locks for Hot Standby. We log AccessExclusiveLocks for replay onto standby nodes, but because of timing issues on ProcArray it is possible to log a lock that is still held by a just committed transaction that is very soon to be removed. To avoid any timing issue we avoid applying locks made by transactions with InvalidXid. Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c172b7b02e6f6008d6dad66ddee8f67faf223c5b Modified Files -- src/backend/storage/ipc/procarray.c |8 +-- src/backend/storage/ipc/standby.c | 110 --- src/backend/storage/lmgr/lock.c | 12 - src/include/storage/standby.h |2 +- 4 files changed, 88 insertions(+), 44 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.
Add new replication mode synchronous_commit = 'write'. Replication occurs only to memory on standby, not to disk, so provides additional performance if user wishes to reduce durability level slightly. Adds concept of multiple independent sync rep queues. Fujii Masao and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/443b4821f1649bc617c5ce1f6f3ffc65842a8930 Modified Files -- doc/src/sgml/config.sgml| 18 +++- doc/src/sgml/high-availability.sgml | 16 +++- src/backend/replication/syncrep.c | 112 ++- src/backend/replication/walsender.c |3 +- src/backend/utils/misc/guc.c|5 +- src/include/access/xact.h |1 + src/include/replication/syncrep.h | 13 +++- src/include/replication/walsender_private.h |8 +- 8 files changed, 124 insertions(+), 52 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Allow pg_basebackup from standby node with safety checking.
Allow pg_basebackup from standby node with safety checking. Base backup follows recommended procedure, plus goes to great lengths to ensure that partial page writes are avoided. Jun Ishizuka and Fujii Masao, with minor modifications Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8366c7803ec3d0591cf2d1226fea1fee947d56c3 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 42 src/backend/access/transam/xlog.c | 404 --- src/backend/postmaster/checkpointer.c | 42 +++- src/backend/postmaster/postmaster.c |4 +- src/backend/replication/basebackup.c| 25 ++- src/backend/utils/misc/guc.c|1 - src/bin/pg_controldata/pg_controldata.c |5 + src/bin/pg_resetxlog/pg_resetxlog.c |7 +- src/include/access/xlog.h |2 + src/include/access/xlog_internal.h |2 +- src/include/catalog/pg_control.h| 11 +- 11 files changed, 501 insertions(+), 44 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.
On Mon, Jan 30, 2012 at 12:30 AM, Tom Lane wrote: > Simon Riggs writes: >> Resolve timing issue with logging locks for Hot Standby. >> We log AccessExclusiveLocks for replay onto standby nodes, >> but because of timing issues on ProcArray it is possible to >> log a lock that is still held by a just committed transaction >> that is very soon to be removed. To avoid any timing issue we >> avoid applying locks made by transactions with InvalidXid. > >> Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee > > I see this was only applied to HEAD. Wouldn't back-patching be in > order? The problem is in 9.1 as well, no? Yes, it is. I prefer to give a little time before backpatching to avoid mistakes (of my own making), especially since we're busy enough not to want to divert energy to other releases right now. The patch will make it in before next minor release. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Various minor comments changes from bgwriter to checkpointer.
Various minor comments changes from bgwriter to checkpointer. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/73f617f13f4ca185977d9f7b09bf9edc491cd12f Modified Files -- src/backend/postmaster/checkpointer.c | 18 +- src/backend/replication/syncrep.c |2 +- src/include/replication/walsender_private.h |2 +- 3 files changed, 11 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Minor bug fix and cleanup from self-review of sync rep queues pa
Minor bug fix and cleanup from self-review of sync rep queues patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ba1868ba3138b2119f8290969b9a3936fbc297ce Modified Files -- src/backend/postmaster/checkpointer.c |2 +- src/backend/postmaster/postmaster.c |6 +++--- src/backend/replication/syncrep.c | 10 -- 3 files changed, 8 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.
On Mon, Jan 30, 2012 at 4:38 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 01/30/2012 10:45 AM, Tom Lane wrote: >>> Another aspect of this is that when the same-or-almost-the-same patch >>> is applied to multiple branches, it's a *lot* easier for future >>> archeology in the commit logs if the patch goes into all the affected >>> branches at the same time (and with the same commit message, please). > >> Yeah, I've been pinged on this before, for exactly this reason. It makes >> release note preparation significantly easier, AIUI. > > Not just release notes, but routine questions like "when was this bug > fixed, and in which branches?". I keep a regularly-updated copy of > the output of src/tools/git_changelog (before git we used cvs2cl > to get similar output from CVS). It's a rare day that I don't have > some occasion to consult it. I don't appreciate committers randomly > cluttering that log by making commits that the tool doesn't know how > to merge. As you request it, I will endeavour to do this next time. I think its more likely errors will occur that way, however. Responsibility for any such errors is still mine so there may be times where that outweighs other thoughts, but as policy I'm happy to make apply-all-at-once the default. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.
Resolve timing issue with logging locks for Hot Standby. We log AccessExclusiveLocks for replay onto standby nodes, but because of timing issues on ProcArray it is possible to log a lock that is still held by a just committed transaction that is very soon to be removed. To avoid any timing issue we avoid applying locks made by transactions with InvalidXid. Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8572cc495cd07d4f4a59624d275a75b45340a3b2 Modified Files -- src/backend/storage/ipc/procarray.c |8 +-- src/backend/storage/ipc/standby.c | 110 --- src/backend/storage/lmgr/lock.c | 12 - src/include/storage/standby.h |2 +- 4 files changed, 88 insertions(+), 44 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
