Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a Summary Table
Daniel Gustafsson writes: > Thanks, I'll await pushing and backpatching if Tom who committed it has > insights into whether it was missed or if it indeed serves a purpose. Hey, I just pushed that for somebody else, I don't claim authorship ;-) It seems clear that the example intends to show a star-schema database where the fact table refers to various dimension tables. But it's incomplete --- there's no foreign-key constraint on time_key, and even less infrastructure for product_key or store_key. I don't have the cited book either, so I don't know how complete the original example was. Perhaps the bit in the trigger function about forbidding updates to time_key has something to do with that model. Anyway, I don't see any reason to object to this patch. The extra table isn't adding much. My only thought is would it make sense to change time_key to be a timestamp or timestamptz value? regards, tom lane
Re: Typo in docs for "recovery_init_sync_method" parameter.
On Tue, Aug 23, 2022 at 02:38:13PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/runtime-config-error-handling.html > Description: > > The second paragraph contains the sentence: > > > ...to ask the operating system to synchronize the whole file systems > that contain the data directory... > > I believe the word "the" in "the whole file systems" should be removed so it > reads: > > > ...to ask the operating system to synchronize whole file systems that > contain the data directory... I ended up with this rewording, attached, and applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 4047eefc64..985cabfc0b 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -10554,7 +10554,7 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir' On Linux, syncfs may be used instead, to ask the -operating system to synchronize the whole file systems that contain the +operating system to synchronize the file systems that contain the data directory, the WAL files and each tablespace (but not any other file systems that may be reachable through symbolic links). See for more information about using
Re: Minor inconsistencies
On Sun, Nov 6, 2022 at 04:16:07PM +0200, Ekaterina Kiryanova wrote: > Hello! > > I've prepared another patch, which contains the previous corrections and > some new found ones concerning upper/lower case letters, misplaced periods > and missing tags. > Please review. I liked all these improvements and applied a modified version of your patch to master, thanks. Sorry for the delay. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.
Re: [very minor] Documentation suggestion
On Fri, Oct 21, 2022 at 02:19:12AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/logicaldecoding-synchronous.html > Description: > > Very minor suggestion. Earlier on this page, commands are referred to that > can cause "a deadlock". Later on the page, it says "cause deadlock". > > https://www.postgresql.org/account/comments/new/15/logicaldecoding-synchronous.html/ > > "Note that these commands that can cause deadlock" The full sentence is: Note that these commands that can cause deadlock apply to not only explicitly indicated system catalog tables above but also to any other [user] catalog table. What I think it means is: Note that these commands, that can cause deadlock, apply to not only explicitly indicated system catalog tables above but also to any other [user] catalog table. so with "a" it would be: Note that these commands, that can cause a deadlock, apply to not only explicitly indicated system catalog tables above but also to any other [user] catalog table. but it still needs help ;-) Here is the text I just applied: Note that these commands can cause deadlocks not only for the system catalog tables listed above but for other catalog tables. Attached is the applied patch to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. commit 16ace6f745 Author: Bruce Momjian Date: Fri Oct 27 11:35:47 2023 -0400 doc: clarify logical decoding's deadlock of system tables Reported-by: andyatkin...@gmail.com Discussion: https://postgr.es/m/166631875298.630.2861049399528658...@wrigleys.postgresql.org Backpatch-through: master diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 5af016cfa9..8067946a25 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1197,9 +1197,8 @@ OutputPluginWrite(ctx, true); - Note that these commands that can cause deadlock apply to not only explicitly - indicated system catalog tables above but also to any other [user] catalog - table. + Note that these commands can cause deadlocks not only for the system + catalog tables listed above but for other catalog tables.
Re: First Person (I) Should be avoided
On Fri, Oct 28, 2022 at 02:56:59AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/oid2name.html > Description: > > This feels a little nit-picky. > > In the Examples > $ # I wonder what file 155173 is ... > > suggested change: > $ # what Postgres object does file 155173 represent ... Fixed with the attached, applied patch to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/oid2name.sgml b/doc/src/sgml/oid2name.sgml index dfe3682739..54cc9be2b8 100644 --- a/doc/src/sgml/oid2name.sgml +++ b/doc/src/sgml/oid2name.sgml @@ -281,7 +281,7 @@ $ ls -lS * | head -10 -rw--- 1 alvherre alvherre163840 sep 14 09:50 16699 -rw--- 1 alvherre alvherre122880 sep 6 17:51 16751 -$ # I wonder what file 155173 is ... +$ # What file is 155173? $ oid2name -d alvherre -f 155173 From database "alvherre": Filenode Table Name
Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a Summary Table
> On 26 Oct 2023, at 12:31, Maxim Yablokov wrote: > > I believe that the attached patch should fix this problem. Please have a look. Thanks, I'll await pushing and backpatching if Tom who committed it has insights into whether it was missed or if it indeed serves a purpose. If not I think it should be backpatched all the way since it exists for all supported versions. -- Daniel Gustafsson
