Re: Use uppercase keywords in foreign key tutorial
On Fri, Oct 24, 2025 at 10:40:18AM -0300, Euler Taveira wrote: > On Thu, Oct 23, 2025, at 7:50 PM, David Rowley wrote: >> I'm not so sure about the "Should be pushed to all stable branches" >> part as it seems more of a general improvement than fixing a mistake. >> I imagine there will be varying opinions on that, however. > > I also classify this as an improvement. No need to backpatch. I would apply > changes to back branches if the query is wrong; that's not the case. +1 -- nathan
Re: Use uppercase keywords in foreign key tutorial
On Thu, Oct 23, 2025, at 7:50 PM, David Rowley wrote: > I'm not so sure about the "Should be pushed to all stable branches" > part as it seems more of a general improvement than fixing a mistake. > I imagine there will be varying opinions on that, however. > I also classify this as an improvement. No need to backpatch. I would apply changes to back branches if the query is wrong; that's not the case. I checked v2 and it looks good to me. Since you are changing the query format, we have a mix of CREATE TABLE foo(a int); CREATE TABLE foo (a int); The latter reads better for me. The same logic applies to VALUES. There is a mix of space or non-space before parenthesis. Consistency is a good goal. -- Euler Taveira EDB https://www.enterprisedb.com/
