Re: copy.sgml: add XML ID attributes to tags.
On 2025-Oct-29, jian he wrote: > hi. > > similar to what we did in > https://git.postgresql.org/cgit/postgresql.git/commit/?id=78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5 > > I happened to notice COPY.sgml Parameters section is un-linkable. > The Parameters section in copy.sgml has shorter explanations compared to > create_table.sgml, but it contains a long list of options. > > So I think making Each parameter linkable would improve readability. Makes sense. I have pushed this. Two minor tweaks: a) I added IDs to refsect1s as well, because we do that in the other ref pages, and it seemed out of place to have them in parameters but not for the sections, and b) I renamed the ones in your patch to use all-lowercase (as well as dash instead of underscore), as well as added the "-params" marker to create a sort of hierarchy of the IDs, the way we do in other pages. Thanks! -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Linux transformó mi computadora, de una `máquina para hacer cosas', en un aparato realmente entretenido, sobre el cual cada día aprendo algo nuevo" (Jaime Salinas)
Re: Documentation improvement patch
> On 30 Oct 2025, at 11:15, Peter Eisentraut wrote: > - Change the definition of a replication slot. > + Changes the definition of a replication slot. > > I think these are intentionally written in imperative style. Compare the > synopses of the main SQL commands: "change the definition of a domain" etc. I agree, I too think these are intentionally written like this. The document isn't entirely consistent and does mix style quite a bit but I don't think these changes change the needle enough to make. Attached is a v3 with the remaining changes and a stab at commit message that I think we should go ahead with. -- Daniel Gustafsson v3-0001-doc-Assorted-documentation-improvements.patch Description: Binary data
Re: Quoting of *_command arguments
On Wed, Nov 12, 2025 at 08:48:39AM -0500, Bruce Momjian wrote: > On Wed, Nov 12, 2025 at 02:45:16PM +0100, Peter Eisentraut wrote: > > On 11.11.25 20:31, Bruce Momjian wrote: > > > We inconsistently double-quote the "%f" and "%p" arguments of > > > "archive_command" and "restore_command". Paths with spaces or special > > > characters, especially directory names in these cases, would need > > > double-quotes. > > > > > > This patch adds double-quotes to all instances. I can also go the other > > > way and remove them all, but we should be consistent. > > > > I think %f doesn't need to be quoted because it will only contain certain > > characters, but if we tried to clarify that it would probably be too > > confusing. It makes sense to nudge people that some quoting is prudent. > > Yeah, I did consider your point but you are right --- it is too complex > to quote one and not the other and expect people to understand why. > > > Your patch looks good to me. > > Thanks. Applied, and I added double-quotes for "%r". -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
