Re: [DOCS] [HACKERS] statement_timeout logging
pgman wrote:
> Simon Riggs wrote:
> > Currently, when we set a statement_timeout and a query runs over that
> > time there is no log message to say that the statement has timed out. We
> > do get a message which says
> > ERROR: canceling query due to user request
> > and so in the server log it is impossible to tell the difference between
> > a query that has been cancelled deliberately by the user and a query
> > whose time(out) has come.
>
> I have updated the message to:
>
> errmsg("canceling query due to user request or statement timeout")));
Oops. Did we freeze the message strings already for this release?
--
Bruce Momjian| http://candle.pha.pa.us
[email protected] | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?
http://www.postgresql.org/docs/faq
Re: [DOCS] [PATCHES] Caveat for Domains
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- David Fetter wrote: > Folks, > > I think this needs to be made explicit in the documentation. Better, > of course, would be some kind of change to the PL infrastructure that > Just Handles It, but until then > > Cheers, > D > -- > David Fetter [EMAIL PROTECTED] http://fetter.org/ > phone: +1 510 893 6100 mobile: +1 415 235 3778 > > Remember to vote! [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 6: explain analyze is your friend -- Bruce Momjian| http://candle.pha.pa.us [email protected] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [DOCS] [HACKERS] statement_timeout logging
On Fri, Sep 16, 2005 at 03:41:11PM -0400, Bruce Momjian wrote:
> pgman wrote:
> > I have updated the message to:
> >
> > errmsg("canceling query due to user request or statement timeout")));
>
> Oops. Did we freeze the message strings already for this release?
Not yet.
I'm not sure I agree with the wording though -- is there no way to tell
the difference?
--
Alvaro Herrera -- Valdivia, Chile Architect, www.EnterpriseDB.com
"No single strategy is always right (Unless the boss says so)"
(Larry Wall)
---(end of broadcast)---
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
Re: [DOCS] [HACKERS] statement_timeout logging
>Alvaro Herrera
> On Fri, Sep 16, 2005 at 03:41:11PM -0400, Bruce Momjian wrote:
> > > I have updated the message to:
> > >
> > > errmsg("canceling query due to user request or
> statement timeout")));
> >
> > Oops. Did we freeze the message strings already for this release?
>
> Not yet.
>
> I'm not sure I agree with the wording though -- is there no
> way to tell
> the difference?
Yes, my patch. :-)
The message is generated following receipt of a SIGINT which is sent by
kill() after the statement_timeout.
My patch was able to generate a different message by logging just before
the kill() is called. (Obviously, there isn't much "after" in this
circumstance).
Best Regards, Simon Riggs
---(end of broadcast)---
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
Re: [DOCS] [HACKERS] statement_timeout logging
Simon Riggs wrote:
> >Alvaro Herrera
> > On Fri, Sep 16, 2005 at 03:41:11PM -0400, Bruce Momjian wrote:
> > > > I have updated the message to:
> > > >
> > > > errmsg("canceling query due to user request or
> > statement timeout")));
> > >
> > > Oops. Did we freeze the message strings already for this release?
> >
> > Not yet.
> >
> > I'm not sure I agree with the wording though -- is there no
> > way to tell
> > the difference?
>
> Yes, my patch. :-)
>
> The message is generated following receipt of a SIGINT which is sent by
> kill() after the statement_timeout.
>
> My patch was able to generate a different message by logging just before
> the kill() is called. (Obviously, there isn't much "after" in this
> circumstance).
Your patch just prints a statement "before" printing the cancel message.
What we should do is to print the proper cause of the cancel, and I am
working on a patch for that.
--
Bruce Momjian| http://candle.pha.pa.us
[email protected] | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
