[DOCS] Fix misleading references to columns in GRANT/REVOKE summaries
Folks,
Per a question Alexey Parshin asked in the IRC channel, I'm attaching
a patch to the GRANT and REVOKE syntax summaries which replaces the
misleading word "column" with "parameter." "Column" is misleading
because it could be read to imply a column-level GRANT/REVOKE, which
we don't have yet.
Cheers,
D
--
David Fetter <[EMAIL PROTECTED]> http://fetter.org/
phone: +1 415 235 3778AIM: dfetter666
Skype: davidfetter
Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
Index: doc/src/sgml/ref/grant.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/grant.sgml,v
retrieving revision 1.64
diff -c -r1.64 grant.sgml
*** doc/src/sgml/ref/grant.sgml 1 Feb 2007 00:28:19 - 1.64
--- doc/src/sgml/ref/grant.sgml 6 Apr 2007 23:39:20 -
***
*** 525,531
GRANT privileges
! ON table [ ( column [, ...] ) ] [, ...]
TO { PUBLIC | username [,
...] } [ WITH GRANT OPTION ]
--- 525,532
GRANT privileges
! ON table [ (
! parameter [, ...] ) ] [, ...]
TO { PUBLIC | username [,
...] } [ WITH GRANT OPTION ]
Index: doc/src/sgml/ref/revoke.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/revoke.sgml,v
retrieving revision 1.42
diff -c -r1.42 revoke.sgml
*** doc/src/sgml/ref/revoke.sgml31 Jan 2007 23:26:04 - 1.42
--- doc/src/sgml/ref/revoke.sgml6 Apr 2007 23:39:20 -
***
*** 235,241
REVOKE [ GRANT OPTION FOR ] privileges
! ON object [ ( column [, ...] ) ]
FROM { PUBLIC | username [,
...] }
{ RESTRICT | CASCADE }
--- 235,242
REVOKE [ GRANT OPTION FOR ] privileges
! ON object [ (
! parameter [, ...] ) ]
FROM { PUBLIC | username [,
...] }
{ RESTRICT | CASCADE }
---(end of broadcast)---
TIP 7: You can help support the PostgreSQL project by donating at
http://www.postgresql.org/about/donate
Re: [DOCS] Fix misleading references to columns in GRANT/REVOKE summaries
David Fetter <[EMAIL PROTECTED]> writes: > Per a question Alexey Parshin asked in the IRC channel, I'm attaching > a patch to the GRANT and REVOKE syntax summaries which replaces the > misleading word "column" with "parameter." "Column" is misleading > because it could be read to imply a column-level GRANT/REVOKE, which > we don't have yet. Apparently it's so misleading that you didn't understand it either. The entire *point* of that paragraph is that we don't have the feature. This proposed change is surely not an improvement... regards, tom lane ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] [DOCS] Fix misleading references to columns in GRANT/REVOKE summaries
Russell Smith <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> The entire *point* of that paragraph is that we don't have the >> feature. This proposed change is surely not an improvement... >> > Maybe removing the entire example would be more helpful. I don't find > it clear to have a command outline in a compatibility block. True, there doesn't seem to be any point in providing a full syntax summary rather than just saying "the SQL spec says you can grant privileges on columns but we don't support that yet". regards, tom lane ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] [DOCS] Fix misleading references to columns in GRANT/REVOKE summaries
Tom Lane wrote:
> Russell Smith <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> The entire *point* of that paragraph is that we don't have the
> >> feature. This proposed change is surely not an improvement...
> >>
> > Maybe removing the entire example would be more helpful. I don't find
> > it clear to have a command outline in a compatibility block.
>
> True, there doesn't seem to be any point in providing a full syntax
> summary rather than just saying "the SQL spec says you can grant
> privileges on columns but we don't support that yet".
Agreed. Patch attached and applied. I don't see any other cases of
this in our documentation.
--
Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: doc/src/sgml/ref/grant.sgml
===
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/grant.sgml,v
retrieving revision 1.64
diff -c -c -r1.64 grant.sgml
*** doc/src/sgml/ref/grant.sgml 1 Feb 2007 00:28:19 - 1.64
--- doc/src/sgml/ref/grant.sgml 7 Apr 2007 03:45:36 -
***
*** 520,533
! The SQL standard allows setting privileges for individual columns
! within a table:
!
!
! GRANT privileges
! ON table [ ( column [, ...] ) ] [, ...]
! TO { PUBLIC | username [, ...] } [ WITH GRANT OPTION ]
!
--- 520,527
! PostgreSQL does not support the SQL-standard
! functionality of setting privileges for individual columns.
Index: doc/src/sgml/ref/revoke.sgml
===
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/revoke.sgml,v
retrieving revision 1.42
diff -c -c -r1.42 revoke.sgml
*** doc/src/sgml/ref/revoke.sgml 31 Jan 2007 23:26:04 - 1.42
--- doc/src/sgml/ref/revoke.sgml 7 Apr 2007 03:45:37 -
***
*** 231,245
The compatibility notes of the command
! apply analogously to REVOKE. The syntax summary is:
!
!
! REVOKE [ GRANT OPTION FOR ] privileges
! ON object [ ( column [, ...] ) ]
! FROM { PUBLIC | username [, ...] }
! { RESTRICT | CASCADE }
!
! One of RESTRICT or CASCADE
is required according to the standard, but PostgreSQL
assumes RESTRICT by default.
--- 231,238
The compatibility notes of the command
! apply analogously to REVOKE.
! RESTRICT or CASCADE
is required according to the standard, but PostgreSQL
assumes RESTRICT by default.
---(end of broadcast)---
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
