[DOCS] when transaction commit begins
I'd like to reword this line in the Asynch commit docs: "when transaction commit begins." Transaction commit is when the transaction ends, so using the word begin in that way is confusing. Index: doc/src/sgml/wal.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/wal.sgml,v retrieving revision 1.45 diff -c -r1.45 wal.sgml *** doc/src/sgml/wal.sgml 1 Aug 2007 22:45:07 - 1.45 --- doc/src/sgml/wal.sgml 25 Sep 2007 08:01:06 - *** *** 216,222 , which can be changed in any of the ways that a configuration parameter can be set. The mode used for any one transaction depends on the value of !synchronous_commit when transaction commit begins. --- 216,223 , which can be changed in any of the ways that a configuration parameter can be set. The mode used for any one transaction depends on the value of !synchronous_commit at the time of transaction commit, !so SET LOCAL can also be used. -- Simon Riggs 2ndQuadrant http://www.2ndQuadrant.com ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [DOCS] when transaction commit begins
Simon Riggs <[EMAIL PROTECTED]> writes: > I'd like to reword this line in the Asynch commit docs: >"when transaction commit begins." I do not think your proposed rewording is better. The point I was trying to cover is that "SET LOCAL synchronous_commit" will affect the upcoming commit, and that fine point is no longer clear with your phrasing. > Transaction commit is when the transaction ends, so using the word begin > in that way is confusing. I don't actually agree with that statement anyway... regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [DOCS] when transaction commit begins
On Tue, 2007-09-25 at 09:24 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > I'd like to reword this line in the Asynch commit docs: > >"when transaction commit begins." > > I do not think your proposed rewording is better. OK > The point I was > trying to cover is that "SET LOCAL synchronous_commit" will affect the > upcoming commit, and that fine point is no longer clear with your > phrasing. So we both agree we want to make sure that point is understood. Saying it explicitly would be the best way, however we word the earlier piece. -- Simon Riggs 2ndQuadrant http://www.2ndQuadrant.com ---(end of broadcast)--- TIP 6: explain analyze is your friend
