Re: [DOCS] Full Text Search examples patch

2008-01-15 Thread Alvaro Herrera
Erik wrote:
> Tom Lane wrote:
> > "Erik" <[EMAIL PROTECTED]> writes:
> >> I changed all references to 'pgweb' to 'apod'. This apod
> >> table initially corresponds with the structure of the
> >> table in the dump file.  (In the documentation, that
> >> table
> >> is subsequently changed by adding a tsvector column.)
> >
> > Huh?  These are just examples, they are not supposed to
> > refer to any
> > specific real table, much less one that comes standard
> > with Postgres.
> 
> I understand that, of course.  I am suggesting it might be
> an improvement to offer the data to go with the examples.

Hmm, wouldn't it be easier to provide the pgweb table?

-- 
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

---(end of broadcast)---
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate


Re: [DOCS] Full Text Search examples patch

2008-01-15 Thread Erik
Alvaro Herrera wrote:
> Erik wrote:
>> Tom Lane wrote:
>> > "Erik" <[EMAIL PROTECTED]> writes:
>> >> I changed all references to 'pgweb' to 'apod'. This
>> apod
>> >> table initially corresponds with the structure of the
>> >> table in the dump file.  (In the documentation, that
>> >> table
>> >> is subsequently changed by adding a tsvector column.)
>> >
>> > Huh?  These are just examples, they are not supposed
>> to
>> > refer to any
>> > specific real table, much less one that comes standard
>> > with Postgres.
>>
>> I understand that, of course.  I am suggesting it might
>> be
>> an improvement to offer the data to go with the
>> examples.
>
> Hmm, wouldn't it be easier to provide the pgweb table?

Maybe - I don't know what that pgweb data would be.

There are really two issues:

  1. Apply changes I suggested (and attached earlier) to
the documentation text to make code examples use a
single table instead of two different ones.  I chose
apod because I knew apod from tsearch2.  In the patch
there are also some confusing inconsistencies removed,
for instance column  'textsearch_indexable_col' is in a
later code example used as column 'textsearch'.

  2. Whether or not to include some actual table data (be
it apod or pgweb). This is less important as far as I am
concerned.

 The first is more useful and easier to apply than the
second.

> Alvaro Herrera
> http://www.CommandPrompt.com/
> PostgreSQL Replication, Consulting, Custom Development,
> 24x7 support
>
> ---(end of
> broadcast)---
> TIP 7: You can help support the PostgreSQL project by
> donating at
>
> http://www.postgresql.org/about/donate
>

regards,

Erik Rijkers


---(end of broadcast)---
TIP 6: explain analyze is your friend