[DOCS] Incorrect SQL on CREATE INDEX page
In the "Examples" section of the page for CREATE INDEX: http://www.postgresql.org/docs/current/static/sql-createindex.html it says: To create a GIN index with fast updates disabled: CREATE INDEX gin_idx ON documents_table (locations) WITH (fastupdate = off); This SQL fails with 'ERROR: unrecognized parameter "fastupdate"', as it is missing the USING clause. Correct syntax should be: CREATE INDEX gin_idx ON documents_table USING gin(locations) WITH (fastupdate = off); Also, a more minor quibble about the same section: the first example says: To create a B-tree index on the column title in the table films: CREATE UNIQUE INDEX title_idx ON films (title); Perhaps the mention of "B-tree" should be omitted here, since "USING btree" is not actually used in the SQL provided. Or is there an explicit guarantee that CREATE UNIQUE INDEX will always use a B-Tree documented somewhere? Josh -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] Incorrect SQL on CREATE INDEX page
Josh Kupershmidt writes: > In the "Examples" section of the page for CREATE INDEX: > http://www.postgresql.org/docs/current/static/sql-createindex.html > it says: >To create a GIN index with fast updates disabled: >CREATE INDEX gin_idx ON documents_table (locations) WITH (fastupdate = > off); > This SQL fails with 'ERROR: unrecognized parameter "fastupdate"', as > it is missing the USING clause. Ooops. You're right, that's definitely a mistake. Will fix. > Also, a more minor quibble about the same section: the first example says: > To create a B-tree index on the column title in the table films: > CREATE UNIQUE INDEX title_idx ON films (title); > Perhaps the mention of "B-tree" should be omitted here, since "USING > btree" is not actually used in the SQL provided. Or is there an > explicit guarantee that CREATE UNIQUE INDEX will always use a B-Tree > documented somewhere? It's pointed out further up the page that btree is the default access method. regards, tom lane -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] Incorrect SQL on CREATE INDEX page
Tom Lane wrote: Josh Kupershmidt writes: Also, a more minor quibble about the same section: the first example says: To create a B-tree index on the column title in the table films: CREATE UNIQUE INDEX title_idx ON films (title); Perhaps the mention of "B-tree" should be omitted here, since "USING btree" is not actually used in the SQL provided. Or is there an explicit guarantee that CREATE UNIQUE INDEX will always use a B-Tree documented somewhere? It's pointed out further up the page that btree is the default access method. Maybe change it to " ... B-tree index (the default) on the column ... " for those of us with short memories. \\||/ Rod -- -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] The type of ssl_renegotiation_limit
On Wed, Mar 17, 2010 at 03:28, Fujii Masao wrote: > Hi, > > http://developer.postgresql.org/pgdocs/postgres/runtime-config-connection.html#RUNTIME-CONFIG-CONNECTION-SECURITY > >> ssl_renegotiation_limit (int) > > It's described that the type of ssl_renegotiation_limit is "int". > Though it's not apparent error, we should use "integer" rather than > "int". In the description of other parameters, "integer" has been > used. Here is the patch. You are right, of course. Applied, thanks! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
