[DOCS] minor typofixes for pg_standby.c
I noticed I had some typofixes for comments in pg_standby.c hanging
around. Basically, just s/its /it's / .
Josh
diff --git a/contrib/pg_standby/pg_standby.c b/contrib/pg_standby/pg_standby.c
index d51f391..b1f23c3 100644
*** a/contrib/pg_standby/pg_standby.c
--- b/contrib/pg_standby/pg_standby.c
*** CustomizableInitialize(void)
*** 169,175
/*
* This code assumes that archiveLocation is a directory You may wish to
* add code to check for tape libraries, etc.. So, since it is a
! * directory, we use stat to test if its accessible
*/
if (stat(archiveLocation, &stat_buf) != 0)
{
--- 169,175
/*
* This code assumes that archiveLocation is a directory You may wish to
* add code to check for tape libraries, etc.. So, since it is a
! * directory, we use stat to test if it's accessible
*/
if (stat(archiveLocation, &stat_buf) != 0)
{
*** CustomizableNextWALFileReady()
*** 190,197
if (stat(WALFilePath, &stat_buf) == 0)
{
/*
! * If its a backup file, return immediately If its a regular file
! * return only if its the right size already
*/
if (strlen(nextWALFileName) > 24 &&
strspn(nextWALFileName, "0123456789ABCDEF") == 24 &&
--- 190,197
if (stat(WALFilePath, &stat_buf) == 0)
{
/*
! * If it's a backup file, return immediately. If it's a regular file
! * return only if it's the right size already.
*/
if (strlen(nextWALFileName) > 24 &&
strspn(nextWALFileName, "0123456789ABCDEF") == 24 &&
*** CustomizableCleanupPriorWALFiles(void)
*** 250,256
struct dirent *xlde;
/*
! * Assume its OK to keep failing. The failure situation may change
* over time, so we'd rather keep going on the main processing than
* fail because we couldnt clean up yet.
*/
--- 250,256
struct dirent *xlde;
/*
! * Assume it's OK to keep failing. The failure situation may change
* over time, so we'd rather keep going on the main processing than
* fail because we couldnt clean up yet.
*/
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] minor typofixes for pg_standby.c
Josh Kupershmidt wrote: > I noticed I had some typofixes for comments in pg_standby.c hanging > around. Basically, just s/its /it's / . Thanks, fixed. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
[DOCS] some re-formatting in xfunc.sgml
Attached some formatting improvements to xfunc.sgml (1 typo; 2x wrap long code examples to make them readable in .pdf) Erik Rijkers--- doc/src/sgml/xfunc.sgml.orig 2010-05-14 23:00:23.0 +0200 +++ doc/src/sgml/xfunc.sgml 2010-05-15 01:52:52.0 +0200 @@ -859,7 +859,8 @@ output parameters, like this: -CREATE FUNCTION sum_n_product_with_tab (x int, OUT sum int, OUT product int) RETURNS SETOF record AS $$ +CREATE FUNCTION sum_n_product_with_tab (x int, OUT sum int, OUT product int) +RETURNS SETOF record AS $$ SELECT $1 + tab.y, $1 * tab.y FROM tab; $$ LANGUAGE SQL; @@ -957,7 +958,8 @@ done this way: -CREATE FUNCTION sum_n_product_with_tab (x int) RETURNS TABLE(sum int, product int) AS $$ +CREATE FUNCTION sum_n_product_with_tab (x int) +RETURNS TABLE(sum int, product int) AS $$ SELECT $1 + tab.y, $1 * tab.y FROM tab; $$ LANGUAGE SQL; @@ -1026,7 +1028,8 @@ SELECT 1; $$ LANGUAGE SQL; ERROR: cannot determine result data type -DETAIL: A function returning a polymorphic type must have at least one polymorphic argument. +DETAIL: A function returning a polymorphic type must have + at least one polymorphic argument. @@ -2075,7 +2078,7 @@ PG_FUNCTION_INFO_V1(funcname); - must appear in the same source file. (Conventionally. it's + must appear in the same source file. (Conventionally, it's written just before the function itself.) This macro call is not needed for internal-language functions, since PostgreSQL assumes that all internal functions -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] some re-formatting in xfunc.sgml
On Sat, May 15, 2010 at 1:52 PM, Erik Rijkers wrote: > Attached some formatting improvements to xfunc.sgml > > (1 typo; 2x wrap long code examples to make them readable in .pdf) I applied this typo fix all the way back to 7.4, and the two changes to the CREATE OR REPLACE function formatting to HEAD. I don't want to break the error message, though, because (1) it breaks grepability for that error message and (2) it'll look wrong in the HTML version of the documentation. The formatting of CREATE OR REPLACE is somewhat arbitrary and we have similar examples to your proposed formatting elsewhere in the documentation, but the error message is what it is. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
