[DOCS] commit_delay and commit_siblings -- restart or reload?

2010-06-01 Thread Joshua Tolley
The documentation for commit_delay and commit_siblings doesn't mention whether
a reload or restart is required to set them. I recommend something like the
trivial attached docs patch to make it clear(er) that a reload is required.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 48ad9f6..c513eba 100644
*** a/doc/src/sgml/config.sgml
--- b/doc/src/sgml/config.sgml
*** SET ENABLE_SEQSCAN TO OFF;
*** 1643,1649 
  commit. Therefore, the delay is only performed if at least
  commit_siblings other transactions are
  active at the instant that a server process has written its
! commit record. The default is zero (no delay).
 

   
--- 1643,1651 
  commit. Therefore, the delay is only performed if at least
  commit_siblings other transactions are
  active at the instant that a server process has written its
! commit record. The default is zero (no delay). This parameter can only
! be set in the postgresql.conf file or on the server
! command line.
 

   
*** SET ENABLE_SEQSCAN TO OFF;
*** 1659,1665 
  before performing the commit_delay delay. A larger
  value makes it more probable that at least one other
  transaction will become ready to commit during the delay
! interval. The default is five transactions.
 

   
--- 1661,1669 
  before performing the commit_delay delay. A larger
  value makes it more probable that at least one other
  transaction will become ready to commit during the delay
! interval. The default is five transactions. This parameter can only be
! set in the postgresql.conf file or on the server command
! line.
 

   


signature.asc
Description: Digital signature


Re: [DOCS] commit_delay and commit_siblings -- restart or reload?

2010-06-01 Thread Robert Haas
On Tue, Jun 1, 2010 at 11:51 AM, Joshua Tolley  wrote:
> The documentation for commit_delay and commit_siblings doesn't mention whether
> a reload or restart is required to set them. I recommend something like the
> trivial attached docs patch to make it clear(er) that a reload is required.

These parameters are PGC_USERSET - a reload is not the only way to change them.

Of course, changing any parameter in postgresql.conf won't take effect
unless you reload, but the point of that sentence, in the other places
where we use it, is that you can't change those parameters using
things like ALTER DATABASE ... SET, ALTER USER ... SET, just plain
SET, etc.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Re: [DOCS] commit_delay and commit_siblings -- restart or reload?

2010-06-01 Thread Joshua Tolley
On Tue, Jun 01, 2010 at 03:33:24PM -0400, Robert Haas wrote:
> On Tue, Jun 1, 2010 at 11:51 AM, Joshua Tolley  wrote:
> > The documentation for commit_delay and commit_siblings doesn't mention 
> > whether
> > a reload or restart is required to set them. I recommend something like the
> > trivial attached docs patch to make it clear(er) that a reload is required.
> 
> These parameters are PGC_USERSET - a reload is not the only way to change 
> them.
> 
> Of course, changing any parameter in postgresql.conf won't take effect
> unless you reload, but the point of that sentence, in the other places
> where we use it, is that you can't change those parameters using
> things like ALTER DATABASE ... SET, ALTER USER ... SET, just plain
> SET, etc.

Ah, you're right. My mistake -- thanks.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com


signature.asc
Description: Digital signature