Re: [DOCS] Tidy up boolean data type page

2010-07-24 Thread Peter Eisentraut
On tor, 2010-07-22 at 23:02 +0100, Thom Brown wrote:
> Hi all,
> 
> I wanted to clean up the boolean data type documentation page a bit,
> so thought the following was needed:
> 
>  - use a data type table like most of the other main data types so
> it's more uniform (the the size of a boolean is only mentioned at the
> very end and looks a bit odd, so removed that too)
>  - move the reference to the usage example to before the example
>  - minor text change in the first sentence so that it doesn't look
> like it reads "boolean.boolean"
> 
> I've attached a patch with these changes, although feel free to list
> the many reasons why this is a bad idea. ;)

Looks good to me.  Committed to 9.0 and 9.1.


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Re: [DOCS] Adding a crucial element to an example

2010-07-24 Thread Peter Eisentraut
On fre, 2010-07-23 at 12:02 +0200, John Gage wrote:
> In this section, you create the table for the example, but you do
> not  
> populate it, although the example select statements are against the  
> phantom population that has not been inserted.
> 
> I suggest strongly including the minimal code necessary to populate  
> the table, so that the user doesn't have to populate it himself.
> Call  
> me lazy, but I did go into pgAdmin and insert values after creating
> a  
> primary key.

Could you send a patch, or a list of the statements that need to be
inserted?


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Re: [DOCS] Adding a crucial element to an example

2010-07-24 Thread John Gage

After the CREATE statement I would simply put:

INSERT INTO emp VALUES ('Bill', 4200, 45, '(2,1)');

What that accomplishes is making it so the user can simply copy and  
paste the entire section and run it in pg_admin.  Then, the user can  
start fiddling with it as he wants to.


I know this sounds terribly simple, but simplicity is good,  
particularly when you're climbing a steep learning curve.  And there  
is certainly, unequivocally, no harm in simplicity.


Thanks,

John

On Jul 24, 2010, at 2:21 PM, Peter Eisentraut wrote:


On fre, 2010-07-23 at 12:02 +0200, John Gage wrote:

In this section, you create the table for the example, but you do
not
populate it, although the example select statements are against the
phantom population that has not been inserted.

I suggest strongly including the minimal code necessary to populate
the table, so that the user doesn't have to populate it himself.
Call
me lazy, but I did go into pgAdmin and insert values after creating
a
primary key.


Could you send a patch, or a list of the statements that need to be
inserted?


--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Re: [DOCS] Please provide stable target anchors

2010-07-24 Thread Robert Haas
On Thu, Jul 22, 2010 at 5:23 AM, Daniele Varrazzo
 wrote:
> If I had to provide a patch, what would be the best source tree to
> modify? Is master on http://git.postgresql.org/gitweb?p=postgresql.git
> ok?

That git repo is mildly out of sync with CVS, but it should be
adequate for this purpose.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs