Re: [DOCS] Obsolete description in pg_ctl-ref.sgml

2010-12-14 Thread Robert Haas
On Sun, Dec 12, 2010 at 11:21 PM, Fujii Masao  wrote:
> On Sat, Dec 11, 2010 at 1:27 PM, Robert Haas  wrote:
 Notes

 Waiting for complete startup is not a well-defined operation and
 might fail if access control is set up so that a local client cannot
 connect without manual interaction (e.g., password authentication).
 For additional connection variables, see Section 31.13, and for
 passwords, also see Section 31.14.
>>>
>>> The above also seems to be obsolete, thanks to recently-introduced
>>> PQping. Can we remove that?
>>
>> Should we remove only the first sentence and keep the second one, or
>> is it more appropriate to remove the whole thing?
>
> At least the reference to section 31.14 is needless since password
> authentication doesn't affect the pg_ctl -w for now. But, on the second
> thought, it can still fail because of miss-configuration of connection
> variable, for example PGHOST.

I thought PQping() was supposed to handle that correctly.  There are
four return values: PQPING_OK, PQPING_REJECT, PQPING_NO_RESPONSE,
PQPING_NO_ATTEMPT.  I believe the last is intended to cover blatant
misconfiguration.  Or maybe I'm not understanding what you're
referring to.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Re: [DOCS] Is timestamptz alias documented?

2010-12-14 Thread Robert Haas
On Tue, Dec 7, 2010 at 2:20 PM, Alvaro Herrera
 wrote:
> Excerpts from Tom Lane's message of mar dic 07 15:35:53 -0300 2010:
>> Chris  writes:
>
>> > Is this a new alias, or
>> > has it been around for some time?
>>
>> It's been around since the '90s I'm sure, maybe even back to Berkeley days.
>
> It appeared later; "timestamp" was the alias for "timestamp with time
> zone" previously.  But this was against the SQL standard so the new
> alias was introduced as a backwards incompatible change.  There are no
> hits for a "grep -r timestamptz src/backend" in 7.1, but they are there
> in 7.2.  2002 or so, then.

I think it'd be helpful to make brief mention of this in the section
on "Date/Time Types", perhaps along the lines of the attached patch.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


timestamptz-doc.patch
Description: Binary data

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Re: [DOCS] Obsolete description in pg_ctl-ref.sgml

2010-12-14 Thread Fujii Masao
On Wed, Dec 15, 2010 at 6:35 AM, Robert Haas  wrote:
>> At least the reference to section 31.14 is needless since password
>> authentication doesn't affect the pg_ctl -w for now. But, on the second
>> thought, it can still fail because of miss-configuration of connection
>> variable, for example PGHOST.
>
> I thought PQping() was supposed to handle that correctly.  There are
> four return values: PQPING_OK, PQPING_REJECT, PQPING_NO_RESPONSE,
> PQPING_NO_ATTEMPT.  I believe the last is intended to cover blatant
> misconfiguration.

True. But even though the server is running normally, the misconfiguration
might still make PQping return PQPING_NO_ATTEMPT and make pg_ctl -w
fail to wait for complete startup. Currently misconfiguration of password
authentication doesn't interfere with pg_ctl -w, so we can remove the
reference to that. But other misconfigurations can be still harm, so I thought
the sentence still needs to be in the document.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs