[DOCS] Clarification suggestion for 46.4 chapter.

2011-12-05 Thread Dmitriy Igrishin
Hey,

The section 46.4 describes the base data types used in messages.
http://www.postgresql.org/docs/9.1/static/protocol-message-types.html

According to section 46.5
http://www.postgresql.org/docs/9.1/static/protocol-message-formats.html
there are cases when Int32 can be negative (e.g. see DataRow(B) message
description.)

Thus, I would like to suggest to change the description of Int(i)
from
"An n-bit integer in network byte order ..."
to
"An n-bit signed integer in network byte order ..."

-- 
// Dmitriy.


Re: [DOCS] docs update for count(*) and index-only scans

2011-12-05 Thread Josh Kupershmidt
On Fri, Nov 4, 2011 at 4:10 PM, Robert Haas  wrote:
> On Tue, Nov 1, 2011 at 8:07 PM, Tom Lane  wrote:
>> It's the "lobotomized engines" that are the problem, IMO --- people
>> coming from databases like mysql tend to think count(*) just means
>> reading a table size counter that the engine has anyway.
>
> This is probably a much less common misconception than formerly, due
> to the rise of InnoDB and the falling-out-of-favor experienced by
> MyISAM.
>
> I think some pessimism removal is probably warranted.  Yeah, somebody
> else might be faster than us on this test, but that's probably true of
> many tests.  And on others we will be faster than them.

So, if Tom still wants to keep that paragraph and its warning, how
about we just fix the now-incorrect bit at the end? Maybe just tweak
"will be executed" to "will often be executed", or change "using a
sequential scan of the entire table." to "using a sequential scan of
the table, or an index-only scan of one of its indexes".

Josh

-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


[DOCS] pg_stat_get_wal_senders documented

2011-12-05 Thread Euler Taveira de Oliveira
Hi,

Is $SUBJECT an oversight? I noticed that pg_stat_get_activity (function behind
pg_stat_activity) is documented so for consistency, function
pg_stat_get_wal_senders (function behind pg_stat_replication) should be
documented too. Patch is attached.


-- 
   Euler Taveira de Oliveira - Timbira   http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index b9dc1d2..d6056a2 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -1182,6 +1182,15 @@ postgres: user database host 
 
  
+  pg_stat_get_wal_senders()
+  setof record
+  
+	   One record for each active wal sender. The fields returned are a subset
+	   of those in the pg_stat_replication view.
+  
+ 
+
+ 
   pg_stat_clear_snapshot()
   void
   

-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs