Re: [DOCS] Capitalization of 'TimeZone' GUC
On fre, 2012-05-04 at 17:37 -0700, Josh Kupershmidt wrote: > Hi all, > > I noticed that the 'TimeZone' GUC is displayed in all-lowercase at: > http://www.postgresql.org/docs/9.1/static/runtime-config-client.html > > when it should be camel-cased like 'DateStyle' and 'IntervalStyle' > above it, since that is how the GUC is displayed to users, e.g. as the > column name for 'SHOW timezone;' Fixed that (you forgot to change xreflabel). There are many other places where this is "misspelled", but there are also many other places where DateStyle is capitalized inconsistently. It's perhaps not worth fixing all that. -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] NAME maximum length in _bytes_
On Tue, May 08, 2012 at 05:13:45PM -0400, Bruce Momjian wrote: > psql \dTS+ shows for data type 'name': > >pg_catalog | name| name| 64 | | > | 63-character type for storing system identifiers > > I believe this is really 63 bytes, not characters. I also see it > mismatched in our docs: > > in the internal system catalogs and is not intended for use by the > general user. Its > length is currently defined as 64 bytes (63 usable characters plus >-- > terminator) but should be referenced using the constant > NAMEDATALEN in C source code. > > Should I fix this? Fix applied; no catalog bump. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] Confusing section of 'Setting Parameters'
Josh Kupershmidt writes: > This bit of "Section 18.1. Setting Parameters"[1] is highly confusing: Yeah, that's badly in need of editing. > Second, I think Section 18.1 as a whole could be much improved by > breaking it up into sub-sections; it seems too long and disjointed > as-is. I gave this reorganization a shot with a larger patch > (setting_parameters_subsections.diff) which includes the > include_if_exists clarification, and also breaks the page up into > three sub-sections. I think this is a good idea, but I didn't like your section division at all. I broke it up like this instead: Parameter Names and Values Setting Parameters via the Configuration File Other Ways to Set Parameters Examining Parameter Settings See what you think. > This is my preferred fix (for now -- I'll try to > send in some further explanation/consolidation of GUC contexts > relevant to that page later). Yeah, the discussion on the pg_settings page maybe should be moved here. On the other hand, this is very introductory material, so it might not be the best place for anything too detailed. regards, tom lane -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] Confusing section of 'Setting Parameters'
On Thu, May 10, 2012 at 8:05 PM, Tom Lane wrote: > I think this is a good idea, but I didn't like your section division > at all. I broke it up like this instead: > > Parameter Names and Values > Setting Parameters via the Configuration File > Other Ways to Set Parameters > Examining Parameter Settings > > See what you think. Looks much better now, thanks. Josh -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
