Re: [DOCS] PGDATA confusion

2012-08-16 Thread Thom Brown
On 16 August 2012 04:00, Bruce Momjian  wrote:
> On Fri, Nov  4, 2011 at 12:32:13PM -0400, Bruce Momjian wrote:
>> Thom Brown wrote:
>> > > So if one set PGDATA to somewhere which had no database files at all,
>> > > but just postgresql.conf, it could still work (assuming it, in turn,
>> > > set data_directory correctly), but not vice versa. ?It would make more
>> > > sense to call it PGCONFIG, although I'm not proposing that, especially
>> > > since PGDATA makes sense when it comes to initdb.
>> > >
>> > > There are probably plenty of other places in the docs which also don't
>> > > adequately describe PGDATA or -D.
>> > >
>> > > Any disagreements? ?If not, should I write a patch (since someone will
>> > > probably accuse me of volunteering anyway) or would someone like to
>> > > commit some adjustments?
>> >
>> > No opinions on this?
>>
>> Yes.  I had kept it to deal with later.  Please work on a doc patch to
>> try to clean this up.  pg_upgrade just went through this confusion and I
>> also was unhappy at how vague things are in this area.
>>
>> Things got very confusing with pg_upgrade when PGDATA pointed to the
>> configuration directory and the data_directory GUC pointed to the data
>> directory.
>
> I have applied the attached doc patch for PG 9.3 to clarify PGDATA.

Thanks Bruce.

-- 
Thom


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Re: [DOCS] Clarification suggestion for 46.4 chapter.

2012-08-16 Thread Bruce Momjian
On Mon, Dec  5, 2011 at 02:53:22PM +0300, Dmitriy Igrishin wrote:
> Hey,
> 
> The section 46.4 describes the base data types used in messages.
> http://www.postgresql.org/docs/9.1/static/protocol-message-types.html
> 
> According to section 46.5
> http://www.postgresql.org/docs/9.1/static/protocol-message-formats.html
> there are cases when Int32 can be negative (e.g. see DataRow(B) message
> description.)
> 
> Thus, I would like to suggest to change the description of Int(i)
> from
> "An n-bit integer in network byte order ..."
> to
> "An n-bit signed integer in network byte order ..."

OK, documentation updated.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

  + It's impossible for everything to be true. +
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
new file mode 100644
index e725563..8778c58
*** a/doc/src/sgml/protocol.sgml
--- b/doc/src/sgml/protocol.sgml
*** This section describes the base data typ
*** 1819,1825 
  
  
  
! An n-bit integer in network byte
  order (most significant byte first).
  If i is specified it
  is the exact value that will appear, otherwise the value
--- 1819,1825 
  
  
  
! An n-bit signed integer in network byte
  order (most significant byte first).
  If i is specified it
  is the exact value that will appear, otherwise the value

-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs